René's URL Explorer Experiment


Title: Validate rate limit window and cost in RateLimitMiddleware by dereuromark · Pull Request #19766 · cakephp/cakephp · GitHub

Open Graph Title: Validate rate limit window and cost in RateLimitMiddleware by dereuromark · Pull Request #19766 · cakephp/cakephp

X Title: Validate rate limit window and cost in RateLimitMiddleware by dereuromark · Pull Request #19766 · cakephp/cakephp

Description: CakePHP: The Rapid Development Framework for PHP - Official Repository - Validate rate limit window and cost in RateLimitMiddleware by dereuromark · Pull Request #19766 · cakephp/cakephp

Open Graph Description: Follow-up to review feedback on #19754. RateLimitMiddleware passed window and the result of costCallback to the limiter without checks: A window of 0 crashed all three limiters with DivisionByZero...

X Description: Follow-up to review feedback on #19754. RateLimitMiddleware passed window and the result of costCallback to the limiter without checks: A window of 0 crashed all three limiters with DivisionByZero...

Opengraph URL: https://github.com/cakephp/cakephp/pull/19766

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fbc1f513-ffb8-6a03-f9dc-9dec69eeefbc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA26:39A230:FB9B5:15609F:6AFD3FE9
html-safe-noncefa79e2c2579466e09237d77842055067191359ceb4a665eccea7b71fc67f2545
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTI2OjM5QTIzMDpGQjlCNToxNTYwOUY6NkFGRDNGRTkiLCJ2aXNpdG9yX2lkIjoiMzE4MDc1MjgzMzAyODYzNjY0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac59e87a08909881fb1aa44e53dc7deed283751390ea939ad78d85a45064f8e4ba
hovercard-subject-tagpull_request:5124715159
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/cakephp/cakephp/19766/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ed5f5cb9c2e93e82e2f089ff9ff6a5739960388afc8b4237aec4adc602631be2/cakephp/cakephp/pull/19766
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ed5f5cb9c2e93e82e2f089ff9ff6a5739960388afc8b4237aec4adc602631be2/cakephp/cakephp/pull/19766
og:image:altFollow-up to review feedback on #19754. RateLimitMiddleware passed window and the result of costCallback to the limiter without checks: A window of 0 crashed all three limiters with DivisionByZero...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedereuromark
hostnamegithub.com
expected-hostnamegithub.com
Nonebdbacc25b921224ff0befcb9e629560a1255be51aec9991d6e3f95b5e9151474
turbo-cache-controlno-cache
go-importgithub.com/cakephp/cakephp git https://github.com/cakephp/cakephp.git
octolytics-dimension-user_id23666
octolytics-dimension-user_logincakephp
octolytics-dimension-repository_id656494
octolytics-dimension-repository_nwocakephp/cakephp
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id656494
octolytics-dimension-repository_network_root_nwocakephp/cakephp
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release556dd37bb0aceffb25724e151b5d858b3265b40b
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/cakephp/cakephp/pull/19766#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19766
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19766
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=cakephp%2Fcakephp
Reloadhttps://github.com/cakephp/cakephp/pull/19766
Reloadhttps://github.com/cakephp/cakephp/pull/19766
Reloadhttps://github.com/cakephp/cakephp/pull/19766
cakephphttps://github.com/cakephp
cakephphttps://github.com/cakephp/cakephp
Codehttps://github.com/cakephp/cakephp
Issues13 (13)https://github.com/cakephp/cakephp/issues
Pull requests16 (16)https://github.com/cakephp/cakephp/pulls
Actionshttps://github.com/cakephp/cakephp/actions
Projectshttps://github.com/cakephp/cakephp/projects
Wikihttps://github.com/cakephp/cakephp/wiki
Security and quality6 (6)https://github.com/cakephp/cakephp/security
Insightshttps://github.com/cakephp/cakephp/insights
https://github.com/cakephp/cakephp
dereuromarkhttps://github.com/dereuromark
5.xhttps://github.com/cakephp/cakephp/tree/5.x
5.x-rate-limit-validationhttps://github.com/cakephp/cakephp/tree/5.x-rate-limit-validation
Conversationhttps://github.com/cakephp/cakephp/pull/19766
Commits1 (1)https://github.com/cakephp/cakephp/pull/19766/commits
Checkshttps://github.com/cakephp/cakephp/pull/19766/checks
Files changedhttps://github.com/cakephp/cakephp/pull/19766/files
Validate rate limit window and cost in RateLimitMiddlewarehttps://github.com/cakephp/cakephp/pull/19766#top
dereuromarkhttps://github.com/dereuromark
5.xhttps://github.com/cakephp/cakephp/tree/5.x
5.x-rate-limit-validationhttps://github.com/cakephp/cakephp/tree/5.x-rate-limit-validation
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
Nov 2, 2026https://github.com/cakephp/cakephp/pull/19766#issue-6167772701
#19754https://github.com/cakephp/cakephp/pull/19754
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19766
https://github.com/dereuromark
Validate rate limit window and cost in RateLimitMiddlewarehttps://github.com/cakephp/cakephp/pull/19766/commits/5cbf9c7364764a67444a110bc8bddf7f6ad10a1f
5cbf9c7https://github.com/cakephp/cakephp/pull/19766/commits/5cbf9c7364764a67444a110bc8bddf7f6ad10a1f
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
5.4.5https://github.com/cakephp/cakephp/milestone/362
Nov 2, 2026https://github.com/cakephp/cakephp/pull/19766#event-34937759833
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
defect https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Adefect
middleware https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Amiddleware
Nov 2, 2026https://github.com/cakephp/cakephp/pull/19766#event-34937759919
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
5.4.5https://github.com/cakephp/cakephp/milestone/362
5.4.4https://github.com/cakephp/cakephp/milestone/360
Nov 2, 2026https://github.com/cakephp/cakephp/pull/19766#event-34937977546
https://github.com/dereuromark
dereuromarkhttps://github.com/dereuromark
Nov 2, 2026 https://github.com/cakephp/cakephp/pull/19766#ref-pullrequest-6097823678
Fix SlidingWindowRateLimiter allowing unlimited requests #19754 https://github.com/cakephp/cakephp/pull/19754
https://github.com/markstory
markstoryhttps://github.com/markstory
5.4.4https://github.com/cakephp/cakephp/milestone/360
5.4.5https://github.com/cakephp/cakephp/milestone/362
Nov 2, 2026https://github.com/cakephp/cakephp/pull/19766#event-34960417142
https://github.co/hiddenchars
https://github.com/cakephp/cakephp/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fcakephp%2Fcakephp%2Fpull%2F19766
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19766
defect https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Adefect
middleware https://github.com/cakephp/cakephp/issues?q=state%3Aopen%20label%3Amiddleware
5.4.5 https://github.com/cakephp/cakephp/milestone/362
Please reload this pagehttps://github.com/cakephp/cakephp/pull/19766
https://github.com/dereuromark
https://github.com/markstory
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.