René's URL Explorer Experiment


Title: WIP: Adding type hints to formatter.py by Ben-Reg · Pull Request #947 · bpython/bpython · GitHub

Open Graph Title: WIP: Adding type hints to formatter.py by Ben-Reg · Pull Request #947 · bpython/bpython

X Title: WIP: Adding type hints to formatter.py by Ben-Reg · Pull Request #947 · bpython/bpython

Description: bpython - A fancy curses interface to the Python interactive interpreter - WIP: Adding type hints to formatter.py by Ben-Reg · Pull Request #947 · bpython/bpython

Open Graph Description: Adding type hints to formatter.py. A note on line 128. token = token.parent causes some problems with mypy because token is type _TokenType while token.parent is Optional[_TokenType] The easy solu...

X Description: Adding type hints to formatter.py. A note on line 128. token = token.parent causes some problems with mypy because token is type _TokenType while token.parent is Optional[_TokenType] The easy solu...

Opengraph URL: https://github.com/bpython/bpython/pull/947

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f65fc563-11d2-d968-6c96-c77672bbd948
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id898C:1FE434:1684C9B:1DB5803:6B02011F
html-safe-nonce9abdc6159d1eef0edf0c829dc995dd6b64907b4476da28e2a692bb92dabf15b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OThDOjFGRTQzNDoxNjg0QzlCOjFEQjU4MDM6NkIwMjAxMUYiLCJ2aXNpdG9yX2lkIjoiODk2NTAxMDc1NDg2MDM1MTc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc8ea063b2c36389dede289013e93530c010a7aa7bfd9adfc53e967e1f3c00c29
hovercard-subject-tagpull_request:813559355
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/bpython/bpython/947/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/fa04ca45ab646721ccfbcc7271560b7861c2646c5b4ed5298630959a215b737e/bpython/bpython/pull/947
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fa04ca45ab646721ccfbcc7271560b7861c2646c5b4ed5298630959a215b737e/bpython/bpython/pull/947
og:image:altAdding type hints to formatter.py. A note on line 128. token = token.parent causes some problems with mypy because token is type _TokenType while token.parent is Optional[_TokenType] The easy solu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBen-Reg
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/bpython/bpython git https://github.com/bpython/bpython.git
octolytics-dimension-user_id8071396
octolytics-dimension-user_loginbpython
octolytics-dimension-repository_id21508865
octolytics-dimension-repository_nwobpython/bpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id21508865
octolytics-dimension-repository_network_root_nwobpython/bpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/bpython/bpython/pull/947#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F947
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F947
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=bpython%2Fbpython
Reloadhttps://github.com/bpython/bpython/pull/947
Reloadhttps://github.com/bpython/bpython/pull/947
Reloadhttps://github.com/bpython/bpython/pull/947
bpythonhttps://github.com/bpython
bpythonhttps://github.com/bpython/bpython
Codehttps://github.com/bpython/bpython
Issues126 (126)https://github.com/bpython/bpython/issues
Pull requests6 (6)https://github.com/bpython/bpython/pulls
Actionshttps://github.com/bpython/bpython/actions
Projectshttps://github.com/bpython/bpython/projects
Wikihttps://github.com/bpython/bpython/wiki
Security and qualityhttps://github.com/bpython/bpython/security
Insightshttps://github.com/bpython/bpython/insights
https://github.com/bpython/bpython
Ben-Reghttps://github.com/Ben-Reg
bpython:mainhttps://github.com/bpython/bpython/tree/main
Ben-Reg:pr/addTypeHintshttps://github.com/Ben-Reg/bpython/tree/pr/addTypeHints
Conversationhttps://github.com/bpython/bpython/pull/947
Commits4 (4)https://github.com/bpython/bpython/pull/947/commits
Checkshttps://github.com/bpython/bpython/pull/947/checks
Files changedhttps://github.com/bpython/bpython/pull/947/files
WIP: Adding type hints to formatter.pyhttps://github.com/bpython/bpython/pull/947#top
Ben-Reghttps://github.com/Ben-Reg
bpython:mainhttps://github.com/bpython/bpython/tree/main
Ben-Reg:pr/addTypeHintshttps://github.com/Ben-Reg/bpython/tree/pr/addTypeHints
https://github.com/Ben-Reg
Ben-Reghttps://github.com/Ben-Reg
Jan 4, 2022https://github.com/bpython/bpython/pull/947#issue-1093000589
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/Ben-Reg
WIP: Adding type hints to formatter.pyhttps://github.com/bpython/bpython/pull/947/commits/a3d7b94c77411405d058ad517d8414391730b629
a3d7b94https://github.com/bpython/bpython/pull/947/commits/a3d7b94c77411405d058ad517d8414391730b629
https://github.com/Ben-Reg
Ben-Reghttps://github.com/Ben-Reg
Jan 4, 2022 https://github.com/bpython/bpython/pull/947#ref-issue-851196765
Add type annotations #892 https://github.com/bpython/bpython/issues/892
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jan 5, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1005831091
Please reload this pagehttps://github.com/bpython/bpython/pull/947
Codecovhttps://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
#947https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
0ca23b1https://github.com/bpython/bpython/commit/0ca23b1a6de9bc46f74171ec340677a5d261aabb
mainhttps://codecov.io/gh/bpython/bpython/commit/4d33cc6ef6114fb173452ade774b8995ffc54783?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
4d33cc6https://github.com/bpython/bpython/commit/4d33cc6ef6114fb173452ade774b8995ffc54783
https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
Impacted Fileshttps://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
bpython/formatter.pyhttps://codecov.io/gh/bpython/bpython/pull/947/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython#diff-YnB5dGhvbi9mb3JtYXR0ZXIucHk=
Continue to review full report at Codecovhttps://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
Codecovhttps://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
4d33cc6...0ca23b1https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/Ben-Reg
Ben-Reghttps://github.com/Ben-Reg
Jan 6, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1006668295
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/Ben-Reg
Formatted with Blackhttps://github.com/bpython/bpython/pull/947/commits/895fdc0a046693bea17e7dd0e8009828ff780285
895fdc0https://github.com/bpython/bpython/pull/947/commits/895fdc0a046693bea17e7dd0e8009828ff780285
https://github.com/thomasballinger
thomasballingerhttps://github.com/thomasballinger
Jan 6, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1006919221
Please reload this pagehttps://github.com/bpython/bpython/pull/947
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/Ben-Reg
Ben-Reghttps://github.com/Ben-Reg
Jan 6, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1006952585
@thomasballingerhttps://github.com/thomasballinger
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/Ben-Reg
Added temp variable to allow for stricter typing.https://github.com/bpython/bpython/pull/947/commits/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81
8d71839https://github.com/bpython/bpython/pull/947/commits/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81
https://github.com/sebastinas
sebastinashttps://github.com/sebastinas
Jan 6, 2022 https://github.com/bpython/bpython/pull/947#pullrequestreview-846144170
View reviewed changes https://github.com/bpython/bpython/pull/947/files/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81
bpython/formatter.pyhttps://github.com/bpython/bpython/pull/947/files/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81#diff-fdfcaba32e80de36c1d2a69fedae67b083876d6f10e9ad624984ac00e87f01f2
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/Ben-Reg
Second attempt at stricter typing.https://github.com/bpython/bpython/pull/947/commits/0ca23b1a6de9bc46f74171ec340677a5d261aabb
0ca23b1https://github.com/bpython/bpython/pull/947/commits/0ca23b1a6de9bc46f74171ec340677a5d261aabb
https://github.com/Ben-Reg
Ben-Reghttps://github.com/Ben-Reg
Jan 14, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1013237926
@thomasballingerhttps://github.com/thomasballinger
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/thomasballinger
thomasballingerhttps://github.com/thomasballinger
Jan 14, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1013250527
Please reload this pagehttps://github.com/bpython/bpython/pull/947
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/thomasballinger
thomasballingerhttps://github.com/thomasballinger
Jan 14, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1013374334
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/thomasballinger
thomasballingerhttps://github.com/thomasballinger
Jan 14, 2022https://github.com/bpython/bpython/pull/947#issuecomment-1013377537
@Ben-Reghttps://github.com/Ben-Reg
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/thomasballinger
thomasballingerhttps://github.com/thomasballinger
Jan 14, 2022https://github.com/bpython/bpython/pull/947#event-5896671377
https://github.co/hiddenchars
https://github.com/bpython/bpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F947
https://github.com/sebastinas
sebastinas https://github.com/sebastinas
https://github.com/bpython/bpython/pull/947/files/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81
Please reload this pagehttps://github.com/bpython/bpython/pull/947
Please reload this pagehttps://github.com/bpython/bpython/pull/947
https://github.com/Ben-Reg
https://github.com/codecov-commenter
https://github.com/thomasballinger
https://github.com/sebastinas
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.