| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f65fc563-11d2-d968-6c96-c77672bbd948 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 898C:1FE434:1684C9B:1DB5803:6B02011F |
| html-safe-nonce | 9abdc6159d1eef0edf0c829dc995dd6b64907b4476da28e2a692bb92dabf15b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OThDOjFGRTQzNDoxNjg0QzlCOjFEQjU4MDM6NkIwMjAxMUYiLCJ2aXNpdG9yX2lkIjoiODk2NTAxMDc1NDg2MDM1MTc3NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c8ea063b2c36389dede289013e93530c010a7aa7bfd9adfc53e967e1f3c00c29 |
| hovercard-subject-tag | pull_request:813559355 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/bpython/bpython/947/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/fa04ca45ab646721ccfbcc7271560b7861c2646c5b4ed5298630959a215b737e/bpython/bpython/pull/947 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fa04ca45ab646721ccfbcc7271560b7861c2646c5b4ed5298630959a215b737e/bpython/bpython/pull/947 |
| og:image:alt | Adding type hints to formatter.py.
A note on line 128. token = token.parent causes some problems with mypy because token is type _TokenType while token.parent is Optional[_TokenType]
The easy solu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Ben-Reg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/bpython/bpython git https://github.com/bpython/bpython.git |
| octolytics-dimension-user_id | 8071396 |
| octolytics-dimension-user_login | bpython |
| octolytics-dimension-repository_id | 21508865 |
| octolytics-dimension-repository_nwo | bpython/bpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21508865 |
| octolytics-dimension-repository_network_root_nwo | bpython/bpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/bpython/bpython/pull/947#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F947 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F947 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=bpython%2Fbpython |
| Reload | https://github.com/bpython/bpython/pull/947 |
| Reload | https://github.com/bpython/bpython/pull/947 |
| Reload | https://github.com/bpython/bpython/pull/947 |
| bpython | https://github.com/bpython |
| bpython | https://github.com/bpython/bpython |
| Code | https://github.com/bpython/bpython |
| Issues126 (126) | https://github.com/bpython/bpython/issues |
| Pull requests6 (6) | https://github.com/bpython/bpython/pulls |
| Actions | https://github.com/bpython/bpython/actions |
| Projects | https://github.com/bpython/bpython/projects |
| Wiki | https://github.com/bpython/bpython/wiki |
| Security and quality | https://github.com/bpython/bpython/security |
| Insights | https://github.com/bpython/bpython/insights |
| https://github.com/bpython/bpython |
| Ben-Reg | https://github.com/Ben-Reg |
| bpython:main | https://github.com/bpython/bpython/tree/main |
| Ben-Reg:pr/addTypeHints | https://github.com/Ben-Reg/bpython/tree/pr/addTypeHints |
| Conversation | https://github.com/bpython/bpython/pull/947 |
| Commits4 (4) | https://github.com/bpython/bpython/pull/947/commits |
| Checks | https://github.com/bpython/bpython/pull/947/checks |
| Files changed | https://github.com/bpython/bpython/pull/947/files |
| WIP: Adding type hints to formatter.py | https://github.com/bpython/bpython/pull/947#top |
| Ben-Reg | https://github.com/Ben-Reg |
| bpython:main | https://github.com/bpython/bpython/tree/main |
| Ben-Reg:pr/addTypeHints | https://github.com/Ben-Reg/bpython/tree/pr/addTypeHints |
|
| https://github.com/Ben-Reg |
| Ben-Reg | https://github.com/Ben-Reg |
| Jan 4, 2022 | https://github.com/bpython/bpython/pull/947#issue-1093000589 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
|
| https://github.com/Ben-Reg |
| WIP: Adding type hints to formatter.py | https://github.com/bpython/bpython/pull/947/commits/a3d7b94c77411405d058ad517d8414391730b629 |
| a3d7b94 | https://github.com/bpython/bpython/pull/947/commits/a3d7b94c77411405d058ad517d8414391730b629 |
| https://github.com/Ben-Reg |
| Ben-Reg | https://github.com/Ben-Reg |
|
Jan 4, 2022
| https://github.com/bpython/bpython/pull/947#ref-issue-851196765 |
|
Add type annotations
#892
| https://github.com/bpython/bpython/issues/892 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Jan 5, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1005831091 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| Codecov | https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| #947 | https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| 0ca23b1 | https://github.com/bpython/bpython/commit/0ca23b1a6de9bc46f74171ec340677a5d261aabb |
| main | https://codecov.io/gh/bpython/bpython/commit/4d33cc6ef6114fb173452ade774b8995ffc54783?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| 4d33cc6 | https://github.com/bpython/bpython/commit/4d33cc6ef6114fb173452ade774b8995ffc54783 |
| https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| Impacted Files | https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| bpython/formatter.py | https://codecov.io/gh/bpython/bpython/pull/947/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython#diff-YnB5dGhvbi9mb3JtYXR0ZXIucHk= |
| Continue to review full report at Codecov | https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| Codecov | https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| 4d33cc6...0ca23b1 | https://codecov.io/gh/bpython/bpython/pull/947?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| comment docs | https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bpython |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| https://github.com/Ben-Reg |
| Ben-Reg | https://github.com/Ben-Reg |
| Jan 6, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1006668295 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
|
| https://github.com/Ben-Reg |
| Formatted with Black | https://github.com/bpython/bpython/pull/947/commits/895fdc0a046693bea17e7dd0e8009828ff780285 |
| 895fdc0 | https://github.com/bpython/bpython/pull/947/commits/895fdc0a046693bea17e7dd0e8009828ff780285 |
| https://github.com/thomasballinger |
| thomasballinger | https://github.com/thomasballinger |
| Jan 6, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1006919221 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| https://github.com/Ben-Reg |
| Ben-Reg | https://github.com/Ben-Reg |
| Jan 6, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1006952585 |
| @thomasballinger | https://github.com/thomasballinger |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
|
| https://github.com/Ben-Reg |
| Added temp variable to allow for stricter typing. | https://github.com/bpython/bpython/pull/947/commits/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81 |
| 8d71839 | https://github.com/bpython/bpython/pull/947/commits/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81 |
| https://github.com/sebastinas |
| sebastinas | https://github.com/sebastinas |
|
Jan 6, 2022
| https://github.com/bpython/bpython/pull/947#pullrequestreview-846144170 |
|
View reviewed changes
| https://github.com/bpython/bpython/pull/947/files/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81 |
| bpython/formatter.py | https://github.com/bpython/bpython/pull/947/files/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81#diff-fdfcaba32e80de36c1d2a69fedae67b083876d6f10e9ad624984ac00e87f01f2 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
|
| https://github.com/Ben-Reg |
| Second attempt at stricter typing. | https://github.com/bpython/bpython/pull/947/commits/0ca23b1a6de9bc46f74171ec340677a5d261aabb |
| 0ca23b1 | https://github.com/bpython/bpython/pull/947/commits/0ca23b1a6de9bc46f74171ec340677a5d261aabb |
| https://github.com/Ben-Reg |
| Ben-Reg | https://github.com/Ben-Reg |
| Jan 14, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1013237926 |
| @thomasballinger | https://github.com/thomasballinger |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| https://github.com/thomasballinger |
| thomasballinger | https://github.com/thomasballinger |
| Jan 14, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1013250527 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| https://github.com/thomasballinger |
| thomasballinger | https://github.com/thomasballinger |
| Jan 14, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1013374334 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| https://github.com/thomasballinger |
| thomasballinger | https://github.com/thomasballinger |
| Jan 14, 2022 | https://github.com/bpython/bpython/pull/947#issuecomment-1013377537 |
| @Ben-Reg | https://github.com/Ben-Reg |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| https://github.com/thomasballinger |
| thomasballinger | https://github.com/thomasballinger |
| Jan 14, 2022 | https://github.com/bpython/bpython/pull/947#event-5896671377 |
| https://github.co/hiddenchars |
| https://github.com/bpython/bpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F947 |
|
| https://github.com/sebastinas |
|
sebastinas
| https://github.com/sebastinas |
|
| https://github.com/bpython/bpython/pull/947/files/8d71839cb5e3a54f17de308d1b450cf7d7a1cd81 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
| Please reload this page | https://github.com/bpython/bpython/pull/947 |
|
| https://github.com/Ben-Reg |
|
| https://github.com/codecov-commenter |
|
| https://github.com/thomasballinger |
|
| https://github.com/sebastinas |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |