Title: Add width awareness to fix wrapping of strings with full width chars by rybarczykj · Pull Request #839 · bpython/bpython · GitHub
Open Graph Title: Add width awareness to fix wrapping of strings with full width chars by rybarczykj · Pull Request #839 · bpython/bpython
X Title: Add width awareness to fix wrapping of strings with full width chars by rybarczykj · Pull Request #839 · bpython/bpython
Description: This is a redux of #731 which was put on hold until a need for width awareness was found. I'd say this is a decent justification for bringing it back Wrapping strings with fullwidth chars Here's the same string being typed before and after width awareness: New method to fix cursor position: When we put a 2-column character at the end of the line where there's only 1 column of room, curtsies adds a padding character (space) so we can kick it down to the line below. Therefore, in order to get the right cursor position, I had to add a method that determines how many padding chars there are (number_of_padding_chars_on_current_cursor_line). Note on this method: Right now, to determine the amount of padding, it calls display_linize, doubling the amount of times we call that function. It's definitely possible to keep track of this as a variable in the repl class instead, or to do some changes other to ensure less redundant work is done. Feedback appreciated. Runtime One of the barriers stopping us from implementing this before was runtime . I did not find any noticeable difference when pasting, printing, or moving my cursor around large strings.
Open Graph Description: This is a redux of #731 which was put on hold until a need for width awareness was found. I'd say this is a decent justification for bringing it back Wrapping strings with fullwidth chars Here&...
X Description: This is a redux of #731 which was put on hold until a need for width awareness was found. I'd say this is a decent justification for bringing it back Wrapping strings with fullwidth chars H...
Opengraph URL: https://github.com/bpython/bpython/pull/839
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c13ebc18-d975-abe4-f5e1-2a2618b25ce9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B99E:34EAA:F2F462:14EFBBA:6968A593 |
| html-safe-nonce | fe7b3e25551e4fc39b5e3871bf993c170b5724b52b74d54ac2bcd3ddf55e2ec8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTlFOjM0RUFBOkYyRjQ2MjoxNEVGQkJBOjY5NjhBNTkzIiwidmlzaXRvcl9pZCI6IjEwMTA3MjMzMTI1Mjc1MTcwNzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6f5caea1f1b62becb00d7d44c70755287a3e3afc5f3088fb34dc087bc692a3ac |
| hovercard-subject-tag | pull_request:463670430 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/bpython/bpython/pull/839/files |
| twitter:image | https://avatars.githubusercontent.com/u/48132522?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/48132522?s=400&v=4 |
| og:image:alt | This is a redux of #731 which was put on hold until a need for width awareness was found. I'd say this is a decent justification for bringing it back Wrapping strings with fullwidth chars Here&... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/bpython/bpython git https://github.com/bpython/bpython.git |
| octolytics-dimension-user_id | 8071396 |
| octolytics-dimension-user_login | bpython |
| octolytics-dimension-repository_id | 21508865 |
| octolytics-dimension-repository_nwo | bpython/bpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21508865 |
| octolytics-dimension-repository_network_root_nwo | bpython/bpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width