| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e38550bb-5abf-dcb5-1f62-e8b8b471250e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C358:2250E:9AF51A:D65B4D:6968A60A |
| html-safe-nonce | 2d4905b47b28840272d586f1db24ee624330036f79bd60a5d21ad26bb34e7a82 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzU4OjIyNTBFOjlBRjUxQTpENjVCNEQ6Njk2OEE2MEEiLCJ2aXNpdG9yX2lkIjoiNjQ0NTA3MDcxOTkzNjUyNzQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2c9aaaa7c23feb470cfcd07e98a98ef50f2f5660c484038f16d862a8820517ef |
| hovercard-subject-tag | pull_request:440785371 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/bpython/bpython/pull/814/files |
| twitter:image | https://avatars.githubusercontent.com/u/67104884?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/67104884?s=400&v=4 |
| og:image:alt | Use os.path.realpath to see the source of symbolic links and makes sure that we are not in a loop. Also include importtest.py and importtestfolder to test if program gets stuck in a loop.
Resolves ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | fdc7c66bd36a6c12eb8e771e806db863266e573fc299e77f27505a768d4f8a98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/bpython/bpython git https://github.com/bpython/bpython.git |
| octolytics-dimension-user_id | 8071396 |
| octolytics-dimension-user_login | bpython |
| octolytics-dimension-repository_id | 21508865 |
| octolytics-dimension-repository_nwo | bpython/bpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 21508865 |
| octolytics-dimension-repository_network_root_nwo | bpython/bpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3223a6503d318917691422cdadfbe16cd8fb21e5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/bpython/bpython/pull/814/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F814%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbpython%2Fbpython%2Fpull%2F814%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=bpython%2Fbpython |
| Reload | https://github.com/bpython/bpython/pull/814/files |
| Reload | https://github.com/bpython/bpython/pull/814/files |
| Reload | https://github.com/bpython/bpython/pull/814/files |
|
bpython
| https://github.com/bpython |
| bpython | https://github.com/bpython/bpython |
| Please reload this page | https://github.com/bpython/bpython/pull/814/files |
|
Notifications
| https://github.com/login?return_to=%2Fbpython%2Fbpython |
|
Fork
252
| https://github.com/login?return_to=%2Fbpython%2Fbpython |
|
Star
2.8k
| https://github.com/login?return_to=%2Fbpython%2Fbpython |
|
Code
| https://github.com/bpython/bpython |
|
Issues
143
| https://github.com/bpython/bpython/issues |
|
Pull requests
4
| https://github.com/bpython/bpython/pulls |
|
Actions
| https://github.com/bpython/bpython/actions |
|
Projects
0
| https://github.com/bpython/bpython/projects |
|
Wiki
| https://github.com/bpython/bpython/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/bpython/bpython/security |
| Please reload this page | https://github.com/bpython/bpython/pull/814/files |
|
Insights
| https://github.com/bpython/bpython/pulse |
|
Code
| https://github.com/bpython/bpython |
|
Issues
| https://github.com/bpython/bpython/issues |
|
Pull requests
| https://github.com/bpython/bpython/pulls |
|
Actions
| https://github.com/bpython/bpython/actions |
|
Projects
| https://github.com/bpython/bpython/projects |
|
Wiki
| https://github.com/bpython/bpython/wiki |
|
Security
| https://github.com/bpython/bpython/security |
|
Insights
| https://github.com/bpython/bpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fbpython%2Fbpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fbpython%2Fbpython%2Fissues%2Fnew%2Fchoose |
| thomasballinger | https://github.com/thomasballinger |
| bpython:master | https://github.com/bpython/bpython/tree/master |
| etiennerichart:sym-two | https://github.com/etiennerichart/bpython/tree/sym-two |
|
Conversation
36
| https://github.com/bpython/bpython/pull/814 |
|
Commits
24
| https://github.com/bpython/bpython/pull/814/commits |
|
Checks
0
| https://github.com/bpython/bpython/pull/814/checks |
|
Files changed
| https://github.com/bpython/bpython/pull/814/files |
| Please reload this page | https://github.com/bpython/bpython/pull/814/files |
|
Sym two
| https://github.com/bpython/bpython/pull/814/files#top |
|
Show all changes
24 commits
| https://github.com/bpython/bpython/pull/814/files |
|
f4c0ed6
some changes to file reading
etiennerichart Jun 25, 2020
| https://github.com/bpython/bpython/pull/814/commits/f4c0ed66f34593d8caa5cfb92e0d2aee765a3395 |
|
347707d
Some work on symbolic link files
etiennerichart Jun 26, 2020
| https://github.com/bpython/bpython/pull/814/commits/347707dde58c33055356c743494181ee9b8cb7b8 |
|
3f13a28
Cleaned up symlink fix ideas
etiennerichart Jun 26, 2020
| https://github.com/bpython/bpython/pull/814/commits/3f13a28574b61bab7fc36da0bbe818fec8af7105 |
|
47ea5ee
More clean up
etiennerichart Jun 26, 2020
| https://github.com/bpython/bpython/pull/814/commits/47ea5ee6728f032664d5a150e1ddfe59e1059fe4 |
|
6eff3b2
Make it easier to test different methods
etiennerichart Jun 26, 2020
| https://github.com/bpython/bpython/pull/814/commits/6eff3b2ca6ea228772be8e381a6a225372fc7520 |
|
8e08f3a
Found an even better way. useNameSubname = 4
etiennerichart Jun 26, 2020
| https://github.com/bpython/bpython/pull/814/commits/8e08f3a7b963b36466449cc2e6b57f6df671b7d0 |
|
2b96e8d
"Used os.path.realpath to fix issue"
etiennerichart Jun 29, 2020
| https://github.com/bpython/bpython/pull/814/commits/2b96e8d69ace845794102d398e361e6f2da5b6f1 |
|
44f76f7
Removed code that I was using for testing
etiennerichart Jun 29, 2020
| https://github.com/bpython/bpython/pull/814/commits/44f76f7fbd1655748a74167d45d3c712b5444033 |
|
513f37d
Made variable to store paths for comparison.
etiennerichart Jun 30, 2020
| https://github.com/bpython/bpython/pull/814/commits/513f37d45c48464297d3fa792ede5e7358d820bb |
|
01a6a4c
further finalize changes to importcompletion.py
etiennerichart Jul 3, 2020
| https://github.com/bpython/bpython/pull/814/commits/01a6a4c1a789b37d02e59a613b2c5e30b50cca73 |
|
2edc977
Working on test but am having issues with the try
etiennerichart Jul 6, 2020
| https://github.com/bpython/bpython/pull/814/commits/2edc977f46f73ff4b79804eb600d032b3931fa7e |
|
62bed48
replaced import test file with them file directory
etiennerichart Jul 7, 2020
| https://github.com/bpython/bpython/pull/814/commits/62bed480afa42c6fa2757fb83cf31a4affe1ca9b |
|
45ada74
fixed importtest.py
etiennerichart Jul 8, 2020
| https://github.com/bpython/bpython/pull/814/commits/45ada741bb37876ce126cc8b6192df25bfb67168 |
|
9fafb2e
moved and renamed importtest to test folder
etiennerichart Jul 8, 2020
| https://github.com/bpython/bpython/pull/814/commits/9fafb2ee2a82fd385b9c8973194c94bda12045c1 |
|
52cef9f
cleaned up test file
etiennerichart Jul 9, 2020
| https://github.com/bpython/bpython/pull/814/commits/52cef9ffb115d82d2396fe816502dfe225e43972 |
|
6983428
improved test
etiennerichart Jul 9, 2020
| https://github.com/bpython/bpython/pull/814/commits/6983428af5bbc717a9ee3a72a89ca5cff1792806 |
|
5928198
made it so test skips in python 2
etiennerichart Jul 9, 2020
| https://github.com/bpython/bpython/pull/814/commits/5928198b149db10e8a7f8b2024123085432f3513 |
|
dbc1d4f
made skipping work
etiennerichart Jul 9, 2020
| https://github.com/bpython/bpython/pull/814/commits/dbc1d4fe7a4dddef5e96a7d7f50ecbda5e769335 |
|
5f15d7d
removed chdir and made better test skip
etiennerichart Jul 13, 2020
| https://github.com/bpython/bpython/pull/814/commits/5f15d7d61e1b95a01db126123afa8e6b2308686b |
|
8bd85e9
fix symbolic links for the test
etiennerichart Jul 16, 2020
| https://github.com/bpython/bpython/pull/814/commits/8bd85e91ee203e3915265cb50e40a75bbd1f728b |
|
0a29731
used black auto format
etiennerichart Jul 16, 2020
| https://github.com/bpython/bpython/pull/814/commits/0a2973112710b3568db36642f29de18600d987d2 |
|
cec627a
improved test to work on other computers
etiennerichart Jul 16, 2020
| https://github.com/bpython/bpython/pull/814/commits/cec627a7f67eb8dffe47664e6dd6e844a085624e |
|
629bf1e
made testing strickter
etiennerichart Jul 16, 2020
| https://github.com/bpython/bpython/pull/814/commits/629bf1e915fa3ebff12f9f73ce6ceb7900b52a83 |
|
11369fc
further testing
etiennerichart Jul 16, 2020
| https://github.com/bpython/bpython/pull/814/commits/11369fcc2cd60dd9f4dcf2618424f9b3ae994696 |
|
Clear filters
| https://github.com/bpython/bpython/pull/814/files |
| Please reload this page | https://github.com/bpython/bpython/pull/814/files |
| Please reload this page | https://github.com/bpython/bpython/pull/814/files |
|
importcompletion.py
| https://github.com/bpython/bpython/pull/814/files#diff-eeac661e48b14eea3002706465fef5017e9311536ac398cc49b8e7ddef549489 |
|
test_import_not_cyclical.py
| https://github.com/bpython/bpython/pull/814/files#diff-9d83ea480c1ee6bd4526b464a99951a5dc895ca408af4b07e8c8802fdaea6cbc |
| bpython/importcompletion.py | https://github.com/bpython/bpython/pull/814/files#diff-eeac661e48b14eea3002706465fef5017e9311536ac398cc49b8e7ddef549489 |
|
View file
| https://github.com/etiennerichart/bpython/blob/11369fcc2cd60dd9f4dcf2618424f9b3ae994696/bpython/importcompletion.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/bpython/bpython/pull/814/{{ revealButtonHref }} |
|
| https://github.com/bpython/bpython/pull/814/files#diff-eeac661e48b14eea3002706465fef5017e9311536ac398cc49b8e7ddef549489 |
|
| https://github.com/bpython/bpython/pull/814/files#diff-eeac661e48b14eea3002706465fef5017e9311536ac398cc49b8e7ddef549489 |
|
| https://github.com/bpython/bpython/pull/814/files#diff-eeac661e48b14eea3002706465fef5017e9311536ac398cc49b8e7ddef549489 |
| thomasballinger | https://github.com/thomasballinger |
| Jul 1, 2020 | https://github.com/bpython/bpython/pull/814/files#r448074341 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| set up VSCode to run black automatically | https://code.visualstudio.com/docs/python/editing#_formatting |
| Please reload this page | https://github.com/bpython/bpython/pull/814/files |
|
| https://github.com/bpython/bpython/pull/814/files#diff-eeac661e48b14eea3002706465fef5017e9311536ac398cc49b8e7ddef549489 |
| bpython/test/test_import_not_cyclical.py | https://github.com/bpython/bpython/pull/814/files#diff-9d83ea480c1ee6bd4526b464a99951a5dc895ca408af4b07e8c8802fdaea6cbc |
|
View file
| https://github.com/etiennerichart/bpython/blob/11369fcc2cd60dd9f4dcf2618424f9b3ae994696/bpython/test/test_import_not_cyclical.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/bpython/bpython/pull/814/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |