René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Uncaught exception by `repl.complete`","articleBody":"When generating completions, bpython has to interact with the given objects.  These objects might be the product of active development, so a bug in, for example, `__getattribute__` of the user code happens sometimes.  bpython should stomach such errors.\r\n\r\nMinimal reproducing example:\r\n```\r\n$ bpython3\r\nbpython version 0.17.1 on top of Python 3.7.3 /usr/bin/python3\r\n\u003e\u003e\u003e class BadClass:\r\n...     def __getattribute__(self, name):\r\n...         assert False, \"Let's say there is a bug here.\"\r\n... \r\n\u003e\u003e\u003e x = BadClass()\r\n\u003e\u003e\u003e x(\r\nTraceback (most recent call last):\r\n  File \"/usr/bin/bpython3\", line 11, in \u003cmodule\u003e\r\n    load_entry_point('bpython==0.17.1', 'console_scripts', 'bpython')()\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsies.py\", line 191, in main\r\n    exit_value = repl.mainloop(True, paste)\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsies.py\", line 126, in mainloop\r\n    self.process_event_and_paint(e)\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsies.py\", line 90, in process_event_and_paint\r\n    self.process_event(e)\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsiesfrontend/repl.py\", line 603, in process_event\r\n    return self.process_key_event(e)\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsiesfrontend/repl.py\", line 757, in process_key_event\r\n    self.add_normal_character(e)\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsiesfrontend/repl.py\", line 1001, in add_normal_character\r\n    self.cursor_offset += 1\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsiesfrontend/repl.py\", line 1594, in _set_cursor_offset\r\n    self.update_completion()\r\n  File \"/usr/lib/python3/dist-packages/bpython/curtsiesfrontend/repl.py\", line 1032, in update_completion\r\n    self.list_win_visible = self.complete(tab)\r\n  File \"/usr/lib/python3/dist-packages/bpython/repl.py\", line 724, in complete\r\n    self.set_docstring()\r\n  File \"/usr/lib/python3/dist-packages/bpython/repl.py\", line 688, in set_docstring\r\n    if not self.get_args():\r\n  File \"/usr/lib/python3/dist-packages/bpython/repl.py\", line 635, in get_args\r\n    if inspect.isclass(f):\r\n  File \"/usr/lib/python3.7/inspect.py\", line 78, in isclass\r\n    return isinstance(object, type)\r\n  File \"\u003cbpython-input-5\u003e\", line 3, in __getattribute__\r\nAssertionError: Let's say there is a bug here.\r\n[$? = 1]\r\n```\r\n\r\nIn the above session, I typed the `(`, but it did not appear on screen.  (Boo me, I edited that part.)\r\n\r\nI see two ways to fix this: Either wrap the code in `complete` in a `try … finally`, or wrap all the places where user code gets called.  (This might be hard to find.)\r\n\r\nNone of the other issues seem to be related.","author":{"url":"https://github.com/BenWiederhake","@type":"Person","name":"BenWiederhake"},"datePublished":"2019-07-15T23:57:54.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/776/bpython/issues/776"}