René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add tests for problems exposed by cosmic-ray","articleBody":"```diff\r\njob ID 1f37d3c49055482e8dbcea3a1d3f8830:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   1\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -13,7 +13,7 @@\r\n         app.add_url_rule(rule=endpoint, endpoint=endpoint, view_func=self._postreceive, methods=['POST'])\r\n         self._hooks = collections.defaultdict(list)\r\n         self._logger = logging.getLogger('webhook')\r\n-        if ((secret is not None) and (not isinstance(secret, six.binary_type))):\r\n+        if ((secret != None) and (not isinstance(secret, six.binary_type))):\r\n             secret = secret.encode('utf-8')\r\n         self._secret = secret\r\n\r\n\r\njob ID 2e66309c18ed4f9c8953fc622f5f5211:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   1 0\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -32,7 +32,7 @@\r\n     def _postreceive(self):\r\n         'Callback from Flask'\r\n         digest = self._get_digest()\r\n-        if (digest is not None):\r\n+        if (digest != None):\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n\r\njob ID 634be3d1ff434425bf254ead62935081:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   1 9\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if ((len(sig_parts) != 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\njob ID 5ae6d0a91c2d4684b02aaa340d9d3eab:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   2 1\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if ((len(sig_parts) \u003e 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\njob ID 4a2be988d3894f3d8d9fdc46b55fa306:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   2 4\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if ((len(sig_parts) is not 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\njob ID 3933a0d64fe546699d25aed4d58afece:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   2 8\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if ((len(sig_parts) \u003c 2) or (sig_parts[0] \u003c 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\njob ID f8a284e6c67f4f669de506b73523cb11:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 0\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if ((len(sig_parts) \u003c 2) or (sig_parts[0] \u003e 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\njob ID d7f60eb0989f4aacabd62e9086d87975:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 2\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if ((len(sig_parts) \u003c 2) or (sig_parts[0] is 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\njob ID 12a01fb33247430394d523dce2bdf91a:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 4\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if ((len(sig_parts) \u003c 2) or (sig_parts[0] not in 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\njob ID a300f614a83a4c109e266885c72fc6c0:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ c o m p a r i s o n _ o p e r a t o r   3 5\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -40,7 +40,7 @@\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n-        if (data is None):\r\n+        if (data == None):\r\n             abort(400, 'Request body must contain json')\r\n         self._logger.info('%s (%s)', _format_event(event_type, data), _get_header('X-Github-Delivery'))\r\n         for hook in self._hooks.get(event_type, []):\r\n\r\njob ID 498e409e8cff49ceb7a6af2505d8ea98:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   m u t a t e _ u n a r y _ o p e r a t o r   1\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -34,7 +34,7 @@\r\n         digest = self._get_digest()\r\n         if (digest is not None):\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n-            if (not isinstance(digest, six.text_type)):\r\n+            if isinstance(digest, six.text_type):\r\n                 digest = six.text_type(digest)\r\n             if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n\r\njob ID af7031344c8f4fb4ae68441982768390:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   n u m b e r _ r e p l a c e r   0\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -33,7 +33,7 @@\r\n         'Callback from Flask'\r\n         digest = self._get_digest()\r\n         if (digest is not None):\r\n-            sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n+            sig_parts = _get_header('X-Hub-Signature').split('=', 2)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n             if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n\r\njob ID e6f95eb27afc43149a31b00e09224996:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   n u m b e r _ r e p l a c e r   6\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -45,7 +45,7 @@\r\n         self._logger.info('%s (%s)', _format_event(event_type, data), _get_header('X-Github-Delivery'))\r\n         for hook in self._hooks.get(event_type, []):\r\n             hook(data)\r\n-        return ('', 204)\r\n+        return ('', 205)\r\n\r\n def _get_header(key):\r\n     'Return message header'\r\n\r\njob ID a3c71ec1bc31429c97003395b4ab6389:survived:github_webhook.webhook\r\ncommand: c o s m i c - r a y   w o r k e r   g i t h u b _ w e b h o o k . w e b h o o k   r e p l a c e _ o r _ w i t h _ a n d   1\r\n--- mutation diff ---\r\n--- a/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n+++ b/Users/fphillips7/Code/python-github-webhook/github_webhook/webhook.py\r\n@@ -36,7 +36,7 @@\r\n             sig_parts = _get_header('X-Hub-Signature').split('=', 1)\r\n             if (not isinstance(digest, six.text_type)):\r\n                 digest = six.text_type(digest)\r\n-            if ((len(sig_parts) \u003c 2) or (sig_parts[0] != 'sha1') or (not hmac.compare_digest(sig_parts[1], digest))):\r\n+            if (((len(sig_parts) \u003c 2) and (sig_parts[0] != 'sha1')) or (not hmac.compare_digest(sig_parts[1], digest))):\r\n                 abort(400, 'Invalid signature')\r\n         event_type = _get_header('X-Github-Event')\r\n         data = request.get_json()\r\n\r\ntotal jobs: 79\r\ncomplete: 79 (100.00%)\r\nsurvival rate: 17.72%\r\n```","author":{"url":"https://github.com/fophillips","@type":"Person","name":"fophillips"},"datePublished":"2017-10-30T09:59:08.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/11/python-github-webhook/issues/11"}