| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:df20f971-5375-ca85-25e1-f26146a8d49b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B76A:2E124E:31C0B75:3F9496E:6B01DC5B |
| html-safe-nonce | d8090e8daf56456ff05bcadb87142de853784b15b205225b7e613106d403c747 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzZBOjJFMTI0RTozMUMwQjc1OjNGOTQ5NkU6NkIwMURDNUIiLCJ2aXNpdG9yX2lkIjoiMTA0MDEzMTQxMzE5MTU0Nzk5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 040346c58f3e26688de79f29b9ec160a346163b89f86d3f2395c84df9001e372 |
| hovercard-subject-tag | pull_request:969102014 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/bloomberg/TypeScript/68/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/12dd10c532dd9b24f915eb2d64fc0207f3b72981a1b78ca53db0da2ce29870a0/bloomberg/TypeScript/pull/68 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12dd10c532dd9b24f915eb2d64fc0207f3b72981a1b78ca53db0da2ce29870a0/bloomberg/TypeScript/pull/68 |
| og:image:alt | Issue number of the reported bug or feature request: microsoft#35867
Describe your changes
I've added tests to prevent regressions for this bug. I created a few scenarios that could trigger thi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lawrencecraft |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/bloomberg/TypeScript git https://github.com/bloomberg/TypeScript.git |
| octolytics-dimension-user_id | 1416818 |
| octolytics-dimension-user_login | bloomberg |
| octolytics-dimension-repository_id | 138790476 |
| octolytics-dimension-repository_nwo | bloomberg/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | true |
| octolytics-dimension-repository_parent_id | 20929025 |
| octolytics-dimension-repository_parent_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/bloomberg/TypeScript/pull/68#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbloomberg%2FTypeScript%2Fpull%2F68 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbloomberg%2FTypeScript%2Fpull%2F68 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=bloomberg%2FTypeScript |
| Reload | https://github.com/bloomberg/TypeScript/pull/68 |
| Reload | https://github.com/bloomberg/TypeScript/pull/68 |
| Reload | https://github.com/bloomberg/TypeScript/pull/68 |
| bloomberg | https://github.com/bloomberg |
| TypeScript | https://github.com/bloomberg/TypeScript |
| Code | https://github.com/bloomberg/TypeScript |
| Issues | https://github.com/bloomberg/TypeScript/issues |
| Pull requests3 (3) | https://github.com/bloomberg/TypeScript/pulls |
| Actions | https://github.com/bloomberg/TypeScript/actions |
| Projects | https://github.com/bloomberg/TypeScript/projects |
| Security and quality | https://github.com/bloomberg/TypeScript/security |
| Insights | https://github.com/bloomberg/TypeScript/insights |
| https://github.com/bloomberg/TypeScript |
| acutmore | https://github.com/acutmore |
| bloomberg:oss-hackathon-35867 | https://github.com/bloomberg/TypeScript/tree/oss-hackathon-35867 |
| lawrencecraft:tests-for-35867-enum | https://github.com/lawrencecraft/TypeScript/tree/tests-for-35867-enum |
| Conversation | https://github.com/bloomberg/TypeScript/pull/68 |
| Commits3 (3) | https://github.com/bloomberg/TypeScript/pull/68/commits |
| Checks | https://github.com/bloomberg/TypeScript/pull/68/checks |
| Files changed | https://github.com/bloomberg/TypeScript/pull/68/files |
| Add case to capture enum subtype reduction (addresses #35867) | https://github.com/bloomberg/TypeScript/pull/68#top |
| acutmore | https://github.com/acutmore |
| bloomberg:oss-hackathon-35867 | https://github.com/bloomberg/TypeScript/tree/oss-hackathon-35867 |
| lawrencecraft:tests-for-35867-enum | https://github.com/lawrencecraft/TypeScript/tree/tests-for-35867-enum |
|
| https://github.com/lawrencecraft |
| lawrencecraft | https://github.com/lawrencecraft |
| Jun 16, 2022 | https://github.com/bloomberg/TypeScript/pull/68#issue-1273308447 |
| microsoft#35867 | https://github.com/microsoft/TypeScript/issues/35867 |
| Please reload this page | https://github.com/bloomberg/TypeScript/pull/68 |
|
| https://github.com/lawrencecraft |
| Add case to capture enum subtype reduction (addresses | https://github.com/bloomberg/TypeScript/pull/68/commits/c710b9621fb4d2665538002bed10aec520c65065 |
| microsoft#35867 | https://github.com/microsoft/TypeScript/issues/35867 |
| ) | https://github.com/bloomberg/TypeScript/pull/68/commits/c710b9621fb4d2665538002bed10aec520c65065 |
| c710b96 | https://github.com/bloomberg/TypeScript/pull/68/commits/c710b9621fb4d2665538002bed10aec520c65065 |
| https://github.com/lawrencecraft |
| lawrencecraft | https://github.com/lawrencecraft |
| force-pushed | https://github.com/bloomberg/TypeScript/compare/d3076faba2c28cf96776e87e22934e60dd072503..c710b9621fb4d2665538002bed10aec520c65065 |
| d3076fa | https://github.com/bloomberg/TypeScript/commit/d3076faba2c28cf96776e87e22934e60dd072503 |
| c710b96 | https://github.com/bloomberg/TypeScript/commit/c710b9621fb4d2665538002bed10aec520c65065 |
|
Compare
| https://github.com/bloomberg/TypeScript/compare/d3076faba2c28cf96776e87e22934e60dd072503..c710b9621fb4d2665538002bed10aec520c65065 |
| June 16, 2022 09:37 | https://github.com/bloomberg/TypeScript/pull/68#event-6819554108 |
|
| https://github.com/lawrencecraft |
| format | https://github.com/bloomberg/TypeScript/pull/68/commits/5126ba99408d7e4f99bade21b06aecdf5371ea2e |
| 5126ba9 | https://github.com/bloomberg/TypeScript/pull/68/commits/5126ba99408d7e4f99bade21b06aecdf5371ea2e |
| https://github.com/lawrencecraft |
| lawrencecraft | https://github.com/lawrencecraft |
| force-pushed | https://github.com/bloomberg/TypeScript/compare/99459012bbfd42be9ef128a25849800e26434b80..5126ba99408d7e4f99bade21b06aecdf5371ea2e |
| 9945901 | https://github.com/bloomberg/TypeScript/commit/99459012bbfd42be9ef128a25849800e26434b80 |
| 5126ba9 | https://github.com/bloomberg/TypeScript/commit/5126ba99408d7e4f99bade21b06aecdf5371ea2e |
|
Compare
| https://github.com/bloomberg/TypeScript/compare/99459012bbfd42be9ef128a25849800e26434b80..5126ba99408d7e4f99bade21b06aecdf5371ea2e |
| June 16, 2022 09:40 | https://github.com/bloomberg/TypeScript/pull/68#event-6819578877 |
|
| https://github.com/lawrencecraft |
| Adding new test for empty string enum | https://github.com/bloomberg/TypeScript/pull/68/commits/19c703b1c83d1240e1fb986eac2e2c54c8ceaf7e |
| 19c703b | https://github.com/bloomberg/TypeScript/pull/68/commits/19c703b1c83d1240e1fb986eac2e2c54c8ceaf7e |
| https://github.com/acutmore |
| acutmore | https://github.com/acutmore |
|
Jun 16, 2022
| https://github.com/bloomberg/TypeScript/pull/68#pullrequestreview-1008790312 |
|
View reviewed changes
| https://github.com/bloomberg/TypeScript/pull/68/files/19c703b1c83d1240e1fb986eac2e2c54c8ceaf7e |
| acutmore | https://github.com/acutmore |
| https://github.com/bloomberg/TypeScript/pull/68#pullrequestreview-1008790312 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @lawrencecraft | https://github.com/lawrencecraft |
| Please reload this page | https://github.com/bloomberg/TypeScript/pull/68 |
| https://github.com/acutmore |
| acutmore | https://github.com/acutmore |
| bdf99c4 | https://github.com/bloomberg/TypeScript/commit/bdf99c452f6b7c6bd99ad7f52edff9a3b3fe0b0b |
| Jun 16, 2022 | https://github.com/bloomberg/TypeScript/pull/68#event-6819657868 |
| https://github.com/acutmore |
| acutmore | https://github.com/acutmore |
| Jun 16, 2022 | https://github.com/bloomberg/TypeScript/pull/68#issuecomment-1157467305 |
| Please reload this page | https://github.com/bloomberg/TypeScript/pull/68 |
| @lawrencecraft | https://github.com/lawrencecraft |
| Please reload this page | https://github.com/bloomberg/TypeScript/pull/68 |
| https://github.co/hiddenchars |
| https://github.com/bloomberg/TypeScript/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbloomberg%2FTypeScript%2Fpull%2F68 |
|
| https://github.com/acutmore |
|
acutmore
| https://github.com/acutmore |
|
| https://github.com/bloomberg/TypeScript/pull/68/files/19c703b1c83d1240e1fb986eac2e2c54c8ceaf7e |
| Please reload this page | https://github.com/bloomberg/TypeScript/pull/68 |
| Please reload this page | https://github.com/bloomberg/TypeScript/pull/68 |
|
| https://github.com/lawrencecraft |
|
| https://github.com/acutmore |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |