René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"部分请求方法会造成无限递归","articleBody":"### 简要描述\r\n在开发过程中发现 BaseWxMpServiceImpl.execute（）调用  executeInternal方法 异常内 如果出现指定code会刷新token后调用execute（）\r\n而execute（）方法终止条件为 为方法变量 int retryTimes = 0; 那么会如果一直出现指定code会造成无限递归\r\n\r\n### 模块版本情况\r\n* WxJava 模块名: weixin-java-mp\r\n* WxJava 版本号:3.7.0\r\n\r\n### 详细描述\r\n\r\n    public \u003cT, E\u003e T execute(RequestExecutor\u003cT, E\u003e executor, String uri, E data) throws WxErrorException {\r\n        int retryTimes = 0;\r\n\r\n        while(true) {\r\n            try {\r\n                return this.executeInternal(executor, uri, data);\r\n            } catch (WxErrorException var10) {\r\n                if (retryTimes + 1 \u003e this.maxRetryTimes) {\r\n                    log.warn(\"重试达到最大次数【{}】\", this.maxRetryTimes);\r\n                    throw new RuntimeException(\"微信服务端异常，超出重试次数\");\r\n                }\r\n\r\n                WxError error = var10.getError();\r\n                if (error.getErrorCode() != -1) {\r\n                    throw var10;\r\n                }\r\n\r\n                int sleepMillis = this.retrySleepMillis * (1 \u003c\u003c retryTimes);\r\n\r\n                try {\r\n                    log.warn(\"微信系统繁忙，{} ms 后重试(第{}次)\", sleepMillis, retryTimes + 1);\r\n                    Thread.sleep((long)sleepMillis);\r\n                } catch (InterruptedException var9) {\r\n                    throw new RuntimeException(var9);\r\n                }\r\n\r\n                if (retryTimes++ \u003e= this.maxRetryTimes) {\r\n                    log.warn(\"重试达到最大次数【{}】\", this.maxRetryTimes);\r\n                    throw new RuntimeException(\"微信服务端异常，超出重试次数\");\r\n                }\r\n            }\r\n        }\r\n    }\r\n\r\n    protected \u003cT, E\u003e T executeInternal(RequestExecutor\u003cT, E\u003e executor, String uri, E data) throws WxErrorException {\r\n        E dataForLog = DataUtils.handleDataWithSecret(data);\r\n        if (uri.contains(\"access_token=\")) {\r\n            throw new IllegalArgumentException(\"uri参数中不允许有access_token: \" + uri);\r\n        } else {\r\n            String accessToken = this.getAccessToken(false);\r\n            String uriWithAccessToken = uri + (uri.contains(\"?\") ? \"\u0026\" : \"?\") + \"access_token=\" + accessToken;\r\n\r\n            try {\r\n                T result = executor.execute(uriWithAccessToken, data, WxType.MP);\r\n                log.debug(\"\\n【请求地址】: {}\\n【请求参数】：{}\\n【响应数据】：{}\", new Object[]{uriWithAccessToken, dataForLog, result});\r\n                return result;\r\n            } catch (WxErrorException var9) {\r\n                WxError error = var9.getError();\r\n                if (error.getErrorCode() == 42001 || error.getErrorCode() == 40001 || error.getErrorCode() == 40014) {\r\n                    this.getWxMpConfigStorage().expireAccessToken();\r\n                    if (this.getWxMpConfigStorage().autoRefreshToken()) {\r\n                        return this.execute(executor, uri, data);\r\n                    }\r\n                }\r\n\r\n                if (error.getErrorCode() != 0) {\r\n                    log.error(\"\\n【请求地址】: {}\\n【请求参数】：{}\\n【错误信息】：{}\", new Object[]{uriWithAccessToken, dataForLog, error});\r\n                    throw new WxErrorException(error, var9);\r\n                } else {\r\n                    return null;\r\n                }\r\n            } catch (IOException var10) {\r\n                log.error(\"\\n【请求地址】: {}\\n【请求参数】：{}\\n【异常信息】：{}\", new Object[]{uriWithAccessToken, dataForLog, var10.getMessage()});\r\n                throw new WxErrorException(WxError.builder().errorMsg(var10.getMessage()).build(), var10);\r\n            }\r\n        }\r\n    }\r\n","author":{"url":"https://github.com/shuxuefu","@type":"Person","name":"shuxuefu"},"datePublished":"2020-05-29T07:42:30.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":6},"url":"https://github.com/1591/WxJava/issues/1591"}