René's URL Explorer Experiment


Title: feat: Implement discriminators knowledge in code generation BNCH-30443 by GitOnUp · Pull Request #87 · benchling/openapi-python-client · GitHub

Open Graph Title: feat: Implement discriminators knowledge in code generation BNCH-30443 by GitOnUp · Pull Request #87 · benchling/openapi-python-client

X Title: feat: Implement discriminators knowledge in code generation BNCH-30443 by GitOnUp · Pull Request #87 · benchling/openapi-python-client

Description: The bulk of logic for this change is in https://github.com/benchling/benchling-sdk/pull/180. This change adds knowledge of type mappings in the union property type for usage downstream.

Open Graph Description: The bulk of logic for this change is in https://github.com/benchling/benchling-sdk/pull/180. This change adds knowledge of type mappings in the union property type for usage downstream.

X Description: The bulk of logic for this change is in https://github.com/benchling/benchling-sdk/pull/180. This change adds knowledge of type mappings in the union property type for usage downstream.

Opengraph URL: https://github.com/benchling/openapi-python-client/pull/87

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5438a50b-8bfa-c70b-3e18-c589e763c627
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC364:27367:2781B3:31269A:697F566A
html-safe-nonce211658293e8a136033ba785f5aa6b782f513a0b9f49fef033214931c213b9d5e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzY0OjI3MzY3OjI3ODFCMzozMTI2OUE6Njk3RjU2NkEiLCJ2aXNpdG9yX2lkIjoiMzA0NzA5NTQyMjE0MjA3NjUyMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac643d1713304d672eb0a61e5a93b65ec8a659519aea3292be51033690c76ecf23
hovercard-subject-tagpull_request:737748742
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/benchling/openapi-python-client/87/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2290219a3db8c90550d098e4b4fda2dd530c2e551effa43aef924aa360b46678/benchling/openapi-python-client/pull/87
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2290219a3db8c90550d098e4b4fda2dd530c2e551effa43aef924aa360b46678/benchling/openapi-python-client/pull/87
og:image:altThe bulk of logic for this change is in https://github.com/benchling/benchling-sdk/pull/180. This change adds knowledge of type mappings in the union property type for usage downstream.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGitOnUp
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/benchling/openapi-python-client git https://github.com/benchling/openapi-python-client.git
octolytics-dimension-user_id2392113
octolytics-dimension-user_loginbenchling
octolytics-dimension-repository_id292424898
octolytics-dimension-repository_nwobenchling/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id240776275
octolytics-dimension-repository_parent_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/benchling/openapi-python-client/pull/87#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F87
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F87
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=benchling%2Fopenapi-python-client
Reloadhttps://github.com/benchling/openapi-python-client/pull/87
Reloadhttps://github.com/benchling/openapi-python-client/pull/87
Reloadhttps://github.com/benchling/openapi-python-client/pull/87
benchling https://github.com/benchling
openapi-python-clienthttps://github.com/benchling/openapi-python-client
openapi-generators/openapi-python-clienthttps://github.com/openapi-generators/openapi-python-client
Notifications https://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Fork 1 https://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Star 0 https://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Code https://github.com/benchling/openapi-python-client
Pull requests 7 https://github.com/benchling/openapi-python-client/pulls
Actions https://github.com/benchling/openapi-python-client/actions
Projects 0 https://github.com/benchling/openapi-python-client/projects
Security 0 https://github.com/benchling/openapi-python-client/security
Insights https://github.com/benchling/openapi-python-client/pulse
Code https://github.com/benchling/openapi-python-client
Pull requests https://github.com/benchling/openapi-python-client/pulls
Actions https://github.com/benchling/openapi-python-client/actions
Projects https://github.com/benchling/openapi-python-client/projects
Security https://github.com/benchling/openapi-python-client/security
Insights https://github.com/benchling/openapi-python-client/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/benchling/openapi-python-client/pull/87#issue-comment-box
GitOnUphttps://github.com/GitOnUp
benchling-sdk-m1-fixes-01282021https://github.com/benchling/openapi-python-client/tree/benchling-sdk-m1-fixes-01282021
george/discriminatorshttps://github.com/benchling/openapi-python-client/tree/george/discriminators
feat: Implement discriminators knowledge in code generation BNCH-30443 https://github.com/benchling/openapi-python-client/pull/87#top
GitOnUphttps://github.com/GitOnUp
benchling-sdk-m1-fixes-01282021https://github.com/benchling/openapi-python-client/tree/benchling-sdk-m1-fixes-01282021
george/discriminatorshttps://github.com/benchling/openapi-python-client/tree/george/discriminators
Conversation 6 https://github.com/benchling/openapi-python-client/pull/87
Commits 9 https://github.com/benchling/openapi-python-client/pull/87/commits
Checks 0 https://github.com/benchling/openapi-python-client/pull/87/checks
Files changed https://github.com/benchling/openapi-python-client/pull/87/files
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
https://github.co/hiddenchars
https://github.com/benchling/openapi-python-client/pull/{{ revealButtonHref }}
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
Sep 20, 2021https://github.com/benchling/openapi-python-client/pull/87#issue-1001174808
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
https://github.com/benchling/benchling-sdk/pull/180https://github.com/benchling/benchling-sdk/pull/180
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
https://github.com/GitOnUp
Discriminator supporthttps://github.com/benchling/openapi-python-client/pull/87/commits/1d4fa964a19dcf37a3136345a44ee0f785402b24
1d4fa96https://github.com/benchling/openapi-python-client/pull/87/commits/1d4fa964a19dcf37a3136345a44ee0f785402b24
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
packyghttps://github.com/packyg
September 20, 2021 16:38https://github.com/benchling/openapi-python-client/pull/87#event-5329598311
https://github.com/GitOnUp
Remove debugging printshttps://github.com/benchling/openapi-python-client/pull/87/commits/0632dfff59d5021e77b5acd5a0675993dea0e6de
0632dffhttps://github.com/benchling/openapi-python-client/pull/87/commits/0632dfff59d5021e77b5acd5a0675993dea0e6de
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
Sep 20, 2021 https://github.com/benchling/openapi-python-client/pull/87#pullrequestreview-758881015
View reviewed changes https://github.com/benchling/openapi-python-client/pull/87/files/0632dfff59d5021e77b5acd5a0675993dea0e6de
openapi_python_client/templates/property_templates/union_property.pyihttps://github.com/benchling/openapi-python-client/pull/87/files/0632dfff59d5021e77b5acd5a0675993dea0e6de#diff-d8d1edc9cd6d71225a8ab1bafb6d8fe82c498483a68f08719391a58e11917df7
GitOnUphttps://github.com/GitOnUp
Sep 20, 2021https://github.com/benchling/openapi-python-client/pull/87#discussion_r712349439
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
GitOnUphttps://github.com/GitOnUp
Sep 20, 2021https://github.com/benchling/openapi-python-client/pull/87#discussion_r712370028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
packyghttps://github.com/packyg
Sep 22, 2021https://github.com/benchling/openapi-python-client/pull/87#discussion_r713537549
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
packyghttps://github.com/packyg
Sep 22, 2021https://github.com/benchling/openapi-python-client/pull/87#discussion_r713538647
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
Sep 20, 2021 https://github.com/benchling/openapi-python-client/pull/87#pullrequestreview-758884438
View reviewed changes https://github.com/benchling/openapi-python-client/pull/87/files/0632dfff59d5021e77b5acd5a0675993dea0e6de
openapi_python_client/templates/property_templates/union_property.pyihttps://github.com/benchling/openapi-python-client/pull/87/files/0632dfff59d5021e77b5acd5a0675993dea0e6de#diff-d8d1edc9cd6d71225a8ab1bafb6d8fe82c498483a68f08719391a58e11917df7
GitOnUphttps://github.com/GitOnUp
Sep 20, 2021https://github.com/benchling/openapi-python-client/pull/87#discussion_r712352017
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
GitOnUphttps://github.com/GitOnUp
September 23, 2021 23:13https://github.com/benchling/openapi-python-client/pull/87#commits-pushed-fd1f32b
https://github.com/GitOnUp
WIPhttps://github.com/benchling/openapi-python-client/pull/87/commits/fd1f32b602708e9e65d50647115bc58dfc146a8a
fd1f32bhttps://github.com/benchling/openapi-python-client/pull/87/commits/fd1f32b602708e9e65d50647115bc58dfc146a8a
https://github.com/GitOnUp
Move json checkk to inner typehttps://github.com/benchling/openapi-python-client/pull/87/commits/bd5a1bf433f0e3bf9c9f54f677808a46bf493636
bd5a1bfhttps://github.com/benchling/openapi-python-client/pull/87/commits/bd5a1bf433f0e3bf9c9f54f677808a46bf493636
https://github.com/GitOnUp
Move template to benchling-sdkhttps://github.com/benchling/openapi-python-client/pull/87/commits/ad3ed2a9116b95dc502c30e6dd72d6bd586b41f3
ad3ed2ahttps://github.com/benchling/openapi-python-client/pull/87/commits/ad3ed2a9116b95dc502c30e6dd72d6bd586b41f3
https://github.com/GitOnUp
Revert endpoint changehttps://github.com/benchling/openapi-python-client/pull/87/commits/0195d846b732758e6e7c661fe0138ae516737d47
0195d84https://github.com/benchling/openapi-python-client/pull/87/commits/0195d846b732758e6e7c661fe0138ae516737d47
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
September 24, 2021 16:37https://github.com/benchling/openapi-python-client/pull/87#event-5357215517
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
Sep 24, 2021https://github.com/benchling/openapi-python-client/pull/87#event-5357253320
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
Sep 24, 2021 https://github.com/benchling/openapi-python-client/pull/87#pullrequestreview-763421044
View reviewed changes https://github.com/benchling/openapi-python-client/pull/87/files/0195d846b732758e6e7c661fe0138ae516737d47
openapi_python_client/parser/properties/__init__.pyhttps://github.com/benchling/openapi-python-client/pull/87/files/0195d846b732758e6e7c661fe0138ae516737d47#diff-61e8ac1a0d02be37f61e720be24f89c399fc6325938adfe140017e45198dc241
GitOnUphttps://github.com/GitOnUp
Sep 24, 2021https://github.com/benchling/openapi-python-client/pull/87#discussion_r715863893
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
GitOnUphttps://github.com/GitOnUp
September 24, 2021 16:09https://github.com/benchling/openapi-python-client/pull/87#commits-pushed-03c3dc2
https://github.com/GitOnUp
Avoid unioning if for properties without templates, only allow one cl…https://github.com/benchling/openapi-python-client/pull/87/commits/03c3dc23dd53523c8d28bbff85c3690095cc4dc9
03c3dc2https://github.com/benchling/openapi-python-client/pull/87/commits/03c3dc23dd53523c8d28bbff85c3690095cc4dc9
https://github.com/GitOnUp
properties without templates can now have UnknownTypehttps://github.com/benchling/openapi-python-client/pull/87/commits/32d7c190d6c7922b387a077d71a53f5b0e0d1ab0
32d7c19https://github.com/benchling/openapi-python-client/pull/87/commits/32d7c190d6c7922b387a077d71a53f5b0e0d1ab0
https://github.com/packyg
packyghttps://github.com/packyg
Sep 25, 2021 https://github.com/benchling/openapi-python-client/pull/87#pullrequestreview-763550775
View reviewed changes https://github.com/benchling/openapi-python-client/pull/87/files/32d7c190d6c7922b387a077d71a53f5b0e0d1ab0
https://github.com/GitOnUp
Merge branch 'benchling-sdk-m1-fixes-01282021' of github.com:benchlin…https://github.com/benchling/openapi-python-client/pull/87/commits/4b0275a220260116c357acf3f76afe07319fb005
4b0275ahttps://github.com/benchling/openapi-python-client/pull/87/commits/4b0275a220260116c357acf3f76afe07319fb005
https://github.com/GitOnUp
GitOnUphttps://github.com/GitOnUp
6c40881https://github.com/benchling/openapi-python-client/commit/6c40881765505f4700543a428a89449652895343
Sep 25, 2021https://github.com/benchling/openapi-python-client/pull/87#event-5358991977
https://github.com/eli-bl
eli-blhttps://github.com/eli-bl
November 26, 2024 22:45https://github.com/benchling/openapi-python-client/pull/87#event-15442984330
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F87
https://github.com/packyg
packyg https://github.com/packyg
https://github.com/benchling/openapi-python-client/pull/87/files/32d7c190d6c7922b387a077d71a53f5b0e0d1ab0
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/87
https://github.com/GitOnUp
https://github.com/packyg
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.