René's URL Explorer Experiment


Title: fix: Fix bug parsing `allOf` in nested keys BNCH-20174 by forest-benchling · Pull Request #29 · benchling/openapi-python-client · GitHub

Open Graph Title: fix: Fix bug parsing `allOf` in nested keys BNCH-20174 by forest-benchling · Pull Request #29 · benchling/openapi-python-client

X Title: fix: Fix bug parsing `allOf` in nested keys BNCH-20174 by forest-benchling · Pull Request #29 · benchling/openapi-python-client

Description: Description Our code was not correctly generating models where allOf was done on a nested key, such as NotFoundError: NotFoundError: type: object additionalProperties: false p...

Open Graph Description: Description Our code was not correctly generating models where allOf was done on a nested key, such as NotFoundError: NotFoundError: type: object additionalProperties: false p...

X Description: Description Our code was not correctly generating models where allOf was done on a nested key, such as NotFoundError: NotFoundError: type: object additionalProperties: false p...

Opengraph URL: https://github.com/benchling/openapi-python-client/pull/29

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9f8022f9-7afa-7dba-df53-4072999b1b0d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA9D2:3AA924:59D358:74C72A:697F6F7B
html-safe-nonce6b70a91d6f66f049a7a022fb96946376e99f141d1e424dc4daf9d8ed7c387c66
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUQyOjNBQTkyNDo1OUQzNTg6NzRDNzJBOjY5N0Y2RjdCIiwidmlzaXRvcl9pZCI6IjI0MjM5OTMwMzg2OTYwNTA1NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace6bb66aeb3e71575db80f27ddbe1e544842228ae89f07aed1d73796e7cc2c251
hovercard-subject-tagpull_request:554470440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/benchling/openapi-python-client/29/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/23587e010db49fba1df7da3f216cad881adb40ae8b659cd36d0f30563efa7ba4/benchling/openapi-python-client/pull/29
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/23587e010db49fba1df7da3f216cad881adb40ae8b659cd36d0f30563efa7ba4/benchling/openapi-python-client/pull/29
og:image:altDescription Our code was not correctly generating models where allOf was done on a nested key, such as NotFoundError: NotFoundError: type: object additionalProperties: false p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameforest-benchling
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
go-importgithub.com/benchling/openapi-python-client git https://github.com/benchling/openapi-python-client.git
octolytics-dimension-user_id2392113
octolytics-dimension-user_loginbenchling
octolytics-dimension-repository_id292424898
octolytics-dimension-repository_nwobenchling/openapi-python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forktrue
octolytics-dimension-repository_parent_id240776275
octolytics-dimension-repository_parent_nwoopenapi-generators/openapi-python-client
octolytics-dimension-repository_network_root_id240776275
octolytics-dimension-repository_network_root_nwoopenapi-generators/openapi-python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/benchling/openapi-python-client/pull/29#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F29
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F29
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=benchling%2Fopenapi-python-client
Reloadhttps://github.com/benchling/openapi-python-client/pull/29
Reloadhttps://github.com/benchling/openapi-python-client/pull/29
Reloadhttps://github.com/benchling/openapi-python-client/pull/29
benchling https://github.com/benchling
openapi-python-clienthttps://github.com/benchling/openapi-python-client
openapi-generators/openapi-python-clienthttps://github.com/openapi-generators/openapi-python-client
Notifications https://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Fork 1 https://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Star 0 https://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client
Code https://github.com/benchling/openapi-python-client
Pull requests 7 https://github.com/benchling/openapi-python-client/pulls
Actions https://github.com/benchling/openapi-python-client/actions
Projects 0 https://github.com/benchling/openapi-python-client/projects
Security 0 https://github.com/benchling/openapi-python-client/security
Insights https://github.com/benchling/openapi-python-client/pulse
Code https://github.com/benchling/openapi-python-client
Pull requests https://github.com/benchling/openapi-python-client/pulls
Actions https://github.com/benchling/openapi-python-client/actions
Projects https://github.com/benchling/openapi-python-client/projects
Security https://github.com/benchling/openapi-python-client/security
Insights https://github.com/benchling/openapi-python-client/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fbenchling%2Fopenapi-python-client%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/benchling/openapi-python-client/pull/29#issue-comment-box
forest-benchlinghttps://github.com/forest-benchling
main-v.0.7.3https://github.com/benchling/openapi-python-client/tree/main-v.0.7.3
forest-allof-2https://github.com/benchling/openapi-python-client/tree/forest-allof-2
fix: Fix bug parsing allOf in nested keys BNCH-20174 https://github.com/benchling/openapi-python-client/pull/29#top
forest-benchlinghttps://github.com/forest-benchling
main-v.0.7.3https://github.com/benchling/openapi-python-client/tree/main-v.0.7.3
forest-allof-2https://github.com/benchling/openapi-python-client/tree/forest-allof-2
Conversation 13 https://github.com/benchling/openapi-python-client/pull/29
Commits 6 https://github.com/benchling/openapi-python-client/pull/29/commits
Checks 0 https://github.com/benchling/openapi-python-client/pull/29/checks
Files changed https://github.com/benchling/openapi-python-client/pull/29/files
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.co/hiddenchars
https://github.com/benchling/openapi-python-client/pull/{{ revealButtonHref }}
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
Jan 13, 2021https://github.com/benchling/openapi-python-client/pull/29#issue-785442202
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
forest-benchlinghttps://github.com/forest-benchling
January 13, 2021 15:42https://github.com/benchling/openapi-python-client/pull/29#commits-pushed-7ef87d5
https://github.com/forest-benchling
Remove continuehttps://github.com/benchling/openapi-python-client/pull/29/commits/7ef87d571d8e556c08bd7c94b4933c41a3011c66
7ef87d5https://github.com/benchling/openapi-python-client/pull/29/commits/7ef87d571d8e556c08bd7c94b4933c41a3011c66
https://github.com/forest-benchling
Add top-level allOf checkhttps://github.com/benchling/openapi-python-client/pull/29/commits/2a05ca115425c3a1ed4201da417c947aa79b8612
2a05ca1https://github.com/benchling/openapi-python-client/pull/29/commits/2a05ca115425c3a1ed4201da417c947aa79b8612
https://github.com/forest-benchling
Update poetryhttps://github.com/benchling/openapi-python-client/pull/29/commits/637832acf3d157af228189243f6c3c0a4697b11d
637832ahttps://github.com/benchling/openapi-python-client/pull/29/commits/637832acf3d157af228189243f6c3c0a4697b11d
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
Jan 13, 2021https://github.com/benchling/openapi-python-client/pull/29#event-4203193974
https://github.com/forest-benchling
Add testhttps://github.com/benchling/openapi-python-client/pull/29/commits/3a90f2be87d88e7b5dd82cda54ac4274ce862b95
3a90f2bhttps://github.com/benchling/openapi-python-client/pull/29/commits/3a90f2be87d88e7b5dd82cda54ac4274ce862b95
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
January 13, 2021 21:26https://github.com/benchling/openapi-python-client/pull/29#event-4203292708
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
dtkavhttps://github.com/dtkav
packyghttps://github.com/packyg
January 13, 2021 21:27https://github.com/benchling/openapi-python-client/pull/29#event-4203293880
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
Jan 13, 2021https://github.com/benchling/openapi-python-client/pull/29#issuecomment-759750041
@bowenwrhttps://github.com/bowenwr
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/bowenwr
bowenwrhttps://github.com/bowenwr
Jan 13, 2021 https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-567714365
View reviewed changes https://github.com/benchling/openapi-python-client/pull/29/files/3a90f2be87d88e7b5dd82cda54ac4274ce862b95
bowenwrhttps://github.com/bowenwr
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-567714365
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@forest-benchlinghttps://github.com/forest-benchling
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/packyg
packyghttps://github.com/packyg
Jan 14, 2021 https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-567807126
View reviewed changes https://github.com/benchling/openapi-python-client/pull/29/files/3a90f2be87d88e7b5dd82cda54ac4274ce862b95
packyghttps://github.com/packyg
https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-567807126
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/packyg
packyghttps://github.com/packyg
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#issuecomment-759889719
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
@bowenwrhttps://github.com/bowenwr
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/packyg
packyghttps://github.com/packyg
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#issuecomment-759890300
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/forest-benchling
Revert poetry.lockhttps://github.com/benchling/openapi-python-client/pull/29/commits/24a9ce6612cb0e03bc1953496e544f6be62d5cc9
24a9ce6https://github.com/benchling/openapi-python-client/pull/29/commits/24a9ce6612cb0e03bc1953496e544f6be62d5cc9
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
Jan 14, 2021 https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-568241233
View reviewed changes https://github.com/benchling/openapi-python-client/pull/29/files/24a9ce6612cb0e03bc1953496e544f6be62d5cc9
tests/test_parser/test_properties/test_model_property.pyhttps://github.com/benchling/openapi-python-client/pull/29/files/24a9ce6612cb0e03bc1953496e544f6be62d5cc9#diff-36824c880ba9e752de856f28c0fc852da3c47b40e9ad9b6a250d38f2f251bcdb
forest-benchlinghttps://github.com/forest-benchling
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#discussion_r557402106
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
packyghttps://github.com/packyg
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#discussion_r557598292
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@forest-benchlinghttps://github.com/forest-benchling
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
forest-benchlinghttps://github.com/forest-benchling
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#discussion_r557611515
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@packyghttps://github.com/packyg
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/bowenwr
bowenwrhttps://github.com/bowenwr
January 14, 2021 16:11https://github.com/benchling/openapi-python-client/pull/29#event-4207013331
https://github.com/bowenwr
bowenwrhttps://github.com/bowenwr
Jan 14, 2021 https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-568389645
View reviewed changes https://github.com/benchling/openapi-python-client/pull/29/files/24a9ce6612cb0e03bc1953496e544f6be62d5cc9
https://github.com/forest-benchling
Fix testhttps://github.com/benchling/openapi-python-client/pull/29/commits/c63d42fc9335ed38c02dd8447a0c62d6f236c25b
c63d42fhttps://github.com/benchling/openapi-python-client/pull/29/commits/c63d42fc9335ed38c02dd8447a0c62d6f236c25b
https://github.com/dtkav
dtkavhttps://github.com/dtkav
Jan 14, 2021 https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-568582044
View reviewed changes https://github.com/benchling/openapi-python-client/pull/29/files/c63d42fc9335ed38c02dd8447a0c62d6f236c25b
openapi_python_client/parser/properties/__init__.pyhttps://github.com/benchling/openapi-python-client/pull/29/files/c63d42fc9335ed38c02dd8447a0c62d6f236c25b#diff-61e8ac1a0d02be37f61e720be24f89c399fc6325938adfe140017e45198dc241
dtkavhttps://github.com/dtkav
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#discussion_r557664341
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
forest-benchlinghttps://github.com/forest-benchling
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#discussion_r557722085
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@dtkavhttps://github.com/dtkav
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
dtkavhttps://github.com/dtkav
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#discussion_r557760965
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
packyghttps://github.com/packyg
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#discussion_r557763334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/dtkav
dtkavhttps://github.com/dtkav
Jan 14, 2021 https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-568704340
View reviewed changes https://github.com/benchling/openapi-python-client/pull/29/files/c63d42fc9335ed38c02dd8447a0c62d6f236c25b
dtkavhttps://github.com/dtkav
https://github.com/benchling/openapi-python-client/pull/29#pullrequestreview-568704340
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
0b9a99ahttps://github.com/benchling/openapi-python-client/commit/0b9a99aa40cbf0df340a9a93de6c8f36991ec096
Jan 14, 2021https://github.com/benchling/openapi-python-client/pull/29#event-4208714930
https://github.com/forest-benchling
forest-benchlinghttps://github.com/forest-benchling
January 14, 2021 23:53https://github.com/benchling/openapi-python-client/pull/29#event-4208715000
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbenchling%2Fopenapi-python-client%2Fpull%2F29
https://github.com/packyg
packyg https://github.com/packyg
https://github.com/benchling/openapi-python-client/pull/29/files/c63d42fc9335ed38c02dd8447a0c62d6f236c25b
https://github.com/dtkav
dtkav https://github.com/dtkav
https://github.com/benchling/openapi-python-client/pull/29/files/c63d42fc9335ed38c02dd8447a0c62d6f236c25b
https://github.com/bowenwr
bowenwr https://github.com/bowenwr
https://github.com/benchling/openapi-python-client/pull/29/files/24a9ce6612cb0e03bc1953496e544f6be62d5cc9
Please reload this pagehttps://github.com/benchling/openapi-python-client/pull/29
https://github.com/forest-benchling
https://github.com/packyg
https://github.com/dtkav
https://github.com/bowenwr
https://github.com/apps/copilot-swe-agent
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.