Title: TLS version 1.2 Java1.6 BouncyCastle Internal TLS error · Issue #289 · bcgit/bc-java · GitHub
Open Graph Title: TLS version 1.2 Java1.6 BouncyCastle Internal TLS error · Issue #289 · bcgit/bc-java
X Title: TLS version 1.2 Java1.6 BouncyCastle Internal TLS error · Issue #289 · bcgit/bc-java
Description: We have application written in java 1.6 we have developed a customized TLSSocketConnection factory based on Bouncy Castle Libraries (v. 1.57) Here is code snippet of TLSSocketConnection factory /** * This Class enables TLS V1.2 connectio...
Open Graph Description: We have application written in java 1.6 we have developed a customized TLSSocketConnection factory based on Bouncy Castle Libraries (v. 1.57) Here is code snippet of TLSSocketConnection factory /**...
X Description: We have application written in java 1.6 we have developed a customized TLSSocketConnection factory based on Bouncy Castle Libraries (v. 1.57) Here is code snippet of TLSSocketConnection factory /**...
Opengraph URL: https://github.com/bcgit/bc-java/issues/289
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TLS version 1.2 Java1.6 BouncyCastle Internal TLS error","articleBody":"We have application written in java 1.6\r\nwe have developed a customized TLSSocketConnection factory based on Bouncy Castle Libraries (v. 1.57)\r\n\r\nHere is code snippet of TLSSocketConnection factory\r\n\r\n```\r\n\r\n /**\r\n * This Class enables TLS V1.2 connection based on BouncyCastle Providers.\r\n */\r\n public class TLSSocketConnectionFactory extends SSLSocketFactory {\r\n \r\n \t// ******************Adding Custom BouncyCastleProvider*********************//\r\n \r\n \tstatic {\r\n \t\tif (Security.getProvider(BouncyCastleProvider.PROVIDER_NAME) == null)\r\n \t\t\tSecurity.addProvider(new BouncyCastleProvider());\r\n \t}\r\n \r\n \t// ******************HANDSHAKE LISTENER*********************//\r\n \r\n \tpublic class TLSHandshakeListener implements HandshakeCompletedListener {\r\n \t\t@Override\r\n \t\tpublic void handshakeCompleted(HandshakeCompletedEvent event) {\r\n \r\n \t\t}\r\n \t}\r\n \r\n \tprivate SecureRandom _secureRandom = new SecureRandom();\r\n \r\n \t// ******************Adding Custom BouncyCastleProvider*********************//\r\n \r\n \t@Override\r\n \tpublic Socket createSocket(Socket socket, final String host, int port, boolean arg3) throws IOException {\r\n \t\tif (socket == null) {\r\n \t\t\tsocket = new Socket();\r\n \t\t}\r\n \t\tif (!socket.isConnected()) {\r\n \t\t\tsocket.connect(new InetSocketAddress(host, port));\r\n \t\t}\r\n \r\n \t\tfinal TlsClientProtocol tlsClientProtocol = new TlsClientProtocol(socket.getInputStream(), socket.getOutputStream(), _secureRandom);\r\n \t\treturn _createSSLSocket(host, tlsClientProtocol);\r\n \t}\r\n \r\n \t// ******************SOCKET FACTORY METHODS*********************//\r\n \r\n \t@Override\r\n \tpublic String[] getDefaultCipherSuites() {\r\n \t\treturn null;\r\n \t}\r\n \r\n \t@Override\r\n \tpublic String[] getSupportedCipherSuites() {\r\n \t\treturn null;\r\n \t}\r\n \r\n \t@Override\r\n \tpublic Socket createSocket(String host, int port) throws IOException, UnknownHostException {\r\n \t\treturn null;\r\n \t}\r\n \r\n \t@Override\r\n \tpublic Socket createSocket(InetAddress host, int port) throws IOException {\r\n \t\treturn null;\r\n \t}\r\n \r\n \t@Override\r\n \tpublic Socket createSocket(String host, int port, InetAddress localHost, int localPort) throws IOException, UnknownHostException {\r\n \t\treturn null;\r\n \t}\r\n \r\n \t@Override\r\n \tpublic Socket createSocket(InetAddress address, int port, InetAddress localAddress, int localPort) throws IOException {\r\n \t\treturn null;\r\n \t}\r\n \r\n \t// ******************SOCKET CREATION*********************//\r\n \r\n \tprivate SSLSocket _createSSLSocket(final String host, final TlsClientProtocol tlsClientProtocol) {\r\n \t\treturn new SSLSocket() {\r\n \t\t\tprivate java.security.cert.Certificate[] peertCerts;\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic InputStream getInputStream() throws IOException {\r\n \t\t\t\treturn tlsClientProtocol.getInputStream();\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic OutputStream getOutputStream() throws IOException {\r\n \t\t\t\treturn tlsClientProtocol.getOutputStream();\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic synchronized void close() throws IOException {\r\n \t\t\t\ttlsClientProtocol.close();\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void addHandshakeCompletedListener(HandshakeCompletedListener arg0) {\r\n \r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic boolean getEnableSessionCreation() {\r\n \t\t\t\treturn false;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic String[] getEnabledCipherSuites() {\r\n \t\t\t\treturn null;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic String[] getEnabledProtocols() {\r\n \t\t\t\treturn null;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic boolean getNeedClientAuth() {\r\n \t\t\t\treturn false;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic SSLSession getSession() {\r\n \t\t\t\treturn new SSLSession() {\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic int getApplicationBufferSize() {\r\n \t\t\t\t\t\treturn 0;\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic String getCipherSuite() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic long getCreationTime() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic byte[] getId() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic long getLastAccessedTime() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic java.security.cert.Certificate[] getLocalCertificates() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic Principal getLocalPrincipal() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic int getPacketBufferSize() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic X509Certificate[] getPeerCertificateChain() throws SSLPeerUnverifiedException {\r\n \t\t\t\t\t\treturn null;\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic java.security.cert.Certificate[] getPeerCertificates() throws SSLPeerUnverifiedException {\r\n \t\t\t\t\t\treturn peertCerts;\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic String getPeerHost() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic int getPeerPort() {\r\n \t\t\t\t\t\treturn 0;\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic Principal getPeerPrincipal() throws SSLPeerUnverifiedException {\r\n \t\t\t\t\t\treturn null;\r\n \t\t\t\t\t\t//throw new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic String getProtocol() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic SSLSessionContext getSessionContext() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic Object getValue(String arg0) {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic String[] getValueNames() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic void invalidate() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic boolean isValid() {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic void putValue(String arg0, Object arg1) {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic void removeValue(String arg0) {\r\n \t\t\t\t\t\tthrow new UnsupportedOperationException();\r\n \t\t\t\t\t}\r\n \t\t\t\t};\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic String[] getSupportedProtocols() {\r\n \t\t\t\treturn null;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic boolean getUseClientMode() {\r\n \t\t\t\treturn false;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic boolean getWantClientAuth() {\r\n \t\t\t\treturn false;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void removeHandshakeCompletedListener(HandshakeCompletedListener arg0) {\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void setEnableSessionCreation(boolean arg0) {\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void setEnabledCipherSuites(String[] arg0) {\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void setEnabledProtocols(String[] arg0) {\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void setNeedClientAuth(boolean arg0) {\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void setUseClientMode(boolean arg0) {\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void setWantClientAuth(boolean arg0) {\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic String[] getSupportedCipherSuites() {\r\n \t\t\t\treturn null;\r\n \t\t\t}\r\n \r\n \t\t\t@Override\r\n \t\t\tpublic void startHandshake() throws IOException {\r\n \t\t\t\ttlsClientProtocol.connect(new DefaultTlsClient() {\r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic Hashtable\u003cInteger, byte[]> getClientExtensions() throws IOException {\r\n \t\t\t\t\t\tHashtable\u003cInteger, byte[]> clientExtensions = super.getClientExtensions();\r\n \t\t\t\t\t\tif (clientExtensions == null) {\r\n \t\t\t\t\t\t\tclientExtensions = new Hashtable\u003cInteger, byte[]>();\r\n \t\t\t\t\t\t}\r\n \r\n \t\t\t\t\t\t//Add host_name\r\n \t\t\t\t\t\tbyte[] host_name = host.getBytes();\r\n \r\n \t\t\t\t\t\tfinal ByteArrayOutputStream baos = new ByteArrayOutputStream();\r\n \t\t\t\t\t\tfinal DataOutputStream dos = new DataOutputStream(baos);\r\n \t\t\t\t\t\tdos.writeShort(host_name.length + 3); // entry size\r\n \t\t\t\t\t\tdos.writeByte(0); // name type = hostname\r\n \t\t\t\t\t\tdos.writeShort(host_name.length);\r\n \t\t\t\t\t\tdos.write(host_name);\r\n \t\t\t\t\t\tdos.close();\r\n \t\t\t\t\t\tclientExtensions.put(ExtensionType.server_name, baos.toByteArray());\r\n \t\t\t\t\t\treturn clientExtensions;\r\n \t\t\t\t\t}\r\n \r\n \t\t\t\t\t@Override\r\n \t\t\t\t\tpublic TlsAuthentication getAuthentication() throws IOException {\r\n \t\t\t\t\t\treturn new TlsAuthentication() {\r\n \t\t\t\t\t\t\t@Override\r\n \t\t\t\t\t\t\tpublic void notifyServerCertificate(Certificate serverCertificate) throws IOException {\r\n \t\t\t\t\t\t\t\ttry {\r\n \t\t\t\t\t\t\t\t\tCertificateFactory cf = CertificateFactory.getInstance(\"X.509\");\r\n \t\t\t\t\t\t\t\t\tList\u003cjava.security.cert.Certificate> certs = new LinkedList\u003cjava.security.cert.Certificate>();\r\n \t\t\t\t\t\t\t\t\tfor (org.bouncycastle.asn1.x509.Certificate c : serverCertificate.getCertificateList()) {\r\n \t\t\t\t\t\t\t\t\t\tcerts.add(cf.generateCertificate(new ByteArrayInputStream(c.getEncoded())));\r\n \t\t\t\t\t\t\t\t\t}\r\n \t\t\t\t\t\t\t\t\tpeertCerts = certs.toArray(new java.security.cert.Certificate[0]);\r\n \t\t\t\t\t\t\t\t} catch (CertificateException e) {\r\n \t\t\t\t\t\t\t\t\tSystem.out.println(\"Failed to cache server certs\" + e);\r\n \t\t\t\t\t\t\t\t\tthrow new IOException(e);\r\n \t\t\t\t\t\t\t\t}\r\n \t\t\t\t\t\t\t}\r\n \r\n \t\t\t\t\t\t\t@Override\r\n \t\t\t\t\t\t\tpublic TlsCredentials getClientCredentials(CertificateRequest arg0) throws IOException {\r\n \t\t\t\t\t\t\t\treturn null;\r\n \t\t\t\t\t\t\t}\r\n \t\t\t\t\t\t};\r\n \t\t\t\t\t}\r\n \t\t\t\t});\r\n \t\t\t}\r\n \t\t};//Socket\r\n \r\n \t}\r\n }\r\n```\r\n\r\nThe way we use it\r\n\r\n```\r\n HttpClient httpclient = HttpClientBuilder.create().setDefaultRequestConfig(getRequestConfig()).setRedirectStrategy(new LaxRedirectStrategy()).setSSLSocketFactory(getSSLContext()).build();\r\n \t\tlogger.info(httpclient.toString());\r\n \t\tHttpClientContext context = getHttpContext();\r\n \r\n \t\tHttpPost httppost = new HttpPost(urlString);\r\n \t\tHttpResponse httpResponse = httpclient.execute(httppost, context);\r\n \r\n private RequestConfig getRequestConfig() {\r\n \t\treturn RequestConfig.custom().setConnectTimeout(320 * 1000).setConnectionRequestTimeout(320 * 1000).setSocketTimeout(320 * 1000).build();\r\n \t}\r\n \r\n \tprivate SSLConnectionSocketFactory getSSLContext() throws Exception {\r\n \t\treturn new SSLConnectionSocketFactory(new TLSSocketConnectionFactory(), new String[] { \"TLSv1.2\" }, null, SSLConnectionSocketFactory.ALLOW_ALL_HOSTNAME_VERIFIER);\r\n \t}\r\n\r\n```\r\n\r\nWith this I end up getting error in logs as\r\n\r\n```\r\n Exception: : java.io.IOException: Internal TLS error, this could be an attack\r\n \tat org.bouncycastle.crypto.tls.TlsProtocol.failWithError(Unknown Source) [:1.57.0]\r\n \tat org.bouncycastle.crypto.tls.TlsProtocol.safeReadRecord(Unknown Source) [:1.57.0]\r\n \tat org.bouncycastle.crypto.tls.TlsProtocol.readApplicationData(Unknown Source) [:1.57.0]\r\n \tat org.bouncycastle.crypto.tls.TlsInputStream.read(Unknown Source) [:1.57.0]\r\n \tat org.apache.http.impl.io.SessionInputBufferImpl.streamRead(SessionInputBufferImpl.java:136) [:4.3.3]\r\n```\r\n\r\n\r\nAny idea how to fix it? Is it due to LaxRedirectStrategy or setting SSL socket connection timeout?\r\nIts hard to figure out how to approach the issue. Rather where to start to solve this.","author":{"url":"https://github.com/shivrajjadhav733","@type":"Person","name":"shivrajjadhav733"},"datePublished":"2018-02-09T19:50:49Z","url":"https://github.com/bcgit/bc-java/issues/289"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:986f5bb4-5060-f2e0-39f3-e799a5881d55 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 895A:3F351B:4E7CD8:69F46D:6AFBF1C1 |
| html-safe-nonce | f2378735d280a88cb4cf436141744dfc12c190ee3934ffe3f442812617cf03d5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTVBOjNGMzUxQjo0RTdDRDg6NjlGNDZEOjZBRkJGMUMxIiwidmlzaXRvcl9pZCI6Ijg1MzA5MzI2ODI0Mjk1NTkyMzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c24876f428b13d2b6ee164e5c80867d8822989852d9131f192385234a25f9834 |
| hovercard-subject-tag | issue:295991524 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/bcgit/bc-java/289/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0588d92469372ce77afe1b7d3d47b4b7c60663a76f868080b8d0a27e1af2dddc/bcgit/bc-java/issues/289 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0588d92469372ce77afe1b7d3d47b4b7c60663a76f868080b8d0a27e1af2dddc/bcgit/bc-java/issues/289 |
| og:image:alt | We have application written in java 1.6 we have developed a customized TLSSocketConnection factory based on Bouncy Castle Libraries (v. 1.57) Here is code snippet of TLSSocketConnection factory /**... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | shivrajjadhav733 |
| hostname | github.com |
| expected-hostname | github.com |
| None | fa74413a1d84dac536fcca0740780bcbd3207bafec0e51873b73ff8e8cca032f |
| turbo-cache-control | no-preview |
| go-import | github.com/bcgit/bc-java git https://github.com/bcgit/bc-java.git |
| octolytics-dimension-user_id | 4566970 |
| octolytics-dimension-user_login | bcgit |
| octolytics-dimension-repository_id | 10416648 |
| octolytics-dimension-repository_nwo | bcgit/bc-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 10416648 |
| octolytics-dimension-repository_network_root_nwo | bcgit/bc-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b3b5633a74535d9c23385512d534c66c8fde1907 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width