René's URL Explorer Experiment


Title: Fixes exception when passing incorrect bytes to decode by ncordon · Pull Request #190 · bblfsh/python-client · GitHub

Open Graph Title: Fixes exception when passing incorrect bytes to decode by ncordon · Pull Request #190 · bblfsh/python-client

X Title: Fixes exception when passing incorrect bytes to decode by ncordon · Pull Request #190 · bblfsh/python-client

Description: Babelfish Python client. Contribute to bblfsh/python-client development by creating an account on GitHub.

Open Graph Description: An uncaught exception was thrown and python interpreter was killed because of that. Closes #189 Signed-off-by: ncordon nacho.cordon.castillo@gmail.com This change is 

X Description: An uncaught exception was thrown and python interpreter was killed because of that. Closes #189 Signed-off-by: ncordon nacho.cordon.castillo@gmail.com This change is 

Mail addresses
nacho.cordon.castillo@gmail.com

Opengraph URL: https://github.com/bblfsh/python-client/pull/190

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0326ae50-8612-8034-bf8c-195e9540f4dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id849A:A6D52:2148976:2DD7B9C:6A4F3A99
html-safe-nonce9511ec039576541fef875918ea8083b6282151ab6e4a8e143e2c0f4248773239
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDlBOkE2RDUyOjIxNDg5NzY6MkREN0I5Qzo2QTRGM0E5OSIsInZpc2l0b3JfaWQiOiI2MDg0MzI5ODY4MTk5MTQ4MTg2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf93fcf8245e9d84e2b12820bbc7990bf67c00723bf2d98d94499a9458f1b3b03
hovercard-subject-tagpull_request:316535984
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/bblfsh/python-client/190/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c801e1e5036ccbc08e8e05c7d6cf9088739729ef351dcc5b5c652042f14f00ad/bblfsh/python-client/pull/190
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c801e1e5036ccbc08e8e05c7d6cf9088739729ef351dcc5b5c652042f14f00ad/bblfsh/python-client/pull/190
og:image:altAn uncaught exception was thrown and python interpreter was killed because of that. Closes #189 Signed-off-by: ncordon nacho.cordon.castillo@gmail.com This change is 
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamencordon
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/bblfsh/python-client git https://github.com/bblfsh/python-client.git
octolytics-dimension-user_id25795418
octolytics-dimension-user_loginbblfsh
octolytics-dimension-repository_id94333938
octolytics-dimension-repository_nwobblfsh/python-client
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id94333938
octolytics-dimension-repository_network_root_nwobblfsh/python-client
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/bblfsh/python-client/pull/190#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbblfsh%2Fpython-client%2Fpull%2F190
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbblfsh%2Fpython-client%2Fpull%2F190
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=bblfsh%2Fpython-client
Reloadhttps://github.com/bblfsh/python-client/pull/190
Reloadhttps://github.com/bblfsh/python-client/pull/190
Reloadhttps://github.com/bblfsh/python-client/pull/190
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
bblfsh https://github.com/bblfsh
python-clienthttps://github.com/bblfsh/python-client
Notifications https://github.com/login?return_to=%2Fbblfsh%2Fpython-client
Fork 20 https://github.com/login?return_to=%2Fbblfsh%2Fpython-client
Star 17 https://github.com/login?return_to=%2Fbblfsh%2Fpython-client
Code https://github.com/bblfsh/python-client
Issues 9 https://github.com/bblfsh/python-client/issues
Pull requests 0 https://github.com/bblfsh/python-client/pulls
Actions https://github.com/bblfsh/python-client/actions
Projects https://github.com/bblfsh/python-client/projects
Security and quality 0 https://github.com/bblfsh/python-client/security
Insights https://github.com/bblfsh/python-client/pulse
Code https://github.com/bblfsh/python-client
Issues https://github.com/bblfsh/python-client/issues
Pull requests https://github.com/bblfsh/python-client/pulls
Actions https://github.com/bblfsh/python-client/actions
Projects https://github.com/bblfsh/python-client/projects
Security and quality https://github.com/bblfsh/python-client/security
Insights https://github.com/bblfsh/python-client/pulse
ncordonhttps://github.com/ncordon
bblfsh:masterhttps://github.com/bblfsh/python-client/tree/master
ncordon:fix.empty.decodehttps://github.com/ncordon/python-client/tree/fix.empty.decode
Conversationhttps://github.com/bblfsh/python-client/pull/190
Commits3 (3)https://github.com/bblfsh/python-client/pull/190/commits
Checkshttps://github.com/bblfsh/python-client/pull/190/checks
Files changedhttps://github.com/bblfsh/python-client/pull/190/files
Fixes exception when passing incorrect bytes to decodehttps://github.com/bblfsh/python-client/pull/190#top
ncordonhttps://github.com/ncordon
bblfsh:masterhttps://github.com/bblfsh/python-client/tree/master
ncordon:fix.empty.decodehttps://github.com/ncordon/python-client/tree/fix.empty.decode
https://github.com/ncordon
ncordonhttps://github.com/ncordon
Sep 11, 2019https://github.com/bblfsh/python-client/pull/190#issue-492344958
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
#189https://github.com/bblfsh/python-client/issues/189
https://reviewable.io/reviews/bblfsh/python-client/190
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
ncordonhttps://github.com/ncordon
September 11, 2019 18:26https://github.com/bblfsh/python-client/pull/190#commits-pushed-ef7de06
https://github.com/ncordon
Fixes exception when passing empty bytes to decodehttps://github.com/bblfsh/python-client/pull/190/commits/ef7de060bf56b860acda76e426d1ab4f9a248cd2
ef7de06https://github.com/bblfsh/python-client/pull/190/commits/ef7de060bf56b860acda76e426d1ab4f9a248cd2
https://github.com/ncordon
Adds tests for incorrect bytes in decode not killing interpreterhttps://github.com/bblfsh/python-client/pull/190/commits/86ddb9546a012ef2b6e616ffd987dacdd409f85c
86ddb95https://github.com/bblfsh/python-client/pull/190/commits/86ddb9546a012ef2b6e616ffd987dacdd409f85c
https://github.com/ncordon
ncordonhttps://github.com/ncordon
creachadairhttps://github.com/creachadair
September 11, 2019 17:06https://github.com/bblfsh/python-client/pull/190#event-2626487709
https://github.com/creachadair
creachadairhttps://github.com/creachadair
Sep 11, 2019 https://github.com/bblfsh/python-client/pull/190#pullrequestreview-286946083
View reviewed changes https://github.com/bblfsh/python-client/pull/190/files/86ddb9546a012ef2b6e616ffd987dacdd409f85c
creachadairhttps://github.com/creachadair
https://github.com/bblfsh/python-client/pull/190#pullrequestreview-286946083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Reviewablehttps://reviewable.io/reviews/bblfsh/python-client/190
@ncordonhttps://github.com/ncordon
bblfsh/pyuast.cc, line 1060 at r1https://reviewable.io/reviews/bblfsh/python-client/190#-LoWJy_UDD5QxkHo6fpq:-LoWJy_UDD5QxkHo6fpr:b-mhtyg0
raw filehttps://github.com/bblfsh/python-client/blob/86ddb9546a012ef2b6e616ffd987dacdd409f85c/bblfsh/pyuast.cc#L1060
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/ncordon
ncordonhttps://github.com/ncordon
Sep 11, 2019https://github.com/bblfsh/python-client/pull/190#issuecomment-530484995
bblfsh/pyuast.cc, line 1060 at r1https://reviewable.io/reviews/bblfsh/python-client/190#-LoWJy_UDD5QxkHo6fpq:-LoWNzy214AFpdIPHWeH:b-c5x97t
raw filehttps://github.com/bblfsh/python-client/blob/86ddb9546a012ef2b6e616ffd987dacdd409f85c/bblfsh/pyuast.cc#L1060
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/creachadair
creachadairhttps://github.com/creachadair
Sep 11, 2019 https://github.com/bblfsh/python-client/pull/190#pullrequestreview-286959246
View reviewed changes https://github.com/bblfsh/python-client/pull/190/files/86ddb9546a012ef2b6e616ffd987dacdd409f85c
creachadairhttps://github.com/creachadair
https://github.com/bblfsh/python-client/pull/190#pullrequestreview-286959246
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Reviewablehttps://reviewable.io/reviews/bblfsh/python-client/190
@ncordonhttps://github.com/ncordon
bblfsh/pyuast.cc, line 1060 at r1https://reviewable.io/reviews/bblfsh/python-client/190#-LoWJy_UDD5QxkHo6fpq:-LoWOvvz0vy824ad1Z0c:bnih8x
raw filehttps://github.com/bblfsh/python-client/blob/86ddb9546a012ef2b6e616ffd987dacdd409f85c/bblfsh/pyuast.cc#L1060
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/ncordon
ncordonhttps://github.com/ncordon
Sep 11, 2019https://github.com/bblfsh/python-client/pull/190#issuecomment-530492027
bblfsh/pyuast.cc, line 1060 at r1https://reviewable.io/reviews/bblfsh/python-client/190#-LoWJy_UDD5QxkHo6fpq:-LoWS-uHDoBycgVcugLK:bjza2wd
raw filehttps://github.com/bblfsh/python-client/blob/86ddb9546a012ef2b6e616ffd987dacdd409f85c/bblfsh/pyuast.cc#L1060
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/creachadair
creachadairhttps://github.com/creachadair
Sep 11, 2019 https://github.com/bblfsh/python-client/pull/190#pullrequestreview-286970461
View reviewed changes https://github.com/bblfsh/python-client/pull/190/files
creachadairhttps://github.com/creachadair
https://github.com/bblfsh/python-client/pull/190#pullrequestreview-286970461
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Reviewablehttps://reviewable.io/reviews/bblfsh/python-client/190
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/dennwc
dennwchttps://github.com/dennwc
Sep 12, 2019 https://github.com/bblfsh/python-client/pull/190#pullrequestreview-287329561
View reviewed changes https://github.com/bblfsh/python-client/pull/190/files
dennwchttps://github.com/dennwc
https://github.com/bblfsh/python-client/pull/190#pullrequestreview-287329561
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Reviewablehttps://reviewable.io/reviews/bblfsh/python-client/190
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/ncordon
Deletes early return in the ext_decode native methodhttps://github.com/bblfsh/python-client/pull/190/commits/aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
aab45d4https://github.com/bblfsh/python-client/pull/190/commits/aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
https://github.com/ncordon
ncordonhttps://github.com/ncordon
force-pushedhttps://github.com/bblfsh/python-client/compare/7f039ce7bf60b9f6c8479b98ef9ad53383bc069f..aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
7f039cehttps://github.com/bblfsh/python-client/commit/7f039ce7bf60b9f6c8479b98ef9ad53383bc069f
aab45d4https://github.com/bblfsh/python-client/commit/aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
Compare https://github.com/bblfsh/python-client/compare/7f039ce7bf60b9f6c8479b98ef9ad53383bc069f..aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
September 12, 2019 11:37https://github.com/bblfsh/python-client/pull/190#event-2628843341
https://github.com/dennwc
dennwchttps://github.com/dennwc
Sep 12, 2019 https://github.com/bblfsh/python-client/pull/190#pullrequestreview-287367673
View reviewed changes https://github.com/bblfsh/python-client/pull/190/files/aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
dennwchttps://github.com/dennwc
https://github.com/bblfsh/python-client/pull/190#pullrequestreview-287367673
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Reviewablehttps://reviewable.io/reviews/bblfsh/python-client/190
bblfsh/pyuast.cc, line 5 at r2https://reviewable.io/reviews/bblfsh/python-client/190#-Lo_Gkw0ERNhdeDvSiAs:-Lo_Gkw0ERNhdeDvSiAt:b-7728il
raw filehttps://github.com/bblfsh/python-client/blob/7f039ce7bf60b9f6c8479b98ef9ad53383bc069f/bblfsh/pyuast.cc#L5
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/ncordon
ncordonhttps://github.com/ncordon
Sep 12, 2019 https://github.com/bblfsh/python-client/pull/190#ref-pullrequest-492805188
Catches exceptions in decode native method bblfsh/scala-client#131 https://github.com/bblfsh/scala-client/pull/131
https://github.com/ncordon
ncordonhttps://github.com/ncordon
Sep 13, 2019https://github.com/bblfsh/python-client/pull/190#issuecomment-531196196
bblfsh/pyuast.cc, line 5 at r2https://reviewable.io/reviews/bblfsh/python-client/190#-Lo_Gkw0ERNhdeDvSiAs:-LoeII0tEvZU3VhIGSJ5:blmaq4x
raw filehttps://github.com/bblfsh/python-client/blob/7f039ce7bf60b9f6c8479b98ef9ad53383bc069f/bblfsh/pyuast.cc#L5
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/creachadair
creachadairhttps://github.com/creachadair
Sep 16, 2019 https://github.com/bblfsh/python-client/pull/190#pullrequestreview-288735837
View reviewed changes https://github.com/bblfsh/python-client/pull/190/files/aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
creachadairhttps://github.com/creachadair
https://github.com/bblfsh/python-client/pull/190#pullrequestreview-288735837
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Reviewablehttps://reviewable.io/reviews/bblfsh/python-client/190
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/ncordon
ncordonhttps://github.com/ncordon
dd528f9https://github.com/bblfsh/python-client/commit/dd528f966b6b5fae7e74e67e67002864a0c5cea5
Sep 16, 2019https://github.com/bblfsh/python-client/pull/190#event-2637111480
https://github.com/ncordon
ncordonhttps://github.com/ncordon
September 16, 2019 16:54https://github.com/bblfsh/python-client/pull/190#event-2637111618
https://github.co/hiddenchars
https://github.com/bblfsh/python-client/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbblfsh%2Fpython-client%2Fpull%2F190
https://github.com/creachadair
creachadair https://github.com/creachadair
https://github.com/bblfsh/python-client/pull/190/files/aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
https://github.com/dennwc
dennwc https://github.com/dennwc
https://github.com/bblfsh/python-client/pull/190/files/aab45d4978f7bd16f13c669c1a3e0aca8f4c3f34
Incorrect bytes in decode kill the python interpreter https://github.com/bblfsh/python-client/issues/189
Please reload this pagehttps://github.com/bblfsh/python-client/pull/190
https://github.com/ncordon
https://github.com/creachadair
https://github.com/dennwc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.