| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5268db63-59bb-c4c8-0eba-fe0faa25df9a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 84D0:2839F:2E2188:3DBFDF:69697ACC |
| html-safe-nonce | cb5dc166017a0aa1a9bb2d5fb0e8ff484e04e2a2df5cf0245d94bf102c788271 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEQwOjI4MzlGOjJFMjE4ODozREJGREY6Njk2OTdBQ0MiLCJ2aXNpdG9yX2lkIjoiNzExODE0NzUxODc0MTQ0NTMyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2897dac46116d45c402e04b5d5e11a942fd9c57313e656e2f9a158fe94b23051 |
| hovercard-subject-tag | pull_request:2866274799 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/bayesian-optimization/BayesianOptimization/591/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/801affa6803be9e5b074b697b150b4810d3baed05db95a55cdae97474ee4ad50/bayesian-optimization/BayesianOptimization/pull/591 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/801affa6803be9e5b074b697b150b4810d3baed05db95a55cdae97474ee4ad50/bayesian-optimization/BayesianOptimization/pull/591 |
| og:image:alt | This is a WIP attempt to satisfy some of the goals in this issue thread about adding alternative (not just iteration based) termination criteria for the optimizer: #381
New termination criteria are... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cballam |
| hostname | github.com |
| expected-hostname | github.com |
| None | f33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77 |
| turbo-cache-control | no-preview |
| go-import | github.com/bayesian-optimization/BayesianOptimization git https://github.com/bayesian-optimization/BayesianOptimization.git |
| octolytics-dimension-user_id | 133429415 |
| octolytics-dimension-user_login | bayesian-optimization |
| octolytics-dimension-repository_id | 20556335 |
| octolytics-dimension-repository_nwo | bayesian-optimization/BayesianOptimization |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20556335 |
| octolytics-dimension-repository_network_root_nwo | bayesian-optimization/BayesianOptimization |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 48f380098b30acbb700b04f1724481ca10d574fc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbayesian-optimization%2FBayesianOptimization%2Fpull%2F591 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbayesian-optimization%2FBayesianOptimization%2Fpull%2F591 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=bayesian-optimization%2FBayesianOptimization |
| Reload | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| Reload | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| Reload | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
|
bayesian-optimization
| https://github.com/bayesian-optimization |
| BayesianOptimization | https://github.com/bayesian-optimization/BayesianOptimization |
|
Notifications
| https://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization |
|
Fork
1.6k
| https://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization |
|
Star
8.5k
| https://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization |
|
Code
| https://github.com/bayesian-optimization/BayesianOptimization |
|
Issues
7
| https://github.com/bayesian-optimization/BayesianOptimization/issues |
|
Pull requests
1
| https://github.com/bayesian-optimization/BayesianOptimization/pulls |
|
Actions
| https://github.com/bayesian-optimization/BayesianOptimization/actions |
|
Projects
0
| https://github.com/bayesian-optimization/BayesianOptimization/projects |
|
Wiki
| https://github.com/bayesian-optimization/BayesianOptimization/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/bayesian-optimization/BayesianOptimization/security |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
|
Insights
| https://github.com/bayesian-optimization/BayesianOptimization/pulse |
|
Code
| https://github.com/bayesian-optimization/BayesianOptimization |
|
Issues
| https://github.com/bayesian-optimization/BayesianOptimization/issues |
|
Pull requests
| https://github.com/bayesian-optimization/BayesianOptimization/pulls |
|
Actions
| https://github.com/bayesian-optimization/BayesianOptimization/actions |
|
Projects
| https://github.com/bayesian-optimization/BayesianOptimization/projects |
|
Wiki
| https://github.com/bayesian-optimization/BayesianOptimization/wiki |
|
Security
| https://github.com/bayesian-optimization/BayesianOptimization/security |
|
Insights
| https://github.com/bayesian-optimization/BayesianOptimization/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fbayesian-optimization%2FBayesianOptimization%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#issue-comment-box |
| cballam | https://github.com/cballam |
| bayesian-optimization:master | https://github.com/bayesian-optimization/BayesianOptimization/tree/master |
| cballam:convergence_criteria | https://github.com/cballam/BayesianOptimization/tree/convergence_criteria |
|
add alternative termination criteria
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591#top |
| cballam | https://github.com/cballam |
| bayesian-optimization:master | https://github.com/bayesian-optimization/BayesianOptimization/tree/master |
| cballam:convergence_criteria | https://github.com/cballam/BayesianOptimization/tree/convergence_criteria |
|
Conversation
9
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
|
Commits
1
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591/commits |
|
Checks
12
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591/checks |
|
Files changed
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| https://github.co/hiddenchars |
| https://github.com/bayesian-optimization/BayesianOptimization/pull/{{ revealButtonHref }} |
|
| https://github.com/cballam |
| cballam | https://github.com/cballam |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#issue-3460010711 |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| #381 | https://github.com/bayesian-optimization/BayesianOptimization/issues/381 |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
|
| https://github.com/cballam |
| WIP: refactors termination criteria | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/commits/225aa98890f0236361eba83eaee0a3e6d84f96ae |
| 225aa98 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/commits/225aa98890f0236361eba83eaee0a3e6d84f96ae |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#issuecomment-3341426771 |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| documentation | https://docs.coderabbit.ai/pr-reviews/pre-merge-checks |
| Discord post | https://discord.com/channels/1134356397673414807/1414771631775158383 |
| X | https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai |
| Mastodon | https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai |
| Reddit | https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai |
| LinkedIn | https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| https://github.com/cballam |
| cballam | https://github.com/cballam |
|
Sep 27, 2025
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591#ref-issue-1461943226 |
|
Convergence criteria
#381
| https://github.com/bayesian-optimization/BayesianOptimization/issues/381 |
| https://github.com/apps/coderabbitai |
| coderabbitai | https://github.com/apps/coderabbitai |
|
Sep 27, 2025
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591#pullrequestreview-3274752055 |
|
View reviewed changes
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae |
| coderabbitai | https://github.com/apps/coderabbitai |
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591#pullrequestreview-3274752055 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| c410d51 | https://github.com/bayesian-optimization/BayesianOptimization/commit/c410d5115f9a3d9b9d02a2c689493e54839e9aa4 |
| 225aa98 | https://github.com/bayesian-optimization/BayesianOptimization/commit/225aa98890f0236361eba83eaee0a3e6d84f96ae |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| bayes_opt/bayesian_optimization.py | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae#diff-280397341e30f0f657fca7a5e19b311dcc228081bc04cd13ff14854987e368c0 |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#discussion_r2384009556 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| bayes_opt/bayesian_optimization.py | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae#diff-280397341e30f0f657fca7a5e19b311dcc228081bc04cd13ff14854987e368c0 |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#discussion_r2384009558 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| bayes_opt/bayesian_optimization.py | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae#diff-280397341e30f0f657fca7a5e19b311dcc228081bc04cd13ff14854987e368c0 |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#discussion_r2384009560 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| tests/test_bayesian_optimization.py | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae#diff-60bb166dff39855ad641ac3f8b11b4ae0d6eda818232bd26b5c59c812c441a62 |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#discussion_r2384009561 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| tests/test_bayesian_optimization.py | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae#diff-60bb166dff39855ad641ac3f8b11b4ae0d6eda818232bd26b5c59c812c441a62 |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#discussion_r2384009562 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| tests/test_bayesian_optimization.py | https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae#diff-60bb166dff39855ad641ac3f8b11b4ae0d6eda818232bd26b5c59c812c441a62 |
| coderabbitai | https://github.com/apps/coderabbitai |
| Sep 27, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#discussion_r2384009564 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| https://github.com/till-m |
| till-m | https://github.com/till-m |
| Oct 6, 2025 | https://github.com/bayesian-optimization/BayesianOptimization/pull/591#issuecomment-3370256631 |
| @cballam | https://github.com/cballam |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbayesian-optimization%2FBayesianOptimization%2Fpull%2F591 |
|
| https://github.com/apps/coderabbitai |
|
coderabbitai[bot]
| https://github.com/apps/coderabbitai |
|
| https://github.com/bayesian-optimization/BayesianOptimization/pull/591/files/225aa98890f0236361eba83eaee0a3e6d84f96ae |
| Please reload this page | https://github.com/bayesian-optimization/BayesianOptimization/pull/591 |
|
| https://github.com/cballam |
|
| https://github.com/till-m |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |