René's URL Explorer Experiment


Title: Fix min window type check by phi-friday · Pull Request #523 · bayesian-optimization/BayesianOptimization · GitHub

Open Graph Title: Fix min window type check by phi-friday · Pull Request #523 · bayesian-optimization/BayesianOptimization

X Title: Fix min window type check by phi-friday · Pull Request #523 · bayesian-optimization/BayesianOptimization

Description: minimum_window should be typechecked using Mapping, not dict. Also, minimum_window_value should be typechecked using Sequence, not list. And I found it while checking it, is it possible for minimum...

Open Graph Description: minimum_window should be typechecked using Mapping, not dict. Also, minimum_window_value should be typechecked using Sequence, not list. And I found it while checking it, is it possible for minimum...

X Description: minimum_window should be typechecked using Mapping, not dict. Also, minimum_window_value should be typechecked using Sequence, not list. And I found it while checking it, is it possible for minimum...

Opengraph URL: https://github.com/bayesian-optimization/BayesianOptimization/pull/523

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:40b21a54-22dc-bf10-8a53-367e05cd8484
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA050:6BE0D:810C8E:ACE80E:69697AA2
html-safe-nonce2e5829c519b68810c192ede0aa11ed6c0d811fac46a798c6830b1904604cb613
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDUwOjZCRTBEOjgxMEM4RTpBQ0U4MEU6Njk2OTdBQTIiLCJ2aXNpdG9yX2lkIjoiNjczMTgwMjA2MzU3MTM1MjIyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaceeca4d43b53c2d410468f56fcec14d72eadc813987c9d7eaf64537abbd1d9c7b
hovercard-subject-tagpull_request:2083594265
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/bayesian-optimization/BayesianOptimization/523/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/76b3ae250e9442c30733f871b0aa46c11590e7c6e6cf181e3b62c2d3fb321639/bayesian-optimization/BayesianOptimization/pull/523
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/76b3ae250e9442c30733f871b0aa46c11590e7c6e6cf181e3b62c2d3fb321639/bayesian-optimization/BayesianOptimization/pull/523
og:image:altminimum_window should be typechecked using Mapping, not dict. Also, minimum_window_value should be typechecked using Sequence, not list. And I found it while checking it, is it possible for minimum...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamephi-friday
hostnamegithub.com
expected-hostnamegithub.com
Nonef33e4b94c8824ab2b434d82a94139432fb5ebee9df4b75304140ad22508c4a77
turbo-cache-controlno-preview
go-importgithub.com/bayesian-optimization/BayesianOptimization git https://github.com/bayesian-optimization/BayesianOptimization.git
octolytics-dimension-user_id133429415
octolytics-dimension-user_loginbayesian-optimization
octolytics-dimension-repository_id20556335
octolytics-dimension-repository_nwobayesian-optimization/BayesianOptimization
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20556335
octolytics-dimension-repository_network_root_nwobayesian-optimization/BayesianOptimization
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release48f380098b30acbb700b04f1724481ca10d574fc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/bayesian-optimization/BayesianOptimization/pull/523#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbayesian-optimization%2FBayesianOptimization%2Fpull%2F523
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbayesian-optimization%2FBayesianOptimization%2Fpull%2F523
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=bayesian-optimization%2FBayesianOptimization
Reloadhttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
Reloadhttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
Reloadhttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
bayesian-optimization https://github.com/bayesian-optimization
BayesianOptimizationhttps://github.com/bayesian-optimization/BayesianOptimization
Notifications https://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization
Fork 1.6k https://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization
Star 8.5k https://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization
Code https://github.com/bayesian-optimization/BayesianOptimization
Issues 7 https://github.com/bayesian-optimization/BayesianOptimization/issues
Pull requests 1 https://github.com/bayesian-optimization/BayesianOptimization/pulls
Actions https://github.com/bayesian-optimization/BayesianOptimization/actions
Projects 0 https://github.com/bayesian-optimization/BayesianOptimization/projects
Wiki https://github.com/bayesian-optimization/BayesianOptimization/wiki
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/bayesian-optimization/BayesianOptimization/security
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
Insights https://github.com/bayesian-optimization/BayesianOptimization/pulse
Code https://github.com/bayesian-optimization/BayesianOptimization
Issues https://github.com/bayesian-optimization/BayesianOptimization/issues
Pull requests https://github.com/bayesian-optimization/BayesianOptimization/pulls
Actions https://github.com/bayesian-optimization/BayesianOptimization/actions
Projects https://github.com/bayesian-optimization/BayesianOptimization/projects
Wiki https://github.com/bayesian-optimization/BayesianOptimization/wiki
Security https://github.com/bayesian-optimization/BayesianOptimization/security
Insights https://github.com/bayesian-optimization/BayesianOptimization/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fbayesian-optimization%2FBayesianOptimization%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fbayesian-optimization%2FBayesianOptimization%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/bayesian-optimization/BayesianOptimization/pull/523#issue-comment-box
till-mhttps://github.com/till-m
bayesian-optimization:masterhttps://github.com/bayesian-optimization/BayesianOptimization/tree/master
phi-friday:fix-min-window-type-checkhttps://github.com/phi-friday/BayesianOptimization/tree/fix-min-window-type-check
Fix min window type check https://github.com/bayesian-optimization/BayesianOptimization/pull/523#top
till-mhttps://github.com/till-m
bayesian-optimization:masterhttps://github.com/bayesian-optimization/BayesianOptimization/tree/master
phi-friday:fix-min-window-type-checkhttps://github.com/phi-friday/BayesianOptimization/tree/fix-min-window-type-check
Conversation 5 https://github.com/bayesian-optimization/BayesianOptimization/pull/523
Commits 4 https://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits
Checks 0 https://github.com/bayesian-optimization/BayesianOptimization/pull/523/checks
Files changed https://github.com/bayesian-optimization/BayesianOptimization/pull/523/files
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
https://github.co/hiddenchars
https://github.com/bayesian-optimization/BayesianOptimization/pull/{{ revealButtonHref }}
https://github.com/phi-friday
phi-fridayhttps://github.com/phi-friday
Sep 20, 2024https://github.com/bayesian-optimization/BayesianOptimization/pull/523#issue-2539253362
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
BayesianOptimization/bayes_opt/domain_reduction.pyhttps://github.com/bayesian-optimization/BayesianOptimization/blob/10ef3be32bd2dd2e9739f430db98a71ae440c4d8/bayes_opt/domain_reduction.py#L211-L212
10ef3behttps://github.com/bayesian-optimization/BayesianOptimization/commit/10ef3be32bd2dd2e9739f430db98a71ae440c4d8
BayesianOptimization/bayes_opt/domain_reduction.pyhttps://github.com/bayesian-optimization/BayesianOptimization/blob/a6697aabf590c9c6f3000b55c5195401b37cff98/bayes_opt/domain_reduction.py#L56
a6697aahttps://github.com/bayesian-optimization/BayesianOptimization/commit/a6697aabf590c9c6f3000b55c5195401b37cff98
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
https://github.com/till-m
till-mhttps://github.com/till-m
Sep 30, 2024https://github.com/bayesian-optimization/BayesianOptimization/pull/523#issuecomment-2382348490
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
https://github.com/till-m
till-mhttps://github.com/till-m
Oct 1, 2024https://github.com/bayesian-optimization/BayesianOptimization/pull/523#issuecomment-2384958687
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
https://github.com/phi-friday
phi-fridayhttps://github.com/phi-friday
Oct 1, 2024https://github.com/bayesian-optimization/BayesianOptimization/pull/523#issuecomment-2385050067
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
https://github.com/till-m
till-mhttps://github.com/till-m
Oct 1, 2024https://github.com/bayesian-optimization/BayesianOptimization/pull/523#issuecomment-2385106809
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
phi-fridayhttps://github.com/phi-friday
October 1, 2024 17:45https://github.com/bayesian-optimization/BayesianOptimization/pull/523#commits-pushed-e7808b0
https://github.com/phi-friday
fix: replace dict with Mappinghttps://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/e7808b0d839865be52ea6635d5041c4468f450fe
e7808b0https://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/e7808b0d839865be52ea6635d5041c4468f450fe
https://github.com/phi-friday
fix: replace list with Sequencehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/c0d2adf7a68b06a55f6345c893782786e1c407fb
c0d2adfhttps://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/c0d2adf7a68b06a55f6345c893782786e1c407fb
https://github.com/phi-friday
fix: add type hinthttps://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/3ba5e615145fe74a34c67afcc1189ff2095c77a0
3ba5e61https://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/3ba5e615145fe74a34c67afcc1189ff2095c77a0
https://github.com/phi-friday
fix: does not accept Nonehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/094c2acefb86c23ca6ab49c1cad12bb8b0a91583
094c2achttps://github.com/bayesian-optimization/BayesianOptimization/pull/523/commits/094c2acefb86c23ca6ab49c1cad12bb8b0a91583
https://github.com/phi-friday
phi-fridayhttps://github.com/phi-friday
force-pushedhttps://github.com/bayesian-optimization/BayesianOptimization/compare/6eaeb5a7d1924655b34c98133edfedc33ba408f9..094c2acefb86c23ca6ab49c1cad12bb8b0a91583
6eaeb5ahttps://github.com/bayesian-optimization/BayesianOptimization/commit/6eaeb5a7d1924655b34c98133edfedc33ba408f9
094c2achttps://github.com/bayesian-optimization/BayesianOptimization/commit/094c2acefb86c23ca6ab49c1cad12bb8b0a91583
Compare https://github.com/bayesian-optimization/BayesianOptimization/compare/6eaeb5a7d1924655b34c98133edfedc33ba408f9..094c2acefb86c23ca6ab49c1cad12bb8b0a91583
October 1, 2024 08:47https://github.com/bayesian-optimization/BayesianOptimization/pull/523#event-14468505153
https://github.com/phi-friday
phi-fridayhttps://github.com/phi-friday
Oct 1, 2024https://github.com/bayesian-optimization/BayesianOptimization/pull/523#issuecomment-2385199398
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
https://github.com/till-m
till-mhttps://github.com/till-m
c48e566https://github.com/bayesian-optimization/BayesianOptimization/commit/c48e5663e2fcaca1b341a32df66a4a6ad611ebf7
Oct 1, 2024https://github.com/bayesian-optimization/BayesianOptimization/pull/523#event-14468759036
https://github.com/phi-friday
phi-fridayhttps://github.com/phi-friday
October 1, 2024 09:32https://github.com/bayesian-optimization/BayesianOptimization/pull/523#event-14469242795
till-mhttps://github.com/till-m
Oct 9, 2024 https://github.com/bayesian-optimization/BayesianOptimization/pull/523#ref-commit-2b64ff0
https://github.com/phi-friday
https://github.com/till-m
Parameter types more (https://github.com/till-m/BayesianOptimization/commit/2b64ff044f46bbf27e7e93d119b4689277298b8c
#13https://github.com/till-m/BayesianOptimization/pull/13
)https://github.com/till-m/BayesianOptimization/commit/2b64ff044f46bbf27e7e93d119b4689277298b8c
2b64ff0https://github.com/till-m/BayesianOptimization/commit/2b64ff044f46bbf27e7e93d119b4689277298b8c
bayesian-optimization#525https://github.com/bayesian-optimization/BayesianOptimization/pull/525
bayesian-optimization#524https://github.com/bayesian-optimization/BayesianOptimization/pull/524
bayesian-optimization#523https://github.com/bayesian-optimization/BayesianOptimization/pull/523
bayesian-optimization#527https://github.com/bayesian-optimization/BayesianOptimization/pull/527
till-mhttps://github.com/till-m
Dec 27, 2024 https://github.com/bayesian-optimization/BayesianOptimization/pull/523#ref-commit-0ef608f
https://github.com/till-m
https://github.com/phi-friday
Typed Optimization (https://github.com/bayesian-optimization/BayesianOptimization/commit/0ef608f9d1ee3f6dbe5ff9bff0e65853f2593bc1
#531https://github.com/bayesian-optimization/BayesianOptimization/pull/531
)https://github.com/bayesian-optimization/BayesianOptimization/commit/0ef608f9d1ee3f6dbe5ff9bff0e65853f2593bc1
0ef608fhttps://github.com/bayesian-optimization/BayesianOptimization/commit/0ef608f9d1ee3f6dbe5ff9bff0e65853f2593bc1
#13https://github.com/bayesian-optimization/BayesianOptimization/issues/13
#525https://github.com/bayesian-optimization/BayesianOptimization/pull/525
#524https://github.com/bayesian-optimization/BayesianOptimization/pull/524
#523https://github.com/bayesian-optimization/BayesianOptimization/pull/523
#527https://github.com/bayesian-optimization/BayesianOptimization/pull/527
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fbayesian-optimization%2FBayesianOptimization%2Fpull%2F523
Please reload this pagehttps://github.com/bayesian-optimization/BayesianOptimization/pull/523
https://github.com/phi-friday
https://github.com/till-m
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.