Title: Fix bq-show display restoration and timeline.seek() time calculation by Copilot · Pull Request #28 · bQuery/bQuery · GitHub
Open Graph Title: Fix bq-show display restoration and timeline.seek() time calculation by Copilot · Pull Request #28 · bQuery/bQuery
X Title: Fix bq-show display restoration and timeline.seek() time calculation by Copilot · Pull Request #28 · bQuery/bQuery
Description: Addresses two issues from PR #16 review thread 3706692806: bq-show directive display handling Issue: Elements starting with style="display: none" remain hidden when condition becomes truthy because originalDisplay captures the inline 'none' value. Fix: Capture computed display value when inline style is missing or 'none': let originalDisplay = htmlEl.style.display; if (!originalDisplay || originalDisplay === 'none') { const computed = window.getComputedStyle(htmlEl).display; originalDisplay = computed !== 'none' ? computed : ''; } timeline.seek() animation time Issue: seek() subtracts start when setting animation.currentTime, but WAAPI's currentTime already includes delay. This double-applies the offset. Fix: Set currentTime directly to timeline position: // Before: animation.currentTime = Math.max(0, time - start); // After: animation.currentTime = time; Both fixes include test coverage. 💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Open Graph Description: Addresses two issues from PR #16 review thread 3706692806: bq-show directive display handling Issue: Elements starting with style="display: none" remain hidden when condition becomes trut...
X Description: Addresses two issues from PR #16 review thread 3706692806: bq-show directive display handling Issue: Elements starting with style="display: none" remain hidden when condition beco...
Opengraph URL: https://github.com/bQuery/bQuery/pull/28
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6c02aced-77f1-9b58-5757-3f6fa9166a85 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D1D8:2E7285:193D7C:23943C:6A4E656D |
| html-safe-nonce | 51e0e431a929e3ddc4cc81358e12f725ea8987f04928d53be0ffee35b6081abd |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUQ4OjJFNzI4NToxOTNEN0M6MjM5NDNDOjZBNEU2NTZEIiwidmlzaXRvcl9pZCI6IjQ0ODc0OTIzMTIwODgwNzc2NzciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1e61311b0e447be91e207e0bef97328579d8e6727aaff86485e63cc0d57f6bb2 |
| hovercard-subject-tag | pull_request:3211133375 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/bQuery/bQuery/pull/28/files |
| twitter:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| og:image:alt | Addresses two issues from PR #16 review thread 3706692806: bq-show directive display handling Issue: Elements starting with style="display: none" remain hidden when condition becomes trut... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/bQuery/bQuery git https://github.com/bQuery/bQuery.git |
| octolytics-dimension-user_id | 256381806 |
| octolytics-dimension-user_login | bQuery |
| octolytics-dimension-repository_id | 1139284244 |
| octolytics-dimension-repository_nwo | bQuery/bQuery |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1139284244 |
| octolytics-dimension-repository_network_root_nwo | bQuery/bQuery |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width