René's URL Explorer Experiment

Title: Fix async handling, type safety, environment guards, and add test coverage from PR #16 review by Copilot · Pull Request #25 · bQuery/bQuery · GitHub

Open Graph Title: Fix async handling, type safety, environment guards, and add test coverage from PR #16 review by Copilot · Pull Request #25 · bQuery/bQuery

X Title: Fix async handling, type safety, environment guards, and add test coverage from PR #16 review by Copilot · Pull Request #25 · bQuery/bQuery

Description: Addresses 9 review comments from PR #16 (thread 3705776573) and 3 additional review comments (thread 3705830665) covering async promise handling, type narrowing, lifecycle timing, DOM processing bugs, performance optimization, SSR/test environment safety, and cross-realm compatibility. Router Async handling: Wrapped navigate() calls with void + .catch() to prevent unhandled rejections Type narrowing: Added cross-realm compatible instanceof HTMLAnchorElement check using anchor.ownerDocument.defaultView?.HTMLAnchorElement to support anchors from same-origin iframes Component Lifecycle: Deferred required prop validation from constructor (syncProps) to connectedCallback to support programmatic element creation before attributes are set View Directive processing: Skip processChildren() when root element has bq-for directive (which replaces the element and handles children internally) Test coverage: Added regression test for root element with bq-for to prevent future breakage Performance Sanitization: Optimized collection.insertAll() to sanitize HTML once instead of per-element (O(1) vs O(n)) Environment Safety CSP: Guard generateNonce() and hasCSPDirective() for missing crypto/btoa/document globals Storage: Guard persistedSignal() for missing localStorage, fall back to in-memory signal Test coverage: Added comprehensive tests for persistedSignal() fallback behavior including localStorage unavailability (SSR/test environments) and JSON parse error handling Consistency: Use globalThis references throughout for portability // Before: unhandled rejection link('/page', { replace: true }); // After: explicit error handling void navigate('/page', { replace: true }).catch(err => { console.error('Navigation failed:', err); }); Testing ✅ Added 4 tests for persistedSignal() covering persistence, fallback, and error handling ✅ Added regression test for bq-for on root element ✅ Code review passed with 0 issues ✅ Security scan (CodeQL) passed with 0 vulnerabilities 💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Open Graph Description: Addresses 9 review comments from PR #16 (thread 3705776573) and 3 additional review comments (thread 3705830665) covering async promise handling, type narrowing, lifecycle timing, DOM processing bu...

X Description: Addresses 9 review comments from PR #16 (thread 3705776573) and 3 additional review comments (thread 3705830665) covering async promise handling, type narrowing, lifecycle timing, DOM processing bu...

Opengraph URL: https://github.com/bQuery/bQuery/pull/25

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width