Title: fix(ssr): escape bq-text values on raw-text elements in pure renderer by JosunLP · Pull Request #183 · bQuery/bQuery · GitHub
Open Graph Title: fix(ssr): escape bq-text values on raw-text elements in pure renderer by JosunLP · Pull Request #183 · bQuery/bQuery
X Title: fix(ssr): escape bq-text values on raw-text elements in pure renderer by JosunLP · Pull Request #183 · bQuery/bQuery
Description: Summary
Fixes #163 (Critical).
In the default pure SSR renderer, setText wrote bq-text values verbatim as text children, and serializeTree emits text inside raw-text elements (script/style/textarea/title) without escaping. An untrusted value like closed the element and injected live markup — stored XSS in the default backend on Node/Bun/Deno.
Fix
setText now escapes via escapeText when the target element is raw (el.raw), exactly mirroring the pre-existing bq-model reflection handling (which already named this hazard). The bq-model call site now reuses the centralized logic.
Verification
Regression tests for
Open Graph Description: Summary Fixes #163 (Critical). In the default pure SSR renderer, setText wrote bq-text values verbatim as text children, and serializeTree emits text inside raw-text elements (script/style/textarea...
X Description: Summary Fixes #163 (Critical). In the default pure SSR renderer, setText wrote bq-text values verbatim as text children, and serializeTree emits text inside raw-text elements (script/style/textarea...
Opengraph URL: https://github.com/bQuery/bQuery/pull/183
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d0eb7b7b-4aec-8ecb-fea8-6b004bad2714 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9434:19A6A8:D5F3CB:12CA711:6A4E9127 |
| html-safe-nonce | 4b5ea38c516b3cdad6fa6c18de103d12d0ba5fd961163dc2a54cd418f0746c8f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDM0OjE5QTZBODpENUYzQ0I6MTJDQTcxMTo2QTRFOTEyNyIsInZpc2l0b3JfaWQiOiIzMTAxMDk5MDY1MzMwMjc0NTk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | afe0612b4f2ec835cef94740af30d11822afe3d526a44280469d23678c27d4b5 |
| hovercard-subject-tag | pull_request:4000840992 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/bQuery/bQuery/pull/183/files |
| twitter:image | https://avatars.githubusercontent.com/u/20913954?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/20913954?s=400&v=4 |
| og:image:alt | Summary Fixes #163 (Critical). In the default pure SSR renderer, setText wrote bq-text values verbatim as text children, and serializeTree emits text inside raw-text elements (script/style/textarea... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/bQuery/bQuery git https://github.com/bQuery/bQuery.git |
| octolytics-dimension-user_id | 256381806 |
| octolytics-dimension-user_login | bQuery |
| octolytics-dimension-repository_id | 1139284244 |
| octolytics-dimension-repository_nwo | bQuery/bQuery |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1139284244 |
| octolytics-dimension-repository_network_root_nwo | bQuery/bQuery |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width