René's URL Explorer Experiment


Title: fix(security): escape mXSS-detection text fallback in sanitizeHtmlCore by JosunLP · Pull Request #182 · bQuery/bQuery · GitHub

Open Graph Title: fix(security): escape mXSS-detection text fallback in sanitizeHtmlCore by JosunLP · Pull Request #182 · bQuery/bQuery

X Title: fix(security): escape mXSS-detection text fallback in sanitizeHtmlCore by JosunLP · Pull Request #182 · bQuery/bQuery

Description: Summary Fixes #162 (Critical). The anti-mXSS double-parse in sanitizeHtmlCore returned raw, unescaped fragment.textContent when the serialize→re-parse output was unstable. Every caller assigns the return value to an HTML sink (innerHTML/insertAdjacentHTML via .html(), .append(), bq-html, …), so an attacker could smuggle an entity-encoded payload (<img src=x onerror=...>) plus a construct that forces re-parse instability (

… foster-parenting) and get live markup back — the mXSS defense itself was the injection sink. Fix The text fallback is now HTML-escaped before being returned (local escapeHtmlText helper in sanitize-core.ts to avoid a circular import with sanitize.ts). Verification New regression test with the exact audit payload
<img src=x onerror=alert(1)>; asserts no element materializes when the result is assigned to innerHTML. Verified the fallback branch actually fires under happy-dom: output is now <img src=x onerror=alert(1)> (inert text). bun test tests/security.test.ts: 59 pass / 0 fail. tsc --noEmit clean. 🤖 Generated with Claude Code

Open Graph Description: Summary Fixes #162 (Critical). The anti-mXSS double-parse in sanitizeHtmlCore returned raw, unescaped fragment.textContent when the serialize→re-parse output was unstable. Every caller assigns the ...

X Description: Summary Fixes #162 (Critical). The anti-mXSS double-parse in sanitizeHtmlCore returned raw, unescaped fragment.textContent when the serialize→re-parse output was unstable. Every caller assigns the ...

Opengraph URL: https://github.com/bQuery/bQuery/pull/182

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:49fba311-22f5-835f-a419-ff3461000374
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2A8:C86CC:7BFB23:B4C9A2:6A4E113E
html-safe-nonce4dc0359051d4d6b1d1f3ef378fa73dc83b18afba102b932de0ac2b9658bbfa2d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkE4OkM4NkNDOjdCRkIyMzpCNEM5QTI6NkE0RTExM0UiLCJ2aXNpdG9yX2lkIjoiMjU2MDkwODgxMzYyNTMzMjAzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc56f7d8bbd465e3a382bf890b0b8a93927df3a307096e18e5e5921f15d0c42b3
hovercard-subject-tagpull_request:4000822471
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/bQuery/bQuery/pull/182/files
twitter:imagehttps://avatars.githubusercontent.com/u/20913954?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20913954?s=400&v=4
og:image:altSummary Fixes #162 (Critical). The anti-mXSS double-parse in sanitizeHtmlCore returned raw, unescaped fragment.textContent when the serialize→re-parse output was unstable. Every caller assigns the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonedf0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/bQuery/bQuery git https://github.com/bQuery/bQuery.git
octolytics-dimension-user_id256381806
octolytics-dimension-user_loginbQuery
octolytics-dimension-repository_id1139284244
octolytics-dimension-repository_nwobQuery/bQuery
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1139284244
octolytics-dimension-repository_network_root_nwobQuery/bQuery
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release51470c353b8a1f52a88d3e3cc2014b17ab8cc1ce
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/bQuery/bQuery/pull/182/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FbQuery%2FbQuery%2Fpull%2F182%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FbQuery%2FbQuery%2Fpull%2F182%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=bQuery%2FbQuery
Reloadhttps://github.com/bQuery/bQuery/pull/182/files
Reloadhttps://github.com/bQuery/bQuery/pull/182/files
Reloadhttps://github.com/bQuery/bQuery/pull/182/files
Please reload this pagehttps://github.com/bQuery/bQuery/pull/182/files
bQuery https://github.com/bQuery
bQueryhttps://github.com/bQuery/bQuery
Please reload this pagehttps://github.com/bQuery/bQuery/pull/182/files
Notifications https://github.com/login?return_to=%2FbQuery%2FbQuery
Fork 0 https://github.com/login?return_to=%2FbQuery%2FbQuery
Star 1 https://github.com/login?return_to=%2FbQuery%2FbQuery
Code https://github.com/bQuery/bQuery
Issues 0 https://github.com/bQuery/bQuery/issues
Pull requests 0 https://github.com/bQuery/bQuery/pulls
Actions https://github.com/bQuery/bQuery/actions
Security and quality 0 https://github.com/bQuery/bQuery/security
Insights https://github.com/bQuery/bQuery/pulse
Code https://github.com/bQuery/bQuery
Issues https://github.com/bQuery/bQuery/issues
Pull requests https://github.com/bQuery/bQuery/pulls
Actions https://github.com/bQuery/bQuery/actions
Security and quality https://github.com/bQuery/bQuery/security
Insights https://github.com/bQuery/bQuery/pulse
Sign up for GitHub https://github.com/signup?return_to=%2FbQuery%2FbQuery%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2FbQuery%2FbQuery%2Fissues%2Fnew%2Fchoose
JosunLPhttps://github.com/JosunLP
devhttps://github.com/bQuery/bQuery/tree/dev
fix/162-mxss-fallback-escapehttps://github.com/bQuery/bQuery/tree/fix/162-mxss-fallback-escape
Conversation 1 https://github.com/bQuery/bQuery/pull/182
Commits 1 https://github.com/bQuery/bQuery/pull/182/commits
Checks 8 https://github.com/bQuery/bQuery/pull/182/checks
Files changed https://github.com/bQuery/bQuery/pull/182/files
Please reload this pagehttps://github.com/bQuery/bQuery/pull/182/files
fix(security): escape mXSS-detection text fallback in sanitizeHtmlCore https://github.com/bQuery/bQuery/pull/182/files#top
Show all changes 1 commit https://github.com/bQuery/bQuery/pull/182/files
c481e03 fix(security): escape mXSS-detection text fallback in sanitizeHtmlCore JosunLP Jul 6, 2026 https://github.com/bQuery/bQuery/pull/182/commits/c481e035af97ee9f65ce3cff4dc131a0f8b1f018
Clear filters https://github.com/bQuery/bQuery/pull/182/files
Please reload this pagehttps://github.com/bQuery/bQuery/pull/182/files
Please reload this pagehttps://github.com/bQuery/bQuery/pull/182/files
sanitize-core.ts https://github.com/bQuery/bQuery/pull/182/files#diff-3997f7a213e6fdea82df73293863c514455e5672059e7f766d3c2fb755a290c9
security.test.ts https://github.com/bQuery/bQuery/pull/182/files#diff-1874ce6f3c03cecd7ffb4ab6788849648ad62622ebe474f2da8a70a454d087bc
src/security/sanitize-core.tshttps://github.com/bQuery/bQuery/pull/182/files#diff-3997f7a213e6fdea82df73293863c514455e5672059e7f766d3c2fb755a290c9
View file https://github.com/bQuery/bQuery/blob/c481e035af97ee9f65ce3cff4dc131a0f8b1f018/src/security/sanitize-core.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/bQuery/bQuery/pull/182/{{ revealButtonHref }}
https://github.com/bQuery/bQuery/pull/182/files#diff-3997f7a213e6fdea82df73293863c514455e5672059e7f766d3c2fb755a290c9
https://github.com/bQuery/bQuery/pull/182/files#diff-3997f7a213e6fdea82df73293863c514455e5672059e7f766d3c2fb755a290c9
https://github.com/bQuery/bQuery/pull/182/files#diff-3997f7a213e6fdea82df73293863c514455e5672059e7f766d3c2fb755a290c9
https://github.com/bQuery/bQuery/pull/182/files#diff-3997f7a213e6fdea82df73293863c514455e5672059e7f766d3c2fb755a290c9
tests/security.test.tshttps://github.com/bQuery/bQuery/pull/182/files#diff-1874ce6f3c03cecd7ffb4ab6788849648ad62622ebe474f2da8a70a454d087bc
View file https://github.com/bQuery/bQuery/blob/c481e035af97ee9f65ce3cff4dc131a0f8b1f018/tests/security.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/bQuery/bQuery/pull/182/{{ revealButtonHref }}
https://github.com/bQuery/bQuery/pull/182/files#diff-1874ce6f3c03cecd7ffb4ab6788849648ad62622ebe474f2da8a70a454d087bc
https://github.com/bQuery/bQuery/pull/182/files#diff-1874ce6f3c03cecd7ffb4ab6788849648ad62622ebe474f2da8a70a454d087bc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.