Title: Fix security, type safety, and API surface issues from PR #16 review by Copilot · Pull Request #18 · bQuery/bQuery · GitHub
Open Graph Title: Fix security, type safety, and API surface issues from PR #16 review by Copilot · Pull Request #18 · bQuery/bQuery
X Title: Fix security, type safety, and API surface issues from PR #16 review by Copilot · Pull Request #18 · bQuery/bQuery
Description: Addresses 8 review comments from PR #16 covering security vulnerabilities, runtime errors, and API design issues. Security Component styles injection: Use createElement('style') + textContent instead of concatenating into innerHTML to prevent XSS if styles contain DOM clobbering protection: Normalize all RESERVED_IDS to lowercase (Function → function, parentNode → parentnode) for proper case-insensitive comparison in isSafeIdOrName() Type Safety & Runtime Errors Router link handler: Guard e.target with instanceof Element before calling closest() to prevent errors on Text nodes Motion CSS properties: Convert camelCase to kebab-case (backgroundColor → background-color) in applyFinalKeyframeStyles so reduced-motion fallbacks work correctly // Before: style.setProperty('backgroundColor', value) - fails silently // After: style.setProperty('background-color', value) - works const cssProp = prop.startsWith('--') ? prop : toKebabCase(prop); style.setProperty(cssProp, String(value)); API Surface Core utilities: Replace export * from './utils' with explicit named exports to exclude internal helpers like isPrototypePollutionKey from @bquery/bquery/core Documentation View.update(): Clarify it only mutates context; re-renders happen via reactive signals mapGetters: Fix example to avoid destructuring which breaks reactivity Security module: Update version reference from 1.2.x to 1.3.0 ✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Open Graph Description: Addresses 8 review comments from PR #16 covering security vulnerabilities, runtime errors, and API design issues. Security Component styles injection: Use createElement('style') + textCont...
X Description: Addresses 8 review comments from PR #16 covering security vulnerabilities, runtime errors, and API design issues. Security Component styles injection: Use createElement('style') + ...
Opengraph URL: https://github.com/bQuery/bQuery/pull/18
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fe12f612-e768-dd63-1e96-4ec29b7aed27 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F70:11B23B:252DC5:36B10F:6A4DFFDD |
| html-safe-nonce | c1be306b8998ca440c565c5cba76312d0bf46a697592cf45036b38c06673b784 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjcwOjExQjIzQjoyNTJEQzU6MzZCMTBGOjZBNERGRkREIiwidmlzaXRvcl9pZCI6Ijg5MzI5MzExMzMwMTM2MjI3NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2773719971868094df461d09ee7b8efb3e015d6e01d1f93479f93657d2e5c7f5 |
| hovercard-subject-tag | pull_request:3208891345 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/bQuery/bQuery/pull/18/files |
| twitter:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/in/1143301?s=400&v=4 |
| og:image:alt | Addresses 8 review comments from PR #16 covering security vulnerabilities, runtime errors, and API design issues. Security Component styles injection: Use createElement('style') + textCont... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | df0492960db29b4938cb72070351d6b1d0c6c0767b27ceb8394bbf4fcc0223c6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/bQuery/bQuery git https://github.com/bQuery/bQuery.git |
| octolytics-dimension-user_id | 256381806 |
| octolytics-dimension-user_login | bQuery |
| octolytics-dimension-repository_id | 1139284244 |
| octolytics-dimension-repository_nwo | bQuery/bQuery |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1139284244 |
| octolytics-dimension-repository_network_root_nwo | bQuery/bQuery |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 52bde38e24398476f8eb1e0760c81346c6a00812 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width