René's URL Explorer Experiment


Title: [Medium][server] Session and CSRF cookies are not Secure by default · Issue #169 · bQuery/bQuery · GitHub

Open Graph Title: [Medium][server] Session and CSRF cookies are not Secure by default · Issue #169 · bQuery/bQuery

X Title: [Medium][server] Session and CSRF cookies are not Secure by default · Issue #169 · bQuery/bQuery

Description: Severity: 🟡 Medium (insecure default; direct credential-theft impact) Location Session cookie: src/server/session.ts:301-306 (and destroy path :336-343) CSRF secret cookie: src/server/csrf.ts:159-163 Description The session-id cookie def...

Open Graph Description: Severity: 🟡 Medium (insecure default; direct credential-theft impact) Location Session cookie: src/server/session.ts:301-306 (and destroy path :336-343) CSRF secret cookie: src/server/csrf.ts:159-1...

X Description: Severity: 🟡 Medium (insecure default; direct credential-theft impact) Location Session cookie: src/server/session.ts:301-306 (and destroy path :336-343) CSRF secret cookie: src/server/csrf.ts:159-1...

Opengraph URL: https://github.com/bQuery/bQuery/issues/169

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Medium][server] Session and CSRF cookies are not Secure by default","articleBody":"## Severity: 🟡 Medium (insecure default; direct credential-theft impact)\n\n## Location\n- Session cookie: [`src/server/session.ts:301-306`](../blob/main/src/server/session.ts#L301-L306) (and destroy path `:336-343`)\n- CSRF secret cookie: [`src/server/csrf.ts:159-163`](../blob/main/src/server/csrf.ts#L159-L163)\n\n## Description\nThe session-id cookie defaults to `{ httpOnly: true, sameSite: 'lax', path: '/' }` with **no `secure`**:\n```ts\nconst baseCookie: ServerCookieOptions = {\n  httpOnly: true,\n  sameSite: 'lax',\n  path: '/',\n  ...options.cookie,\n};\n```\nThe cookie holds the signed session id — the sole bearer credential for the session. On any deployment reachable over plain HTTP (mixed HTTP during redirect, or behind a misconfigured proxy), the cookie is transmitted in cleartext and can be captured by a network MITM, yielding full session hijack. `sameSite: 'lax'` does not compensate. The behaviour is documented (\"Set `secure: true` in production\"), but insecure-by-default for a session credential is a real trap for anyone who doesn't read the note.\n\nThe CSRF secret cookie (`csrf.ts`) has the same default (`{ sameSite: 'lax', path: '/' }`, no `secure`); in signed mode the token embeds the raw secret, so a MITM over HTTP can read it and forge matching tokens.\n\n## Suggested fix\nDefault `secure: true` and let users explicitly opt out for local HTTP dev, e.g. `secure: options.cookie?.secure ?? true`; or auto-enable `Secure` when the request/base URL is `https:`. Apply consistently to both the session and CSRF cookies. Consider promoting `__Host-` guidance from a doc note to a runtime default.\n\n---\n_Filed as part of a full-codebase security \u0026 correctness audit._\n","author":{"url":"https://github.com/JosunLP","@type":"Person","name":"JosunLP"},"datePublished":"2026-07-05T17:03:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/169/bQuery/issues/169"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:fbc83805-2a0a-7c50-93da-4a39f10003a4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAC0E:11A717:159F4F2:1DEFAAB:6A4DF00C
html-safe-nonce096a3f6c04fc90c66c28f4a10a6e5a45031280fbd84e208f29f5c51643747ed1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzBFOjExQTcxNzoxNTlGNEYyOjFERUZBQUI6NkE0REYwMEMiLCJ2aXNpdG9yX2lkIjoiNjEzNDQwMTYzNjMxNzkxNzE5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac711c07cad75fa44161876f3d50d403e71742af219453591c350fdaf76b7b381e
hovercard-subject-tagissue:4813694337
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/bQuery/bQuery/169/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fc3afe1fee22e2e6c020a80ce4fc4456055d0a6fd1457dff12986a4343d5e2ce/bQuery/bQuery/issues/169
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fc3afe1fee22e2e6c020a80ce4fc4456055d0a6fd1457dff12986a4343d5e2ce/bQuery/bQuery/issues/169
og:image:altSeverity: 🟡 Medium (insecure default; direct credential-theft impact) Location Session cookie: src/server/session.ts:301-306 (and destroy path :336-343) CSRF secret cookie: src/server/csrf.ts:159-1...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJosunLP
hostnamegithub.com
expected-hostnamegithub.com
None5818716c93c6a2925b815402541a32814e43a7b1261c322b0c2df75224289566
turbo-cache-controlno-preview
go-importgithub.com/bQuery/bQuery git https://github.com/bQuery/bQuery.git
octolytics-dimension-user_id256381806
octolytics-dimension-user_loginbQuery
octolytics-dimension-repository_id1139284244
octolytics-dimension-repository_nwobQuery/bQuery
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1139284244
octolytics-dimension-repository_network_root_nwobQuery/bQuery
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef4bb89367ca678f057d79b1abc45d6675b1bd5b2
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/bQuery/bQuery/issues/169#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FbQuery%2FbQuery%2Fissues%2F169
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2FbQuery%2FbQuery%2Fissues%2F169
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=bQuery%2FbQuery
Reloadhttps://github.com/bQuery/bQuery/issues/169
Reloadhttps://github.com/bQuery/bQuery/issues/169
Reloadhttps://github.com/bQuery/bQuery/issues/169
Please reload this pagehttps://github.com/bQuery/bQuery/issues/169
bQuery https://github.com/bQuery
bQueryhttps://github.com/bQuery/bQuery
Please reload this pagehttps://github.com/bQuery/bQuery/issues/169
Notifications https://github.com/login?return_to=%2FbQuery%2FbQuery
Fork 0 https://github.com/login?return_to=%2FbQuery%2FbQuery
Star 1 https://github.com/login?return_to=%2FbQuery%2FbQuery
Code https://github.com/bQuery/bQuery
Issues 0 https://github.com/bQuery/bQuery/issues
Pull requests 0 https://github.com/bQuery/bQuery/pulls
Actions https://github.com/bQuery/bQuery/actions
Security and quality 0 https://github.com/bQuery/bQuery/security
Insights https://github.com/bQuery/bQuery/pulse
Code https://github.com/bQuery/bQuery
Issues https://github.com/bQuery/bQuery/issues
Pull requests https://github.com/bQuery/bQuery/pulls
Actions https://github.com/bQuery/bQuery/actions
Security and quality https://github.com/bQuery/bQuery/security
Insights https://github.com/bQuery/bQuery/pulse
[Medium][server] Session and CSRF cookies are not Secure by defaulthttps://github.com/bQuery/bQuery/issues/169#top
bugSomething isn't workinghttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22bug%22
medium-priorityMedium severityhttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22medium-priority%22
securityChanges to the security modulehttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22security%22
serverhttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22server%22
https://github.com/JosunLP
JosunLPhttps://github.com/JosunLP
on Jul 5, 2026https://github.com/bQuery/bQuery/issues/169#issue-4813694337
src/server/session.ts:301-306https://github.com/bQuery/bQuery/blob/main/src/server/session.ts#L301-L306
src/server/csrf.ts:159-163https://github.com/bQuery/bQuery/blob/main/src/server/csrf.ts#L159-L163
bugSomething isn't workinghttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22bug%22
medium-priorityMedium severityhttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22medium-priority%22
securityChanges to the security modulehttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22security%22
serverhttps://github.com/bQuery/bQuery/issues?q=state%3Aopen%20label%3A%22server%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.