| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:0cd702cd-82d9-489c-ad87-f18e5b0f7a6e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF32:245A7:9D6A2:CDA48:6AFE5360 |
| html-safe-nonce | 713d2c5b8ae2b17ef94275e73b761df3760fa03f5e168c7f03c40dfdf11f7960 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjMyOjI0NUE3OjlENkEyOkNEQTQ4OjZBRkU1MzYwIiwidmlzaXRvcl9pZCI6IjgzMTQyMjc3MDY2MjMzMTY4MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b4150bcf89b22384c31837709b401e935f04cb21a5bbcdf707cbb4c1d261aaf3 |
| hovercard-subject-tag | pull_request:385884775 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/auth0/java-jwt/405/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8f1f89ca77281e2592b29a183d858f7183c53bbccb1c924ff3cdfd1af0b0bfda/auth0/java-jwt/pull/405 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8f1f89ca77281e2592b29a183d858f7183c53bbccb1c924ff3cdfd1af0b0bfda/auth0/java-jwt/pull/405 |
| og:image:alt | …not null
Changes
Please describe both what is changing and why this is important. Include:
If there is no aud/iss field in token, its a breaking change for the apps. In my case, we do not maintain... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ssrm |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3ad2b58e42f481583284b895305360b61b0223636c9dde6d696b575347163a26 |
| turbo-cache-control | no-cache |
| go-import | github.com/auth0/java-jwt git https://github.com/auth0/java-jwt.git |
| octolytics-dimension-user_id | 2824157 |
| octolytics-dimension-user_login | auth0 |
| octolytics-dimension-repository_id | 17517521 |
| octolytics-dimension-repository_nwo | auth0/java-jwt |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 17517521 |
| octolytics-dimension-repository_network_root_nwo | auth0/java-jwt |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8df44dbe1c8091b38c3e0165c05a1e5c1563762e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/auth0/java-jwt/pull/405#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fauth0%2Fjava-jwt%2Fpull%2F405 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fauth0%2Fjava-jwt%2Fpull%2F405 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=auth0%2Fjava-jwt |
| Reload | https://github.com/auth0/java-jwt/pull/405 |
| Reload | https://github.com/auth0/java-jwt/pull/405 |
| Reload | https://github.com/auth0/java-jwt/pull/405 |
| auth0 | https://github.com/auth0 |
| java-jwt | https://github.com/auth0/java-jwt |
| Code | https://github.com/auth0/java-jwt |
| Issues10 (10) | https://github.com/auth0/java-jwt/issues |
| Pull requests19 (19) | https://github.com/auth0/java-jwt/pulls |
| Discussions | https://github.com/auth0/java-jwt/discussions |
| Actions | https://github.com/auth0/java-jwt/actions |
| Security and quality1 (1) | https://github.com/auth0/java-jwt/security |
| Insights | https://github.com/auth0/java-jwt/insights |
| https://github.com/auth0/java-jwt |
| ssrm | https://github.com/ssrm |
| auth0:master | https://github.com/auth0/java-jwt/tree/master |
| ssrm:fix-audience-issuer-null | https://github.com/ssrm/java-jwt/tree/fix-audience-issuer-null |
| Conversation | https://github.com/auth0/java-jwt/pull/405 |
| Commits5 (5) | https://github.com/auth0/java-jwt/pull/405/commits |
| Checks | https://github.com/auth0/java-jwt/pull/405/checks |
| Files changed | https://github.com/auth0/java-jwt/pull/405/files |
| Added additional conditions on varargs to make sure given varargs or … | https://github.com/auth0/java-jwt/pull/405#top |
| ssrm | https://github.com/ssrm |
| auth0:master | https://github.com/auth0/java-jwt/tree/master |
| ssrm:fix-audience-issuer-null | https://github.com/ssrm/java-jwt/tree/fix-audience-issuer-null |
|
| https://github.com/ssrm |
| ssrm | https://github.com/ssrm |
| Mar 10, 2020 | https://github.com/auth0/java-jwt/pull/405#issue-578271179 |
| Please reload this page | https://github.com/auth0/java-jwt/pull/405 |
| Issue on setting audience/issuer as var-args (JWTVerifier) #404 | https://github.com/auth0/java-jwt/issues/404 |
| Auth0 general contribution guidelines | https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md |
| Auth0 Code of Conduct | https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md |
| Please reload this page | https://github.com/auth0/java-jwt/pull/405 |
| Added additional conditions on varargs to make sure given varargs or … | https://github.com/auth0/java-jwt/pull/405/commits/d8b04c4be5d6fcfca8ca955668a297fc5ebcc796 |
| d8b04c4 | https://github.com/auth0/java-jwt/pull/405/commits/d8b04c4be5d6fcfca8ca955668a297fc5ebcc796 |
| https://github.com/ssrm |
| ssrm | https://github.com/ssrm |
| March 10, 2020 00:55 | https://github.com/auth0/java-jwt/pull/405#event-3112877970 |
| March 9, 2020 20:20 | https://github.com/auth0/java-jwt/pull/405#commits-pushed-afddc30 |
| Added tests | https://github.com/auth0/java-jwt/pull/405/commits/afddc30fffd1bbbb630bae639d29e109c7ae22d2 |
| afddc30 | https://github.com/auth0/java-jwt/pull/405/commits/afddc30fffd1bbbb630bae639d29e109c7ae22d2 |
| Added tests | https://github.com/auth0/java-jwt/pull/405/commits/6149426f74a6f827ec6b062e3c2b8c8aa61f20df |
| 6149426 | https://github.com/auth0/java-jwt/pull/405/commits/6149426f74a6f827ec6b062e3c2b8c8aa61f20df |
| refactored issuer and audience check | https://github.com/auth0/java-jwt/pull/405/commits/a312241e64b952b9b60fae2cc25f7db47cc46c80 |
| a312241 | https://github.com/auth0/java-jwt/pull/405/commits/a312241e64b952b9b60fae2cc25f7db47cc46c80 |
| refactored issuer and audience check | https://github.com/auth0/java-jwt/pull/405/commits/968b102e8c47f2d74e550ce704e3038f98746e05 |
| 968b102 | https://github.com/auth0/java-jwt/pull/405/commits/968b102e8c47f2d74e550ce704e3038f98746e05 |
| https://github.com/jimmyjames |
| jimmyjames | https://github.com/jimmyjames |
| jimmyjames | https://github.com/jimmyjames |
| March 18, 2020 16:45 | https://github.com/auth0/java-jwt/pull/405#event-3142300400 |
| https://github.com/jimmyjames |
| jimmyjames | https://github.com/jimmyjames |
|
Mar 18, 2020
| https://github.com/auth0/java-jwt/pull/405#pullrequestreview-377239054 |
|
View reviewed changes
| https://github.com/auth0/java-jwt/pull/405/files/968b102e8c47f2d74e550ce704e3038f98746e05 |
| lib/src/main/java/com/auth0/jwt/JWTVerifier.java | https://github.com/auth0/java-jwt/pull/405/files/968b102e8c47f2d74e550ce704e3038f98746e05#diff-760f7db04ae0a5d36145104eb38caddc1812aca73e426b70b4756dd25524baf4 |
| jimmyjames | https://github.com/jimmyjames |
| Mar 18, 2020 | https://github.com/auth0/java-jwt/pull/405#discussion_r394642747 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/auth0/java-jwt/pull/405 |
| https://github.com/jimmyjames |
| jimmyjames | https://github.com/jimmyjames |
|
small
| https://github.com/auth0/java-jwt/issues?q=state%3Aopen%20label%3Asmall |
|
waiting for customer
| https://github.com/auth0/java-jwt/issues?q=state%3Aopen%20label%3A%22waiting%20for%20customer%22 |
| Mar 23, 2020 | https://github.com/auth0/java-jwt/pull/405#event-3155454508 |
| https://github.com/jimmyjames |
| jimmyjames | https://github.com/jimmyjames |
|
Mar 25, 2020
| https://github.com/auth0/java-jwt/pull/405#ref-pullrequest-587770833 |
|
Check varargs null values in JWTVerifier
#412
| https://github.com/auth0/java-jwt/pull/412 |
| https://github.com/jimmyjames |
| jimmyjames | https://github.com/jimmyjames |
| Mar 25, 2020 | https://github.com/auth0/java-jwt/pull/405#issuecomment-603898196 |
| #412 | https://github.com/auth0/java-jwt/pull/412 |
| Please reload this page | https://github.com/auth0/java-jwt/pull/405 |
| https://github.com/jimmyjames |
| jimmyjames | https://github.com/jimmyjames |
| Mar 25, 2020 | https://github.com/auth0/java-jwt/pull/405#event-3164427263 |
| https://github.co/hiddenchars |
| https://github.com/auth0/java-jwt/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fauth0%2Fjava-jwt%2Fpull%2F405 |
|
| https://github.com/jimmyjames |
|
jimmyjames
| https://github.com/jimmyjames |
|
| https://github.com/auth0/java-jwt/pull/405/files/968b102e8c47f2d74e550ce704e3038f98746e05 |
| Please reload this page | https://github.com/auth0/java-jwt/pull/405 |
|
small
| https://github.com/auth0/java-jwt/issues?q=state%3Aopen%20label%3Asmall |
|
waiting for customer
| https://github.com/auth0/java-jwt/issues?q=state%3Aopen%20label%3A%22waiting%20for%20customer%22 |
| Please reload this page | https://github.com/auth0/java-jwt/pull/405 |
|
| https://github.com/ssrm |
|
| https://github.com/jimmyjames |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |