| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d4c50317-2152-9790-4457-c17f9f60d20c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B59A:DBE5:13C299B:1A760FA:69699E49 |
| html-safe-nonce | b4bb11a6355e6d2e8ead38dfda7c6e60b71c8fd759220f71c66f8b26fbda4cd6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTlBOkRCRTU6MTNDMjk5QjoxQTc2MEZBOjY5Njk5RTQ5IiwidmlzaXRvcl9pZCI6IjY5ODg3MjAzMTU2NTkwMzQxODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 4c4d915b84d344740654db6b83f0947a3b92e5e54689fd36081695672e7f94b4 |
| hovercard-subject-tag | pull_request:116670649 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/atom/github/688/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/28f95ef18d45291179e9f1ab1e88b3441b3dad20b0165794c56b9782cb3d6884/atom/github/pull/688 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/28f95ef18d45291179e9f1ab1e88b3441b3dad20b0165794c56b9782cb3d6884/atom/github/pull/688 |
| og:image:alt | Fixes #386.
Fixes #643.
This PR addresses the issue of Atom freezing due to multiple blocking spawn calls when shelling out to Git in process (#386).
The Options
The solution is to make Git calls i... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kuychaco |
| hostname | github.com |
| expected-hostname | github.com |
| None | 24c4c97a2d520cb286b35e1a4c22d7a4df3c26a2fa28dd7cdf0e65db327b4de7 |
| turbo-cache-control | no-preview |
| go-import | github.com/atom/github git https://github.com/atom/github.git |
| octolytics-dimension-user_id | 1089146 |
| octolytics-dimension-user_login | atom |
| octolytics-dimension-repository_id | 46155786 |
| octolytics-dimension-repository_nwo | atom/github |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 46155786 |
| octolytics-dimension-repository_network_root_nwo | atom/github |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 124667f43168afb6c9c03b7c02eb5b1d2e1be3d9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/atom/github/pull/688#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fpull%2F688 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fpull%2F688 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=atom%2Fgithub |
| Reload | https://github.com/atom/github/pull/688 |
| Reload | https://github.com/atom/github/pull/688 |
| Reload | https://github.com/atom/github/pull/688 |
|
atom
| https://github.com/atom |
| github | https://github.com/atom/github |
|
Notifications
| https://github.com/login?return_to=%2Fatom%2Fgithub |
|
Fork
408
| https://github.com/login?return_to=%2Fatom%2Fgithub |
|
Star
1.2k
| https://github.com/login?return_to=%2Fatom%2Fgithub |
|
Code
| https://github.com/atom/github |
|
Issues
440
| https://github.com/atom/github/issues |
|
Pull requests
65
| https://github.com/atom/github/pulls |
|
Actions
| https://github.com/atom/github/actions |
|
Projects
0
| https://github.com/atom/github/projects |
|
Wiki
| https://github.com/atom/github/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/atom/github/security |
| Please reload this page | https://github.com/atom/github/pull/688 |
|
Insights
| https://github.com/atom/github/pulse |
|
Code
| https://github.com/atom/github |
|
Issues
| https://github.com/atom/github/issues |
|
Pull requests
| https://github.com/atom/github/pulls |
|
Actions
| https://github.com/atom/github/actions |
|
Projects
| https://github.com/atom/github/projects |
|
Wiki
| https://github.com/atom/github/wiki |
|
Security
| https://github.com/atom/github/security |
|
Insights
| https://github.com/atom/github/pulse |
| kuychaco | https://github.com/kuychaco |
| master | https://github.com/atom/github/tree/master |
| ku-renderer-shell-out | https://github.com/atom/github/tree/ku-renderer-shell-out |
|
Run git commands in dedicated renderer process
| https://github.com/atom/github/pull/688#top |
| kuychaco | https://github.com/kuychaco |
| master | https://github.com/atom/github/tree/master |
| ku-renderer-shell-out | https://github.com/atom/github/tree/ku-renderer-shell-out |
|
Conversation
27
| https://github.com/atom/github/pull/688 |
|
Commits
82
| https://github.com/atom/github/pull/688/commits |
|
Checks
0
| https://github.com/atom/github/pull/688/checks |
|
Files changed
| https://github.com/atom/github/pull/688/files |
| Please reload this page | https://github.com/atom/github/pull/688 |
| https://github.co/hiddenchars |
| https://github.com/atom/github/pull/{{ revealButtonHref }} |
|
| https://github.com/kuychaco |
| kuychaco | https://github.com/kuychaco |
| Apr 20, 2017 | https://github.com/atom/github/pull/688#issue-222914822 |
| Please reload this page | https://github.com/atom/github/pull/688 |
| #386 | https://github.com/atom/github/issues/386 |
| #643 | https://github.com/atom/github/issues/643 |
| #386 | https://github.com/atom/github/issues/386 |
| quadratic growth in IPC time | https://github.com/nodejs/node/issues/3145#issuecomment-270799752 |
| fix | https://github.com/nodejs/node/pull/10557 |
| Node integration to web workers | https://github.com/electron/electron/pull/8852 |
| Please reload this page | https://github.com/atom/github/pull/688 |
| kuychaco | https://github.com/kuychaco |
| April 12, 2017 18:39 | https://github.com/atom/github/pull/688#commits-pushed-c07d65b |
|
| https://github.com/kuychaco |
| WIP compare renderer and child process IPC times | https://github.com/atom/github/pull/688/commits/c07d65b048d2a58eece749c507125e91a57ba0b9 |
| c07d65b | https://github.com/atom/github/pull/688/commits/c07d65b048d2a58eece749c507125e91a57ba0b9 |
|
| https://github.com/kuychaco |
| WIP shell out to git in renderer process | https://github.com/atom/github/pull/688/commits/53384de28acdc827aef5c75c0411258c85eb123a |
| 53384de | https://github.com/atom/github/pull/688/commits/53384de28acdc827aef5c75c0411258c85eb123a |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| WIP Create RendererProcessManager | https://github.com/atom/github/pull/688/commits/519ebfc37f8f8684c88aa291473d39e174f721e3 |
| 519ebfc | https://github.com/atom/github/pull/688/commits/519ebfc37f8f8684c88aa291473d39e174f721e3 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| ⬆️ atom-mocha-test-runner@1.0.1 | https://github.com/atom/github/pull/688/commits/c9b2978578e9230c300d74c1b757773d148afd2a |
| c9b2978 | https://github.com/atom/github/pull/688/commits/c9b2978578e9230c300d74c1b757773d148afd2a |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Make RendererProcessManager a singleton | https://github.com/atom/github/pull/688/commits/f91e8cdf6d4d2e43277411aeb6d3bbeaf290850a |
| f91e8cd | https://github.com/atom/github/pull/688/commits/f91e8cdf6d4d2e43277411aeb6d3bbeaf290850a |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Actually import GitError | https://github.com/atom/github/pull/688/commits/8fe00d5c46e6f1057158b0de6ed2de755c04b8dd |
| 8fe00d5 | https://github.com/atom/github/pull/688/commits/8fe00d5c46e6f1057158b0de6ed2de755c04b8dd |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Use import instead of require | https://github.com/atom/github/pull/688/commits/e9aa22d270969a31f3627260cc6b83dc8ec5d276 |
| e9aa22d | https://github.com/atom/github/pull/688/commits/e9aa22d270969a31f3627260cc6b83dc8ec5d276 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Don't show browser window for git renderer process | https://github.com/atom/github/pull/688/commits/169ab2013e3b22c7c96a6b8f46b1e76f47fec3a7 |
| 169ab20 | https://github.com/atom/github/pull/688/commits/169ab2013e3b22c7c96a6b8f46b1e76f47fec3a7 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| WIP wtf is up w/ the tests | https://github.com/atom/github/pull/688/commits/72b5ccce9d9802f3fb69b0ed87fdf0aaceda485e |
| 72b5ccc | https://github.com/atom/github/pull/688/commits/72b5ccce9d9802f3fb69b0ed87fdf0aaceda485e |
| Wait for renderer process to be ready before sending Git commands | https://github.com/atom/github/pull/688/commits/761ff7d712ca1b7d7c46a44c27fe09c9bf4d3188 |
| 761ff7d | https://github.com/atom/github/pull/688/commits/761ff7d712ca1b7d7c46a44c27fe09c9bf4d3188 |
| Destroy any Repositories created during tests after each test | https://github.com/atom/github/pull/688/commits/54c1653dc5670299d934a7625d60c104712b8b08 |
| 54c1653 | https://github.com/atom/github/pull/688/commits/54c1653dc5670299d934a7625d60c104712b8b08 |
| No need to reset singleton RendererProcessManager after each test | https://github.com/atom/github/pull/688/commits/09fdc01e1f852c63244d12dd1d56352114201e56 |
| 09fdc01 | https://github.com/atom/github/pull/688/commits/09fdc01e1f852c63244d12dd1d56352114201e56 |
| Conditionally choose exec strategy | https://github.com/atom/github/pull/688/commits/197b332310412f22476c8394bc5e1dd281bb9d96 |
| 197b332 | https://github.com/atom/github/pull/688/commits/197b332310412f22476c8394bc5e1dd281bb9d96 |
| Fix global test setup | https://github.com/atom/github/pull/688/commits/364b086c98a4e3943622be1550b269c56b4c38e2 |
| 364b086 | https://github.com/atom/github/pull/688/commits/364b086c98a4e3943622be1550b269c56b4c38e2 |
| Extract Git execution into a separate method for stubbing | https://github.com/atom/github/pull/688/commits/ed4c5ed124b29cae72a60d57bc3c1e70863d911d |
| ed4c5ed | https://github.com/atom/github/pull/688/commits/ed4c5ed124b29cae72a60d57bc3c1e70863d911d |
| Un-pend test | https://github.com/atom/github/pull/688/commits/ca3411c0f9a567be0c610e3fbf36c782a9d57091 |
| ca3411c | https://github.com/atom/github/pull/688/commits/ca3411c0f9a567be0c610e3fbf36c782a9d57091 |
|
| https://github.com/BinaryMuse |
|
| https://github.com/kuychaco |
| Fix flaky test | https://github.com/atom/github/pull/688/commits/bc7ae77968024f1dbdf1ff89c88645382fb31e5b |
| bc7ae77 | https://github.com/atom/github/pull/688/commits/bc7ae77968024f1dbdf1ff89c88645382fb31e5b |
|
| https://github.com/BinaryMuse |
|
| https://github.com/kuychaco |
| 🎨 | https://github.com/atom/github/pull/688/commits/3bda0a9a764545aa6668bbc1e337d47cff0d7da5 |
| 3bda0a9 | https://github.com/atom/github/pull/688/commits/3bda0a9a764545aa6668bbc1e337d47cff0d7da5 |
|
| https://github.com/kuychaco |
| 🔥 git-child-process.js | https://github.com/atom/github/pull/688/commits/22281854287ec943a930077f1dfc122ca5fce101 |
| 2228185 | https://github.com/atom/github/pull/688/commits/22281854287ec943a930077f1dfc122ca5fce101 |
|
| https://github.com/kuychaco |
| 🎨 and clean up | https://github.com/atom/github/pull/688/commits/325f48b382d06cbfa96e1e84dca4a7d8e97ff842 |
| 325f48b | https://github.com/atom/github/pull/688/commits/325f48b382d06cbfa96e1e84dca4a7d8e97ff842 |
|
| https://github.com/kuychaco |
| More clean up | https://github.com/atom/github/pull/688/commits/2bd9e3757a72eb863a6b498e2f1ea9a88ec35d69 |
| 2bd9e37 | https://github.com/atom/github/pull/688/commits/2bd9e3757a72eb863a6b498e2f1ea9a88ec35d69 |
|
| https://github.com/kuychaco |
| 🔥 comments | https://github.com/atom/github/pull/688/commits/684ca4ac785e3f352e02dff5375a26ff59bd1c20 |
| 684ca4a | https://github.com/atom/github/pull/688/commits/684ca4ac785e3f352e02dff5375a26ff59bd1c20 |
|
| https://github.com/kuychaco |
| Remove type property from ipc data and rely on channel to identify type | https://github.com/atom/github/pull/688/commits/6494404b46c7a87d7bdb6113b845c20636a66ac2 |
| 6494404 | https://github.com/atom/github/pull/688/commits/6494404b46c7a87d7bdb6113b845c20636a66ac2 |
|
| https://github.com/kuychaco |
| 🔥 unused changes to GitTimingsView | https://github.com/atom/github/pull/688/commits/e7074b7e071485095d936b39965885b9a43afa37 |
| e7074b7 | https://github.com/atom/github/pull/688/commits/e7074b7e071485095d936b39965885b9a43afa37 |
|
| https://github.com/kuychaco |
| Actually, we want to test that... | https://github.com/atom/github/pull/688/commits/5d2fef328405b0ffeca1e617e988acdfa42e4632 |
| 5d2fef3 | https://github.com/atom/github/pull/688/commits/5d2fef328405b0ffeca1e617e988acdfa42e4632 |
|
| https://github.com/kuychaco |
| Put those timeouts back | https://github.com/atom/github/pull/688/commits/9b3a2880db02c003dd4e9d5616f4abd11516785f |
| 9b3a288 | https://github.com/atom/github/pull/688/commits/9b3a2880db02c003dd4e9d5616f4abd11516785f |
|
| https://github.com/kuychaco |
| Mo 🎨 | https://github.com/atom/github/pull/688/commits/0187c4b32be371b0102b0e5d9311f7b4a57f9fda |
| 0187c4b | https://github.com/atom/github/pull/688/commits/0187c4b32be371b0102b0e5d9311f7b4a57f9fda |
|
| https://github.com/kuychaco |
| Communicate on ipc channel based on renderer's web contents id | https://github.com/atom/github/pull/688/commits/de1918bddc2de3f26d3e069a15750108fc921e97 |
| de1918b | https://github.com/atom/github/pull/688/commits/de1918bddc2de3f26d3e069a15750108fc921e97 |
|
| https://github.com/kuychaco |
| Delete entry in RendererProcessManager map after promise is resolved | https://github.com/atom/github/pull/688/commits/b86ad95cc3efd730ed22b1ab4880a450f07058ea |
| b86ad95 | https://github.com/atom/github/pull/688/commits/b86ad95cc3efd730ed22b1ab4880a450f07058ea |
|
| https://github.com/kuychaco |
| rendererWebContentsId -> childWebContentsID | https://github.com/atom/github/pull/688/commits/66a1a0868b343e372d9c71dad0f90ea3c3d5d730 |
| 66a1a08 | https://github.com/atom/github/pull/688/commits/66a1a0868b343e372d9c71dad0f90ea3c3d5d730 |
| kuychaco | https://github.com/kuychaco |
| April 25, 2017 15:47 | https://github.com/atom/github/pull/688#commits-pushed-652459d |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Use static channelName for all ipc communication | https://github.com/atom/github/pull/688/commits/652459d810eb8862302c16a0ce37be01c15d099c |
| 652459d | https://github.com/atom/github/pull/688/commits/652459d810eb8862302c16a0ce37be01c15d099c |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Dispose of webContents listeners before destroying manager window | https://github.com/atom/github/pull/688/commits/7e7d4cec245264f50941bce97321b944cf4cb069 |
| 7e7d4ce | https://github.com/atom/github/pull/688/commits/7e7d4cec245264f50941bce97321b944cf4cb069 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Fix test | https://github.com/atom/github/pull/688/commits/aa09a9618423214a014cac5a95cf4e0896ff34ce |
| aa09a96 | https://github.com/atom/github/pull/688/commits/aa09a9618423214a014cac5a95cf4e0896ff34ce |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Fix other test | https://github.com/atom/github/pull/688/commits/863209dfdf9ca5b4e2c88a0b3acee157157d0886 |
| 863209d | https://github.com/atom/github/pull/688/commits/863209dfdf9ca5b4e2c88a0b3acee157157d0886 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Merge branch 'ku-renderer-shell-out' of github.com:atom/github into k… | https://github.com/atom/github/pull/688/commits/bc3073ca1c0d61d53f84b29e6780ed0ef1eeb389 |
| bc3073c | https://github.com/atom/github/pull/688/commits/bc3073ca1c0d61d53f84b29e6780ed0ef1eeb389 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Include sourceWebContentsId in git data ipc message | https://github.com/atom/github/pull/688/commits/55f9882a5780d0fa0818cf32ef5f5a33b722eef7 |
| 55f9882 | https://github.com/atom/github/pull/688/commits/55f9882a5780d0fa0818cf32ef5f5a33b722eef7 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Don't show browser window | https://github.com/atom/github/pull/688/commits/6502cbfeaa215d91c563bd43b2fc34243a9ea29d |
| 6502cbf | https://github.com/atom/github/pull/688/commits/6502cbfeaa215d91c563bd43b2fc34243a9ea29d |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Don't reject promise for remaining operations during destroy | https://github.com/atom/github/pull/688/commits/c3b875e0177fc8e3759315273080d76ed6b3b08f |
| c3b875e | https://github.com/atom/github/pull/688/commits/c3b875e0177fc8e3759315273080d76ed6b3b08f |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| 🔥 RendererProcessManager | https://github.com/atom/github/pull/688/commits/b7f4b204c628a3d09190a67a92e29bae5414f688 |
| b7f4b20 | https://github.com/atom/github/pull/688/commits/b7f4b204c628a3d09190a67a92e29bae5414f688 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Force reset of WorkerManager after tests complete | https://github.com/atom/github/pull/688/commits/5e34e0e25ebad787b0d17634c82f9f2aabbb4195 |
| 5e34e0e | https://github.com/atom/github/pull/688/commits/5e34e0e25ebad787b0d17634c82f9f2aabbb4195 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Implement WorkerManager.prototype.isReady | https://github.com/atom/github/pull/688/commits/6359895cc49c40b5b3a0c7cd89eeeabe0f1ade46 |
| 6359895 | https://github.com/atom/github/pull/688/commits/6359895cc49c40b5b3a0c7cd89eeeabe0f1ade46 |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Shell out in process if WorkerManager instance isn't ready | https://github.com/atom/github/pull/688/commits/c39aaf662ee424a61362e126ee71a3526f5c2aff |
| c39aaf6 | https://github.com/atom/github/pull/688/commits/c39aaf662ee424a61362e126ee71a3526f5c2aff |
|
| https://github.com/kuychaco |
|
| https://github.com/BinaryMuse |
| Don't await ready promise in RendererProcess#executeOperation | https://github.com/atom/github/pull/688/commits/95fb731b2b52b3d69dd69a70788efad58127e08b |
| 95fb731 | https://github.com/atom/github/pull/688/commits/95fb731b2b52b3d69dd69a70788efad58127e08b |
| First hacky pass at IPC-based Git timings | https://github.com/atom/github/pull/688/commits/7a954461d1822ce80a2a9e4a4fd2a372e2772a29 |
| 7a95446 | https://github.com/atom/github/pull/688/commits/7a954461d1822ce80a2a9e4a4fd2a372e2772a29 |
| https://github.com/kuychaco |
| kuychaco | https://github.com/kuychaco |
| smashwilson | https://github.com/smashwilson |
| April 26, 2017 17:33 | https://github.com/atom/github/pull/688#event-1059056539 |
| kuychaco | https://github.com/kuychaco |
| April 26, 2017 13:51 | https://github.com/atom/github/pull/688#commits-pushed-5d309d1 |
|
| https://github.com/kuychaco |
| 👕 | https://github.com/atom/github/pull/688/commits/5d309d1f3b892d530772cfa4001543cae9a8f4c0 |
| 5d309d1 | https://github.com/atom/github/pull/688/commits/5d309d1f3b892d530772cfa4001543cae9a8f4c0 |
|
| https://github.com/kuychaco |
| Don't clog up IPC channel with 'exec-started' events | https://github.com/atom/github/pull/688/commits/3066270c4ed1e01ea91cac13806f940e3af69703 |
| 3066270 | https://github.com/atom/github/pull/688/commits/3066270c4ed1e01ea91cac13806f940e3af69703 |
|
| https://github.com/kuychaco |
| Destroy WorkerManager in deactivate | https://github.com/atom/github/pull/688/commits/4084aec06491cfc61f45bf2fbe73d59895e54634 |
| 4084aec | https://github.com/atom/github/pull/688/commits/4084aec06491cfc61f45bf2fbe73d59895e54634 |
| https://github.com/BinaryMuse |
| BinaryMuse | https://github.com/BinaryMuse |
|
Apr 27, 2017
| https://github.com/atom/github/pull/688#pullrequestreview-34998750 |
|
View reviewed changes
| https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634 |
| https://github.com/smashwilson |
| smashwilson | https://github.com/smashwilson |
|
Apr 27, 2017
| https://github.com/atom/github/pull/688#pullrequestreview-34998981 |
|
View reviewed changes
| https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634 |
| smashwilson | https://github.com/smashwilson |
| https://github.com/atom/github/pull/688#pullrequestreview-34998981 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| lib/git-shell-out-strategy.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-76392c1f5a8514b35f51f486561f0b750197d4e949db2f51fc2fd699d7df940e |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113596831 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| kuychaco | https://github.com/kuychaco |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113599879 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| lib/git-shell-out-strategy.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-76392c1f5a8514b35f51f486561f0b750197d4e949db2f51fc2fd699d7df940e |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113596975 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| lib/renderer.html | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-936d97c8d36336373e6e4234ae73c62ef570de68541080c9f9c9f0481d0a38d4 |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113597080 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| lib/worker-manager.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-281ccd13eed5f3dfefacb3148c168c99416471225721ff5d3dfbd8e6e9577915 |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113597407 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| lib/worker-manager.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-281ccd13eed5f3dfefacb3148c168c99416471225721ff5d3dfbd8e6e9577915 |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113597470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| kuychaco | https://github.com/kuychaco |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113600237 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| lib/worker.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-df9477f338c214ed04a5e566edd666461eee57595f4b8800d286075824c2ad2c |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113597636 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://camo.githubusercontent.com/c4d5401eae2429dd4cdbc1f547b37af436d5bbb59d0fcd1095458b710391dd4e/68747470733a2f2f696d616765732d6e612e73736c2d696d616765732d616d617a6f6e2e636f6d2f696d616765732f492f38317430794d44564b6f4c2e5f53583432355f2e6a7067 |
| Please reload this page | https://github.com/atom/github/pull/688 |
| kuychaco | https://github.com/kuychaco |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113600294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| test/helpers.js | https://github.com/atom/github/pull/688/files/920b4ca053207dce5b0963a661213176135c7337#diff-3b89f96d1a840d06f933bf99913ac4906757a56d4acdef7b2b96c0b956600e26 |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113597772 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| test/worker-manager.test.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-24fa8edb675434b052e460e6fb7491bab4afd157c568a9a7f9a6d1a777320a6d |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113597875 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| test/worker-manager.test.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-24fa8edb675434b052e460e6fb7491bab4afd157c568a9a7f9a6d1a777320a6d |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113597916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113602674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| lib/git-shell-out-strategy.js | https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634#diff-76392c1f5a8514b35f51f486561f0b750197d4e949db2f51fc2fd699d7df940e |
| smashwilson | https://github.com/smashwilson |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#discussion_r113598092 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/atom/github/pull/688 |
| kuychaco | https://github.com/kuychaco |
| April 26, 2017 18:40 | https://github.com/atom/github/pull/688#commits-pushed-8727017 |
|
| https://github.com/kuychaco |
| Add console.warn to indicate sick worker | https://github.com/atom/github/pull/688/commits/87270176922aaf9dc66d63408a1ba5fc2399c65c |
| 8727017 | https://github.com/atom/github/pull/688/commits/87270176922aaf9dc66d63408a1ba5fc2399c65c |
|
| https://github.com/kuychaco |
| ⌨️ | https://github.com/atom/github/pull/688/commits/7bab3da7f162c101bd9ff8fcab022356f2c64f0a |
| 7bab3da | https://github.com/atom/github/pull/688/commits/7bab3da7f162c101bd9ff8fcab022356f2c64f0a |
|
| https://github.com/kuychaco |
| Use assert.lengthOf | https://github.com/atom/github/pull/688/commits/1740e9b238e6f51aa488018a42f31523f6fe497c |
| 1740e9b | https://github.com/atom/github/pull/688/commits/1740e9b238e6f51aa488018a42f31523f6fe497c |
|
| https://github.com/kuychaco |
| Merge branch 'master' into ku-renderer-shell-out | https://github.com/atom/github/pull/688/commits/c3b4b2304e9a5daf78c248051261e26428716fe5 |
| c3b4b23 | https://github.com/atom/github/pull/688/commits/c3b4b2304e9a5daf78c248051261e26428716fe5 |
|
| https://github.com/kuychaco |
| Only log about sick worker if not in spec mode | https://github.com/atom/github/pull/688/commits/e70866845969f15f4cb1feb693d7fa8528592ea5 |
| e708668 | https://github.com/atom/github/pull/688/commits/e70866845969f15f4cb1feb693d7fa8528592ea5 |
| https://github.com/kuychaco |
| kuychaco | https://github.com/kuychaco |
| 9b8ed5d | https://github.com/atom/github/commit/9b8ed5d8c0c5b1be85d402e31d453738b7b77dbd |
| Apr 27, 2017 | https://github.com/atom/github/pull/688#event-1061122987 |
| https://github.com/kuychaco |
| kuychaco | https://github.com/kuychaco |
| April 27, 2017 20:33 | https://github.com/atom/github/pull/688#event-1061123221 |
| https://github.com/kuychaco |
| kuychaco | https://github.com/kuychaco |
|
work-in-progress
| https://github.com/atom/github/issues?q=state%3Aopen%20label%3Awork-in-progress |
| May 12, 2017 | https://github.com/atom/github/pull/688#event-1080022777 |
| https://github.com/BinaryMuse |
| BinaryMuse | https://github.com/BinaryMuse |
|
Jul 10, 2017
| https://github.com/atom/github/pull/688#ref-pullrequest-229440308 |
|
Move git refresh status task to long running task (Bug #9544)
atom/atom#14456
| https://github.com/atom/atom/pull/14456 |
| https://github.com/smashwilson |
| smashwilson | https://github.com/smashwilson |
|
Feb 28, 2019
| https://github.com/atom/github/pull/688#ref-pullrequest-415105581 |
|
RFC: use git ls to crawl all files in the project
atom/fuzzy-finder#367
| https://github.com/atom/fuzzy-finder/pull/367 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fpull%2F688 |
|
| https://github.com/smashwilson |
|
smashwilson
| https://github.com/smashwilson |
|
| https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634 |
|
| https://github.com/BinaryMuse |
|
BinaryMuse
| https://github.com/BinaryMuse |
|
| https://github.com/atom/github/pull/688/files/4084aec06491cfc61f45bf2fbe73d59895e54634 |
|
Use a persistent child process for git operations
| https://github.com/atom/github/issues/643 |
|
Multiple blocking spawn calls to Git are freezing Atom intermittently
| https://github.com/atom/github/issues/386 |
| Please reload this page | https://github.com/atom/github/pull/688 |
|
| https://github.com/kuychaco |
|
| https://github.com/smashwilson |
|
| https://github.com/BinaryMuse |
|
| https://github.com/apps/copilot-swe-agent |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |