René's URL Explorer Experiment


Title: Real staging by joshaber · Pull Request #3 · atom/github · GitHub

Open Graph Title: Real staging by joshaber · Pull Request #3 · atom/github

X Title: Real staging by joshaber · Pull Request #3 · atom/github

Description: :octocat: Git and GitHub integration for Atom. Contribute to atom/github development by creating an account on GitHub.

Open Graph Description: In order to test diffs, we need to be able to stage. So get line staging working for reals. The tests are pretty lulz right now since we don’t accurately get stagedness from git itself. Kinda chick...

X Description: In order to test diffs, we need to be able to stage. So get line staging working for reals. The tests are pretty lulz right now since we don’t accurately get stagedness from git itself. Kinda chick...

Opengraph URL: https://github.com/atom/github/pull/3

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:19c52671-3352-4a21-9366-9c08186a92a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBC8E:2E564C:79F84D:9F15BE:6A5EC2A2
html-safe-nonce2db86a289c897b1fe10158e6a1244e324b821b04c40149e4a3c0f19a05dfe519
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzhFOjJFNTY0Qzo3OUY4NEQ6OUYxNUJFOjZBNUVDMkEyIiwidmlzaXRvcl9pZCI6IjExOTE5ODIwMzQ5MjUzMDY1MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfeb4caa98057679df28117ae77e7dd1201cd07085f2e2aba98d31204e51f816e
hovercard-subject-tagpull_request:58158054
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/atom/github/3/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7817cfeb9d82dd2ed256126dff33a0983b6d22511a8035042de8940eecf95d0/atom/github/pull/3
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7817cfeb9d82dd2ed256126dff33a0983b6d22511a8035042de8940eecf95d0/atom/github/pull/3
og:image:altIn order to test diffs, we need to be able to stage. So get line staging working for reals. The tests are pretty lulz right now since we don’t accurately get stagedness from git itself. Kinda chick...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoshaber
hostnamegithub.com
expected-hostnamegithub.com
None121697e83b1a53996d2aab5cd5284eafd23e0c69e26d49c4fb688c52668f0720
turbo-cache-controlno-cache
go-importgithub.com/atom/github git https://github.com/atom/github.git
octolytics-dimension-user_id1089146
octolytics-dimension-user_loginatom
octolytics-dimension-repository_id46155786
octolytics-dimension-repository_nwoatom/github
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id46155786
octolytics-dimension-repository_network_root_nwoatom/github
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release79e6b50a3c2621ed3f16ba092856f7db2218ae7d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/atom/github/pull/3#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fpull%2F3
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fpull%2F3
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=atom%2Fgithub
Reloadhttps://github.com/atom/github/pull/3
Reloadhttps://github.com/atom/github/pull/3
Reloadhttps://github.com/atom/github/pull/3
Please reload this pagehttps://github.com/atom/github/pull/3
atom https://github.com/atom
githubhttps://github.com/atom/github
Notifications https://github.com/login?return_to=%2Fatom%2Fgithub
Fork 406 https://github.com/login?return_to=%2Fatom%2Fgithub
Star 1.2k https://github.com/login?return_to=%2Fatom%2Fgithub
Code https://github.com/atom/github
Issues 440 https://github.com/atom/github/issues
Pull requests 65 https://github.com/atom/github/pulls
Actions https://github.com/atom/github/actions
Projects https://github.com/atom/github/projects
Wiki https://github.com/atom/github/wiki
Security and quality 0 https://github.com/atom/github/security
Insights https://github.com/atom/github/pulse
Code https://github.com/atom/github
Issues https://github.com/atom/github/issues
Pull requests https://github.com/atom/github/pulls
Actions https://github.com/atom/github/actions
Projects https://github.com/atom/github/projects
Wiki https://github.com/atom/github/wiki
Security and quality https://github.com/atom/github/security
Insights https://github.com/atom/github/pulse
joshaberhttps://github.com/joshaber
masterhttps://github.com/atom/github/tree/master
real-staginghttps://github.com/atom/github/tree/real-staging
Conversationhttps://github.com/atom/github/pull/3
Commits15 (15)https://github.com/atom/github/pull/3/commits
Checkshttps://github.com/atom/github/pull/3/checks
Files changedhttps://github.com/atom/github/pull/3/files
Real staginghttps://github.com/atom/github/pull/3#top
joshaberhttps://github.com/joshaber
masterhttps://github.com/atom/github/tree/master
real-staginghttps://github.com/atom/github/tree/real-staging
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Feb 3, 2016https://github.com/atom/github/pull/3#issue-131069204
Please reload this pagehttps://github.com/atom/github/pull/3
joshaberhttps://github.com/joshaber
February 2, 2016 17:17https://github.com/atom/github/pull/3#commits-pushed-f75785d
https://github.com/joshaber
Added fixture repo.https://github.com/atom/github/pull/3/commits/f75785dd9f373a283d1f744103e559f7445cbe1d
f75785dhttps://github.com/atom/github/pull/3/commits/f75785dd9f373a283d1f744103e559f7445cbe1d
https://github.com/joshaber
Pass the diff through to the hunk and line.https://github.com/atom/github/pull/3/commits/efddd9559c9da6d807481349ff62ccdbee965102
efddd95https://github.com/atom/github/pull/3/commits/efddd9559c9da6d807481349ff62ccdbee965102
https://github.com/joshaber
Await so that we're all setup once we're done.https://github.com/atom/github/pull/3/commits/b3f84dcafd9f66f0ef1e557a97c6077ea87ad571
b3f84dchttps://github.com/atom/github/pull/3/commits/b3f84dcafd9f66f0ef1e557a97c6077ea87ad571
https://github.com/joshaber
Actually do the staging.https://github.com/atom/github/pull/3/commits/537595d77f5be0f11839bbdd055b1fbe93d9d676
537595dhttps://github.com/atom/github/pull/3/commits/537595d77f5be0f11839bbdd055b1fbe93d9d676
https://github.com/joshaber
Test staging.https://github.com/atom/github/pull/3/commits/06091832b76049e30f52d03e0af25f09400ea7e3
0609183https://github.com/atom/github/pull/3/commits/06091832b76049e30f52d03e0af25f09400ea7e3
https://github.com/joshaber
⬆️ nodegit@0.9https://github.com/atom/github/pull/3/commits/829f716645ae85ad4d1ee91c1b54d1f8444bbc0c
829f716https://github.com/atom/github/pull/3/commits/829f716645ae85ad4d1ee91c1b54d1f8444bbc0c
https://github.com/joshaber
Make sure we get the right nodegit binary.https://github.com/atom/github/pull/3/commits/8ea9b77d0c6a2c9ef2cfc4cf59f2fa679014c09a
8ea9b77https://github.com/atom/github/pull/3/commits/8ea9b77d0c6a2c9ef2cfc4cf59f2fa679014c09a
https://github.com/joshaber
Tests.https://github.com/atom/github/pull/3/commits/f873d24d1e138bc367ff08fed5e448a68ce95230
f873d24https://github.com/atom/github/pull/3/commits/f873d24d1e138bc367ff08fed5e448a68ce95230
https://github.com/joshaber
Supress some warnings for now.https://github.com/atom/github/pull/3/commits/c3c03cd9a2280999c9343da875ddfacc62332459
c3c03cdhttps://github.com/atom/github/pull/3/commits/c3c03cd9a2280999c9343da875ddfacc62332459
https://github.com/joshaber
Don't need to log this anymore.https://github.com/atom/github/pull/3/commits/4d6f1c671c7ab8d9b442c40103a3126160e8924a
4d6f1c6https://github.com/atom/github/pull/3/commits/4d6f1c671c7ab8d9b442c40103a3126160e8924a
https://github.com/joshaber
Restore the previous value if staging fails.https://github.com/atom/github/pull/3/commits/02cfb6272fea75c4b1746f623e2aaf95bc9a3d1d
02cfb62https://github.com/atom/github/pull/3/commits/02cfb6272fea75c4b1746f623e2aaf95bc9a3d1d
https://github.com/joshaber
Wait until we're done staging.https://github.com/atom/github/pull/3/commits/0679be289d51cdd8e8f1bad7a23c8b686c7ac760
0679be2https://github.com/atom/github/pull/3/commits/0679be289d51cdd8e8f1bad7a23c8b686c7ac760
https://github.com/joshaber
Log errors.https://github.com/atom/github/pull/3/commits/af977521c03f0fc607956328bf4792f00e8cda2d
af97752https://github.com/atom/github/pull/3/commits/af977521c03f0fc607956328bf4792f00e8cda2d
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Feb 3, 2016https://github.com/atom/github/pull/3#issuecomment-179314427
Please reload this pagehttps://github.com/atom/github/pull/3
benoglehttps://github.com/benogle
Feb 3, 2016 https://github.com/atom/github/pull/3#discussion-diff-51773263
View reviewed changes https://github.com/atom/github/pull/3/files/af977521c03f0fc607956328bf4792f00e8cda2d#diff-ae7e19e763e7464644b95f33c8a220d399cf73c0a3979148d1c7824eedfd49bc
lib/hunk-line.jshttps://github.com/atom/github/pull/3/files#diff-ae7e19e763e7464644b95f33c8a220d399cf73c0a3979148d1c7824eedfd49bc
benoglehttps://github.com/benogle
Feb 3, 2016https://github.com/atom/github/pull/3#discussion_r51773263
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/atom/github/pull/3
joshaberhttps://github.com/joshaber
Feb 3, 2016https://github.com/atom/github/pull/3#discussion_r51784942
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/atom/github/pull/3
https://github.com/benogle
benoglehttps://github.com/benogle
Feb 3, 2016https://github.com/atom/github/pull/3#issuecomment-179459795
Please reload this pagehttps://github.com/atom/github/pull/3
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Feb 3, 2016https://github.com/atom/github/pull/3#issuecomment-179472778
Please reload this pagehttps://github.com/atom/github/pull/3
https://github.com/benogle
benoglehttps://github.com/benogle
Feb 3, 2016https://github.com/atom/github/pull/3#issuecomment-179473438
Please reload this pagehttps://github.com/atom/github/pull/3
joshaberhttps://github.com/joshaber
February 3, 2016 16:27https://github.com/atom/github/pull/3#commits-pushed-29dafb5
https://github.com/joshaber
Pass the stage function through to the model.https://github.com/atom/github/pull/3/commits/29dafb5d5cd8c35974a66c1c8c1b3694b3b9ccaa
29dafb5https://github.com/atom/github/pull/3/commits/29dafb5d5cd8c35974a66c1c8c1b3694b3b9ccaa
https://github.com/joshaber
Merge branch 'master' into real-staginghttps://github.com/atom/github/pull/3/commits/754de1f289d877e5f119e1eca1155b93897a3f63
754de1fhttps://github.com/atom/github/pull/3/commits/754de1f289d877e5f119e1eca1155b93897a3f63
https://github.com/joshaber
joshaberhttps://github.com/joshaber
Feb 3, 2016https://github.com/atom/github/pull/3#issuecomment-179498173
Please reload this pagehttps://github.com/atom/github/pull/3
joshaberhttps://github.com/joshaber
Feb 3, 2016 https://github.com/atom/github/pull/3#ref-commit-dcb44a7
https://github.com/joshaber
Merge pull requesthttps://github.com/atom/github/commit/dcb44a76eb54a885914ea9d1d5ac92bfc0537732
#3https://github.com/atom/github/pull/3
from atom/real-staginghttps://github.com/atom/github/commit/dcb44a76eb54a885914ea9d1d5ac92bfc0537732
dcb44a7https://github.com/atom/github/commit/dcb44a76eb54a885914ea9d1d5ac92bfc0537732
https://github.com/joshaber
joshaberhttps://github.com/joshaber
dcb44a7https://github.com/atom/github/commit/dcb44a76eb54a885914ea9d1d5ac92bfc0537732
Feb 3, 2016https://github.com/atom/github/pull/3#event-538290582
https://github.com/joshaber
joshaberhttps://github.com/joshaber
February 3, 2016 22:12https://github.com/atom/github/pull/3#event-538290610
https://github.co/hiddenchars
https://github.com/atom/github/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fpull%2F3
Please reload this pagehttps://github.com/atom/github/pull/3
https://github.com/joshaber
https://github.com/benogle
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.