René's URL Explorer Experiment


Title: Exception when handling "copied" status · Issue #482 · atom/github · GitHub

Open Graph Title: Exception when handling "copied" status · Issue #482 · atom/github

X Title: Exception when handling "copied" status · Issue #482 · atom/github

Description: $ git status On branch mkt-gql-login Your branch is up-to-date with 'origin/mkt-gql-login'. Changes to be committed: (use "git reset HEAD ..." to unstage) modified: lib/controllers/github-controller.js modified: lib/git-shell-out-s...

Open Graph Description: $ git status On branch mkt-gql-login Your branch is up-to-date with 'origin/mkt-gql-login'. Changes to be committed: (use "git reset HEAD ..." to unstage) modified: lib/controllers/github-con...

X Description: $ git status On branch mkt-gql-login Your branch is up-to-date with 'origin/mkt-gql-login'. Changes to be committed: (use "git reset HEAD <file>..." to unstage) modified: li...

Opengraph URL: https://github.com/atom/github/issues/482

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Exception when handling \"copied\" status","articleBody":"```\r\n$ git status\r\nOn branch mkt-gql-login\r\nYour branch is up-to-date with 'origin/mkt-gql-login'.\r\nChanges to be committed:\r\n  (use \"git reset HEAD \u003cfile\u003e...\" to unstage)\r\n\r\n\tmodified:   lib/controllers/github-controller.js\r\n\tmodified:   lib/git-shell-out-strategy.js\r\n\tnew file:   lib/models/github-login-model.js\r\n\tmodified:   package.json\r\n\tnew file:   styles/github-controller.less\r\n\tcopied:     styles/github-panel.less -\u003e styles/github-login-view.less\r\n\tmodified:   styles/github-panel.less\r\n```\r\n\r\n`GSOS#getStatusesForChangedFiles` is getting the output\r\n\r\n```\r\nM  lib/controllers/github-controller.js\r\nMM lib/git-shell-out-strategy.js\r\nA  lib/models/github-login-model.js\r\nM  package.json\r\nA  styles/github-controller.less\r\nC  styles/github-login-view.less\r\nstyles/github-panel.less\r\nM  styles/github-panel.less\r\n```\r\n\r\nThe second to last line, which is the file that the file on the line before it was copied *from*, is causing the regex to fail. The following diff fixes:\r\n\r\n```diff\r\ndiff --git a/lib/git-shell-out-strategy.js b/lib/git-shell-out-strategy.js\r\nindex e92a35f..d60fbb0 100644\r\n--- a/lib/git-shell-out-strategy.js\r\n+++ b/lib/git-shell-out-strategy.js\r\n@@ -164,6 +164,7 @@ export default class GitShellOutStrategy {\r\n \r\n     const statusMap = {\r\n       'A': 'added',\r\n+      'C': 'added', // technically copied, but we'll treat as added\r\n       'M': 'modified',\r\n       'D': 'deleted',\r\n       'U': 'modified',\r\n@@ -205,6 +206,10 @@ export default class GitShellOutStrategy {\r\n         if (x !== ' ' \u0026\u0026 x !== '?') {\r\n           stagedFiles[filePath] = statusMap[x];\r\n         }\r\n+        if (x === 'C') {\r\n+          // skip the next line, which is the copied file\r\n+          i++\r\n+        }\r\n       }\r\n     }\r\n```","author":{"url":"https://github.com/BinaryMuse","@type":"Person","name":"BinaryMuse"},"datePublished":"2017-01-25T05:31:17.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/482/github/issues/482"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1b8afc0e-4b35-aa59-19c9-002cbb35a7e1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE7BE:179A4C:FD5F6F:1730426:6A4E3582
html-safe-nonce27544a88fd90d39e8cb91805ff8fbb1d124d8345c2faf3d8a8ac92329b6cffad
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFN0JFOjE3OUE0QzpGRDVGNkY6MTczMDQyNjo2QTRFMzU4MiIsInZpc2l0b3JfaWQiOiI2MzQ2ODA3NzkyMjQyNjY4OTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac694f710940b9f697db4d0b57747e3859dbe8abc5bb8dc1a7a5ee902d7de12107
hovercard-subject-tagissue:203016508
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/atom/github/482/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1be3957c4b1730ff77371832ab2b0eb8e49d3dda1417b398f2947e2e24fe05ef/atom/github/issues/482
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1be3957c4b1730ff77371832ab2b0eb8e49d3dda1417b398f2947e2e24fe05ef/atom/github/issues/482
og:image:alt$ git status On branch mkt-gql-login Your branch is up-to-date with 'origin/mkt-gql-login'. Changes to be committed: (use "git reset HEAD ..." to unstage) modified: lib/controllers/github-con...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameBinaryMuse
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-preview
go-importgithub.com/atom/github git https://github.com/atom/github.git
octolytics-dimension-user_id1089146
octolytics-dimension-user_loginatom
octolytics-dimension-repository_id46155786
octolytics-dimension-repository_nwoatom/github
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id46155786
octolytics-dimension-repository_network_root_nwoatom/github
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release42a6d378d7587a44c93aca255096cd66b7c8eb2d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/atom/github/issues/482#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fissues%2F482
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fatom%2Fgithub%2Fissues%2F482
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=atom%2Fgithub
Reloadhttps://github.com/atom/github/issues/482
Reloadhttps://github.com/atom/github/issues/482
Reloadhttps://github.com/atom/github/issues/482
Please reload this pagehttps://github.com/atom/github/issues/482
atom https://github.com/atom
githubhttps://github.com/atom/github
Notifications https://github.com/login?return_to=%2Fatom%2Fgithub
Fork 406 https://github.com/login?return_to=%2Fatom%2Fgithub
Star 1.2k https://github.com/login?return_to=%2Fatom%2Fgithub
Code https://github.com/atom/github
Issues 440 https://github.com/atom/github/issues
Pull requests 65 https://github.com/atom/github/pulls
Actions https://github.com/atom/github/actions
Projects https://github.com/atom/github/projects
Wiki https://github.com/atom/github/wiki
Security and quality 0 https://github.com/atom/github/security
Insights https://github.com/atom/github/pulse
Code https://github.com/atom/github
Issues https://github.com/atom/github/issues
Pull requests https://github.com/atom/github/pulls
Actions https://github.com/atom/github/actions
Projects https://github.com/atom/github/projects
Wiki https://github.com/atom/github/wiki
Security and quality https://github.com/atom/github/security
Insights https://github.com/atom/github/pulse
Exception when handling "copied" statushttps://github.com/atom/github/issues/482#top
https://github.com/BinaryMuse
BinaryMusehttps://github.com/BinaryMuse
on Jan 25, 2017https://github.com/atom/github/issues/482#issue-203016508
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.