| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:56a9739e-f979-165a-f93c-557c7a940a67 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E2E:AA45D:11292E7:1745B90:6964A434 |
| html-safe-nonce | 00035a950a66e2476698998bc5ef87eea75a17ab07c459794e413a58348585b6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTJFOkFBNDVEOjExMjkyRTc6MTc0NUI5MDo2OTY0QTQzNCIsInZpc2l0b3JfaWQiOiI4OTAzNDc1ODk4MTIzOTcxMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 16ead13849224b2a76421b7f8d3c367dff0977b7f18d89cef21ca5118326c4bb |
| hovercard-subject-tag | pull_request:964551559 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/arrayfire/arrayfire/3258/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/43af8c9454e5e71f7b9760934ecf92d7111a7f9b1710ef1684c6d382ac8ed324/arrayfire/arrayfire/pull/3258 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43af8c9454e5e71f7b9760934ecf92d7111a7f9b1710ef1684c6d382ac8ed324/arrayfire/arrayfire/pull/3258 |
| og:image:alt | Add support for f16 for modulus and norm. This PR also adds tests for the norm function
Description
Adds support for modulus operation for half type. This operation is missing in the CUDA backend ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | umar456 |
| hostname | github.com |
| expected-hostname | github.com |
| None | baa7d9900fdf7b27d604f36887af878d569cfbdcf97126832a5f4f0caf0c6ba5 |
| turbo-cache-control | no-preview |
| go-import | github.com/arrayfire/arrayfire git https://github.com/arrayfire/arrayfire.git |
| octolytics-dimension-user_id | 5395442 |
| octolytics-dimension-user_login | arrayfire |
| octolytics-dimension-repository_id | 25889802 |
| octolytics-dimension-repository_nwo | arrayfire/arrayfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 25889802 |
| octolytics-dimension-repository_network_root_nwo | arrayfire/arrayfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 842eff1d11f899d02b6b3b98fa3ea4860e64b34e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/arrayfire/arrayfire/pull/3258#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F3258 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F3258 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=arrayfire%2Farrayfire |
| Reload | https://github.com/arrayfire/arrayfire/pull/3258 |
| Reload | https://github.com/arrayfire/arrayfire/pull/3258 |
| Reload | https://github.com/arrayfire/arrayfire/pull/3258 |
|
arrayfire
| https://github.com/arrayfire |
| arrayfire | https://github.com/arrayfire/arrayfire |
|
Notifications
| https://github.com/login?return_to=%2Farrayfire%2Farrayfire |
|
Fork
549
| https://github.com/login?return_to=%2Farrayfire%2Farrayfire |
|
Star
4.8k
| https://github.com/login?return_to=%2Farrayfire%2Farrayfire |
|
Code
| https://github.com/arrayfire/arrayfire |
|
Issues
285
| https://github.com/arrayfire/arrayfire/issues |
|
Pull requests
18
| https://github.com/arrayfire/arrayfire/pulls |
|
Actions
| https://github.com/arrayfire/arrayfire/actions |
|
Projects
0
| https://github.com/arrayfire/arrayfire/projects |
|
Wiki
| https://github.com/arrayfire/arrayfire/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/arrayfire/arrayfire/security |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
|
Insights
| https://github.com/arrayfire/arrayfire/pulse |
|
Code
| https://github.com/arrayfire/arrayfire |
|
Issues
| https://github.com/arrayfire/arrayfire/issues |
|
Pull requests
| https://github.com/arrayfire/arrayfire/pulls |
|
Actions
| https://github.com/arrayfire/arrayfire/actions |
|
Projects
| https://github.com/arrayfire/arrayfire/projects |
|
Wiki
| https://github.com/arrayfire/arrayfire/wiki |
|
Security
| https://github.com/arrayfire/arrayfire/security |
|
Insights
| https://github.com/arrayfire/arrayfire/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Farrayfire%2Farrayfire%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Farrayfire%2Farrayfire%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/arrayfire/arrayfire/pull/3258#issue-comment-box |
| christophe-murphy | https://github.com/christophe-murphy |
| arrayfire:master | https://github.com/arrayfire/arrayfire/tree/master |
| umar456:half_mod | https://github.com/umar456/arrayfire/tree/half_mod |
|
Add f16 support for modulus and norm
| https://github.com/arrayfire/arrayfire/pull/3258#top |
| christophe-murphy | https://github.com/christophe-murphy |
| arrayfire:master | https://github.com/arrayfire/arrayfire/tree/master |
| umar456:half_mod | https://github.com/umar456/arrayfire/tree/half_mod |
|
Conversation
5
| https://github.com/arrayfire/arrayfire/pull/3258 |
|
Commits
10
| https://github.com/arrayfire/arrayfire/pull/3258/commits |
|
Checks
4
| https://github.com/arrayfire/arrayfire/pull/3258/checks |
|
Files changed
| https://github.com/arrayfire/arrayfire/pull/3258/files |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| https://github.co/hiddenchars |
| https://github.com/arrayfire/arrayfire/pull/{{ revealButtonHref }} |
|
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| Jun 10, 2022 | https://github.com/arrayfire/arrayfire/pull/3258#issue-1268018399 |
| #3256 | https://github.com/arrayfire/arrayfire/issues/3256 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| force-pushed | https://github.com/arrayfire/arrayfire/compare/6e0dec7a78fa2bea2c794d65d331e83688ebc5e1..9c1389e3219ad9ca0f834031659ee88d43b0aa89 |
| 6e0dec7 | https://github.com/arrayfire/arrayfire/commit/6e0dec7a78fa2bea2c794d65d331e83688ebc5e1 |
| 9c1389e | https://github.com/arrayfire/arrayfire/commit/9c1389e3219ad9ca0f834031659ee88d43b0aa89 |
|
Compare
| https://github.com/arrayfire/arrayfire/compare/6e0dec7a78fa2bea2c794d65d331e83688ebc5e1..9c1389e3219ad9ca0f834031659ee88d43b0aa89 |
| June 10, 2022 22:40 | https://github.com/arrayfire/arrayfire/pull/3258#event-6789129974 |
| umar456 | https://github.com/umar456 |
| June 11, 2022 12:52 | https://github.com/arrayfire/arrayfire/pull/3258#commits-pushed-385a283 |
|
| https://github.com/umar456 |
| Add support for f16 for modulus operations | https://github.com/arrayfire/arrayfire/pull/3258/commits/385a2833002f0bdf1ea0eec08e791167ea248416 |
| 385a283 | https://github.com/arrayfire/arrayfire/pull/3258/commits/385a2833002f0bdf1ea0eec08e791167ea248416 |
|
| https://github.com/umar456 |
| Update float math functions to use ff functions to maintain types | https://github.com/arrayfire/arrayfire/pull/3258/commits/d05c2c67095c6fbd7785b9dbcc6be8d4cb04b06a |
| d05c2c6 | https://github.com/arrayfire/arrayfire/pull/3258/commits/d05c2c67095c6fbd7785b9dbcc6be8d4cb04b06a |
|
| https://github.com/umar456 |
| Add additional binary tests for integer types | https://github.com/arrayfire/arrayfire/pull/3258/commits/7d9ed1de2d407d3998d26e3a2395bac8abb948cc |
| 7d9ed1d | https://github.com/arrayfire/arrayfire/pull/3258/commits/7d9ed1de2d407d3998d26e3a2395bac8abb948cc |
|
| https://github.com/umar456 |
| Add tests for norm | https://github.com/arrayfire/arrayfire/pull/3258/commits/68b5505421563f2397cd6846a4109474fefd145f |
| 68b5505 | https://github.com/arrayfire/arrayfire/pull/3258/commits/68b5505421563f2397cd6846a4109474fefd145f |
|
| https://github.com/umar456 |
| Add support for half for norm | https://github.com/arrayfire/arrayfire/pull/3258/commits/c388d51bcc3baf510b1c475117f975401b088c1c |
| c388d51 | https://github.com/arrayfire/arrayfire/pull/3258/commits/c388d51bcc3baf510b1c475117f975401b088c1c |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| force-pushed | https://github.com/arrayfire/arrayfire/compare/9c1389e3219ad9ca0f834031659ee88d43b0aa89..c388d51bcc3baf510b1c475117f975401b088c1c |
| 9c1389e | https://github.com/arrayfire/arrayfire/commit/9c1389e3219ad9ca0f834031659ee88d43b0aa89 |
| c388d51 | https://github.com/arrayfire/arrayfire/commit/c388d51bcc3baf510b1c475117f975401b088c1c |
|
Compare
| https://github.com/arrayfire/arrayfire/compare/9c1389e3219ad9ca0f834031659ee88d43b0aa89..c388d51bcc3baf510b1c475117f975401b088c1c |
| June 11, 2022 18:01 | https://github.com/arrayfire/arrayfire/pull/3258#event-6790330796 |
| https://github.com/syurkevi |
| syurkevi | https://github.com/syurkevi |
| September 12, 2022 19:20 | https://github.com/arrayfire/arrayfire/pull/3258#event-7370451147 |
| https://github.com/syurkevi |
| syurkevi | https://github.com/syurkevi |
|
Sep 12, 2022
| https://github.com/arrayfire/arrayfire/pull/3258#pullrequestreview-1104708441 |
|
View reviewed changes
| https://github.com/arrayfire/arrayfire/pull/3258/files/c388d51bcc3baf510b1c475117f975401b088c1c |
| test/math.cpp | https://github.com/arrayfire/arrayfire/pull/3258/files/c388d51bcc3baf510b1c475117f975401b088c1c#diff-89c1da456b8cf7791f536387c2d9e35bf22beb0e0398ca9b27f2bbdb1e78a622 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| test/norm.cpp | https://github.com/arrayfire/arrayfire/pull/3258/files/c388d51bcc3baf510b1c475117f975401b088c1c#diff-a52eb7c38c30280d4c473bf11df0276d13b59496a03e09432c29c551d0b26f30 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| test/norm.cpp | https://github.com/arrayfire/arrayfire/pull/3258/files/c388d51bcc3baf510b1c475117f975401b088c1c#diff-a52eb7c38c30280d4c473bf11df0276d13b59496a03e09432c29c551d0b26f30 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| https://github.com/edwinsolisf |
| edwinsolisf | https://github.com/edwinsolisf |
| Jan 28, 2025 | https://github.com/arrayfire/arrayfire/pull/3258#event-16088109170 |
|
| https://github.com/edwinsolisf |
| Added tests for norm and modulus. Made consistent modulus for ints in… | https://github.com/arrayfire/arrayfire/pull/3258/commits/821df19889a20eede17586d0bf067b76a0ff2122 |
| 821df19 | https://github.com/arrayfire/arrayfire/pull/3258/commits/821df19889a20eede17586d0bf067b76a0ff2122 |
| https://github.com/edwinsolisf |
| edwinsolisf | https://github.com/edwinsolisf |
|
Feb 5, 2025
| https://github.com/arrayfire/arrayfire/pull/3258#pullrequestreview-2594479517 |
|
View reviewed changes
| https://github.com/arrayfire/arrayfire/pull/3258/files/821df19889a20eede17586d0bf067b76a0ff2122 |
| src/backend/cpu/binary.hpp | https://github.com/arrayfire/arrayfire/pull/3258/files/c388d51bcc3baf510b1c475117f975401b088c1c..821df19889a20eede17586d0bf067b76a0ff2122#diff-2436804f91471a7f1d784943c952075e9701e4e97637490a39db03555e0a2814 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| https://github.com/melonakos |
| melonakos | https://github.com/melonakos |
| 3.10 | https://github.com/arrayfire/arrayfire/milestone/35 |
| Feb 11, 2025 | https://github.com/arrayfire/arrayfire/pull/3258#event-16271845161 |
| https://github.com/edwinsolisf |
| edwinsolisf | https://github.com/edwinsolisf |
| Feb 18, 2025 | https://github.com/arrayfire/arrayfire/pull/3258#issuecomment-2664476837 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| edwinsolisf | https://github.com/edwinsolisf |
| February 17, 2025 23:21 | https://github.com/arrayfire/arrayfire/pull/3258#commits-pushed-186b306 |
|
| https://github.com/edwinsolisf |
| Added more mod tests | https://github.com/arrayfire/arrayfire/pull/3258/commits/186b30636e4b4a00a73984dee6451ea3250e6e07 |
| 186b306 | https://github.com/arrayfire/arrayfire/pull/3258/commits/186b30636e4b4a00a73984dee6451ea3250e6e07 |
|
| https://github.com/edwinsolisf |
| Updated documentation to reflect status quo of the mod and rem expect… | https://github.com/arrayfire/arrayfire/pull/3258/commits/faf943dfa90abedae7d9cb90105ed48b08ab9364 |
| faf943d | https://github.com/arrayfire/arrayfire/pull/3258/commits/faf943dfa90abedae7d9cb90105ed48b08ab9364 |
|
| https://github.com/christophe-murphy |
| Merge branch 'master' into half_mod | https://github.com/arrayfire/arrayfire/pull/3258/commits/37e2982bc8f1afad2b0c0080f412b5086d225b89 |
| 37e2982 | https://github.com/arrayfire/arrayfire/pull/3258/commits/37e2982bc8f1afad2b0c0080f412b5086d225b89 |
|
| https://github.com/christophe-murphy |
| Update copyright | https://github.com/arrayfire/arrayfire/pull/3258/commits/dfe2ab937394429e7ba0f7dfc149c08acbdf21ea |
| dfe2ab9 | https://github.com/arrayfire/arrayfire/pull/3258/commits/dfe2ab937394429e7ba0f7dfc149c08acbdf21ea |
| https://github.com/christophe-murphy |
| christophe-murphy | https://github.com/christophe-murphy |
|
Mar 7, 2025
| https://github.com/arrayfire/arrayfire/pull/3258#pullrequestreview-2667864121 |
|
View reviewed changes
| https://github.com/arrayfire/arrayfire/pull/3258/files/dfe2ab937394429e7ba0f7dfc149c08acbdf21ea |
| https://github.com/christophe-murphy |
| christophe-murphy | https://github.com/christophe-murphy |
| syurkevi | https://github.com/syurkevi |
| stale review | https://github.com/arrayfire/arrayfire/pull/3258#pullrequestreview-1104708441 |
| March 7, 2025 17:08 | https://github.com/arrayfire/arrayfire/pull/3258#event-16635518745 |
| https://github.com/christophe-murphy |
| christophe-murphy | https://github.com/christophe-murphy |
| 408b504 | https://github.com/arrayfire/arrayfire/commit/408b504c4259ec2cb28c625c0906ab12fd1019d7 |
| Mar 7, 2025 | https://github.com/arrayfire/arrayfire/pull/3258#event-16635532868 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F3258 |
|
| https://github.com/edwinsolisf |
|
edwinsolisf
| https://github.com/edwinsolisf |
|
| https://github.com/arrayfire/arrayfire/pull/3258/files/821df19889a20eede17586d0bf067b76a0ff2122 |
|
| https://github.com/christophe-murphy |
|
christophe-murphy
| https://github.com/christophe-murphy |
|
| https://github.com/arrayfire/arrayfire/pull/3258/files/dfe2ab937394429e7ba0f7dfc149c08acbdf21ea |
|
| https://github.com/syurkevi |
|
syurkevi
| https://github.com/syurkevi |
|
| https://github.com/arrayfire/arrayfire/pull/3258/files/c388d51bcc3baf510b1c475117f975401b088c1c |
|
| https://github.com/edwinsolisf |
|
edwinsolisf
| https://github.com/edwinsolisf |
|
3.10
| https://github.com/arrayfire/arrayfire/milestone/35 |
|
fp16 norm is not supported
| https://github.com/arrayfire/arrayfire/issues/3256 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/3258 |
|
| https://github.com/umar456 |
|
| https://github.com/edwinsolisf |
|
| https://github.com/syurkevi |
|
| https://github.com/christophe-murphy |
|
| https://github.com/melonakos |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |