| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2b633c14-bfe8-0ccd-406c-97a9d508e103 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D538:AC611:112CC19:1741C9D:6964A440 |
| html-safe-nonce | b5c998952c8822cc30ee3a99d81eff3b1361623eb5c4dda1b97a7276a3290d04 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTM4OkFDNjExOjExMkNDMTk6MTc0MUM5RDo2OTY0QTQ0MCIsInZpc2l0b3JfaWQiOiI4MjkwOTY1NzcyODc5MzA3ODQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 128cc80532f5856ffe7a81a7a61901b895e169b94922889f870f54cc202986f5 |
| hovercard-subject-tag | pull_request:402144674 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/arrayfire/arrayfire/2838/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3d6d5682f7642579df6d7fd2725cabf7f8bae6c41b705ae84e3c0aa5e53eab82/arrayfire/arrayfire/pull/2838 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3d6d5682f7642579df6d7fd2725cabf7f8bae6c41b705ae84e3c0aa5e53eab82/arrayfire/arrayfire/pull/2838 |
| og:image:alt | some linear algebra functions could have leaked memory in case the input was null. This PR addresses that potential leak and handles the empty or null array case.
Minor refactor in median
Minor ref... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | umar456 |
| hostname | github.com |
| expected-hostname | github.com |
| None | baa7d9900fdf7b27d604f36887af878d569cfbdcf97126832a5f4f0caf0c6ba5 |
| turbo-cache-control | no-preview |
| go-import | github.com/arrayfire/arrayfire git https://github.com/arrayfire/arrayfire.git |
| octolytics-dimension-user_id | 5395442 |
| octolytics-dimension-user_login | arrayfire |
| octolytics-dimension-repository_id | 25889802 |
| octolytics-dimension-repository_nwo | arrayfire/arrayfire |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 25889802 |
| octolytics-dimension-repository_network_root_nwo | arrayfire/arrayfire |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 842eff1d11f899d02b6b3b98fa3ea4860e64b34e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/arrayfire/arrayfire/pull/2838#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F2838 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F2838 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=arrayfire%2Farrayfire |
| Reload | https://github.com/arrayfire/arrayfire/pull/2838 |
| Reload | https://github.com/arrayfire/arrayfire/pull/2838 |
| Reload | https://github.com/arrayfire/arrayfire/pull/2838 |
|
arrayfire
| https://github.com/arrayfire |
| arrayfire | https://github.com/arrayfire/arrayfire |
|
Notifications
| https://github.com/login?return_to=%2Farrayfire%2Farrayfire |
|
Fork
549
| https://github.com/login?return_to=%2Farrayfire%2Farrayfire |
|
Star
4.8k
| https://github.com/login?return_to=%2Farrayfire%2Farrayfire |
|
Code
| https://github.com/arrayfire/arrayfire |
|
Issues
285
| https://github.com/arrayfire/arrayfire/issues |
|
Pull requests
18
| https://github.com/arrayfire/arrayfire/pulls |
|
Actions
| https://github.com/arrayfire/arrayfire/actions |
|
Projects
0
| https://github.com/arrayfire/arrayfire/projects |
|
Wiki
| https://github.com/arrayfire/arrayfire/wiki |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/arrayfire/arrayfire/security |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
|
Insights
| https://github.com/arrayfire/arrayfire/pulse |
|
Code
| https://github.com/arrayfire/arrayfire |
|
Issues
| https://github.com/arrayfire/arrayfire/issues |
|
Pull requests
| https://github.com/arrayfire/arrayfire/pulls |
|
Actions
| https://github.com/arrayfire/arrayfire/actions |
|
Projects
| https://github.com/arrayfire/arrayfire/projects |
|
Wiki
| https://github.com/arrayfire/arrayfire/wiki |
|
Security
| https://github.com/arrayfire/arrayfire/security |
|
Insights
| https://github.com/arrayfire/arrayfire/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Farrayfire%2Farrayfire%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Farrayfire%2Farrayfire%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/arrayfire/arrayfire/pull/2838#issue-comment-box |
| umar456 | https://github.com/umar456 |
| arrayfire:master | https://github.com/arrayfire/arrayfire/tree/master |
| umar456:empty_fix | https://github.com/umar456/arrayfire/tree/empty_fix |
|
Fix empty array handling in lu, rank, and qr. Other minor refactoring
| https://github.com/arrayfire/arrayfire/pull/2838#top |
| umar456 | https://github.com/umar456 |
| arrayfire:master | https://github.com/arrayfire/arrayfire/tree/master |
| umar456:empty_fix | https://github.com/umar456/arrayfire/tree/empty_fix |
|
Conversation
13
| https://github.com/arrayfire/arrayfire/pull/2838 |
|
Commits
4
| https://github.com/arrayfire/arrayfire/pull/2838/commits |
|
Checks
0
| https://github.com/arrayfire/arrayfire/pull/2838/checks |
|
Files changed
| https://github.com/arrayfire/arrayfire/pull/2838/files |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| https://github.co/hiddenchars |
| https://github.com/arrayfire/arrayfire/pull/{{ revealButtonHref }} |
|
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| Apr 11, 2020 | https://github.com/arrayfire/arrayfire/pull/2838#issue-598197020 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| 3.7.2 | https://github.com/arrayfire/arrayfire/milestone/29 |
| Apr 11, 2020 | https://github.com/arrayfire/arrayfire/pull/2838#event-3223699199 |
| https://github.com/9prady9 |
| 9prady9 | https://github.com/9prady9 |
|
Apr 11, 2020
| https://github.com/arrayfire/arrayfire/pull/2838#pullrequestreview-391747268 |
|
View reviewed changes
| https://github.com/arrayfire/arrayfire/pull/2838/files |
| 9prady9 | https://github.com/9prady9 |
| https://github.com/arrayfire/arrayfire/pull/2838#pullrequestreview-391747268 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| src/api/c/lu.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-ad40fea50e71329a6a92116bffc1cbfd9fe2f5661aa8539e157a71b42e8705b7 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| test/lu_dense.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-161d3f3e8264759a8b9740bc082e286ddba6f014c3bd9907590f0819ad1af5ce |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| src/backend/common/DefaultMemoryManager.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-ea343a7e6e52c3aa89f549053f2fbb392f49928956f49b187b978f351d08d6da |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| src/backend/common/DefaultMemoryManager.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-ea343a7e6e52c3aa89f549053f2fbb392f49928956f49b187b978f351d08d6da |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| src/backend/common/DefaultMemoryManager.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-ea343a7e6e52c3aa89f549053f2fbb392f49928956f49b187b978f351d08d6da |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| src/backend/common/DefaultMemoryManager.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-ea343a7e6e52c3aa89f549053f2fbb392f49928956f49b187b978f351d08d6da |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| src/backend/common/DefaultMemoryManager.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-ea343a7e6e52c3aa89f549053f2fbb392f49928956f49b187b978f351d08d6da |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| src/api/c/median.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-4de3c4dd7a070a55f9e9e7697bde6a3a29f1219ecc0cc82adf6146884cd9f190 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| test/median.cpp | https://github.com/arrayfire/arrayfire/pull/2838/files#diff-0369d96b75f7d27e81331636ee28cedc3d996f770ff1e892c3b7fae4f791aeda |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| force-pushed | https://github.com/arrayfire/arrayfire/compare/e0d9cbbf9a481588d6dee374eee07c9fec85dbb2..70ca59ff1f383dd382df5858e3fe386e9e6d9294 |
| e0d9cbb | https://github.com/arrayfire/arrayfire/commit/e0d9cbbf9a481588d6dee374eee07c9fec85dbb2 |
| 70ca59f | https://github.com/arrayfire/arrayfire/commit/70ca59ff1f383dd382df5858e3fe386e9e6d9294 |
|
Compare
| https://github.com/arrayfire/arrayfire/compare/e0d9cbbf9a481588d6dee374eee07c9fec85dbb2..70ca59ff1f383dd382df5858e3fe386e9e6d9294 |
| April 12, 2020 16:31 | https://github.com/arrayfire/arrayfire/pull/2838#event-3225245904 |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| 9prady9 | https://github.com/9prady9 |
| April 12, 2020 16:32 | https://github.com/arrayfire/arrayfire/pull/2838#event-3225246309 |
| https://github.com/9prady9 |
| 9prady9 | https://github.com/9prady9 |
|
Apr 13, 2020
| https://github.com/arrayfire/arrayfire/pull/2838#pullrequestreview-391948474 |
|
View reviewed changes
| https://github.com/arrayfire/arrayfire/pull/2838/files |
| 9prady9 | https://github.com/9prady9 |
| https://github.com/arrayfire/arrayfire/pull/2838#pullrequestreview-391948474 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| umar456 | https://github.com/umar456 |
| April 13, 2020 06:07 | https://github.com/arrayfire/arrayfire/pull/2838#commits-pushed-4efb3e9 |
|
| https://github.com/umar456 |
| Fix lu, rank and qr handling of empty arrays and check for nullptr | https://github.com/arrayfire/arrayfire/pull/2838/commits/4efb3e92e4425046a144965abe715415c30735d2 |
| 4efb3e9 | https://github.com/arrayfire/arrayfire/pull/2838/commits/4efb3e92e4425046a144965abe715415c30735d2 |
|
| https://github.com/umar456 |
| Renamed a few variables in the default alloc and unlock funcitons | https://github.com/arrayfire/arrayfire/pull/2838/commits/848d166ad4ce29138823fe7857a52b1347c4917d |
| 848d166 | https://github.com/arrayfire/arrayfire/pull/2838/commits/848d166ad4ce29138823fe7857a52b1347c4917d |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| force-pushed | https://github.com/arrayfire/arrayfire/compare/70ca59ff1f383dd382df5858e3fe386e9e6d9294..63303cba542b1937bf51344d6b7f54c0e88b6d84 |
| 70ca59f | https://github.com/arrayfire/arrayfire/commit/70ca59ff1f383dd382df5858e3fe386e9e6d9294 |
| 63303cb | https://github.com/arrayfire/arrayfire/commit/63303cba542b1937bf51344d6b7f54c0e88b6d84 |
|
Compare
| https://github.com/arrayfire/arrayfire/compare/70ca59ff1f383dd382df5858e3fe386e9e6d9294..63303cba542b1937bf51344d6b7f54c0e88b6d84 |
| April 13, 2020 10:10 | https://github.com/arrayfire/arrayfire/pull/2838#event-3226602703 |
| umar456 | https://github.com/umar456 |
| April 13, 2020 06:14 | https://github.com/arrayfire/arrayfire/pull/2838#commits-pushed-2e24dcc |
|
| https://github.com/umar456 |
| Minor refactor in median. Add one and two element tests | https://github.com/arrayfire/arrayfire/pull/2838/commits/2e24dcca62bc4234e9ca81fe8a39b3d1b21384b8 |
| 2e24dcc | https://github.com/arrayfire/arrayfire/pull/2838/commits/2e24dcca62bc4234e9ca81fe8a39b3d1b21384b8 |
|
| https://github.com/umar456 |
| Fixed formatting issue in test/memory.cpp | https://github.com/arrayfire/arrayfire/pull/2838/commits/ade6a3f94d8105dfe8c1ffe3604aabec66772b4c |
| ade6a3f | https://github.com/arrayfire/arrayfire/pull/2838/commits/ade6a3f94d8105dfe8c1ffe3604aabec66772b4c |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| force-pushed | https://github.com/arrayfire/arrayfire/compare/63303cba542b1937bf51344d6b7f54c0e88b6d84..ade6a3f94d8105dfe8c1ffe3604aabec66772b4c |
| 63303cb | https://github.com/arrayfire/arrayfire/commit/63303cba542b1937bf51344d6b7f54c0e88b6d84 |
| ade6a3f | https://github.com/arrayfire/arrayfire/commit/ade6a3f94d8105dfe8c1ffe3604aabec66772b4c |
|
Compare
| https://github.com/arrayfire/arrayfire/compare/63303cba542b1937bf51344d6b7f54c0e88b6d84..ade6a3f94d8105dfe8c1ffe3604aabec66772b4c |
| April 13, 2020 10:16 | https://github.com/arrayfire/arrayfire/pull/2838#event-3226615272 |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| 9prady9 | https://github.com/9prady9 |
| April 13, 2020 10:59 | https://github.com/arrayfire/arrayfire/pull/2838#event-3226717259 |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| Apr 13, 2020 | https://github.com/arrayfire/arrayfire/pull/2838#issuecomment-612854135 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
| https://github.com/9prady9 |
| 9prady9 | https://github.com/9prady9 |
|
Apr 13, 2020
| https://github.com/arrayfire/arrayfire/pull/2838#pullrequestreview-392090926 |
|
View reviewed changes
| https://github.com/arrayfire/arrayfire/pull/2838/files/ade6a3f94d8105dfe8c1ffe3604aabec66772b4c |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
| 2e098d4 | https://github.com/arrayfire/arrayfire/commit/2e098d4d6972b4fdc6520d646f1d1aaa4debafe7 |
| Apr 13, 2020 | https://github.com/arrayfire/arrayfire/pull/2838#event-3227056271 |
| https://github.com/9prady9 |
| 9prady9 | https://github.com/9prady9 |
| April 13, 2020 13:29 | https://github.com/arrayfire/arrayfire/pull/2838#event-3227076010 |
| https://github.com/umar456 |
| umar456 | https://github.com/umar456 |
|
Jun 27, 2020
| https://github.com/arrayfire/arrayfire/pull/2838#ref-pullrequest-646601264 |
|
Backport changes to 3.7
#2949
| https://github.com/arrayfire/arrayfire/pull/2949 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Farrayfire%2Farrayfire%2Fpull%2F2838 |
|
| https://github.com/9prady9 |
|
9prady9
| https://github.com/9prady9 |
|
| https://github.com/arrayfire/arrayfire/pull/2838/files/ade6a3f94d8105dfe8c1ffe3604aabec66772b4c |
|
3.7.2
| https://github.com/arrayfire/arrayfire/milestone/29 |
| Please reload this page | https://github.com/arrayfire/arrayfire/pull/2838 |
|
| https://github.com/umar456 |
|
| https://github.com/9prady9 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |