René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Always set error string before returning errors","articleBody":"The way to deal with this would be to have a macro something along the lines of `AF_ERROR`. Instead of throwing an exception, this just sets the error string and returns the error.\n\nHere are the culprits\n\n```\n $ grep -ri throw src/api/cpp/ | grep -v AF_THROW\nsrc/api/cpp/error.hpp:        throw af::exception(__FILE__, __LINE__, __err); \\\nsrc/api/cpp/error.hpp:        throw af::exception(__msg, __FILE__, __LINE__, __err);  \\\nsrc/api/cpp/error.hpp:#define THROW(__err) throw af::exception(__FILE__, __LINE__, __err)\nsrc/api/cpp/exampleFunction.cpp:                            // is going to return and throw corresponding\nsrc/api/cpp/array.cpp:        if (dim \u003e 3) THROW(AF_ERR_SIZE);\nsrc/api/cpp/array.cpp:        // THOU SHALL NOT THROW IN DESTRUCTORS\nsrc/api/cpp/array.cpp:                default: THROW(AF_ERR_SIZE);\n```\n\n```\n $ grep -r \"return AF_\" src/ | grep -v AF_SUCCESS\nsrc/backend/cpu/platform.cpp:    return AF_BACKEND_CPU;\nsrc/backend/cuda/platform.cpp:    return AF_BACKEND_CUDA;\nsrc/backend/opencl/platform.cpp:    return AF_BACKEND_OPENCL;\nsrc/api/unified/symbol_manager.cpp:            return AF_ERR_LOAD_LIB;\nsrc/api/unified/symbol_manager.cpp:        return AF_ERR_LOAD_LIB;\nsrc/api/unified/symbol_manager.hpp:                return AF_ERR_LOAD_LIB;\nsrc/api/unified/symbol_manager.hpp:                return AF_ERR_LOAD_SYM;\nsrc/api/unified/symbol_manager.hpp:        return AF_ERR_ARR_BKND_MISMATCH;                                                    \\\nsrc/api/c/colorspace.cpp:    return AF_ERR_NOT_SUPPORTED;\nsrc/api/c/colorspace.cpp:        default: return AF_ERR_ARG;\nsrc/api/c/colorspace.cpp:        default: return AF_ERR_ARG;\nsrc/api/c/plot.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/plot.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/version.cpp:    return AF_REVISION;\nsrc/api/c/plot3.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/plot3.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/hist.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/image.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/surface.cpp:    return AF_ERR_NO_GFX;\nsrc/api/c/imageio.cpp:    return AF_ERR_NOT_CONFIGURED;\nsrc/api/c/imageio.cpp:    return AF_ERR_NOT_CONFIGURED;\nsrc/api/c/imageio.cpp:    return AF_ERR_NOT_CONFIGURED;\nsrc/api/c/imageio.cpp:    return AF_ERR_NOT_CONFIGURED;\nsrc/api/c/imageio.cpp:    return AF_ERR_NOT_CONFIGURED;\nsrc/api/c/imageio2.cpp:    return AF_ERR_NOT_CONFIGURED;\nsrc/api/c/imageio2.cpp:    return AF_ERR_NOT_CONFIGURED;\n```\n","author":{"url":"https://github.com/pavanky","@type":"Person","name":"pavanky"},"datePublished":"2015-12-28T21:16:46.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1186/arrayfire/issues/1186"}