René's URL Explorer Experiment

Title: feat: allow to add a command dynamically by KazuCocoa · Pull Request #608 · appium/python-client · GitHub

Open Graph Title: feat: allow to add a command dynamically by KazuCocoa · Pull Request #608 · appium/python-client

X Title: feat: allow to add a command dynamically by KazuCocoa · Pull Request #608 · appium/python-client

Description: Appium 2.0 will allow custom drivers/plugins add their own endpoint. Then, we want to allow clients to add custom commands for them. In Ruby, I've added like https://github.com/appium/ruby_lib_core/blob/b9f015d7dea14964a0733f2385ebcff68da1e18e/test/unit/android/webdriver/w3c/commands_test.rb#L31-L98 as an experimental method. (The method was already used internally, so as Ruby client, it was just exposed the method as a public method.) In Python, I've added two methods. add_command and execute_custom_command. add_command adds the pair of HTTP method and a path in self.command_executor._commands. execute_custom_command calls a method from self.command_executor._commands as self.execute. We want to hide self.execute and self.command_executor since they are for internal usage so far. They may change by updating selenium library, for instance. # add commands driver.add_command(method='POST', url='session/$sessionId/path/to/custom/url', name='test_command') def do_command(): # some logic for arguments return_value = driver.execute_custom_command('test_command', arguments) # dom some process for the return value return result driver.custom_my_command = do_command ... result = driver.custom_my_command() # just call it ... I considered decoration way, but so far, this exposing two methods as public methods are simpler I think. What do you think? Your thought is welcome such as better naming etc.

Open Graph Description: Appium 2.0 will allow custom drivers/plugins add their own endpoint. Then, we want to allow clients to add custom commands for them. In Ruby, I've added like https://github.com/appium/ruby_lib_...

X Description: Appium 2.0 will allow custom drivers/plugins add their own endpoint. Then, we want to allow clients to add custom commands for them. In Ruby, I've added like https://github.com/appium/ruby_...

Opengraph URL: https://github.com/appium/python-client/pull/608

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width