Title: Suspicious functionality change in driver.swipe() and driver.scroll() duration argument · Issue #743 · appium/python-client · GitHub
Open Graph Title: Suspicious functionality change in driver.swipe() and driver.scroll() duration argument · Issue #743 · appium/python-client
X Title: Suspicious functionality change in driver.swipe() and driver.scroll() duration argument · Issue #743 · appium/python-client
Description: The problem Before the ActionChains were used (Appium 1.20.x, Python Client 1.x.x) as they are now written in action_helpers.py we had used the following method to swipe the screen open from screen lock state: driver.swipe(x1, y1, x2, y2...
Open Graph Description: The problem Before the ActionChains were used (Appium 1.20.x, Python Client 1.x.x) as they are now written in action_helpers.py we had used the following method to swipe the screen open from screen...
X Description: The problem Before the ActionChains were used (Appium 1.20.x, Python Client 1.x.x) as they are now written in action_helpers.py we had used the following method to swipe the screen open from screen...
Opengraph URL: https://github.com/appium/python-client/issues/743
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Suspicious functionality change in driver.swipe() and driver.scroll() duration argument","articleBody":"## The problem\r\n\r\nBefore the ActionChains were used (Appium 1.20.x, Python Client 1.x.x) as they are now written in action_helpers.py we had used the following method to swipe the screen open from screen lock state:\r\n\r\n`driver.swipe(x1, y1, x2, y2, duration=3000)`\r\n\r\nThis gave a slow swipe that took 3 seconds to move from x1,y1 to x2,y2.\r\n\r\nWhen updating to Appium 2.0 and the latest Appium Python Client, the swipe did not work properly anymore.\r\n\r\nIf I understand the code properly in action_helpers.py, the functionality now uses the duration argument as pause between the move from x1,y1 to x2,y2:\r\n\r\n`actions.w3c_actions.pointer_action.pause(duration / 1000)`\r\n\r\nBut the actual swipe action is very fast, in my case with a three second pause before the actual fast swipe action!\r\n\r\nTo get the swipe to work as before, I made a copy of the swipe method from action_helpers.py and changed like this:\r\n\r\n def swipe(self: T, start_x: int, start_y: int, end_x: int, end_y: int, duration: int = 0) -\u003e T:\r\n actions = ActionChains(self)\r\n actions.w3c_actions = ActionBuilder(self, mouse=PointerInput(interaction.POINTER_TOUCH, \"touch\"), duration=duration)\r\n actions.w3c_actions.pointer_action.move_to_location(start_x, start_y)\r\n actions.w3c_actions.pointer_action.pointer_down()\r\n actions.w3c_actions.pointer_action.move_to_location(end_x, end_y)\r\n actions.w3c_actions.pointer_action.release()\r\n actions.perform()\r\n\r\n**Notice that I have moved the duration parameter to the ActionBuilder constructor and removed the pause completely.**\r\n\r\n\r\nSo I am proposing to implement the swipe() and scroll() like this and if someone requires an actual pause between the move, then I suggest adding an additional pause argument to the method signature.\r\n\r\nAlso I would like to see long_press(element: WebElement, timeout: int) to be added to action_helpers.py, where the pause would actually use the timeout value.\r\n\r\nThanks! \r\n\r\n## Environment\r\nAppium version: 2.0.0Beta40\r\nAppium Python Client version 2.6.0\r\nOS version: Linux Ubuntu 20.04\r\nMobile platform: Android (real device)\r\n","author":{"url":"https://github.com/jatalahd","@type":"Person","name":"jatalahd"},"datePublished":"2022-06-30T15:52:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/743/python-client/issues/743"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:db26e851-dec0-6493-9420-ca92ac530406 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 860A:225DC1:148729F:1A8C2F0:6A5C4E0D |
| html-safe-nonce | 1737c20105eae1dba9dd10aaa8a51bd8e363eb94d8ec87baf37f503bd0a47c56 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjBBOjIyNURDMToxNDg3MjlGOjFBOEMyRjA6NkE1QzRFMEQiLCJ2aXNpdG9yX2lkIjoiOTE2MjM2ODE1MTcwMjkzMjYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7243057a66edabcf4965519c4753eb716066ca6ecef6877fb167a45e8a10e34b |
| hovercard-subject-tag | issue:1290337160 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/appium/python-client/743/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7091b469099688ef868eb74f67af1221e880f2980a9c8654c8a98f4dce2247b6/appium/python-client/issues/743 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7091b469099688ef868eb74f67af1221e880f2980a9c8654c8a98f4dce2247b6/appium/python-client/issues/743 |
| og:image:alt | The problem Before the ActionChains were used (Appium 1.20.x, Python Client 1.x.x) as they are now written in action_helpers.py we had used the following method to swipe the screen open from screen... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jatalahd |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-preview |
| go-import | github.com/appium/python-client git https://github.com/appium/python-client.git |
| octolytics-dimension-user_id | 3221291 |
| octolytics-dimension-user_login | appium |
| octolytics-dimension-repository_id | 18525395 |
| octolytics-dimension-repository_nwo | appium/python-client |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 18525395 |
| octolytics-dimension-repository_network_root_nwo | appium/python-client |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width