René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ListensToLogcatMessages.class function startLogcatBroadcast improvement","articleBody":"## The problem\r\n\r\nI tried using the '[addLogcatMessagesListener](https://appium.github.io/java-client/io/appium/java_client/android/ListensToLogcatMessages.html)' for the appium Android Driver but it failed with an exception that it can not connect. Only after I looked into the issue more deeply I noticed, that the default port is hardcoded into the startLogcatBroadcast function. I think this is really confusing and unnecessary.\r\n```\r\n    default void startLogcatBroadcast() {\r\n        this.startLogcatBroadcast(\"localhost\", 4723);\r\n    }\r\n\r\n    default void startLogcatBroadcast(String host) {\r\n        this.startLogcatBroadcast(host, 4723);\r\n    }\r\n```\r\nHowever, it is possible to use this to not use the default host and port:\r\n```\r\n    default void startLogcatBroadcast(String host, int port) {\r\n        this.execute(\"executeScript\", ImmutableMap.of(\"script\", \"mobile: startLogsBroadcast\", \"args\", Collections.emptyList()));\r\n\r\n        URI endpointUri;\r\n        try {\r\n            endpointUri = new URI(String.format(\"ws://%s:%s/ws/session/%s/appium/device/logcat\", host, port, ((RemoteWebDriver)this).getSessionId()));\r\n        } catch (URISyntaxException var5) {\r\n            throw new IllegalArgumentException(var5);\r\n        }\r\n\r\n        this.getLogcatClient().connect(endpointUri);\r\n    }\r\n```\r\n\r\nWhat I do not get is why ListensToLogcatMessages.class doesn't simply use the host and port by the driver calling this class/function? Is there even a point in doing logcatListening to another appium service besides the one used by the driver?\r\nIs there a reason why this should not be automated? \r\nImho what it should do is this:\r\n```\r\n    default void startLogcatBroadcast() {\r\n        URL remoteAdress = this.getRemoteAddress();\r\n        this.startLogcatBroadcast(remoteAdress.getHost(), remoteAdress.getPort());\r\n    }\r\n```\r\n\r\n\r\n## Environment\r\n\r\n* Appium version (or git revision) that exhibits the issue: 1.17.1\r\n* Desktop OS/version used to run Appium: Manjaro\r\n* Mobile platform/version under test: Android\r\n* Real device or emulator/simulator: emulator\r\n* Appium CLI or Appium.app|exe: CLI\r\n\r\n## Details\r\n\r\n\r\n## Code To Reproduce Issue [ Good To Have ]\r\nFor testing the addLogcatMessagesListener I took this code:\r\nhttps://github.com/appium/java-client/blob/master/src/test/java/io/appium/java_client/android/AndroidLogcatListenerTest.java\r\n\r\nFor creating the appium service I used this code (which will always uses any free port it finds):\r\n```\r\n    public static URL createAppiumService() {\r\n        AppiumServiceBuilder builder = new AppiumServiceBuilder();\r\n        builder.usingAnyFreePort();\r\n        builder.withArgument(GeneralServerFlag.LOG_LEVEL, LogLevel);\r\n        builder.withArgument(GeneralServerFlag.LOG_TIMESTAMP);\r\n        builder.withArgument(GeneralServerFlag.RELAXED_SECURITY);\r\n        appium = AppiumDriverLocalService.buildService(builder);\r\n        appium.start();\r\n        Assert.assertTrue(appium.isRunning(), \"Der Appium Server läuft nicht!\");\r\n        return appium.getUrl();\r\n    }\r\n```\r\n\r\nThe driver can then be initialized like so:\r\n\r\n`AndroidDriver\u003cAndroidElement\u003e driver = new AndroidDriver\u003cAndroidElement\u003e(createAppiumService(), _YourDesiredCapsHere_);`\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","author":{"url":"https://github.com/hwulfmeyer","@type":"Person","name":"hwulfmeyer"},"datePublished":"2020-05-26T12:16:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/1352/java-client/issues/1352"}