René's URL Explorer Experiment


Title: fix(http-clients): reject a non-positive timeout instead of silently ignoring it by vdusek · Pull Request #2187 · apify/crawlee-python · GitHub

Open Graph Title: fix(http-clients): reject a non-positive timeout instead of silently ignoring it by vdusek · Pull Request #2187 · apify/crawlee-python

X Title: fix(http-clients): reject a non-positive timeout instead of silently ignoring it by vdusek · Pull Request #2187 · apify/crawlee-python

Description: Crawlee—A web scraping and browser automation library for Python to build reliable crawlers. Extract structured data with LLMs via Pydantic AI, or control the browser in natural language with Stagehand. Works with BeautifulSoup, Parsel, Playwright, and raw HTTP. Download HTML, PDF, images, and other files. Proxy rotation included. - fix(http-clients): reject a non-positive timeout instead of silently ignoring it by vdusek · Pull Request #2187 · apify/crawlee-python

Open Graph Description: Follow-up to #2174: a timedelta(0) timeout is falsy, so if timeout else None-style checks silently dropped it and treated it as "no timeout" instead of "expire immediately". Im...

X Description: Follow-up to #2174: a timedelta(0) timeout is falsy, so if timeout else None-style checks silently dropped it and treated it as "no timeout" instead of "expire immediatel...

Opengraph URL: https://github.com/apify/crawlee-python/pull/2187

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:87e3b7bf-9540-17b9-86bd-c52af220c2e8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC080:96DDF:B4B97B:E5D0B6:6B00F621
html-safe-nonce80ef2c5dcd34415b6ce3e65efa176dab38d02ffedea6d73f23cf5ea9a0508e5d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDgwOjk2RERGOkI0Qjk3QjpFNUQwQjY6NkIwMEY2MjEiLCJ2aXNpdG9yX2lkIjoiNDIyODIyMzUyNzQ5MDIyMTYwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac63e326c19372f904d4bd885597e74f107692590e105d33f22f9abc3adf503620
hovercard-subject-tagpull_request:4347017887
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apify/crawlee-python/2187/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5986a0ffc4c013b5a150d8096231de382a48070adb0366481875647fdbc14bf0/apify/crawlee-python/pull/2187
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5986a0ffc4c013b5a150d8096231de382a48070adb0366481875647fdbc14bf0/apify/crawlee-python/pull/2187
og:image:altFollow-up to #2174: a timedelta(0) timeout is falsy, so if timeout else None-style checks silently dropped it and treated it as "no timeout" instead of "expire immediately". Im...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevdusek
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/apify/crawlee-python git https://github.com/apify/crawlee-python.git
octolytics-dimension-user_id24586296
octolytics-dimension-user_loginapify
octolytics-dimension-repository_id741365632
octolytics-dimension-repository_nwoapify/crawlee-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id741365632
octolytics-dimension-repository_network_root_nwoapify/crawlee-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/apify/crawlee-python/pull/2187#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapify%2Fcrawlee-python%2Fpull%2F2187
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapify%2Fcrawlee-python%2Fpull%2F2187
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apify%2Fcrawlee-python
Reloadhttps://github.com/apify/crawlee-python/pull/2187
Reloadhttps://github.com/apify/crawlee-python/pull/2187
Reloadhttps://github.com/apify/crawlee-python/pull/2187
apifyhttps://github.com/apify
crawlee-pythonhttps://github.com/apify/crawlee-python
Codehttps://github.com/apify/crawlee-python
Issues72 (72)https://github.com/apify/crawlee-python/issues
Pull requests14 (14)https://github.com/apify/crawlee-python/pulls
Discussionshttps://github.com/apify/crawlee-python/discussions
Actionshttps://github.com/apify/crawlee-python/actions
Security and quality1 (1)https://github.com/apify/crawlee-python/security
Insightshttps://github.com/apify/crawlee-python/insights
https://github.com/apify/crawlee-python
vdusekhttps://github.com/vdusek
masterhttps://github.com/apify/crawlee-python/tree/master
fix/timeout-falsy-checkhttps://github.com/apify/crawlee-python/tree/fix/timeout-falsy-check
Conversationhttps://github.com/apify/crawlee-python/pull/2187
Commits3 (3)https://github.com/apify/crawlee-python/pull/2187/commits
Checkshttps://github.com/apify/crawlee-python/pull/2187/checks
Files changedhttps://github.com/apify/crawlee-python/pull/2187/files
fix(http-clients): reject a non-positive timeout instead of silently ignoring ithttps://github.com/apify/crawlee-python/pull/2187#top
vdusekhttps://github.com/vdusek
masterhttps://github.com/apify/crawlee-python/tree/master
fix/timeout-falsy-checkhttps://github.com/apify/crawlee-python/tree/fix/timeout-falsy-check
https://github.com/vdusek
vdusekhttps://github.com/vdusek
Aug 24, 2026https://github.com/apify/crawlee-python/pull/2187#issue-5233062100
Please reload this pagehttps://github.com/apify/crawlee-python/pull/2187
#2174https://github.com/apify/crawlee-python/pull/2174
feat: support timeouts in the send_request context helper #2174https://github.com/apify/crawlee-python/pull/2174
Please reload this pagehttps://github.com/apify/crawlee-python/pull/2187
https://github.com/vdusek
fix(http-clients): reject a non-positive timeout instead of silently …https://github.com/apify/crawlee-python/pull/2187/commits/b4fd57a8f4d6065e003b6fc4272c113ce677e285
b4fd57ahttps://github.com/apify/crawlee-python/pull/2187/commits/b4fd57a8f4d6065e003b6fc4272c113ce677e285
https://github.com/vdusek
vdusekhttps://github.com/vdusek
t-tooling https://github.com/apify/crawlee-python/issues?q=state%3Aopen%20label%3At-tooling
adhoc https://github.com/apify/crawlee-python/issues?q=state%3Aopen%20label%3Aadhoc
Aug 24, 2026https://github.com/apify/crawlee-python/pull/2187#event-29902874229
https://github.com/vdusek
vdusekhttps://github.com/vdusek
Aug 24, 2026https://github.com/apify/crawlee-python/pull/2187#event-29902875693
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
148th sprint - Tooling teamhttps://github.com/apify/crawlee-python/milestone/516
Aug 24, 2026https://github.com/apify/crawlee-python/pull/2187#event-29902884368
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
tested https://github.com/apify/crawlee-python/issues?q=state%3Aopen%20label%3Atested
Aug 24, 2026https://github.com/apify/crawlee-python/pull/2187#event-29902885351
https://github.com/apps/codecov
codecovhttps://github.com/apps/codecov
Aug 24, 2026https://github.com/apify/crawlee-python/pull/2187#issuecomment-5393164294
Please reload this pagehttps://github.com/apify/crawlee-python/pull/2187
Codecovhttps://app.codecov.io/gh/apify/crawlee-python/pull/2187?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify
9a084f5https://app.codecov.io/gh/apify/crawlee-python/commit/9a084f56927100f1e714cde2a3b331fda62ecaa0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify
206f167https://app.codecov.io/gh/apify/crawlee-python/commit/206f167a1281140e41615c33f049beeb52b73288?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify
Flaghttps://app.codecov.io/gh/apify/crawlee-python/pull/2187/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify
unithttps://app.codecov.io/gh/apify/crawlee-python/pull/2187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify#carryforward-flags-in-the-pull-request-comment
☔ View full report in Codecov by Harnesshttps://app.codecov.io/gh/apify/crawlee-python/pull/2187?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify
Share it herehttps://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apify
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/apify/crawlee-python/pull/2187
https://github.com/vdusek
refactor(http-clients): dedupe curl timeout guard and extend test cov…https://github.com/apify/crawlee-python/pull/2187/commits/1e9a298bf0b3a5f97a06258c9017321765b93029
1e9a298https://github.com/apify/crawlee-python/pull/2187/commits/1e9a298bf0b3a5f97a06258c9017321765b93029
https://github.com/vdusek
vdusekhttps://github.com/vdusek
August 24, 2026 10:17https://github.com/apify/crawlee-python/pull/2187#event-29905963283
https://github.com/vdusek
vdusekhttps://github.com/vdusek
Mantisushttps://github.com/Mantisus
Pijukatelhttps://github.com/Pijukatel
August 24, 2026 10:17https://github.com/apify/crawlee-python/pull/2187#event-29905967219
https://github.com/Pijukatel
Pijukatelhttps://github.com/Pijukatel
Aug 24, 2026 https://github.com/apify/crawlee-python/pull/2187#pullrequestreview-5007187568
View reviewed changes https://github.com/apify/crawlee-python/pull/2187/files/1e9a298bf0b3a5f97a06258c9017321765b93029
https://github.com/vdusek
fix(playwright): reject a non-positive timeout instead of disabling ithttps://github.com/apify/crawlee-python/pull/2187/commits/206f167a1281140e41615c33f049beeb52b73288
206f167https://github.com/apify/crawlee-python/pull/2187/commits/206f167a1281140e41615c33f049beeb52b73288
https://github.com/vdusek
vdusekhttps://github.com/vdusek
Mantisushttps://github.com/Mantisus
August 24, 2026 11:23https://github.com/apify/crawlee-python/pull/2187#event-29908972513
https://github.com/vdusek
vdusekhttps://github.com/vdusek
b4c59c6https://github.com/apify/crawlee-python/commit/b4c59c65239cb067f9607701b6ff3c12b043161d
Aug 24, 2026https://github.com/apify/crawlee-python/pull/2187#event-29909004533
Please reload this pagehttps://github.com/apify/crawlee-python/pull/2187
https://github.com/vdusek
vdusekhttps://github.com/vdusek
August 24, 2026 11:23https://github.com/apify/crawlee-python/pull/2187#event-29909006535
vdusekhttps://github.com/vdusek
Aug 24, 2026 https://github.com/apify/crawlee-python/pull/2187#ref-commit-c468a86
https://github.com/vdusek
Merge remote-tracking branch 'origin/master' into use-httpx2https://github.com/Mantisus/crawlee-python/commit/c468a86ae357d3d3ed4469c63923fdeec771af82
c468a86https://github.com/Mantisus/crawlee-python/commit/c468a86ae357d3d3ed4469c63923fdeec771af82
apify#2187https://github.com/apify/crawlee-python/pull/2187
apify#2184https://github.com/apify/crawlee-python/pull/2184
https://github.co/hiddenchars
https://github.com/apify/crawlee-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapify%2Fcrawlee-python%2Fpull%2F2187
https://github.com/Pijukatel
Pijukatel https://github.com/Pijukatel
https://github.com/apify/crawlee-python/pull/2187/files/1e9a298bf0b3a5f97a06258c9017321765b93029
Please reload this pagehttps://github.com/apify/crawlee-python/pull/2187
https://github.com/vdusek
vdusek https://github.com/vdusek
adhoc https://github.com/apify/crawlee-python/issues?q=state%3Aopen%20label%3Aadhoc
t-tooling https://github.com/apify/crawlee-python/issues?q=state%3Aopen%20label%3At-tooling
tested https://github.com/apify/crawlee-python/issues?q=state%3Aopen%20label%3Atested
148th sprint - Tooling team https://github.com/apify/crawlee-python/milestone/516
Please reload this pagehttps://github.com/apify/crawlee-python/pull/2187
https://github.com/vdusek
https://github.com/Pijukatel
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.