René's URL Explorer Experiment


Title: Fix CommitTableRequest serialisation by kdbhiggins · Pull Request #525 · apache/iceberg-python · GitHub

Open Graph Title: Fix CommitTableRequest serialisation by kdbhiggins · Pull Request #525 · apache/iceberg-python

X Title: Fix CommitTableRequest serialisation by kdbhiggins · Pull Request #525 · apache/iceberg-python

Description: I discovered an error when trying to deserialize the CommitTableRequest object. request = CommitTableRequest( requirements=(AssertTableUUID(uuid='4bfd18a3-74c6-478e-98b1-71c4c32f4163'),), identifier=TableIdentifier(namespace=['a'], name='b'), ) deserialized_request = CommitTableRequest.model_validate_json(request.model_dump_json()) raises TypeError: Can't instantiate abstract class TableRequirement with abstract method validate I added a test to round-trip serialize/deserialize the CommitTableRequest. After investigating I was able to fix it by using Discriminated Unions, which seem like a natural fit for the TableUpdate and TableRequirement.

Open Graph Description: I discovered an error when trying to deserialize the CommitTableRequest object. request = CommitTableRequest( requirements=(AssertTableUUID(uuid='4bfd18a3-74c6-478e-98b1-71c4c32f4163...

X Description: I discovered an error when trying to deserialize the CommitTableRequest object. request = CommitTableRequest( requirements=(AssertTableUUID(uuid='4bfd18a3-74c6-478e-98b1-71c4c32f416...

Opengraph URL: https://github.com/apache/iceberg-python/pull/525

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:b8769637-3e34-35e8-d061-a9a5b75e8c0b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED34:23810A:3C5170E:4EC7148:6992DB82
html-safe-nonce30a6c7a182b20c81e16b3b293e6714f11b9793b1c84bba994bdc692c9a057b74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDM0OjIzODEwQTozQzUxNzBFOjRFQzcxNDg6Njk5MkRCODIiLCJ2aXNpdG9yX2lkIjoiNTQ4NjQ0MTc3MzE1MTczODc1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca1f1bbf04736599c85607872b2fa5338f75963652e9f0d2f0c37348fc7ee3477
hovercard-subject-tagpull_request:1774646383
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
twitter:imagehttps://avatars.githubusercontent.com/u/2725945?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2725945?s=400&v=4
og:image:altI discovered an error when trying to deserialize the CommitTableRequest object. request = CommitTableRequest( requirements=(AssertTableUUID(uuid='4bfd18a3-74c6-478e-98b1-71c4c32f4163...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/apache/iceberg-python git https://github.com/apache/iceberg-python.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id677260606
octolytics-dimension-repository_nwoapache/iceberg-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id677260606
octolytics-dimension-repository_network_root_nwoapache/iceberg-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84dcb133269e3cfe6e0296cc85fbacb92cae92bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Ficeberg-python%2Fpull%2F525%2Fcommits%2Fca982ccbd9820dd41cc077b08779fe48047a0fac
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Ficeberg-python%2Fpull%2F525%2Fcommits%2Fca982ccbd9820dd41cc077b08779fe48047a0fac
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=apache%2Ficeberg-python
Reloadhttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
Reloadhttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
Reloadhttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
apache https://github.com/apache
iceberg-pythonhttps://github.com/apache/iceberg-python
Notifications https://github.com/login?return_to=%2Fapache%2Ficeberg-python
Fork 441 https://github.com/login?return_to=%2Fapache%2Ficeberg-python
Star 1k https://github.com/login?return_to=%2Fapache%2Ficeberg-python
Code https://github.com/apache/iceberg-python
Issues 115 https://github.com/apache/iceberg-python/issues
Pull requests 119 https://github.com/apache/iceberg-python/pulls
Actions https://github.com/apache/iceberg-python/actions
Projects 0 https://github.com/apache/iceberg-python/projects
Security 0 https://github.com/apache/iceberg-python/security
Insights https://github.com/apache/iceberg-python/pulse
Code https://github.com/apache/iceberg-python
Issues https://github.com/apache/iceberg-python/issues
Pull requests https://github.com/apache/iceberg-python/pulls
Actions https://github.com/apache/iceberg-python/actions
Projects https://github.com/apache/iceberg-python/projects
Security https://github.com/apache/iceberg-python/security
Insights https://github.com/apache/iceberg-python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fapache%2Ficeberg-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fapache%2Ficeberg-python%2Fissues%2Fnew%2Fchoose
Fokkohttps://github.com/Fokko
apache:mainhttps://github.com/apache/iceberg-python/tree/main
kdbhiggins:commit-table-request-fixhttps://github.com/kdbhiggins/iceberg-python/tree/commit-table-request-fix
Conversation 1 https://github.com/apache/iceberg-python/pull/525
Commits 8 https://github.com/apache/iceberg-python/pull/525/commits
Checks 0 https://github.com/apache/iceberg-python/pull/525/checks
Files changed https://github.com/apache/iceberg-python/pull/525/files
Please reload this pagehttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
Fix CommitTableRequest serialisation https://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac#top
Show all changes 8 commits https://github.com/apache/iceberg-python/pull/525/files
ca982cc add failing test Feb 15, 2024 https://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
6b59d22 make requirements a discriminated union Feb 15, 2024 https://github.com/apache/iceberg-python/pull/525/commits/6b59d22ac2a00b6df738ed4d809a2286b08fdd10
d1d59fe use discriminated type union Mar 14, 2024 https://github.com/apache/iceberg-python/pull/525/commits/d1d59fe0b9b8359782bd42e4edb845e4205ba8b9
bb7ddad add return type Mar 14, 2024 https://github.com/apache/iceberg-python/pull/525/commits/bb7ddad97a43569e4ea793ad4316e222252344d8
9cf8bd7 use type annotation Mar 14, 2024 https://github.com/apache/iceberg-python/pull/525/commits/9cf8bd74e8595e0aaed44fb8fc489b256141fbf0
c2492a4 have requirements inherit from ValidatableTableRequirement Mar 14, 2024 https://github.com/apache/iceberg-python/pull/525/commits/c2492a4d1d2278eab7f569a2910cfa87d8780c69
359c780 AddSortOrder filter by type Mar 15, 2024 https://github.com/apache/iceberg-python/pull/525/commits/359c78060af5eab363616b5e61081860ff545712
f8f43ed lint Mar 15, 2024 https://github.com/apache/iceberg-python/pull/525/commits/f8f43ed661f7ab9815217ccb71f9659d96383d2e
Clear filters https://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
Please reload this pagehttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
Please reload this pagehttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
Next https://github.com/apache/iceberg-python/pull/525/commits/6b59d22ac2a00b6df738ed4d809a2286b08fdd10
Please reload this pagehttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac
tests/table/test_init.pyhttps://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac#diff-f3df6bef7f6c6d2b05df9a09e0039ff4391ebb66725d41bb0f27f26bb2eb4047
View file https://github.com/kdbhiggins/iceberg-python/blob/ca982ccbd9820dd41cc077b08779fe48047a0fac/tests/table/test_init.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/iceberg-python/pull/525/commits/{{ revealButtonHref }}
https://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac#diff-f3df6bef7f6c6d2b05df9a09e0039ff4391ebb66725d41bb0f27f26bb2eb4047
https://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac#diff-f3df6bef7f6c6d2b05df9a09e0039ff4391ebb66725d41bb0f27f26bb2eb4047
https://github.com/apache/iceberg-python/pull/525/commits/ca982ccbd9820dd41cc077b08779fe48047a0fac#diff-f3df6bef7f6c6d2b05df9a09e0039ff4391ebb66725d41bb0f27f26bb2eb4047
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.