René's URL Explorer Experiment


Title: Fix `add_files` with non-identity transforms by Fokko · Pull Request #1925 · apache/iceberg-python · GitHub

Open Graph Title: Fix `add_files` with non-identity transforms by Fokko · Pull Request #1925 · apache/iceberg-python

X Title: Fix `add_files` with non-identity transforms by Fokko · Pull Request #1925 · apache/iceberg-python

Description: PyIceberg. Contribute to apache/iceberg-python development by creating an account on GitHub.

Open Graph Description: Rationale for this change Found out I broke this myself after doing a git bisect: 36d383dcb676ae5ef59c34cc2910d16a8e30a80c is the first bad commit commit 36d383dcb676ae5ef59c34cc2910d16a8e30a80c Au...

X Description: Rationale for this change Found out I broke this myself after doing a git bisect: 36d383dcb676ae5ef59c34cc2910d16a8e30a80c is the first bad commit commit 36d383dcb676ae5ef59c34cc2910d16a8e30a80c Au...

Opengraph URL: https://github.com/apache/iceberg-python/pull/1925

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:60aed996-ae2b-9ad3-af25-66bbe610f406
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id815E:15D7ED:951654:C25D2B:6991F252
html-safe-nonced76a165c17e55f9d22cbf9f3f70213504eac4fcd93b8627029ce221927a16b51
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTVFOjE1RDdFRDo5NTE2NTQ6QzI1RDJCOjY5OTFGMjUyIiwidmlzaXRvcl9pZCI6IjI2NDkxNDY0MDg0NDg0MjI0ODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacee3f6d4f1055956609b65603a5b11534840ec7c960b13112911006b917872f0f
hovercard-subject-tagpull_request:2464096358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/iceberg-python/1925/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cf636bc8e94a2cba476f2d49b7b11739dd1c987f0e580e28c6fb409276958d45/apache/iceberg-python/pull/1925
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cf636bc8e94a2cba476f2d49b7b11739dd1c987f0e580e28c6fb409276958d45/apache/iceberg-python/pull/1925
og:image:altRationale for this change Found out I broke this myself after doing a git bisect: 36d383dcb676ae5ef59c34cc2910d16a8e30a80c is the first bad commit commit 36d383dcb676ae5ef59c34cc2910d16a8e30a80c Au...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFokko
hostnamegithub.com
expected-hostnamegithub.com
None42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b
turbo-cache-controlno-cache
go-importgithub.com/apache/iceberg-python git https://github.com/apache/iceberg-python.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id677260606
octolytics-dimension-repository_nwoapache/iceberg-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id677260606
octolytics-dimension-repository_network_root_nwoapache/iceberg-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release848bc6032dcc93a9a7301dcc3f379a72ba13b96e
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/apache/iceberg-python/pull/1925#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Ficeberg-python%2Fpull%2F1925
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Ficeberg-python%2Fpull%2F1925
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Ficeberg-python
Reloadhttps://github.com/apache/iceberg-python/pull/1925
Reloadhttps://github.com/apache/iceberg-python/pull/1925
Reloadhttps://github.com/apache/iceberg-python/pull/1925
apache https://github.com/apache
iceberg-pythonhttps://github.com/apache/iceberg-python
Notifications https://github.com/login?return_to=%2Fapache%2Ficeberg-python
Fork 440 https://github.com/login?return_to=%2Fapache%2Ficeberg-python
Star 1k https://github.com/login?return_to=%2Fapache%2Ficeberg-python
Code https://github.com/apache/iceberg-python
Issues 116 https://github.com/apache/iceberg-python/issues
Pull requests 137 https://github.com/apache/iceberg-python/pulls
Actions https://github.com/apache/iceberg-python/actions
Projects 0 https://github.com/apache/iceberg-python/projects
Security 0 https://github.com/apache/iceberg-python/security
Insights https://github.com/apache/iceberg-python/pulse
Code https://github.com/apache/iceberg-python
Issues https://github.com/apache/iceberg-python/issues
Pull requests https://github.com/apache/iceberg-python/pulls
Actions https://github.com/apache/iceberg-python/actions
Projects https://github.com/apache/iceberg-python/projects
Security https://github.com/apache/iceberg-python/security
Insights https://github.com/apache/iceberg-python/pulse
Fokkohttps://github.com/Fokko
apache:mainhttps://github.com/apache/iceberg-python/tree/main
Fokko:fd-fix-add-non-identity-fileshttps://github.com/Fokko/iceberg-python/tree/fd-fix-add-non-identity-files
Conversationhttps://github.com/apache/iceberg-python/pull/1925
Commits1 (1)https://github.com/apache/iceberg-python/pull/1925/commits
Checkshttps://github.com/apache/iceberg-python/pull/1925/checks
Files changedhttps://github.com/apache/iceberg-python/pull/1925/files
Fix add_files with non-identity transformshttps://github.com/apache/iceberg-python/pull/1925#top
Fokkohttps://github.com/Fokko
apache:mainhttps://github.com/apache/iceberg-python/tree/main
Fokko:fd-fix-add-non-identity-fileshttps://github.com/Fokko/iceberg-python/tree/fd-fix-add-non-identity-files
https://github.com/Fokko
Fokkohttps://github.com/Fokko
Apr 16, 2025https://github.com/apache/iceberg-python/pull/1925#issue-3000231434
Please reload this pagehttps://github.com/apache/iceberg-python/pull/1925
#1917https://github.com/apache/iceberg-python/issues/1917
Please reload this pagehttps://github.com/apache/iceberg-python/pull/1925
https://github.com/Fokko
Fix add_files with non-identity transformshttps://github.com/apache/iceberg-python/pull/1925/commits/e5a766509b5f4f7a83d88d80aa6692a040374011
e5a7665https://github.com/apache/iceberg-python/pull/1925/commits/e5a766509b5f4f7a83d88d80aa6692a040374011
apache#1917https://github.com/apache/iceberg-python/issues/1917
https://github.com/Fokko
Fokkohttps://github.com/Fokko
PyIceberg 0.9.1https://github.com/apache/iceberg-python/milestone/11
Apr 16, 2025https://github.com/apache/iceberg-python/pull/1925#event-17292833368
https://github.com/kevinjqliu
kevinjqliuhttps://github.com/kevinjqliu
Apr 16, 2025 https://github.com/apache/iceberg-python/pull/1925#pullrequestreview-2773358287
View reviewed changes https://github.com/apache/iceberg-python/pull/1925/files/e5a766509b5f4f7a83d88d80aa6692a040374011
kevinjqliuhttps://github.com/kevinjqliu
https://github.com/apache/iceberg-python/pull/1925#pullrequestreview-2773358287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/apache/iceberg-python/pull/1925
pyiceberg/io/pyarrow.pyhttps://github.com/apache/iceberg-python/pull/1925/files/e5a766509b5f4f7a83d88d80aa6692a040374011#diff-8d5e63f2a87ead8cebe2fd8ac5dcf2198d229f01e16bb9e06e21f7277c328abd
kevinjqliuhttps://github.com/kevinjqliu
Apr 16, 2025https://github.com/apache/iceberg-python/pull/1925#discussion_r2047430938
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/apache/iceberg-python/pull/1555/files#diff-8d5e63f2a87ead8cebe2fd8ac5dcf2198d229f01e16bb9e06e21f7277c328abdR2179-R2182
Please reload this pagehttps://github.com/apache/iceberg-python/pull/1925
Fokkohttps://github.com/Fokko
Apr 16, 2025https://github.com/apache/iceberg-python/pull/1925#discussion_r2047501380
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/apache/iceberg-python/pull/1925
https://github.com/Fokko
Fokkohttps://github.com/Fokko
5f10bbchttps://github.com/apache/iceberg-python/commit/5f10bbc89c4f2fb3055f1e618e256c379c08ce54
Apr 16, 2025https://github.com/apache/iceberg-python/pull/1925#event-17294030486
Please reload this pagehttps://github.com/apache/iceberg-python/pull/1925
https://github.com/Fokko
Fokkohttps://github.com/Fokko
April 16, 2025 18:35https://github.com/apache/iceberg-python/pull/1925#event-17294031570
Fokkohttps://github.com/Fokko
Apr 17, 2025 https://github.com/apache/iceberg-python/pull/1925#ref-commit-562de40
https://github.com/Fokko
Fixhttps://github.com/apache/iceberg-python/commit/562de407d0dbf5e1212f0a541001a12543a645f3
add_fileshttps://github.com/apache/iceberg-python/commit/562de407d0dbf5e1212f0a541001a12543a645f3
with non-identity transforms (https://github.com/apache/iceberg-python/commit/562de407d0dbf5e1212f0a541001a12543a645f3
#1925https://github.com/apache/iceberg-python/pull/1925
)https://github.com/apache/iceberg-python/commit/562de407d0dbf5e1212f0a541001a12543a645f3
562de40https://github.com/apache/iceberg-python/commit/562de407d0dbf5e1212f0a541001a12543a645f3
36d383dhttps://github.com/apache/iceberg-python/commit/36d383dcb676ae5ef59c34cc2910d16a8e30a80c
36d383dhttps://github.com/apache/iceberg-python/commit/36d383dcb676ae5ef59c34cc2910d16a8e30a80c
#1555https://github.com/apache/iceberg-python/pull/1555
#1539https://github.com/apache/iceberg-python/pull/1539
#208 (comment)https://github.com/apache/iceberg-python/issues/208#issuecomment-1889891973
#1491https://github.com/apache/iceberg-python/issues/1491
#1917https://github.com/apache/iceberg-python/issues/1917
gabeigliohttps://github.com/gabeiglio
Aug 13, 2025 https://github.com/apache/iceberg-python/pull/1925#ref-commit-8863361
https://github.com/Fokko
https://github.com/gabeiglio
Fixhttps://github.com/Netflix/iceberg-python/commit/886336101807a0a220263d362b415923d4d32708
add_fileshttps://github.com/Netflix/iceberg-python/commit/886336101807a0a220263d362b415923d4d32708
with non-identity transforms (https://github.com/Netflix/iceberg-python/commit/886336101807a0a220263d362b415923d4d32708
apache#1925https://github.com/apache/iceberg-python/pull/1925
)https://github.com/Netflix/iceberg-python/commit/886336101807a0a220263d362b415923d4d32708
8863361https://github.com/Netflix/iceberg-python/commit/886336101807a0a220263d362b415923d4d32708
36d383dhttps://github.com/Netflix/iceberg-python/commit/36d383dcb676ae5ef59c34cc2910d16a8e30a80c
36d383dhttps://github.com/Netflix/iceberg-python/commit/36d383dcb676ae5ef59c34cc2910d16a8e30a80c
apache#1555https://github.com/apache/iceberg-python/pull/1555
apache#1539https://github.com/apache/iceberg-python/pull/1539
apache#208 (comment)https://github.com/apache/iceberg-python/issues/208#issuecomment-1889891973
apache#1491https://github.com/apache/iceberg-python/issues/1491
apache#1917https://github.com/apache/iceberg-python/issues/1917
https://github.co/hiddenchars
https://github.com/apache/iceberg-python/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Ficeberg-python%2Fpull%2F1925
https://github.com/kevinjqliu
kevinjqliu https://github.com/kevinjqliu
https://github.com/apache/iceberg-python/pull/1925/files/e5a766509b5f4f7a83d88d80aa6692a040374011
PyIceberg 0.9.1 https://github.com/apache/iceberg-python/milestone/11
Pyiceberg 9.0 not adding files with hour(timestamp) partitions https://github.com/apache/iceberg-python/issues/1917
Please reload this pagehttps://github.com/apache/iceberg-python/pull/1925
https://github.com/Fokko
https://github.com/kevinjqliu
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.