| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6af984ec-6028-aa13-a387-34de5784085e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A672:1EF1:29F3BB5:3BBDAF3:6A4D00E8 |
| html-safe-nonce | 4d02c498747d6509c383fb2ce2231b379efa546e09c0a3eb7235717e1a641604 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjcyOjFFRjE6MjlGM0JCNTozQkJEQUYzOjZBNEQwMEU4IiwidmlzaXRvcl9pZCI6IjMyMDQ0NDUwOTIzOTI1MzQyNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | deeb0581cbed6a4a4bcbd357536e3396282bf10a9452b9f63029344ce4061f48 |
| hovercard-subject-tag | pull_request:1655868828 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/dolphinscheduler-sdk-python/123/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/1b79a632803c31fe84c5c917688fbdb1faa1934e9eee6daa0e0e9ee0a3de5f20/apache/dolphinscheduler-sdk-python/pull/123 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1b79a632803c31fe84c5c917688fbdb1faa1934e9eee6daa0e0e9ee0a3de5f20/apache/dolphinscheduler-sdk-python/pull/123 |
| og:image:alt | Purpose of the pull request
close #122
Brief Summary of The Change
Change the parameter types of task and workflow to Union[timedelta, int]
Pull Request checklist
I confirm that the following chec... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | lukeyan2023 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 31e4db13a9e20081f2fac78f441659a6576e582bbb15e153f9c7fb6473aa29f5 |
| turbo-cache-control | no-cache |
| go-import | github.com/apache/dolphinscheduler-sdk-python git https://github.com/apache/dolphinscheduler-sdk-python.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 562819934 |
| octolytics-dimension-repository_nwo | apache/dolphinscheduler-sdk-python |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 562819934 |
| octolytics-dimension-repository_network_root_nwo | apache/dolphinscheduler-sdk-python |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | fb70bd3c4b2bec429781b65419e912c66e2d5581 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdolphinscheduler-sdk-python%2Fpull%2F123 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdolphinscheduler-sdk-python%2Fpull%2F123 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fdolphinscheduler-sdk-python |
| Reload | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| Reload | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| Reload | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
|
apache
| https://github.com/apache |
| dolphinscheduler-sdk-python | https://github.com/apache/dolphinscheduler-sdk-python |
|
Notifications
| https://github.com/login?return_to=%2Fapache%2Fdolphinscheduler-sdk-python |
|
Fork
26
| https://github.com/login?return_to=%2Fapache%2Fdolphinscheduler-sdk-python |
|
Star
71
| https://github.com/login?return_to=%2Fapache%2Fdolphinscheduler-sdk-python |
|
Code
| https://github.com/apache/dolphinscheduler-sdk-python |
|
Issues
27
| https://github.com/apache/dolphinscheduler-sdk-python/issues |
|
Pull requests
3
| https://github.com/apache/dolphinscheduler-sdk-python/pulls |
|
Actions
| https://github.com/apache/dolphinscheduler-sdk-python/actions |
|
Security and quality
0
| https://github.com/apache/dolphinscheduler-sdk-python/security |
|
Insights
| https://github.com/apache/dolphinscheduler-sdk-python/pulse |
|
Code
| https://github.com/apache/dolphinscheduler-sdk-python |
|
Issues
| https://github.com/apache/dolphinscheduler-sdk-python/issues |
|
Pull requests
| https://github.com/apache/dolphinscheduler-sdk-python/pulls |
|
Actions
| https://github.com/apache/dolphinscheduler-sdk-python/actions |
|
Security and quality
| https://github.com/apache/dolphinscheduler-sdk-python/security |
|
Insights
| https://github.com/apache/dolphinscheduler-sdk-python/pulse |
| zhongjiajie | https://github.com/zhongjiajie |
| apache:main | https://github.com/apache/dolphinscheduler-sdk-python/tree/main |
| lukeyan2023:feature-task-workflow-timeout | https://github.com/lukeyan2023/dolphinscheduler-sdk-python/tree/feature-task-workflow-timeout |
| Conversation | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| Commits5 (5) | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits |
| Checks | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/checks |
| Files changed | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/files |
| [impv] Change the parameter types of task and workflow to Union[timedelta, int] | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#top |
| zhongjiajie | https://github.com/zhongjiajie |
| apache:main | https://github.com/apache/dolphinscheduler-sdk-python/tree/main |
| lukeyan2023:feature-task-workflow-timeout | https://github.com/lukeyan2023/dolphinscheduler-sdk-python/tree/feature-task-workflow-timeout |
|
| https://github.com/lukeyan2023 |
| lukeyan2023 | https://github.com/lukeyan2023 |
| Dec 23, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#issue-2054788040 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| #122 | https://github.com/apache/dolphinscheduler-sdk-python/issues/122 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| Change the parameter types of task and workflow to Union[timedelta, int] | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/a3ee2eaa781a0cc48b19a2405d8d01258e17d257 |
| a3ee2ea | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/a3ee2eaa781a0cc48b19a2405d8d01258e17d257 |
| https://github.com/lukeyan2023 |
| lukeyan2023 | https://github.com/lukeyan2023 |
| Dec 24, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#event-11331725629 |
| https://github.com/zhongjiajie |
| zhongjiajie | https://github.com/zhongjiajie |
|
Dec 25, 2023
| https://github.com/apache/dolphinscheduler-sdk-python/pull/123#pullrequestreview-1795662800 |
|
View reviewed changes
| https://github.com/apache/dolphinscheduler-sdk-python/pull/123/files/a3ee2eaa781a0cc48b19a2405d8d01258e17d257 |
| zhongjiajie | https://github.com/zhongjiajie |
| https://github.com/apache/dolphinscheduler-sdk-python/pull/123#pullrequestreview-1795662800 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| src/pydolphinscheduler/core/task.py | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/files/a3ee2eaa781a0cc48b19a2405d8d01258e17d257#diff-b9f3febe9968add7cb2ade313e0712f87b00a56994ff7434d09aeabdb18c7f02 |
| zhongjiajie | https://github.com/zhongjiajie |
| Dec 25, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#discussion_r1435917023 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| zhongjiajie | https://github.com/zhongjiajie |
| December 25, 2023 11:41 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#commits-pushed-d85b27a |
|
| https://github.com/zhongjiajie |
| Change some code | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/d85b27a91a8b60567e1274d057eb3a72d8e503d5 |
| d85b27a | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/d85b27a91a8b60567e1274d057eb3a72d8e503d5 |
|
| https://github.com/zhongjiajie |
| Merge remote-tracking branch 'lukeyan2023/feature-task-workflow-timeo… | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/b0feb0666bffef18ecf774406cafe237aed998de |
| b0feb06 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/b0feb0666bffef18ecf774406cafe237aed998de |
|
| https://github.com/zhongjiajie |
| code format | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/f825292ef45063894577e1be0371814cf0533d36 |
| f825292 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/f825292ef45063894577e1be0371814cf0533d36 |
| https://github.com/zhongjiajie |
| zhongjiajie | https://github.com/zhongjiajie |
|
improvement
| https://github.com/apache/dolphinscheduler-sdk-python/issues?q=state%3Aopen%20label%3Aimprovement |
| Dec 25, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#event-11333716891 |
| https://github.com/zhongjiajie |
| zhongjiajie | https://github.com/zhongjiajie |
| lukeyan2023 | https://github.com/lukeyan2023 |
| Dec 25, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#event-11333717021 |
| https://github.com/zhongjiajie |
| zhongjiajie | https://github.com/zhongjiajie |
|
Dec 25, 2023
| https://github.com/apache/dolphinscheduler-sdk-python/pull/123#pullrequestreview-1795684548 |
|
View reviewed changes
| https://github.com/apache/dolphinscheduler-sdk-python/pull/123/files/f825292ef45063894577e1be0371814cf0533d36 |
| zhongjiajie | https://github.com/zhongjiajie |
| https://github.com/apache/dolphinscheduler-sdk-python/pull/123#pullrequestreview-1795684548 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
|
| https://github.com/zhongjiajie |
| remove method unnessary | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/fae048c330c1eda9bff1111422c20854355f8ee7 |
| fae048c | https://github.com/apache/dolphinscheduler-sdk-python/pull/123/commits/fae048c330c1eda9bff1111422c20854355f8ee7 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Dec 25, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#issuecomment-1868708097 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| Codecov | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| (48586a3) | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/48586a3702df3f708044c8c03eedd442f21cf24f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| (fae048c) | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/fae048c330c1eda9bff1111422c20854355f8ee7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Files | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| src/pydolphinscheduler/core/task.py | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123?src=pr&el=tree&filepath=src%2Fpydolphinscheduler%2Fcore%2Ftask.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3Rhc2sucHk= |
| 1 Missing ⚠️ | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| src/pydolphinscheduler/core/workflow.py | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123?src=pr&el=tree&filepath=src%2Fpydolphinscheduler%2Fcore%2Fworkflow.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3dvcmtmbG93LnB5 |
| 1 Missing ⚠️ | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Flag | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| unittests | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Click here | https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/123?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| https://github.com/zhongjiajie |
| zhongjiajie | https://github.com/zhongjiajie |
| d47f03c | https://github.com/apache/dolphinscheduler-sdk-python/commit/d47f03cbfbfdb9e4c61c91be5d32a9956d080171 |
| Dec 25, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#event-11333760876 |
| https://github.com/lukeyan2023 |
| lukeyan2023 | https://github.com/lukeyan2023 |
| Dec 27, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#issuecomment-1869858192 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| https://github.com/zhongjiajie |
| zhongjiajie | https://github.com/zhongjiajie |
| Dec 27, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#issuecomment-1869875035 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| https://github.com/lukeyan2023 |
| lukeyan2023 | https://github.com/lukeyan2023 |
| Dec 27, 2023 | https://github.com/apache/dolphinscheduler-sdk-python/pull/123#issuecomment-1869935197 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
| https://github.co/hiddenchars |
| https://github.com/apache/dolphinscheduler-sdk-python/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdolphinscheduler-sdk-python%2Fpull%2F123 |
|
| https://github.com/zhongjiajie |
|
zhongjiajie
| https://github.com/zhongjiajie |
|
| https://github.com/apache/dolphinscheduler-sdk-python/pull/123/files/f825292ef45063894577e1be0371814cf0533d36 |
|
| https://github.com/lukeyan2023 |
|
lukeyan2023
| https://github.com/lukeyan2023 |
|
improvement
| https://github.com/apache/dolphinscheduler-sdk-python/issues?q=state%3Aopen%20label%3Aimprovement |
|
The timeout types of workflow and task parameters are inconsistent
| https://github.com/apache/dolphinscheduler-sdk-python/issues/122 |
| Please reload this page | https://github.com/apache/dolphinscheduler-sdk-python/pull/123 |
|
| https://github.com/lukeyan2023 |
|
| https://github.com/codecov-commenter |
|
| https://github.com/zhongjiajie |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |