| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f511f31f-badc-08b3-e701-e2972cf4045e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B6D6:2BE4CA:DCDD1A:1231B57:6B02E884 |
| html-safe-nonce | 5725337c47819b81263558176461a90fd9a8b7d413b8f422fedbf23b25533c07 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNkQ2OjJCRTRDQTpEQ0REMUE6MTIzMUI1Nzo2QjAyRTg4NCIsInZpc2l0b3JfaWQiOiI1MTAyMTg4OTE2MjY2NjkwNjkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ce2769164cb5df2a6ee54a6349bc6d32e06755b070caf77f0a0ab42a64b99eac |
| hovercard-subject-tag | pull_request:5075500822 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/datasketches-java/785/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f614b62b3688ef0845218c619c1b79c20cad7a31c92d52a71d176c6c078c996a/apache/datasketches-java/pull/785 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f614b62b3688ef0845218c619c1b79c20cad7a31c92d52a71d176c6c078c996a/apache/datasketches-java/pull/785 |
| og:image:alt | Summary
Java tuple sketches always hashed with the default seed. They wrote a fixed seed hash and never checked the seed hash, either when reading an image or when combining sketches. As a result, ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | leerho |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/apache/datasketches-java git https://github.com/apache/datasketches-java.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 38279790 |
| octolytics-dimension-repository_nwo | apache/datasketches-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38279790 |
| octolytics-dimension-repository_network_root_nwo | apache/datasketches-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/apache/datasketches-java/pull/785#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F785 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F785 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fdatasketches-java |
| Reload | https://github.com/apache/datasketches-java/pull/785 |
| Reload | https://github.com/apache/datasketches-java/pull/785 |
| Reload | https://github.com/apache/datasketches-java/pull/785 |
| apache | https://github.com/apache |
| datasketches-java | https://github.com/apache/datasketches-java |
| Code | https://github.com/apache/datasketches-java |
| Issues4 (4) | https://github.com/apache/datasketches-java/issues |
| Pull requests6 (6) | https://github.com/apache/datasketches-java/pulls |
| Actions | https://github.com/apache/datasketches-java/actions |
| Projects | https://github.com/apache/datasketches-java/projects |
| Wiki | https://github.com/apache/datasketches-java/wiki |
| Security and quality | https://github.com/apache/datasketches-java/security |
| Insights | https://github.com/apache/datasketches-java/insights |
| https://github.com/apache/datasketches-java |
| leerho | https://github.com/leerho |
| main | https://github.com/apache/datasketches-java/tree/main |
| tuple-custom-seed | https://github.com/apache/datasketches-java/tree/tuple-custom-seed |
| Conversation | https://github.com/apache/datasketches-java/pull/785 |
| Commits4 (4) | https://github.com/apache/datasketches-java/pull/785/commits |
| Checks | https://github.com/apache/datasketches-java/pull/785/checks |
| Files changed | https://github.com/apache/datasketches-java/pull/785/files |
| Tuple: support custom update seeds, and check seed hashes | https://github.com/apache/datasketches-java/pull/785#top |
| leerho | https://github.com/leerho |
| main | https://github.com/apache/datasketches-java/tree/main |
| tuple-custom-seed | https://github.com/apache/datasketches-java/tree/tuple-custom-seed |
|
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| Oct 29, 2026 | https://github.com/apache/datasketches-java/pull/785#issue-6108444118 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| Align theta and tuple JaccardSimilarity; check theta seeds in tuple set operations #782 | https://github.com/apache/datasketches-java/pull/782 |
| Align theta and tuple JaccardSimilarity; check theta seeds in tuple set operations #782 | https://github.com/apache/datasketches-java/pull/782 |
| Claude Code | https://claude.com/claude-code |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| proost | https://github.com/proost |
| tisonkun | https://github.com/tisonkun |
| October 29, 2026 21:11 | https://github.com/apache/datasketches-java/pull/785#event-34632975960 |
| https://github.com/apps/github-advanced-security |
| github-advanced-security | https://github.com/apps/github-advanced-security |
|
Oct 29, 2026
| https://github.com/apache/datasketches-java/pull/785#pullrequestreview-5705393457 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/785/files |
| src/main/java/org/apache/datasketches/tuple/TupleSketch.java | https://github.com/apache/datasketches-java/pull/785/files#diff-39640c532853e3aea0d531e2cae95d2eb3118db425106c6f1b947aa32cd0e9a4 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| src/test/java/org/apache/datasketches/tuple/TupleCustomSeedTest.java | https://github.com/apache/datasketches-java/pull/785/files#diff-f60bb4455c9caa2dbe24a5d3fccc7a2ce233c474fb3b2e5f07913693d4cc5232 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| src/test/java/org/apache/datasketches/tuple/TupleCustomSeedTest.java | https://github.com/apache/datasketches-java/pull/785/files#diff-f60bb4455c9caa2dbe24a5d3fccc7a2ce233c474fb3b2e5f07913693d4cc5232 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
|
| https://github.com/leerho |
|
| https://github.com/claude |
| Tuple: support custom update seeds, and check seed hashes | https://github.com/apache/datasketches-java/pull/785/commits/74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3 |
| 74ed06c | https://github.com/apache/datasketches-java/pull/785/commits/74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| force-pushed | https://github.com/apache/datasketches-java/compare/212cc54f53c469cf9a58fbc8bc718040aebfdf45..74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3 |
| 212cc54 | https://github.com/apache/datasketches-java/commit/212cc54f53c469cf9a58fbc8bc718040aebfdf45 |
| 74ed06c | https://github.com/apache/datasketches-java/commit/74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3 |
|
Compare
| https://github.com/apache/datasketches-java/compare/212cc54f53c469cf9a58fbc8bc718040aebfdf45..74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3 |
| October 30, 2026 17:47 | https://github.com/apache/datasketches-java/pull/785#event-34717453946 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| Oct 30, 2026 | https://github.com/apache/datasketches-java/pull/785#issuecomment-6529681928 |
| #784 | https://github.com/apache/datasketches-java/pull/784 |
| #784 | https://github.com/apache/datasketches-java/pull/784 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| https://github.com/proost |
| proost | https://github.com/proost |
|
Oct 31, 2026
| https://github.com/apache/datasketches-java/pull/785#pullrequestreview-5721827956 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/785/files/74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3 |
| proost | https://github.com/proost |
| https://github.com/apache/datasketches-java/pull/785#pullrequestreview-5721827956 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| src/main/java/org/apache/datasketches/tuple/QuickSelectSketch.java | https://github.com/apache/datasketches-java/pull/785/files/74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3#diff-d64365b4265c66ba16c055525bb3d7c36372af8139faf311b8ed40b028eb6393 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| leerho | https://github.com/leerho |
| October 31, 2026 15:26 | https://github.com/apache/datasketches-java/pull/785#commits-pushed-f2622cd |
|
| https://github.com/leerho |
|
| https://github.com/claude |
| Tuple: refuse updatable serialization by the full seed, not the seed … | https://github.com/apache/datasketches-java/pull/785/commits/f2622cd575174204f89a19b909b9ef2c80b47fa5 |
| f2622cd | https://github.com/apache/datasketches-java/pull/785/commits/f2622cd575174204f89a19b909b9ef2c80b47fa5 |
|
| https://github.com/leerho |
|
| https://github.com/claude |
| Theta: deprecate UpdatableThetaSketch.getSeed() in favor of getSeedHa… | https://github.com/apache/datasketches-java/pull/785/commits/4ec9e7805c9049167020f9bfbb81cd3a04fc91c1 |
| 4ec9e78 | https://github.com/apache/datasketches-java/pull/785/commits/4ec9e7805c9049167020f9bfbb81cd3a04fc91c1 |
| https://github.com/apps/github-advanced-security |
| github-advanced-security | https://github.com/apps/github-advanced-security |
|
Oct 31, 2026
| https://github.com/apache/datasketches-java/pull/785#pullrequestreview-5725299445 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/785/files/4ec9e7805c9049167020f9bfbb81cd3a04fc91c1 |
| src/test/java/org/apache/datasketches/tuple/TupleCustomSeedTest.java | https://github.com/apache/datasketches-java/pull/785/files/4ec9e7805c9049167020f9bfbb81cd3a04fc91c1#diff-f60bb4455c9caa2dbe24a5d3fccc7a2ce233c474fb3b2e5f07913693d4cc5232 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| src/test/java/org/apache/datasketches/tuple/TupleCustomSeedTest.java | https://github.com/apache/datasketches-java/pull/785/files/4ec9e7805c9049167020f9bfbb81cd3a04fc91c1#diff-f60bb4455c9caa2dbe24a5d3fccc7a2ce233c474fb3b2e5f07913693d4cc5232 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| src/test/java/org/apache/datasketches/tuple/TupleCustomSeedTest.java | https://github.com/apache/datasketches-java/pull/785/files/4ec9e7805c9049167020f9bfbb81cd3a04fc91c1#diff-f60bb4455c9caa2dbe24a5d3fccc7a2ce233c474fb3b2e5f07913693d4cc5232 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
|
| https://github.com/leerho |
|
| https://github.com/claude |
| Theta: print the seed hash, not the seed, in the builders' toString() | https://github.com/apache/datasketches-java/pull/785/commits/6b9ca4e06e330d1e7b6bb9a62e2923c889c5fe83 |
| 6b9ca4e | https://github.com/apache/datasketches-java/pull/785/commits/6b9ca4e06e330d1e7b6bb9a62e2923c889c5fe83 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| ade7ecb | https://github.com/apache/datasketches-java/commit/ade7ecbd5b3ee0c0d93098933a253061542eaf79 |
| Oct 31, 2026 | https://github.com/apache/datasketches-java/pull/785#event-34803711036 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| October 31, 2026 23:34 | https://github.com/apache/datasketches-java/pull/785#event-34803713004 |
| https://github.co/hiddenchars |
| https://github.com/apache/datasketches-java/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F785 |
|
| https://github.com/proost |
|
proost
| https://github.com/proost |
|
| https://github.com/apache/datasketches-java/pull/785/files/74ed06cb58e1cf4c113fc195a8e5f6279c4da8f3 |
|
| https://github.com/tisonkun |
|
tisonkun
| https://github.com/tisonkun |
|
| https://github.com/apps/github-advanced-security |
|
github-advanced-security[bot]
| https://github.com/apps/github-advanced-security |
|
| https://github.com/apache/datasketches-java/pull/785/files/4ec9e7805c9049167020f9bfbb81cd3a04fc91c1 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/785 |
|
| https://github.com/leerho |
|
| https://github.com/proost |
|
| https://github.com/apps/github-advanced-security |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |