| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e257f9a2-84d8-b0c2-167d-293d1a86b5c0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E136:223EE1:17EEED1:1F90A6E:6B02DBDD |
| html-safe-nonce | 94b643e55df5cfec334432aef8c9f4bc5ee4c2d5510e89d9a7cc3fe393fe3cdc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTM2OjIyM0VFMToxN0VFRUQxOjFGOTBBNkU6NkIwMkRCREQiLCJ2aXNpdG9yX2lkIjoiNzI3NzIzMTkwMDUyNjMwNDIyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6498780632574677b32bdde81be625681c940071007987c64c310874b917dc4f |
| hovercard-subject-tag | pull_request:4464528092 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/datasketches-java/762/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5bbdbdf55ab2f28e65b43980b8f7f7bfed099dae9978adc86e9eab9f77effb4d/apache/datasketches-java/pull/762 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5bbdbdf55ab2f28e65b43980b8f7f7bfed099dae9978adc86e9eab9f77effb4d/apache/datasketches-java/pull/762 |
| og:image:alt | Util.numDigits(0) and Util.numDigits(1) both return 0, and Util.numDigits(1000000000000000000L) returns 18 for a number with 19 digits.
The method is at src/main/java/org/apache/datasketches/common... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MaxFreedomPollard |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/apache/datasketches-java git https://github.com/apache/datasketches-java.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 38279790 |
| octolytics-dimension-repository_nwo | apache/datasketches-java |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 38279790 |
| octolytics-dimension-repository_network_root_nwo | apache/datasketches-java |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/apache/datasketches-java/pull/762#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F762 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F762 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fdatasketches-java |
| Reload | https://github.com/apache/datasketches-java/pull/762 |
| Reload | https://github.com/apache/datasketches-java/pull/762 |
| Reload | https://github.com/apache/datasketches-java/pull/762 |
| apache | https://github.com/apache |
| datasketches-java | https://github.com/apache/datasketches-java |
| Code | https://github.com/apache/datasketches-java |
| Issues4 (4) | https://github.com/apache/datasketches-java/issues |
| Pull requests6 (6) | https://github.com/apache/datasketches-java/pulls |
| Actions | https://github.com/apache/datasketches-java/actions |
| Projects | https://github.com/apache/datasketches-java/projects |
| Wiki | https://github.com/apache/datasketches-java/wiki |
| Security and quality | https://github.com/apache/datasketches-java/security |
| Insights | https://github.com/apache/datasketches-java/insights |
| https://github.com/apache/datasketches-java |
| leerho | https://github.com/leerho |
| apache:main | https://github.com/apache/datasketches-java/tree/main |
| MaxFreedomPollard:fix-numdigits-zero-and-one | https://github.com/MaxFreedomPollard/datasketches-java/tree/fix-numdigits-zero-and-one |
| Conversation | https://github.com/apache/datasketches-java/pull/762 |
| Commits4 (4) | https://github.com/apache/datasketches-java/pull/762/commits |
| Checks | https://github.com/apache/datasketches-java/pull/762/checks |
| Files changed | https://github.com/apache/datasketches-java/pull/762/files |
| Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18 | https://github.com/apache/datasketches-java/pull/762#top |
| leerho | https://github.com/leerho |
| apache:main | https://github.com/apache/datasketches-java/tree/main |
| MaxFreedomPollard:fix-numdigits-zero-and-one | https://github.com/MaxFreedomPollard/datasketches-java/tree/fix-numdigits-zero-and-one |
|
| https://github.com/MaxFreedomPollard |
| MaxFreedomPollard | https://github.com/MaxFreedomPollard |
| Sep 7, 2026 | https://github.com/apache/datasketches-java/pull/762#issue-5375132939 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
|
| https://github.com/MaxFreedomPollard |
| Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18 | https://github.com/apache/datasketches-java/pull/762/commits/bda4c332476ff6fcf4e7e6a5f3281dd3611ba882 |
| bda4c33 | https://github.com/apache/datasketches-java/pull/762/commits/bda4c332476ff6fcf4e7e6a5f3281dd3611ba882 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| Sep 7, 2026 | https://github.com/apache/datasketches-java/pull/762#issuecomment-5576527483 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
|
Sep 7, 2026
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5135701865 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/762/files/bda4c332476ff6fcf4e7e6a5f3281dd3611ba882 |
| leerho | https://github.com/leerho |
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5135701865 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
|
| https://github.com/MaxFreedomPollard |
| Make numDigits count characters including the minus sign | https://github.com/apache/datasketches-java/pull/762/commits/6040f84c911aecdf5912aaf938d6db7d239d0848 |
| 6040f84 | https://github.com/apache/datasketches-java/pull/762/commits/6040f84c911aecdf5912aaf938d6db7d239d0848 |
| https://github.com/apps/github-advanced-security |
| github-advanced-security | https://github.com/apps/github-advanced-security |
|
Sep 10, 2026
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5162762331 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/762/files/6040f84c911aecdf5912aaf938d6db7d239d0848 |
| src/test/java/org/apache/datasketches/common/UtilTest.java | https://github.com/apache/datasketches-java/pull/762/files/6040f84c911aecdf5912aaf938d6db7d239d0848#diff-3ca36e464d56151a770a06c877617bf54497d15695445ffb1119aa3315bc56fe |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
|
| https://github.com/MaxFreedomPollard |
| Drop the always true loop guard in checkNumDigits | https://github.com/apache/datasketches-java/pull/762/commits/6498a90f1c4ca5e9aedf42d3b58565f1a9372216 |
| 6498a90 | https://github.com/apache/datasketches-java/pull/762/commits/6498a90f1c4ca5e9aedf42d3b58565f1a9372216 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| Sep 10, 2026 | https://github.com/apache/datasketches-java/pull/762#issuecomment-5622246677 |
| @MaxFreedomPollard | https://github.com/MaxFreedomPollard |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| Sep 13, 2026 | https://github.com/apache/datasketches-java/pull/762#issuecomment-5655335024 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
|
Sep 13, 2026
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5191812045 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/762/files/6498a90f1c4ca5e9aedf42d3b58565f1a9372216 |
| leerho | https://github.com/leerho |
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5191812045 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| Check only the decimal-character transition points in checkNumDigits | https://github.com/apache/datasketches-java/pull/762/commits/accfafb0931306445e55de5ef9c00fa770cae204 |
| accfafb | https://github.com/apache/datasketches-java/pull/762/commits/accfafb0931306445e55de5ef9c00fa770cae204 |
| https://github.com/MaxFreedomPollard |
| MaxFreedomPollard | https://github.com/MaxFreedomPollard |
| Sep 14, 2026 | https://github.com/apache/datasketches-java/pull/762#issuecomment-5671602978 |
| accfafb | https://github.com/apache/datasketches-java/commit/accfafb0931306445e55de5ef9c00fa770cae204 |
| @test | https://github.com/test |
| @test | https://github.com/test |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
|
Sep 15, 2026
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5217036971 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204 |
| leerho | https://github.com/leerho |
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5217036971 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| https://github.com/apps/github-advanced-security |
| github-advanced-security | https://github.com/apps/github-advanced-security |
|
Sep 15, 2026
| https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5217048743 |
|
View reviewed changes
| https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204 |
| src/test/java/org/apache/datasketches/common/UtilTest.java | https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204#diff-3ca36e464d56151a770a06c877617bf54497d15695445ffb1119aa3315bc56fe |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| https://github.com/leerho |
| leerho | https://github.com/leerho |
| 20678c4 | https://github.com/apache/datasketches-java/commit/20678c4d2f00de0ce04707f49848c609433bc525 |
| Sep 16, 2026 | https://github.com/apache/datasketches-java/pull/762#event-31211217604 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| https://github.co/hiddenchars |
| https://github.com/apache/datasketches-java/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F762 |
|
| https://github.com/leerho |
|
leerho
| https://github.com/leerho |
|
| https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204 |
|
| https://github.com/apps/github-advanced-security |
|
github-advanced-security[bot]
| https://github.com/apps/github-advanced-security |
|
| https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
| Please reload this page | https://github.com/apache/datasketches-java/pull/762 |
|
| https://github.com/MaxFreedomPollard |
|
| https://github.com/leerho |
|
| https://github.com/apps/github-advanced-security |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |