René's URL Explorer Experiment


Title: Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18 by MaxFreedomPollard · Pull Request #762 · apache/datasketches-java · GitHub

Open Graph Title: Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18 by MaxFreedomPollard · Pull Request #762 · apache/datasketches-java

X Title: Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18 by MaxFreedomPollard · Pull Request #762 · apache/datasketches-java

Description: A software library of stochastic streaming algorithms, a.k.a. sketches. - Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18 by MaxFreedomPollard · Pull Request #762 · apache/datasketches-java

Open Graph Description: Util.numDigits(0) and Util.numDigits(1) both return 0, and Util.numDigits(1000000000000000000L) returns 18 for a number with 19 digits. The method is at src/main/java/org/apache/datasketches/common...

X Description: Util.numDigits(0) and Util.numDigits(1) both return 0, and Util.numDigits(1000000000000000000L) returns 18 for a number with 19 digits. The method is at src/main/java/org/apache/datasketches/common...

Opengraph URL: https://github.com/apache/datasketches-java/pull/762

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e257f9a2-84d8-b0c2-167d-293d1a86b5c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE136:223EE1:17EEED1:1F90A6E:6B02DBDD
html-safe-nonce94b643e55df5cfec334432aef8c9f4bc5ee4c2d5510e89d9a7cc3fe393fe3cdc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMTM2OjIyM0VFMToxN0VFRUQxOjFGOTBBNkU6NkIwMkRCREQiLCJ2aXNpdG9yX2lkIjoiNzI3NzIzMTkwMDUyNjMwNDIyMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6498780632574677b32bdde81be625681c940071007987c64c310874b917dc4f
hovercard-subject-tagpull_request:4464528092
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/datasketches-java/762/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5bbdbdf55ab2f28e65b43980b8f7f7bfed099dae9978adc86e9eab9f77effb4d/apache/datasketches-java/pull/762
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5bbdbdf55ab2f28e65b43980b8f7f7bfed099dae9978adc86e9eab9f77effb4d/apache/datasketches-java/pull/762
og:image:altUtil.numDigits(0) and Util.numDigits(1) both return 0, and Util.numDigits(1000000000000000000L) returns 18 for a number with 19 digits. The method is at src/main/java/org/apache/datasketches/common...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMaxFreedomPollard
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/apache/datasketches-java git https://github.com/apache/datasketches-java.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id38279790
octolytics-dimension-repository_nwoapache/datasketches-java
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id38279790
octolytics-dimension-repository_network_root_nwoapache/datasketches-java
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/apache/datasketches-java/pull/762#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F762
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F762
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fdatasketches-java
Reloadhttps://github.com/apache/datasketches-java/pull/762
Reloadhttps://github.com/apache/datasketches-java/pull/762
Reloadhttps://github.com/apache/datasketches-java/pull/762
apachehttps://github.com/apache
datasketches-javahttps://github.com/apache/datasketches-java
Codehttps://github.com/apache/datasketches-java
Issues4 (4)https://github.com/apache/datasketches-java/issues
Pull requests6 (6)https://github.com/apache/datasketches-java/pulls
Actionshttps://github.com/apache/datasketches-java/actions
Projectshttps://github.com/apache/datasketches-java/projects
Wikihttps://github.com/apache/datasketches-java/wiki
Security and qualityhttps://github.com/apache/datasketches-java/security
Insightshttps://github.com/apache/datasketches-java/insights
https://github.com/apache/datasketches-java
leerhohttps://github.com/leerho
apache:mainhttps://github.com/apache/datasketches-java/tree/main
MaxFreedomPollard:fix-numdigits-zero-and-onehttps://github.com/MaxFreedomPollard/datasketches-java/tree/fix-numdigits-zero-and-one
Conversationhttps://github.com/apache/datasketches-java/pull/762
Commits4 (4)https://github.com/apache/datasketches-java/pull/762/commits
Checkshttps://github.com/apache/datasketches-java/pull/762/checks
Files changedhttps://github.com/apache/datasketches-java/pull/762/files
Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18https://github.com/apache/datasketches-java/pull/762#top
leerhohttps://github.com/leerho
apache:mainhttps://github.com/apache/datasketches-java/tree/main
MaxFreedomPollard:fix-numdigits-zero-and-onehttps://github.com/MaxFreedomPollard/datasketches-java/tree/fix-numdigits-zero-and-one
https://github.com/MaxFreedomPollard
MaxFreedomPollardhttps://github.com/MaxFreedomPollard
Sep 7, 2026https://github.com/apache/datasketches-java/pull/762#issue-5375132939
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/MaxFreedomPollard
Fix Util.numDigits returning 0 for 0 and 1, and 18 for 1E18https://github.com/apache/datasketches-java/pull/762/commits/bda4c332476ff6fcf4e7e6a5f3281dd3611ba882
bda4c33https://github.com/apache/datasketches-java/pull/762/commits/bda4c332476ff6fcf4e7e6a5f3281dd3611ba882
https://github.com/leerho
leerhohttps://github.com/leerho
Sep 7, 2026https://github.com/apache/datasketches-java/pull/762#issuecomment-5576527483
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/leerho
leerhohttps://github.com/leerho
Sep 7, 2026 https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5135701865
View reviewed changes https://github.com/apache/datasketches-java/pull/762/files/bda4c332476ff6fcf4e7e6a5f3281dd3611ba882
leerhohttps://github.com/leerho
https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5135701865
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/MaxFreedomPollard
Make numDigits count characters including the minus signhttps://github.com/apache/datasketches-java/pull/762/commits/6040f84c911aecdf5912aaf938d6db7d239d0848
6040f84https://github.com/apache/datasketches-java/pull/762/commits/6040f84c911aecdf5912aaf938d6db7d239d0848
https://github.com/apps/github-advanced-security
github-advanced-securityhttps://github.com/apps/github-advanced-security
Sep 10, 2026 https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5162762331
View reviewed changes https://github.com/apache/datasketches-java/pull/762/files/6040f84c911aecdf5912aaf938d6db7d239d0848
src/test/java/org/apache/datasketches/common/UtilTest.javahttps://github.com/apache/datasketches-java/pull/762/files/6040f84c911aecdf5912aaf938d6db7d239d0848#diff-3ca36e464d56151a770a06c877617bf54497d15695445ffb1119aa3315bc56fe
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/MaxFreedomPollard
Drop the always true loop guard in checkNumDigitshttps://github.com/apache/datasketches-java/pull/762/commits/6498a90f1c4ca5e9aedf42d3b58565f1a9372216
6498a90https://github.com/apache/datasketches-java/pull/762/commits/6498a90f1c4ca5e9aedf42d3b58565f1a9372216
https://github.com/leerho
leerhohttps://github.com/leerho
Sep 10, 2026https://github.com/apache/datasketches-java/pull/762#issuecomment-5622246677
@MaxFreedomPollardhttps://github.com/MaxFreedomPollard
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/leerho
leerhohttps://github.com/leerho
Sep 13, 2026https://github.com/apache/datasketches-java/pull/762#issuecomment-5655335024
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/leerho
leerhohttps://github.com/leerho
Sep 13, 2026 https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5191812045
View reviewed changes https://github.com/apache/datasketches-java/pull/762/files/6498a90f1c4ca5e9aedf42d3b58565f1a9372216
leerhohttps://github.com/leerho
https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5191812045
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
Check only the decimal-character transition points in checkNumDigitshttps://github.com/apache/datasketches-java/pull/762/commits/accfafb0931306445e55de5ef9c00fa770cae204
accfafbhttps://github.com/apache/datasketches-java/pull/762/commits/accfafb0931306445e55de5ef9c00fa770cae204
https://github.com/MaxFreedomPollard
MaxFreedomPollardhttps://github.com/MaxFreedomPollard
Sep 14, 2026https://github.com/apache/datasketches-java/pull/762#issuecomment-5671602978
accfafbhttps://github.com/apache/datasketches-java/commit/accfafb0931306445e55de5ef9c00fa770cae204
@testhttps://github.com/test
@testhttps://github.com/test
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/leerho
leerhohttps://github.com/leerho
Sep 15, 2026 https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5217036971
View reviewed changes https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204
leerhohttps://github.com/leerho
https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5217036971
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/apps/github-advanced-security
github-advanced-securityhttps://github.com/apps/github-advanced-security
Sep 15, 2026 https://github.com/apache/datasketches-java/pull/762#pullrequestreview-5217048743
View reviewed changes https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204
src/test/java/org/apache/datasketches/common/UtilTest.javahttps://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204#diff-3ca36e464d56151a770a06c877617bf54497d15695445ffb1119aa3315bc56fe
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/leerho
leerhohttps://github.com/leerho
20678c4https://github.com/apache/datasketches-java/commit/20678c4d2f00de0ce04707f49848c609433bc525
Sep 16, 2026https://github.com/apache/datasketches-java/pull/762#event-31211217604
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.co/hiddenchars
https://github.com/apache/datasketches-java/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatasketches-java%2Fpull%2F762
https://github.com/leerho
leerho https://github.com/leerho
https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204
https://github.com/apps/github-advanced-security
github-advanced-security[bot] https://github.com/apps/github-advanced-security
https://github.com/apache/datasketches-java/pull/762/files/accfafb0931306445e55de5ef9c00fa770cae204
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
Please reload this pagehttps://github.com/apache/datasketches-java/pull/762
https://github.com/MaxFreedomPollard
https://github.com/leerho
https://github.com/apps/github-advanced-security
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Response headers:
Servergithub.com
Content-Typetext/html; charset=utf-8
Cache-Controlno-cache

Viewport: width=device-width


URLs of crawlers that visited me.