René's URL Explorer Experiment


Title: Bugfix: Calling count with None arguments by timsaucer · Pull Request #768 · apache/datafusion-python · GitHub

Open Graph Title: Bugfix: Calling count with None arguments by timsaucer · Pull Request #768 · apache/datafusion-python

X Title: Bugfix: Calling count with None arguments by timsaucer · Pull Request #768 · apache/datafusion-python

Description: Which issue does this PR close? None Rationale for this change This is a two line bugfix. What changes are included in this PR? If the user calls count() it should internally use count_star() Are t...

Open Graph Description: Which issue does this PR close? None Rationale for this change This is a two line bugfix. What changes are included in this PR? If the user calls count() it should internally use count_star() Are t...

X Description: Which issue does this PR close? None Rationale for this change This is a two line bugfix. What changes are included in this PR? If the user calls count() it should internally use count_star() Are t...

Opengraph URL: https://github.com/apache/datafusion-python/pull/768

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:26c5c9f5-d8d2-a526-9a0a-05317698c08d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA38:1F2CE1:1B0C8:23877:69783D86
html-safe-nonce0ded9c2b9d80f163c9c8b91345a724459b7185a653cd31a66394cfb10d4b8992
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTM4OjFGMkNFMToxQjBDODoyMzg3Nzo2OTc4M0Q4NiIsInZpc2l0b3JfaWQiOiIxMTk5NTk1MzM2ODg4NzYxNzM0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace5855c414e56ede0d8a45032f6bc31be15970c1c44490222e2935cc013cae976
hovercard-subject-tagpull_request:1985384601
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/datafusion-python/768/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1c8aca1d8c7d546ee251b8392f4375c1bce7ce9bbf94f49671952b92d6155c31/apache/datafusion-python/pull/768
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1c8aca1d8c7d546ee251b8392f4375c1bce7ce9bbf94f49671952b92d6155c31/apache/datafusion-python/pull/768
og:image:altWhich issue does this PR close? None Rationale for this change This is a two line bugfix. What changes are included in this PR? If the user calls count() it should internally use count_star() Are t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametimsaucer
hostnamegithub.com
expected-hostnamegithub.com
None2981c597c945c1d90ac6fa355ce7929b2f413dfe7872ca5c435ee53a24a1de50
turbo-cache-controlno-preview
go-importgithub.com/apache/datafusion-python git https://github.com/apache/datafusion-python.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id515951203
octolytics-dimension-repository_nwoapache/datafusion-python
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id515951203
octolytics-dimension-repository_network_root_nwoapache/datafusion-python
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release520b65a872113b919c1bbdb03834a50af15859fd
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/apache/datafusion-python/pull/768#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatafusion-python%2Fpull%2F768
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatafusion-python%2Fpull%2F768
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fdatafusion-python
Reloadhttps://github.com/apache/datafusion-python/pull/768
Reloadhttps://github.com/apache/datafusion-python/pull/768
Reloadhttps://github.com/apache/datafusion-python/pull/768
apache https://github.com/apache
datafusion-pythonhttps://github.com/apache/datafusion-python
Notifications https://github.com/login?return_to=%2Fapache%2Fdatafusion-python
Fork 142 https://github.com/login?return_to=%2Fapache%2Fdatafusion-python
Star 553 https://github.com/login?return_to=%2Fapache%2Fdatafusion-python
Code https://github.com/apache/datafusion-python
Issues 80 https://github.com/apache/datafusion-python/issues
Pull requests 27 https://github.com/apache/datafusion-python/pulls
Actions https://github.com/apache/datafusion-python/actions
Security 0 https://github.com/apache/datafusion-python/security
Insights https://github.com/apache/datafusion-python/pulse
Code https://github.com/apache/datafusion-python
Issues https://github.com/apache/datafusion-python/issues
Pull requests https://github.com/apache/datafusion-python/pulls
Actions https://github.com/apache/datafusion-python/actions
Security https://github.com/apache/datafusion-python/security
Insights https://github.com/apache/datafusion-python/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fapache%2Fdatafusion-python%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fapache%2Fdatafusion-python%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/apache/datafusion-python/pull/768#issue-comment-box
andygrovehttps://github.com/andygrove
apache:mainhttps://github.com/apache/datafusion-python/tree/main
timsaucer:tsaucer/bugfix-count-with-nonehttps://github.com/timsaucer/datafusion-python/tree/tsaucer/bugfix-count-with-none
Bugfix: Calling count with None arguments https://github.com/apache/datafusion-python/pull/768#top
andygrovehttps://github.com/andygrove
apache:mainhttps://github.com/apache/datafusion-python/tree/main
timsaucer:tsaucer/bugfix-count-with-nonehttps://github.com/timsaucer/datafusion-python/tree/tsaucer/bugfix-count-with-none
Conversation 4 https://github.com/apache/datafusion-python/pull/768
Commits 2 https://github.com/apache/datafusion-python/pull/768/commits
Checks 0 https://github.com/apache/datafusion-python/pull/768/checks
Files changed https://github.com/apache/datafusion-python/pull/768/files
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
https://github.co/hiddenchars
https://github.com/apache/datafusion-python/pull/{{ revealButtonHref }}
https://github.com/timsaucer
timsaucerhttps://github.com/timsaucer
Jul 24, 2024https://github.com/apache/datafusion-python/pull/768#issue-2427512536
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
https://github.com/timsaucer
Small bugfix. When arguments are None, we should use count_starhttps://github.com/apache/datafusion-python/pull/768/commits/5cabf833940466c8798524320682032e90559ea5
5cabf83https://github.com/apache/datafusion-python/pull/768/commits/5cabf833940466c8798524320682032e90559ea5
https://github.com/Michael-J-Ward
Michael-J-Wardhttps://github.com/Michael-J-Ward
Jul 25, 2024https://github.com/apache/datafusion-python/pull/768#issuecomment-2249237406
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
#771https://github.com/apache/datafusion-python/pull/771
#771https://github.com/apache/datafusion-python/pull/771
AggregateExt traithttps://docs.rs/datafusion/40.0.0/datafusion/logical_expr/trait.AggregateExt.html
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
https://github.com/Michael-J-Ward
Michael-J-Wardhttps://github.com/Michael-J-Ward
Jul 25, 2024 https://github.com/apache/datafusion-python/pull/768#pullrequestreview-2198135159
View reviewed changes https://github.com/apache/datafusion-python/pull/768/files/5cabf833940466c8798524320682032e90559ea5
https://github.com/timsaucer
timsaucerhttps://github.com/timsaucer
Jul 25, 2024https://github.com/apache/datafusion-python/pull/768#issuecomment-2249996193
#750https://github.com/apache/datafusion-python/pull/750
apache/datafusion#11550https://github.com/apache/datafusion/pull/11550
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
https://github.com/Michael-J-Ward
Michael-J-Wardhttps://github.com/Michael-J-Ward
Jul 25, 2024https://github.com/apache/datafusion-python/pull/768#issuecomment-2250309086
apache/datafusion#11550https://github.com/apache/datafusion/pull/11550
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
https://github.com/andygrove
andygrovehttps://github.com/andygrove
Jul 25, 2024 https://github.com/apache/datafusion-python/pull/768#pullrequestreview-2199444428
View reviewed changes https://github.com/apache/datafusion-python/pull/768/files/5cabf833940466c8798524320682032e90559ea5
https://github.com/timsaucer
When no arguments are given to count, set argument to lit(1) so that …https://github.com/apache/datafusion-python/pull/768/commits/1a068e0c0377deb264945f848a7cbd5d4622768e
1a068e0https://github.com/apache/datafusion-python/pull/768/commits/1a068e0c0377deb264945f848a7cbd5d4622768e
https://github.com/timsaucer
timsaucerhttps://github.com/timsaucer
Jul 25, 2024https://github.com/apache/datafusion-python/pull/768#issuecomment-2250473990
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
https://github.com/timsaucer
timsaucerhttps://github.com/timsaucer
Jul 26, 2024 https://github.com/apache/datafusion-python/pull/768#ref-pullrequest-2428325270
Upgrade Datafusion 40 #771 https://github.com/apache/datafusion-python/pull/771
https://github.com/Michael-J-Ward
Michael-J-Wardhttps://github.com/Michael-J-Ward
Jul 26, 2024 https://github.com/apache/datafusion-python/pull/768#ref-issue-2430413202
Tracking DF 40 release #776 https://github.com/apache/datafusion-python/issues/776
https://github.com/andygrove
andygrovehttps://github.com/andygrove
66bfe36https://github.com/apache/datafusion-python/commit/66bfe36d2b6d7f17446a4205aa98172abe439ee2
Aug 1, 2024https://github.com/apache/datafusion-python/pull/768#event-13727539321
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fdatafusion-python%2Fpull%2F768
https://github.com/andygrove
andygrove https://github.com/andygrove
https://github.com/apache/datafusion-python/pull/768/files/5cabf833940466c8798524320682032e90559ea5
https://github.com/Michael-J-Ward
Michael-J-Ward https://github.com/Michael-J-Ward
https://github.com/apache/datafusion-python/pull/768/files/5cabf833940466c8798524320682032e90559ea5
Please reload this pagehttps://github.com/apache/datafusion-python/pull/768
https://github.com/timsaucer
https://github.com/Michael-J-Ward
https://github.com/andygrove
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.