René's URL Explorer Experiment


Title: Prevent password updates for SAML and LDAP users by bernardodemarco · Pull Request #9999 · apache/cloudstack · GitHub

Open Graph Title: Prevent password updates for SAML and LDAP users by bernardodemarco · Pull Request #9999 · apache/cloudstack

X Title: Prevent password updates for SAML and LDAP users by bernardodemarco · Pull Request #9999 · apache/cloudstack

Description: Description Currently, CloudStack does not support dual authentication methods for SAML users. If their source is equal to SAML or SAMLDISABLED, then they're not able to login with a username and password. However, when executing the updateUser API to update their password, the password is changed in the database, even though username/password authentication is unsupported for these users. Regarding LDAP users, password updates directly through CloudStack should also not be allowed. Therefore, this PR addresses these issues by providing a clear error message when SAML or LDAP users attempt to change their password via the updateUser API. Fixes #9933 Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds functionality) Bug fix (non-breaking change which fixes an issue) Enhancement (improves an existing feature and functionality) Cleanup (Code refactoring and cleanup, that may add test cases) build/CI test (unit or integration test code) Feature/Enhancement Scale or Bug Severity Bug Severity BLOCKER Critical Major Minor Trivial Screenshots (if appropriate): How Has This Been Tested? Verified that attempting to update a SAML or LDAP user's password results in an appropriate error message. Verified that attempting to update a SAMLDISABLED user's password also triggers the error message. Verified that non-SAML/LDAP users can update their passwords without any issues.

Open Graph Description: Description Currently, CloudStack does not support dual authentication methods for SAML users. If their source is equal to SAML or SAMLDISABLED, then they're not able to login with a username a...

X Description: Description Currently, CloudStack does not support dual authentication methods for SAML users. If their source is equal to SAML or SAMLDISABLED, then they're not able to login with a userna...

Opengraph URL: https://github.com/apache/cloudstack/pull/9999

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f3e48a52-6bc7-89b0-7068-b782c8ec7f50
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B2E:2D34EE:77F367:A29A48:6A554AA0
html-safe-nonce104704376456e699e64bfe116beac324b111c01860ecfdd0a565d4a17d3fd393
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjJFOjJEMzRFRTo3N0YzNjc6QTI5QTQ4OjZBNTU0QUEwIiwidmlzaXRvcl9pZCI6IjQ1ODk0MDgzMzQwODQ2NTU3NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae5d32d73a42be283f0f64460c745594ce6498d332648af914a4c710c4c0128e
hovercard-subject-tagpull_request:2203724387
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/9999/files
twitter:imagehttps://avatars.githubusercontent.com/u/115510880?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/115510880?s=400&v=4
og:image:altDescription Currently, CloudStack does not support dual authentication methods for SAML users. If their source is equal to SAML or SAMLDISABLED, then they're not able to login with a username a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/apache/cloudstack/pull/9999/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F9999%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F9999%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://github.com/apache/cloudstack/pull/9999/files
Reloadhttps://github.com/apache/cloudstack/pull/9999/files
Reloadhttps://github.com/apache/cloudstack/pull/9999/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/9999/files
apache https://github.com/apache
cloudstackhttps://github.com/apache/cloudstack
Notifications https://github.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Star 3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Code https://github.com/apache/cloudstack
Issues 538 https://github.com/apache/cloudstack/issues
Pull requests 258 https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality 0 https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
Code https://github.com/apache/cloudstack
Issues https://github.com/apache/cloudstack/issues
Pull requests https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
DaanHooglandhttps://github.com/DaanHoogland
apache:4.19https://github.com/apache/cloudstack/tree/4.19
scclouds:error-message-when-saml-ldap-change-their-passwordshttps://github.com/scclouds/cloudstack/tree/error-message-when-saml-ldap-change-their-passwords
Conversation 11 https://github.com/apache/cloudstack/pull/9999
Commits 2 https://github.com/apache/cloudstack/pull/9999/commits
Checks 0 https://github.com/apache/cloudstack/pull/9999/checks
Files changed https://github.com/apache/cloudstack/pull/9999/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/9999/files
Prevent password updates for SAML and LDAP users https://github.com/apache/cloudstack/pull/9999/files#top
Show all changes 2 commits https://github.com/apache/cloudstack/pull/9999/files
28691a5 dont allow ldap and saml users to change their password bernardodemarco Nov 26, 2024 https://github.com/apache/cloudstack/pull/9999/commits/28691a566f55399946635d712ddf028605efbde1
89f13ac add error message to logs bernardodemarco Nov 26, 2024 https://github.com/apache/cloudstack/pull/9999/commits/89f13ac975855586226ad9442720789c0ec21dea
Clear filters https://github.com/apache/cloudstack/pull/9999/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/9999/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/9999/files
AccountManagerImpl.java https://github.com/apache/cloudstack/pull/9999/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
AccountManagerImplTest.java https://github.com/apache/cloudstack/pull/9999/files#diff-9ee1a679f4c9f18ea68c7b9288a2cdb2b224b8cee933831a906337891c54dbb2
server/src/main/java/com/cloud/user/AccountManagerImpl.javahttps://github.com/apache/cloudstack/pull/9999/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
View file https://github.com/scclouds/cloudstack/blob/89f13ac975855586226ad9442720789c0ec21dea/server/src/main/java/com/cloud/user/AccountManagerImpl.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/9999/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/9999/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
https://github.com/apache/cloudstack/pull/9999/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
https://github.com/apache/cloudstack/pull/9999/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
server/src/test/java/com/cloud/user/AccountManagerImplTest.javahttps://github.com/apache/cloudstack/pull/9999/files#diff-9ee1a679f4c9f18ea68c7b9288a2cdb2b224b8cee933831a906337891c54dbb2
View file https://github.com/scclouds/cloudstack/blob/89f13ac975855586226ad9442720789c0ec21dea/server/src/test/java/com/cloud/user/AccountManagerImplTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/9999/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/9999/files#diff-9ee1a679f4c9f18ea68c7b9288a2cdb2b224b8cee933831a906337891c54dbb2
https://github.com/apache/cloudstack/pull/9999/files#diff-9ee1a679f4c9f18ea68c7b9288a2cdb2b224b8cee933831a906337891c54dbb2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.