Title: Maintenance mode: Add host to deployment planner avoid list to fix local storage migration by BartJM · Pull Request #9892 · apache/cloudstack · GitHub
Open Graph Title: Maintenance mode: Add host to deployment planner avoid list to fix local storage migration by BartJM · Pull Request #9892 · apache/cloudstack
X Title: Maintenance mode: Add host to deployment planner avoid list to fix local storage migration by BartJM · Pull Request #9892 · apache/cloudstack
Description: Description This PR adds the host preparing for maintenance to the avoid list for the deployment planner. Without adding the host to the avoid list the deployment planner will return the host preparing for maintenance when a vm has a local storage root disk and has the host preparing for maintenance as the last host. Steps to reproduce Create vm with local storage Set host with the vm in maintenance Actual behaviour (qa6-4.19-upstream-54bd5b60-kvm-host1) Failed to prepare host for maintenance due to: Migration of the vm VM instance {"id":13,"instanceName":"i-2-13-VM","type":"User","uuid":"209d346b-b2e7-485f-a889-8462dd0078cc"}from host Host {"id":1,"name":"qa6-4.19-upstream-54bd5b60-kvm-host1","type":"Routing","uuid":"224ca458-90e6-4efb-8532-e5efc83df9f4"} to destination host Host {"id":1,"name":"qa6-4.19-upstream-54bd5b60-kvm-host1","type":"Routing","uuid":"224ca458-90e6-4efb-8532-e5efc83df9f4"} doesn't involve migrating the volumes. Expected Local storage vm live migrated to another host. Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds functionality) Bug fix (non-breaking change which fixes an issue) Enhancement (improves an existing feature and functionality) Cleanup (Code refactoring and cleanup, that may add test cases) build/CI test (unit or integration test code) Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale Major Minor Bug Severity BLOCKER Critical Major Minor Trivial Screenshots (if appropriate): How Has This Been Tested? Centos8 mbx env with host.maintenance.local.storage.strategy set to Migration. Tested maintenance mode on a host with Local storage vm HA vm Local storage vm with ha data disk ha vm with ha datadisk Local storage vm with local data disk ha vm with local datadisk 5 and 6 result in an ErrorInMaintenance due to dest being null. Similar as described in #9887. Without this patch these would still fail with the same error as described in actual behavior. After creation of a ha vm with ha data disk maintenance was not possible. After manual migration to another host and back, migration did complete. Migration without selecting host also gave a no destination found error and also occurred without this patch so is unrelated. How did you try to break this feature and the system with this change?
Open Graph Description: Description This PR adds the host preparing for maintenance to the avoid list for the deployment planner. Without adding the host to the avoid list the deployment planner will return the host prepa...
X Description: Description This PR adds the host preparing for maintenance to the avoid list for the deployment planner. Without adding the host to the avoid list the deployment planner will return the host prepa...
Opengraph URL: https://github.com/apache/cloudstack/pull/9892
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:0259ed64-4d52-ea11-32ca-521ec002c785 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 98EA:364D1D:1379DBA:1C7F3A4:6A56282E |
| html-safe-nonce | 51a5d10b71e271608ac0f35f427d853895d631f2570eee02e40ffe8791e80c6a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEVBOjM2NEQxRDoxMzc5REJBOjFDN0YzQTQ6NkE1NjI4MkUiLCJ2aXNpdG9yX2lkIjoiMjU1MTcxMDIzNDkyMzM3ODczNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c9d0c534c7d10c2aaf4c8095fa77be226e223706008917b5313054a72ab8bfe8 |
| hovercard-subject-tag | pull_request:2163115169 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/9892/files |
| twitter:image | https://avatars.githubusercontent.com/u/16014786?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/16014786?s=400&v=4 |
| og:image:alt | Description This PR adds the host preparing for maintenance to the avoid list for the deployment planner. Without adding the host to the avoid list the deployment planner will return the host prepa... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9d78ea552aac0685ca5f006d44f88166cbbf3bb96843f8da0c5a2c0b9908430b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/apache/cloudstack git https://github.com/apache/cloudstack.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 9759448 |
| octolytics-dimension-repository_nwo | apache/cloudstack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9759448 |
| octolytics-dimension-repository_network_root_nwo | apache/cloudstack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 160a6fceec0fef718a0c3ac46f2d71ae9d5c0ff5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width