| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3929d5e2-d1bd-9a53-ee32-9aafd9f112ee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2B2:172DE4:61385:82F9F:6A4D28C9 |
| html-safe-nonce | dfd2363d4587e37a6b81fe493f0e783c10578765cce4023f59cef43b3e8f8123 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkIyOjE3MkRFNDo2MTM4NTo4MkY5Rjo2QTREMjhDOSIsInZpc2l0b3JfaWQiOiI2MTQ2NjYyMjM4OTM5NTg4ODA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | afac1a71b0a756be3ea70b85b1cea15f6ff92aa8075effab1209587a8b270494 |
| hovercard-subject-tag | pull_request:1726225669 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/8654/files |
| twitter:image | https://avatars.githubusercontent.com/u/39202678?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/39202678?s=400&v=4 |
| og:image:alt | Description
Each hypervisor can support a different number of network adapters. Comparing KVM and VMWare, VMWare defines a limited number of NICs for each ESXi machine (https://configmax.esp.vmware... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/apache/cloudstack git https://github.com/apache/cloudstack.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 9759448 |
| octolytics-dimension-repository_nwo | apache/cloudstack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9759448 |
| octolytics-dimension-repository_network_root_nwo | apache/cloudstack |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 93f17a978ee60bc4668e1d7b90e6bd2d622261fd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/apache/cloudstack/pull/8654/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F8654%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F8654%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=apache%2Fcloudstack |
| Reload | https://github.com/apache/cloudstack/pull/8654/files |
| Reload | https://github.com/apache/cloudstack/pull/8654/files |
| Reload | https://github.com/apache/cloudstack/pull/8654/files |
| Please reload this page | https://github.com/apache/cloudstack/pull/8654/files |
|
apache
| https://github.com/apache |
| cloudstack | https://github.com/apache/cloudstack |
|
Notifications
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Fork
1.3k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Star
3k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
535
| https://github.com/apache/cloudstack/issues |
|
Pull requests
265
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security and quality
0
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
| https://github.com/apache/cloudstack/issues |
|
Pull requests
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security and quality
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose |
| hsato03 | https://github.com/hsato03 |
| apache:4.22 | https://github.com/apache/cloudstack/tree/4.22 |
| scclouds:update-vpc.max.networks-setting-and-set-to-cluster-level | https://github.com/scclouds/cloudstack/tree/update-vpc.max.networks-setting-and-set-to-cluster-level |
|
Conversation
113
| https://github.com/apache/cloudstack/pull/8654 |
|
Commits
22
| https://github.com/apache/cloudstack/pull/8654/commits |
|
Checks
26
| https://github.com/apache/cloudstack/pull/8654/checks |
|
Files changed
| https://github.com/apache/cloudstack/pull/8654/files |
| Please reload this page | https://github.com/apache/cloudstack/pull/8654/files |
|
Update vpc.max.networks setting & settings to limit the number of NICs for each hypervisor
| https://github.com/apache/cloudstack/pull/8654/files#top |
|
Show all changes
22 commits
| https://github.com/apache/cloudstack/pull/8654/files |
|
f1aa837
Update vpc.max.networks setting
Jan 17, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/f1aa83770cb4c2c2ba76097b5a2cd79c0a3fac44 |
|
b29a3c6
Change vpc.max.networks to account scope & create vm.max.nics settings
Mar 1, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/b29a3c65915cb4635287845c40a75ecbe0ae80a1 |
|
89ad7fb
Adjusts
Mar 1, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/89ad7fbfb7b537e74068260806257242433d8fd6 |
|
cd297f2
Limit number of tiers
Mar 21, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/cd297f269338a54cb6a39f1f72087a6985261c0e |
|
4412ecd
Fix validation
Mar 21, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/4412ecd97caa610c964541664bf5346e726b1388 |
|
f2f7bfc
Desconsider redundant routers in validation
Mar 21, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/f2f7bfca4f141b08023b4da6e8b1ceeef31a2c06 |
|
639ff8a
Change query
Mar 22, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/639ff8a4e22bfd9f0b930157573c29bf904a4e1b |
|
a78f8fe
Compare single VR
Mar 26, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/a78f8fe42b5058cd66773836b58e7506767f2d08 |
|
b4b2b20
Refactor code
Apr 9, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/b4b2b20ba836ae7b56584f7dc9c8e6ee1720b4f4 |
|
405b996
Remove unused import & improve VR NIC validation
Apr 10, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/405b996a73b29553014dcbd25874c4a72d1d4d8e |
|
bd3d414
Remove whitespaces
Apr 10, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/bd3d414487fa3c0fd3acb26a9a60ca9e51d66160 |
|
230d2d0
Fix tests
Apr 12, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/230d2d0e148b78d4552e032976e47bbddf719264 |
|
1711d1d
Add integration tests
Apr 22, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/1711d1d1d73c56a9b4d166abc080fb358eda3668 |
|
e63837c
Refactor
Apr 22, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/e63837ccef9dcde5ed8ffe1b9f2b64593102faaa |
|
cd0dd9d
Change tests file
May 2, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/cd0dd9d4bcddf18aebf092367c16d375f21a2b0e |
|
4bb19d1
Restore old tests file
May 2, 2024
| https://github.com/apache/cloudstack/pull/8654/commits/4bb19d166c2c15d402d66d7aa68a1ac47e0821d1 |
|
f32807a
Fix tests
hsato03 Nov 6, 2025
| https://github.com/apache/cloudstack/pull/8654/commits/f32807a3785227fe28248ace2cd646c4b5804e71 |
|
ed2e8a6
Change conditional
hsato03 Jan 19, 2026
| https://github.com/apache/cloudstack/pull/8654/commits/ed2e8a6e24a3ac958cc0b4aa409f8fa29178a819 |
|
870dece
Merge branch '4.22' into update-vpc.max.networks-setting-and-set-to-c…
hsato03 Jan 27, 2026
| https://github.com/apache/cloudstack/pull/8654/commits/870dececfafab57a27851c4fdd3fcde462dbb826 |
|
8cd4e08
Merge branch '4.22' into update-vpc.max.networks-setting-and-set-to-c…
hsato03 Feb 2, 2026
| https://github.com/apache/cloudstack/pull/8654/commits/8cd4e0876c56fadb6a6037698382903b74aa0757 |
|
65b5f0c
fix tests
hsato03 Feb 2, 2026
| https://github.com/apache/cloudstack/pull/8654/commits/65b5f0c6eeaf18f33fce6bf5506f804f0842c4e9 |
|
4bf0685
Resolve conflicts
hsato03 Jun 26, 2026
| https://github.com/apache/cloudstack/pull/8654/commits/4bf06854248055575ab507e2dfc3bbf0190e11a8 |
|
Clear filters
| https://github.com/apache/cloudstack/pull/8654/files |
| Please reload this page | https://github.com/apache/cloudstack/pull/8654/files |
| Please reload this page | https://github.com/apache/cloudstack/pull/8654/files |
|
ci.yml
| https://github.com/apache/cloudstack/pull/8654/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f |
|
NetworkOrchestrationService.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-98ff849de67485ce559c6d8a7dab4688c294291f27875052ceb0619f7e4237b5 |
|
VpcManager.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-e05a38f41c85defb2befa710fffaf3ff9d57d6a6fd4e101d6e5c5c306964f6d2 |
|
NetworkOrchestrator.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-4c7db7a01c7c11625b21047cdc68424840136950614fea10eb0e8642a5581b3a |
|
NetworkOrchestratorTest.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-df822688c8c3cfdc8a153aa77f98c20b213cc8e0c8723ab42ca3159ddf0f5c95 |
|
DomainRouterDao.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-e139b565a00aa186b3f6040551efc6b447601f02cf8a5dcd23f313524244b38e |
|
DomainRouterDaoImpl.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-b3355b092f9d5c5db3debc6a7f35a5288d721d78c178faa76998c5148eb39c8a |
|
DomainRouterJoinDao.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-2692b798b3dd4a99762610f03bd0471489d8256090f448929382d1ee87e440d3 |
|
DomainRouterJoinDaoImpl.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-841bac7790ae0e3a0f13427a5b0b65d761fd73fe3bd4dcdf1c873d18186ecd54 |
|
Config.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-0dbb07fafeb6f537bd703ca50b7980c05c765ce57c06d2f19336ce504f35c2c2 |
|
VpcManagerImpl.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-07bd71d9f58832d4429d7743f4887188a96aacc913dc48e0101470147ce42032 |
|
VpcManagerImplTest.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-b0d96e688fba4af4a7e5c46de9776e3b5110ded7b34d1ea1e9fbf2821a5a0c89 |
|
MockNetworkManagerImpl.java
| https://github.com/apache/cloudstack/pull/8654/files#diff-10f1ae2ecb8ba813536b1cc0638d22744a7877da0e61eed1dcd4309d76ab264f |
|
test_vpc_vms_deployment.py
| https://github.com/apache/cloudstack/pull/8654/files#diff-97b6ef87f6322116dacaaca44cab75aaf8d86aee8655f60a9a4f19fdb50ec900 |
|
test_vpc_hypervisor_max_networks.py
| https://github.com/apache/cloudstack/pull/8654/files#diff-974cd99b9626045ae2cce464142cb6a2f187817f2f45208cb2eda386621d7bd2 |
| .github/workflows/ci.yml | https://github.com/apache/cloudstack/pull/8654/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f |
|
View file
| https://github.com/apache/cloudstack/blob/4bf06854248055575ab507e2dfc3bbf0190e11a8/.github/workflows/ci.yml |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/apache/cloudstack/pull/8654/{{ revealButtonHref }} |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f |
| .../java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java | https://github.com/apache/cloudstack/pull/8654/files#diff-98ff849de67485ce559c6d8a7dab4688c294291f27875052ceb0619f7e4237b5 |
|
View file
| https://github.com/apache/cloudstack/blob/4bf06854248055575ab507e2dfc3bbf0190e11a8/engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/NetworkOrchestrationService.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/apache/cloudstack/pull/8654/{{ revealButtonHref }} |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-98ff849de67485ce559c6d8a7dab4688c294291f27875052ceb0619f7e4237b5 |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-98ff849de67485ce559c6d8a7dab4688c294291f27875052ceb0619f7e4237b5 |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-98ff849de67485ce559c6d8a7dab4688c294291f27875052ceb0619f7e4237b5 |
| engine/components-api/src/main/java/com/cloud/network/vpc/VpcManager.java | https://github.com/apache/cloudstack/pull/8654/files#diff-e05a38f41c85defb2befa710fffaf3ff9d57d6a6fd4e101d6e5c5c306964f6d2 |
|
View file
| https://github.com/apache/cloudstack/blob/4bf06854248055575ab507e2dfc3bbf0190e11a8/engine/components-api/src/main/java/com/cloud/network/vpc/VpcManager.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/apache/cloudstack/pull/8654/{{ revealButtonHref }} |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-e05a38f41c85defb2befa710fffaf3ff9d57d6a6fd4e101d6e5c5c306964f6d2 |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-e05a38f41c85defb2befa710fffaf3ff9d57d6a6fd4e101d6e5c5c306964f6d2 |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-e05a38f41c85defb2befa710fffaf3ff9d57d6a6fd4e101d6e5c5c306964f6d2 |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-e05a38f41c85defb2befa710fffaf3ff9d57d6a6fd4e101d6e5c5c306964f6d2 |
| ...tration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java | https://github.com/apache/cloudstack/pull/8654/files#diff-4c7db7a01c7c11625b21047cdc68424840136950614fea10eb0e8642a5581b3a |
|
View file
| https://github.com/apache/cloudstack/blob/4bf06854248055575ab507e2dfc3bbf0190e11a8/engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/apache/cloudstack/pull/8654/{{ revealButtonHref }} |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-4c7db7a01c7c11625b21047cdc68424840136950614fea10eb0e8642a5581b3a |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-4c7db7a01c7c11625b21047cdc68424840136950614fea10eb0e8642a5581b3a |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-4c7db7a01c7c11625b21047cdc68424840136950614fea10eb0e8642a5581b3a |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-4c7db7a01c7c11625b21047cdc68424840136950614fea10eb0e8642a5581b3a |
|
| https://github.com/apache/cloudstack/pull/8654/files#diff-4c7db7a01c7c11625b21047cdc68424840136950614fea10eb0e8642a5581b3a |
| Please reload this page | https://github.com/apache/cloudstack/pull/8654/files |
| Please reload this page | https://github.com/apache/cloudstack/pull/8654/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |