René's URL Explorer Experiment


Title: [marvin, VMware] Fix repeated test failures observed on 'main' branch by Pearl1594 · Pull Request #5992 · apache/cloudstack · GitHub

Open Graph Title: [marvin, VMware] Fix repeated test failures observed on 'main' branch by Pearl1594 · Pull Request #5992 · apache/cloudstack

X Title: [marvin, VMware] Fix repeated test failures observed on 'main' branch by Pearl1594 · Pull Request #5992 · apache/cloudstack

Description: Description This PR fixes the test failure observed on main branch for test_06_disk_offering_strictness_false The main reason for the failure, is that the volume fails to resize on change of service offering reporting that the volume has a parent. 022-02-14 07:22:01,410 ERROR [c.c.h.v.r.VmwareResource] (DirectAgent-80:ctx-df1ac830 10.0.34.173, job-59/job-60, cmd: ResizeVolumeCommand) (logid:02e59892) Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9]. 2022-02-14 07:22:01,410 ERROR [c.c.h.v.r.VmwareResource] (DirectAgent-80:ctx-df1ac830 10.0.34.173, job-59/job-60, cmd: ResizeVolumeCommand) (logid:02e59892) Failed to resize volume of VM [name: i-6-7-VM] due to: [Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9].]. java.lang.Exception: Resize of volume in VM [name: i-6-7-VM] is not supported because Disk device [path: i-6-7-VM] has Parents: [6000C296-e4fb-b280-4d56-8e62cda83de9]. at com.cloud.hypervisor.vmware.resource.VmwareResource.getDiskAfterResizeDiskValidations(VmwareResource.java:951) at com.cloud.hypervisor.vmware.resource.VmwareResource.execute(VmwareResource.java:878) at com.cloud.hypervisor.vmware.resource.VmwareResource.executeRequest(VmwareResource.java:569) at com.cloud.agent.manager.DirectAgentAttache$Task.runInContext(DirectAgentAttache.java:315) at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102) at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52) at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) For resizing volumes in VMware it is required that vmware.create.full.clone be true. Hence, the test has been modified to set it to true at the start of the test and reset it back on completion. Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds functionality) Bug fix (non-breaking change which fixes an issue) Enhancement (improves an existing feature and functionality) Cleanup (Code refactoring and cleanup, that may add test cases) Feature/Enhancement Scale or Bug Severity Bug Severity BLOCKER Critical Major Minor Trivial Screenshots (if appropriate): How Has This Been Tested?

Open Graph Description: Description This PR fixes the test failure observed on main branch for test_06_disk_offering_strictness_false The main reason for the failure, is that the volume fails to resize on change of servic...

X Description: Description This PR fixes the test failure observed on main branch for test_06_disk_offering_strictness_false The main reason for the failure, is that the volume fails to resize on change of servic...

Opengraph URL: https://github.com/apache/cloudstack/pull/5992

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:99804f79-821e-1b7c-8389-536ed998c9ae
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF9C:418ED:4CC2971:6A665F0:6A4F67B2
html-safe-nonce1f9be8b6520682abbea62fa8a6a43efe7b9508cc4e99851f5aa85378e3114ecb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjlDOjQxOEVEOjRDQzI5NzE6NkE2NjVGMDo2QTRGNjdCMiIsInZpc2l0b3JfaWQiOiI1MjI5MDU3NTgxNTQ5MzE2MDE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3574aa4df4e3c8c528962d8eef006aa667747e62d11de92280d3f2b0a3196b92
hovercard-subject-tagpull_request:851733405
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/5992/files
twitter:imagehttps://avatars.githubusercontent.com/u/10495417?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10495417?s=400&v=4
og:image:altDescription This PR fixes the test failure observed on main branch for test_06_disk_offering_strictness_false The main reason for the failure, is that the volume fails to resize on change of servic...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4b249b445842943ed31549e027f57a8ade9881ed
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/apache/cloudstack/pull/5992/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F5992%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F5992%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://github.com/apache/cloudstack/pull/5992/files
Reloadhttps://github.com/apache/cloudstack/pull/5992/files
Reloadhttps://github.com/apache/cloudstack/pull/5992/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/5992/files
apache https://github.com/apache
cloudstackhttps://github.com/apache/cloudstack
Notifications https://github.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Star 3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Code https://github.com/apache/cloudstack
Issues 536 https://github.com/apache/cloudstack/issues
Pull requests 266 https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality 0 https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
Code https://github.com/apache/cloudstack
Issues https://github.com/apache/cloudstack/issues
Pull requests https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
nvazquezhttps://github.com/nvazquez
apache:mainhttps://github.com/apache/cloudstack/tree/main
shapeblue:fix-change-svc-offering-testhttps://github.com/shapeblue/cloudstack/tree/fix-change-svc-offering-test
Conversation 34 https://github.com/apache/cloudstack/pull/5992
Commits 4 https://github.com/apache/cloudstack/pull/5992/commits
Checks 0 https://github.com/apache/cloudstack/pull/5992/checks
Files changed https://github.com/apache/cloudstack/pull/5992/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/5992/files
[marvin, VMware] Fix repeated test failures observed on 'main' branch https://github.com/apache/cloudstack/pull/5992/files#top
Show all changes 4 commits https://github.com/apache/cloudstack/pull/5992/files
a96bc13 [marvin, VMware] Fix test_06_disk_offering_strictness_false observed … Pearl1594 Feb 14, 2022 https://github.com/apache/cloudstack/pull/5992/commits/a96bc13a25480f223dafc3adc4a4b5d93c8aa37a
73fb707 Fix test Pearl1594 Feb 14, 2022 https://github.com/apache/cloudstack/pull/5992/commits/73fb70788f0fcd005322bc9d401cb1b5763627b9
3ad8316 update config only if false Pearl1594 Feb 15, 2022 https://github.com/apache/cloudstack/pull/5992/commits/3ad83165ddc91aff777c10a33eef690504774f28
71e7b01 reset full clone setting to original values Pearl1594 Feb 15, 2022 https://github.com/apache/cloudstack/pull/5992/commits/71e7b0110151e0a9aa63cf7534712cb497418269
Clear filters https://github.com/apache/cloudstack/pull/5992/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/5992/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/5992/files
ManagementServerImpl.java https://github.com/apache/cloudstack/pull/5992/files#diff-eb21dad2af4d6b0008ab4330419b8f156ac1d7176cf4ad55c246beb83296b79f
VolumeApiServiceImpl.java https://github.com/apache/cloudstack/pull/5992/files#diff-b93da5c5293f8cb4470ff6b1642d312131bb053df07b71b4b951b08dff0ad9ab
test_service_offerings.py https://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
server/src/main/java/com/cloud/server/ManagementServerImpl.javahttps://github.com/apache/cloudstack/pull/5992/files#diff-eb21dad2af4d6b0008ab4330419b8f156ac1d7176cf4ad55c246beb83296b79f
View file https://github.com/shapeblue/cloudstack/blob/71e7b0110151e0a9aa63cf7534712cb497418269/server/src/main/java/com/cloud/server/ManagementServerImpl.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/5992/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/5992/files#diff-eb21dad2af4d6b0008ab4330419b8f156ac1d7176cf4ad55c246beb83296b79f
https://github.com/apache/cloudstack/pull/5992/files#diff-eb21dad2af4d6b0008ab4330419b8f156ac1d7176cf4ad55c246beb83296b79f
https://github.com/apache/cloudstack/pull/5992/files#diff-eb21dad2af4d6b0008ab4330419b8f156ac1d7176cf4ad55c246beb83296b79f
https://github.com/apache/cloudstack/pull/5992/files#diff-eb21dad2af4d6b0008ab4330419b8f156ac1d7176cf4ad55c246beb83296b79f
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.javahttps://github.com/apache/cloudstack/pull/5992/files#diff-b93da5c5293f8cb4470ff6b1642d312131bb053df07b71b4b951b08dff0ad9ab
View file https://github.com/shapeblue/cloudstack/blob/71e7b0110151e0a9aa63cf7534712cb497418269/server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/5992/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/5992/files#diff-b93da5c5293f8cb4470ff6b1642d312131bb053df07b71b4b951b08dff0ad9ab
https://github.com/apache/cloudstack/pull/5992/files#diff-b93da5c5293f8cb4470ff6b1642d312131bb053df07b71b4b951b08dff0ad9ab
test/integration/smoke/test_service_offerings.pyhttps://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
View file https://github.com/shapeblue/cloudstack/blob/71e7b0110151e0a9aa63cf7534712cb497418269/test/integration/smoke/test_service_offerings.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/5992/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
https://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
https://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
https://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
https://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
Please reload this pagehttps://github.com/apache/cloudstack/pull/5992/files
https://github.com/apache/cloudstack/pull/5992/files#diff-c4309ed3c0de9849a9d08d316d49716c663d197436ebaf5bf3d4d9006124240d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.