| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1d281e28-e24e-512c-4cdd-140de5953932 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BAD0:1ECC21:C6429:10DA35:6982587F |
| html-safe-nonce | b2af28b0d7eb35e0f00a08ff8140b243ab3215e7a951f8be51cbc9c2fcd82ba6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUQwOjFFQ0MyMTpDNjQyOToxMERBMzU6Njk4MjU4N0YiLCJ2aXNpdG9yX2lkIjoiNzQ5MjM2OTc2MTc1MTc1ODA3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9bf7b7daedfa5ee485f186c6479e17df0465cb8b88afe1ce6fefe14195b42be8 |
| hovercard-subject-tag | pull_request:38100122 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/cloudstack/490/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d6ce37150f1678dd447fca3ef5dcd65401ee2bcba208ef4c5b006cbcfc7694e4/apache/cloudstack/pull/490 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d6ce37150f1678dd447fca3ef5dcd65401ee2bcba208ef4c5b006cbcfc7694e4/apache/cloudstack/pull/490 |
| og:image:alt | not sure what findbugs means yet, is it negating the if-condition against the assert?
This should at least turn both warnings into one. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DaanHoogland |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2bc3c2e32013a4dd01fdb54fd1244a7e41120ff63edbc321c8a14178d8474054 |
| turbo-cache-control | no-preview |
| go-import | github.com/apache/cloudstack git https://github.com/apache/cloudstack.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 9759448 |
| octolytics-dimension-repository_nwo | apache/cloudstack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9759448 |
| octolytics-dimension-repository_network_root_nwo | apache/cloudstack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5f31d9afe0fd4cabff2441cbbd77c7f545418340 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/apache/cloudstack/pull/490#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F490 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F490 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fcloudstack |
| Reload | https://github.com/apache/cloudstack/pull/490 |
| Reload | https://github.com/apache/cloudstack/pull/490 |
| Reload | https://github.com/apache/cloudstack/pull/490 |
|
apache
| https://github.com/apache |
| cloudstack | https://github.com/apache/cloudstack |
|
Notifications
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Fork
1.3k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Star
2.8k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
440
| https://github.com/apache/cloudstack/issues |
|
Pull requests
147
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
3
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security
0
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
| https://github.com/apache/cloudstack/issues |
|
Pull requests
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/apache/cloudstack/pull/490#issue-comment-box |
| DaanHoogland | https://github.com/DaanHoogland |
| apache:master | https://github.com/apache/cloudstack/tree/master |
| DaanHoogland:findbugs-UC | https://github.com/DaanHoogland/cloudstack/tree/findbugs-UC |
|
findbugs UC useless condition
| https://github.com/apache/cloudstack/pull/490#top |
| DaanHoogland | https://github.com/DaanHoogland |
| apache:master | https://github.com/apache/cloudstack/tree/master |
| DaanHoogland:findbugs-UC | https://github.com/DaanHoogland/cloudstack/tree/findbugs-UC |
|
Conversation
3
| https://github.com/apache/cloudstack/pull/490 |
|
Commits
1
| https://github.com/apache/cloudstack/pull/490/commits |
|
Checks
0
| https://github.com/apache/cloudstack/pull/490/checks |
|
Files changed
| https://github.com/apache/cloudstack/pull/490/files |
| Please reload this page | https://github.com/apache/cloudstack/pull/490 |
| https://github.co/hiddenchars |
| https://github.com/apache/cloudstack/pull/{{ revealButtonHref }} |
|
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Jun 19, 2015 | https://github.com/apache/cloudstack/pull/490#issue-89544739 |
| Please reload this page | https://github.com/apache/cloudstack/pull/490 |
|
| https://github.com/DaanHoogland |
| findbugs UC useless condition | https://github.com/apache/cloudstack/pull/490/commits/90b9e9328d662fc45e5ccc24e1213f2308fa5bcf |
| 90b9e93 | https://github.com/apache/cloudstack/pull/490/commits/90b9e9328d662fc45e5ccc24e1213f2308fa5bcf |
| yadvr | https://github.com/yadvr |
|
Jun 19, 2015
| https://github.com/apache/cloudstack/pull/490#discussion-diff-32824227 |
| View reviewed changes
| https://github.com/apache/cloudstack/pull/490/files/90b9e9328d662fc45e5ccc24e1213f2308fa5bcf#diff-a80bb28429aa71da32bf665f5cee8a23a67fe8b3a2037b3f0199110bda0045a9 |
| engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java | https://github.com/apache/cloudstack/pull/490/files#diff-a80bb28429aa71da32bf665f5cee8a23a67fe8b3a2037b3f0199110bda0045a9 |
| yadvr | https://github.com/yadvr |
| Jun 19, 2015 | https://github.com/apache/cloudstack/pull/490#discussion_r32824227 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/cloudstack/pull/490 |
| DaanHoogland | https://github.com/DaanHoogland |
| Jun 19, 2015 | https://github.com/apache/cloudstack/pull/490#discussion_r32825228 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @bhaisaab | https://github.com/bhaisaab |
| Please reload this page | https://github.com/apache/cloudstack/pull/490 |
| https://github.com/asfgit |
| asfgit | https://github.com/asfgit |
| c45c9bf | https://github.com/apache/cloudstack/commit/c45c9bfeefd052633c82d76cc69956f4527cca26 |
| Jun 19, 2015 | https://github.com/apache/cloudstack/pull/490#event-335257645 |
| https://github.com/asfbot |
| asfbot | https://github.com/asfbot |
| Jun 19, 2015 | https://github.com/apache/cloudstack/pull/490#issuecomment-113630005 |
| cloudstack-pull-requests #505 | https://builds.apache.org/job/cloudstack-pull-requests/505/ |
| Please reload this page | https://github.com/apache/cloudstack/pull/490 |
| kishankavala | https://github.com/kishankavala |
|
Jun 25, 2015
| https://github.com/apache/cloudstack/pull/490#ref-commit-da58788 |
|
| https://github.com/DaanHoogland |
|
| https://github.com/kishankavala |
| findbugs UC useless condition not sure what findbugs means yet, but t… | https://github.com/kishankavala/cloudstack/commit/da587881a345969877c2a552dd7187541f5bbe64 |
| da58788 | https://github.com/kishankavala/cloudstack/commit/da587881a345969877c2a552dd7187541f5bbe64 |
| apache#490 | https://github.com/apache/cloudstack/pull/490 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| August 3, 2015 20:43 | https://github.com/apache/cloudstack/pull/490#event-372420872 |
| yadvr | https://github.com/yadvr |
|
Jan 20, 2021
| https://github.com/apache/cloudstack/pull/490#ref-commit-1647c55 |
|
| https://github.com/davidjumani |
|
| https://github.com/yadvr |
| compute: Simplifying Deploy VM Wizard ( | https://github.com/apache/cloudstack/commit/1647c556396a576141a5c0a012133038e3bd0d88 |
| #499 | https://github.com/apache/cloudstack/pull/499 |
| ) | https://github.com/apache/cloudstack/commit/1647c556396a576141a5c0a012133038e3bd0d88 |
| 1647c55 | https://github.com/apache/cloudstack/commit/1647c556396a576141a5c0a012133038e3bd0d88 |
| #490 | https://github.com/apache/cloudstack/pull/490 |
| #491 | https://github.com/apache/cloudstack/pull/491 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F490 |
| Please reload this page | https://github.com/apache/cloudstack/pull/490 |
|
| https://github.com/DaanHoogland |
|
| https://github.com/asfbot |
|
| https://github.com/yadvr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |