| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4393bf47-0059-d579-30c3-45ec42b8257d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7A4:2D29C2:C2A270:10CD60F:6A53A485 |
| html-safe-nonce | 0ebdcd15d2a3576fab0ae9c3f284e5f8f4b33eba36e01832949457b10d0d69cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0E0OjJEMjlDMjpDMkEyNzA6MTBDRDYwRjo2QTUzQTQ4NSIsInZpc2l0b3JfaWQiOiI2NDY2OTYyMDUzNTU5MTk4ODUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c57d405569932958b0d6324049201b693e1fc06a3b511fbc848347b93e83cc1e |
| hovercard-subject-tag | pull_request:392263427 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/cloudstack/3983/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9f839b4bd752ea6134639e0c397076171102a7dce50e49636f0efc8860730428/apache/cloudstack/pull/3983 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9f839b4bd752ea6134639e0c397076171102a7dce50e49636f0efc8860730428/apache/cloudstack/pull/3983 |
| og:image:alt | Description
This is an attempt to address vmware issues with #3638, to prevent having to revert the entire PR. see #3978 for the issue.
Types of changes
Breaking change (fix or feature th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DaanHoogland |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/apache/cloudstack git https://github.com/apache/cloudstack.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 9759448 |
| octolytics-dimension-repository_nwo | apache/cloudstack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9759448 |
| octolytics-dimension-repository_network_root_nwo | apache/cloudstack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/apache/cloudstack/pull/3983#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F3983 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F3983 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fcloudstack |
| Reload | https://github.com/apache/cloudstack/pull/3983 |
| Reload | https://github.com/apache/cloudstack/pull/3983 |
| Reload | https://github.com/apache/cloudstack/pull/3983 |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
|
apache
| https://github.com/apache |
| cloudstack | https://github.com/apache/cloudstack |
|
Notifications
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Fork
1.3k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Star
3k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
541
| https://github.com/apache/cloudstack/issues |
|
Pull requests
260
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security and quality
0
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
| https://github.com/apache/cloudstack/issues |
|
Pull requests
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security and quality
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
| DaanHoogland | https://github.com/DaanHoogland |
| apache:master | https://github.com/apache/cloudstack/tree/master |
| shapeblue:uefisupport-fixes | https://github.com/shapeblue/cloudstack/tree/uefisupport-fixes |
| Conversation | https://github.com/apache/cloudstack/pull/3983 |
| Commits2 (2) | https://github.com/apache/cloudstack/pull/3983/commits |
| Checks | https://github.com/apache/cloudstack/pull/3983/checks |
| Files changed | https://github.com/apache/cloudstack/pull/3983/files |
| UEFI fixes and comments addressed | https://github.com/apache/cloudstack/pull/3983#top |
| DaanHoogland | https://github.com/DaanHoogland |
| apache:master | https://github.com/apache/cloudstack/tree/master |
| shapeblue:uefisupport-fixes | https://github.com/shapeblue/cloudstack/tree/uefisupport-fixes |
|
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#issue-586060685 |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| #3638 | https://github.com/apache/cloudstack/pull/3638 |
| #3978 | https://github.com/apache/cloudstack/issues/3978 |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
|
| https://github.com/DaanHoogland |
| fixes and comments addressed | https://github.com/apache/cloudstack/pull/3983/commits/6586c63fc316fd2ad7a0510617dd0ec59c2140bf |
| 6586c63 | https://github.com/apache/cloudstack/pull/3983/commits/6586c63fc316fd2ad7a0510617dd0ec59c2140bf |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3155247974 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| 4.14.0.0 | https://github.com/apache/cloudstack/milestone/10 |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3155248512 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
|
type:bug
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Atype%3Abug |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3155249110 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
|
Mar 23, 2020
| https://github.com/apache/cloudstack/pull/3983#ref-pullrequest-507820495 |
|
UEFI Support on CloudStack
#3638
| https://github.com/apache/cloudstack/pull/3638 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
|
Mar 23, 2020
| https://github.com/apache/cloudstack/pull/3983#pullrequestreview-379513761 |
|
View reviewed changes
| https://github.com/apache/cloudstack/pull/3983/files/6586c63fc316fd2ad7a0510617dd0ec59c2140bf |
| engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java | https://github.com/apache/cloudstack/pull/3983/files/6586c63fc316fd2ad7a0510617dd0ec59c2140bf#diff-c6161dd221f494ea2570714cfa2a5e86557a8c30a79fc36e8ecfcb94a09c268a |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
|
| https://github.com/DaanHoogland |
| null check for VM params on logging | https://github.com/apache/cloudstack/pull/3983/commits/4b87885dfccc16a9f0c5c4c24707005fcebe50aa |
| 4b87885 | https://github.com/apache/cloudstack/pull/3983/commits/4b87885dfccc16a9f0c5c4c24707005fcebe50aa |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-602692011 |
| @blueorangutan | https://github.com/blueorangutan |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/apache |
| apache | https://github.com/apache |
| blueorangutan | https://github.com/blueorangutan |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3155890640 |
| https://github.com/apache |
| apache | https://github.com/apache |
| blueorangutan | https://github.com/blueorangutan |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3155890992 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-602692442 |
| @DaanHoogland | https://github.com/DaanHoogland |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-602707109 |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-602723927 |
| @blueorangutan | https://github.com/blueorangutan |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-602724482 |
| @DaanHoogland | https://github.com/DaanHoogland |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/svenvogel |
| svenvogel | https://github.com/svenvogel |
|
component:vmware
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Avmware |
| Mar 23, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3156925051 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Mar 24, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-603112382 |
| @blueorangutan | https://github.com/blueorangutan |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/apache |
| apache | https://github.com/apache |
| blueorangutan | https://github.com/blueorangutan |
| Mar 24, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3158671515 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Mar 24, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-603112860 |
| @DaanHoogland | https://github.com/DaanHoogland |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Mar 24, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-603136289 |
| @pavanaravapalli | https://github.com/pavanaravapalli |
| #3985 | https://github.com/apache/cloudstack/pull/3985 |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Mar 24, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-603414779 |
| https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3983-t1290-vmware-67u3.zip | https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3983-t1290-vmware-67u3.zip |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| 4.14.0.0 | https://github.com/apache/cloudstack/milestone/10 |
| Mar 25, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3163558859 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 7, 2020 | https://github.com/apache/cloudstack/pull/3983#issuecomment-610276568 |
| #3985 | https://github.com/apache/cloudstack/pull/3985 |
| #4021 | https://github.com/apache/cloudstack/pull/4021 |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 7, 2020 | https://github.com/apache/cloudstack/pull/3983#event-3208969429 |
| https://github.co/hiddenchars |
| https://github.com/apache/cloudstack/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F3983 |
|
| https://github.com/weizhouapache |
|
weizhouapache
| https://github.com/weizhouapache |
|
| https://github.com/apache/cloudstack/pull/3983/files/6586c63fc316fd2ad7a0510617dd0ec59c2140bf |
|
component:vmware
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Avmware |
|
type:bug
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Atype%3Abug |
| Please reload this page | https://github.com/apache/cloudstack/pull/3983 |
|
| https://github.com/DaanHoogland |
|
| https://github.com/blueorangutan |
|
| https://github.com/weizhouapache |
|
| https://github.com/svenvogel |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |