René's URL Explorer Experiment


Title: Fix checkRoleEscalation performance and bugs in access checking by nvazquez · Pull Request #12973 · apache/cloudstack · GitHub

Open Graph Title: Fix checkRoleEscalation performance and bugs in access checking by nvazquez · Pull Request #12973 · apache/cloudstack

X Title: Fix checkRoleEscalation performance and bugs in access checking by nvazquez · Pull Request #12973 · apache/cloudstack

Description: Description This PR fixes performance issues and bugs in AccountManagerImpl.checkRoleEscalation(Account, Account). Performance problem: The method iterated all ~742 API commands individually, calling checkApiAccess for each command through 2 API checkers. DynamicRoleBasedAPIAccessChecker.checkAccess(Account, String) made a redundant uncached DB call on every invocation, ignoring already-cached data from getRolePermissionsUsingCache(). Additionally, ProjectRoleBasedApiAccessChecker.checkAccess(Account, String) always returns true but was still called 742 times. Impact before fix: ~1,484 DB calls per checkRoleEscalation invocation for non-admin roles. Impact after fix: ~2 DB calls (or 0 with warm cache). Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds functionality) Bug fix (non-breaking change which fixes an issue) Enhancement (improves an existing feature and functionality) Cleanup (Code refactoring and cleanup, that may add test cases) Build/CI Test (unit or integration test code) Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale Major Minor Bug Severity BLOCKER Critical Major Minor Trivial Screenshots (if appropriate): How Has This Been Tested? How did you try to break this feature and the system with this change?

Open Graph Description: Description This PR fixes performance issues and bugs in AccountManagerImpl.checkRoleEscalation(Account, Account). Performance problem: The method iterated all ~742 API commands individually, calli...

X Description: Description This PR fixes performance issues and bugs in AccountManagerImpl.checkRoleEscalation(Account, Account). Performance problem: The method iterated all ~742 API commands individually, calli...

Opengraph URL: https://github.com/apache/cloudstack/pull/12973

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cb99f266-d519-cee9-9363-88bd322e0043
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFC8:380AD5:6B447C:91A9BA:6A4D4422
html-safe-nonce420df55fa9800656ce125fef2a3527caae92b1edfa82c823144d195a0d5bea30
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkM4OjM4MEFENTo2QjQ0N0M6OTFBOUJBOjZBNEQ0NDIyIiwidmlzaXRvcl9pZCI6Ijk3ODQ3MjMyMTUxMjQ1NzI1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac232a9526ad3f34836b0ef01bda4ee6643e2d02721d52602366d34a377223635e
hovercard-subject-tagpull_request:3498060660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/12973/files
twitter:imagehttps://avatars.githubusercontent.com/u/5295080?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5295080?s=400&v=4
og:image:altDescription This PR fixes performance issues and bugs in AccountManagerImpl.checkRoleEscalation(Account, Account). Performance problem: The method iterated all ~742 API commands individually, calli...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release56fc8347865a14e2ec811533d68f929cf4e0ec19
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/apache/cloudstack/pull/12973/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12973%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12973%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://github.com/apache/cloudstack/pull/12973/files
Reloadhttps://github.com/apache/cloudstack/pull/12973/files
Reloadhttps://github.com/apache/cloudstack/pull/12973/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/12973/files
apache https://github.com/apache
cloudstackhttps://github.com/apache/cloudstack
Notifications https://github.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Star 3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Code https://github.com/apache/cloudstack
Issues 535 https://github.com/apache/cloudstack/issues
Pull requests 267 https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality 0 https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
Code https://github.com/apache/cloudstack
Issues https://github.com/apache/cloudstack/issues
Pull requests https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fapache%2Fcloudstack%2Fissues%2Fnew%2Fchoose
nvazquezhttps://github.com/nvazquez
apache:4.22https://github.com/apache/cloudstack/tree/4.22
shapeblue:422-fix-checkroleescalation-performancehttps://github.com/shapeblue/cloudstack/tree/422-fix-checkroleescalation-performance
Conversation 11 https://github.com/apache/cloudstack/pull/12973
Commits 15 https://github.com/apache/cloudstack/pull/12973/commits
Checks 26 https://github.com/apache/cloudstack/pull/12973/checks
Files changed https://github.com/apache/cloudstack/pull/12973/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/12973/files
Fix checkRoleEscalation performance and bugs in access checking https://github.com/apache/cloudstack/pull/12973/files#top
Show all changes 15 commits https://github.com/apache/cloudstack/pull/12973/files
429c945 Fix checkRoleEscalation performance and bugs in access checking sliceofapplepie Mar 5, 2026 https://github.com/apache/cloudstack/pull/12973/commits/429c9454b1018baa5957403b0f4b25892212da6b
7055bf2 Add tests for checkRoleEscalation, checkAccess, and getApisAllowedToA… sliceofapplepie Mar 5, 2026 https://github.com/apache/cloudstack/pull/12973/commits/7055bf211a2ca3b57e5e94a696cd2866a3afe3ed
098ba06 Add debug logging exception sliceofapplepie Mar 10, 2026 https://github.com/apache/cloudstack/pull/12973/commits/098ba06e62b8defdd9b1820a5c7bdd0ad48e49d5
f84ed2a make logging vars consistent to other files sliceofapplepie Mar 11, 2026 https://github.com/apache/cloudstack/pull/12973/commits/f84ed2aadf350191c1cee89373353a192729a3eb
5996ee1 Potential fix for pull request finding sliceofapplepie Mar 19, 2026 https://github.com/apache/cloudstack/pull/12973/commits/5996ee16ecf51efaad423d012366cd86d70c84d4
d6289b6 Potential fix for pull request finding sliceofapplepie Mar 19, 2026 https://github.com/apache/cloudstack/pull/12973/commits/d6289b648ab05bc813ae8ddfad0446b180783244
5dce6fc Potential fix for pull request finding sliceofapplepie Mar 19, 2026 https://github.com/apache/cloudstack/pull/12973/commits/5dce6fc7d7f0af44daaa385abc506a696c41783d
3b5c919 Potential fix for pull request finding sliceofapplepie Mar 19, 2026 https://github.com/apache/cloudstack/pull/12973/commits/3b5c9195f887a1bb305ad1b7e6acfea89c4e2328
d0cad25 Potential fix for pull request finding sliceofapplepie Mar 19, 2026 https://github.com/apache/cloudstack/pull/12973/commits/d0cad25a5b5bc9c4ca3c8f83a99060c40d5ae719
987b3b3 fix complation and test sliceofapplepie Mar 19, 2026 https://github.com/apache/cloudstack/pull/12973/commits/987b3b3448f6d8b17b288d7d1b1b876a43684af5
8e04b15 fix mokito UnnecessaryStubbing sliceofapplepie Mar 20, 2026 https://github.com/apache/cloudstack/pull/12973/commits/8e04b154a5bb598d473c91a3cc0f632a7338e2a8
63ae895 fix cachePeriodField illegal arg sliceofapplepie Mar 20, 2026 https://github.com/apache/cloudstack/pull/12973/commits/63ae895269101486e7be90b308db67050c731ed0
4eda50e fix null test sliceofapplepie Mar 20, 2026 https://github.com/apache/cloudstack/pull/12973/commits/4eda50efa8b713aead2ffa58fd34832717c2a9ab
5b1aca4 Fix build nvazquez Apr 7, 2026 https://github.com/apache/cloudstack/pull/12973/commits/5b1aca4b4d4daa57cf1e81e0c9022954356660eb
3a3df82 Remove unnecessary stubbings nvazquez Apr 7, 2026 https://github.com/apache/cloudstack/pull/12973/commits/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0
Clear filters https://github.com/apache/cloudstack/pull/12973/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/12973/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/12973/files
APIChecker.java https://github.com/apache/cloudstack/pull/12973/files#diff-145e8e7d1310c5b00c5fd352119b0e84f2fa87a6d1aa01715cf2576500a45b85
DynamicRoleBasedAPIAccessChecker.java https://github.com/apache/cloudstack/pull/12973/files#diff-fda34b2efe234e7e6ef3017e734c3d4095eb528a1ffdab0f21f3aa745c77d3aa
DynamicRoleBasedAPIAccessCheckerTest.java https://github.com/apache/cloudstack/pull/12973/files#diff-5e0a79cd492fe0d19caac8615fb60f984241516fa8b0f2328c0e0e854aee5980
ProjectRoleBasedApiAccessChecker.java https://github.com/apache/cloudstack/pull/12973/files#diff-33b17f93be5d401446e6ad252243f8b597bad3a5ec72b3681d49faf5bc12fc87
StaticRoleBasedAPIAccessChecker.java https://github.com/apache/cloudstack/pull/12973/files#diff-15fe740c402fdef57a0275e47ae4eebae73568ddca4ef3c23036badbbfb747c8
AccountManagerImpl.java https://github.com/apache/cloudstack/pull/12973/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
AccountManagerImplTest.java https://github.com/apache/cloudstack/pull/12973/files#diff-9ee1a679f4c9f18ea68c7b9288a2cdb2b224b8cee933831a906337891c54dbb2
api/src/main/java/org/apache/cloudstack/acl/APIChecker.javahttps://github.com/apache/cloudstack/pull/12973/files#diff-145e8e7d1310c5b00c5fd352119b0e84f2fa87a6d1aa01715cf2576500a45b85
View file https://github.com/apache/cloudstack/blob/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0/api/src/main/java/org/apache/cloudstack/acl/APIChecker.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/12973/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/12973/files#diff-145e8e7d1310c5b00c5fd352119b0e84f2fa87a6d1aa01715cf2576500a45b85
https://github.com/apache/cloudstack/pull/12973/files#diff-145e8e7d1310c5b00c5fd352119b0e84f2fa87a6d1aa01715cf2576500a45b85
...-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.javahttps://github.com/apache/cloudstack/pull/12973/files#diff-fda34b2efe234e7e6ef3017e734c3d4095eb528a1ffdab0f21f3aa745c77d3aa
View file https://github.com/apache/cloudstack/blob/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0/plugins/acl/dynamic-role-based/src/main/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/12973/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/12973/files#diff-fda34b2efe234e7e6ef3017e734c3d4095eb528a1ffdab0f21f3aa745c77d3aa
https://github.com/apache/cloudstack/pull/12973/files#diff-fda34b2efe234e7e6ef3017e734c3d4095eb528a1ffdab0f21f3aa745c77d3aa
https://github.com/apache/cloudstack/pull/12973/files#diff-fda34b2efe234e7e6ef3017e734c3d4095eb528a1ffdab0f21f3aa745c77d3aa
https://github.com/apache/cloudstack/pull/12973/files#diff-fda34b2efe234e7e6ef3017e734c3d4095eb528a1ffdab0f21f3aa745c77d3aa
...e-based/src/test/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessCheckerTest.javahttps://github.com/apache/cloudstack/pull/12973/files#diff-5e0a79cd492fe0d19caac8615fb60f984241516fa8b0f2328c0e0e854aee5980
View file https://github.com/apache/cloudstack/blob/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0/plugins/acl/dynamic-role-based/src/test/java/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessCheckerTest.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/12973/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/12973/files#diff-5e0a79cd492fe0d19caac8615fb60f984241516fa8b0f2328c0e0e854aee5980
https://github.com/apache/cloudstack/pull/12973/files#diff-5e0a79cd492fe0d19caac8615fb60f984241516fa8b0f2328c0e0e854aee5980
https://github.com/apache/cloudstack/pull/12973/files#diff-5e0a79cd492fe0d19caac8615fb60f984241516fa8b0f2328c0e0e854aee5980
...-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.javahttps://github.com/apache/cloudstack/pull/12973/files#diff-33b17f93be5d401446e6ad252243f8b597bad3a5ec72b3681d49faf5bc12fc87
View file https://github.com/apache/cloudstack/blob/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0/plugins/acl/project-role-based/src/main/java/org/apache/cloudstack/acl/ProjectRoleBasedApiAccessChecker.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/12973/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/12973/files#diff-33b17f93be5d401446e6ad252243f8b597bad3a5ec72b3681d49faf5bc12fc87
https://github.com/apache/cloudstack/pull/12973/files#diff-33b17f93be5d401446e6ad252243f8b597bad3a5ec72b3681d49faf5bc12fc87
...c-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.javahttps://github.com/apache/cloudstack/pull/12973/files#diff-15fe740c402fdef57a0275e47ae4eebae73568ddca4ef3c23036badbbfb747c8
View file https://github.com/apache/cloudstack/blob/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0/plugins/acl/static-role-based/src/main/java/org/apache/cloudstack/acl/StaticRoleBasedAPIAccessChecker.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/12973/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/12973/files#diff-15fe740c402fdef57a0275e47ae4eebae73568ddca4ef3c23036badbbfb747c8
https://github.com/apache/cloudstack/pull/12973/files#diff-15fe740c402fdef57a0275e47ae4eebae73568ddca4ef3c23036badbbfb747c8
https://github.com/apache/cloudstack/pull/12973/files#diff-15fe740c402fdef57a0275e47ae4eebae73568ddca4ef3c23036badbbfb747c8
https://github.com/apache/cloudstack/pull/12973/files#diff-15fe740c402fdef57a0275e47ae4eebae73568ddca4ef3c23036badbbfb747c8
server/src/main/java/com/cloud/user/AccountManagerImpl.javahttps://github.com/apache/cloudstack/pull/12973/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
View file https://github.com/apache/cloudstack/blob/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0/server/src/main/java/com/cloud/user/AccountManagerImpl.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/apache/cloudstack/pull/12973/{{ revealButtonHref }}
https://github.com/apache/cloudstack/pull/12973/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
https://github.com/apache/cloudstack/pull/12973/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
https://github.com/apache/cloudstack/pull/12973/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
https://github.com/apache/cloudstack/pull/12973/files#diff-fdd46eb6e71ed13aa5bc82ca928751e334a0e743c1142a0201a7cba7986882ff
Please reload this pagehttps://github.com/apache/cloudstack/pull/12973/files
Please reload this pagehttps://github.com/apache/cloudstack/pull/12973/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.