René's URL Explorer Experiment


Title: Fix checkRoleEscalation performance and bugs in access checking by nvazquez · Pull Request #12973 · apache/cloudstack · GitHub

Open Graph Title: Fix checkRoleEscalation performance and bugs in access checking by nvazquez · Pull Request #12973 · apache/cloudstack

X Title: Fix checkRoleEscalation performance and bugs in access checking by nvazquez · Pull Request #12973 · apache/cloudstack

Description: Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform - Fix checkRoleEscalation performance and bugs in access checking by nvazquez · Pull Request #12973 · apache/cloudstack

Open Graph Description: Description This PR fixes performance issues and bugs in AccountManagerImpl.checkRoleEscalation(Account, Account). Performance problem: The method iterated all ~742 API commands individually, calli...

X Description: Description This PR fixes performance issues and bugs in AccountManagerImpl.checkRoleEscalation(Account, Account). Performance problem: The method iterated all ~742 API commands individually, calli...

Opengraph URL: https://github.com/apache/cloudstack/pull/12973

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:9e9073fd-5357-44ad-6cd9-d84cb65c987a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDCFC:1FD40F:67276:8CF02:6A4D2898
html-safe-nonced9aa091ff0252cda81eb2a879407502fb6a916897b3cda83f67d0f088cc96520
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQ0ZDOjFGRDQwRjo2NzI3Njo4Q0YwMjo2QTREMjg5OCIsInZpc2l0b3JfaWQiOiI4NjQwOTkwODc1NzgwNzIwNzkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3657ed771139d691002a10ece90c5d4a154690504902be1c46af26184b8b2c58
hovercard-subject-tagpull_request:3498060660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/12973/commits
twitter:imagehttps://opengraph.githubassets.com/b0637b306e9934457877ebe29845782ffd58a5558119ab49d8d12aa7503c0137/apache/cloudstack/pull/12973
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b0637b306e9934457877ebe29845782ffd58a5558119ab49d8d12aa7503c0137/apache/cloudstack/pull/12973
og:image:altDescription This PR fixes performance issues and bugs in AccountManagerImpl.checkRoleEscalation(Account, Account). Performance problem: The method iterated all ~742 API commands individually, calli...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenvazquez
hostnamegithub.com
expected-hostnamegithub.com
None92571a8944142227b7e19cd10918b1ddd06e5066c1ad5bc7e4769cf6140a87e6
turbo-cache-controlno-cache
go-importgithub.com/apache/cloudstack git https://github.com/apache/cloudstack.git
octolytics-dimension-user_id47359
octolytics-dimension-user_loginapache
octolytics-dimension-repository_id9759448
octolytics-dimension-repository_nwoapache/cloudstack
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id9759448
octolytics-dimension-repository_network_root_nwoapache/cloudstack
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release93f17a978ee60bc4668e1d7b90e6bd2d622261fd
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/apache/cloudstack/pull/12973/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12973%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F12973%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=apache%2Fcloudstack
Reloadhttps://github.com/apache/cloudstack/pull/12973/commits
Reloadhttps://github.com/apache/cloudstack/pull/12973/commits
Reloadhttps://github.com/apache/cloudstack/pull/12973/commits
Please reload this pagehttps://github.com/apache/cloudstack/pull/12973/commits
apache https://github.com/apache
cloudstackhttps://github.com/apache/cloudstack
Notifications https://github.com/login?return_to=%2Fapache%2Fcloudstack
Fork 1.3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Star 3k https://github.com/login?return_to=%2Fapache%2Fcloudstack
Code https://github.com/apache/cloudstack
Issues 535 https://github.com/apache/cloudstack/issues
Pull requests 265 https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality 0 https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
Code https://github.com/apache/cloudstack
Issues https://github.com/apache/cloudstack/issues
Pull requests https://github.com/apache/cloudstack/pulls
Discussions https://github.com/apache/cloudstack/discussions
Actions https://github.com/apache/cloudstack/actions
Projects https://github.com/apache/cloudstack/projects
Wiki https://github.com/apache/cloudstack/wiki
Security and quality https://github.com/apache/cloudstack/security
Insights https://github.com/apache/cloudstack/pulse
nvazquezhttps://github.com/nvazquez
apache:4.22https://github.com/apache/cloudstack/tree/4.22
shapeblue:422-fix-checkroleescalation-performancehttps://github.com/shapeblue/cloudstack/tree/422-fix-checkroleescalation-performance
Conversationhttps://github.com/apache/cloudstack/pull/12973
Commits15 (15)https://github.com/apache/cloudstack/pull/12973/commits
Checkshttps://github.com/apache/cloudstack/pull/12973/checks
Files changedhttps://github.com/apache/cloudstack/pull/12973/files
Fix checkRoleEscalation performance and bugs in access checkinghttps://github.com/apache/cloudstack/pull/12973/commits#top
nvazquezhttps://github.com/nvazquez
apache:4.22https://github.com/apache/cloudstack/tree/4.22
shapeblue:422-fix-checkroleescalation-performancehttps://github.com/shapeblue/cloudstack/tree/422-fix-checkroleescalation-performance
Fix checkRoleEscalation performance and bugs in access checkinghttps://github.com/apache/cloudstack/pull/12973/commits/429c9454b1018baa5957403b0f4b25892212da6b
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
429c945https://github.com/apache/cloudstack/pull/12973/commits/429c9454b1018baa5957403b0f4b25892212da6b
https://github.com/apache/cloudstack/tree/429c9454b1018baa5957403b0f4b25892212da6b
Add tests for checkRoleEscalation, checkAccess, and getApisAllowedToAccounthttps://github.com/apache/cloudstack/pull/12973/commits/7055bf211a2ca3b57e5e94a696cd2866a3afe3ed
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
7055bf2https://github.com/apache/cloudstack/pull/12973/commits/7055bf211a2ca3b57e5e94a696cd2866a3afe3ed
https://github.com/apache/cloudstack/tree/7055bf211a2ca3b57e5e94a696cd2866a3afe3ed
Add debug logging exceptionhttps://github.com/apache/cloudstack/pull/12973/commits/098ba06e62b8defdd9b1820a5c7bdd0ad48e49d5
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
098ba06https://github.com/apache/cloudstack/pull/12973/commits/098ba06e62b8defdd9b1820a5c7bdd0ad48e49d5
https://github.com/apache/cloudstack/tree/098ba06e62b8defdd9b1820a5c7bdd0ad48e49d5
make logging vars consistent to other fileshttps://github.com/apache/cloudstack/pull/12973/commits/f84ed2aadf350191c1cee89373353a192729a3eb
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
f84ed2ahttps://github.com/apache/cloudstack/pull/12973/commits/f84ed2aadf350191c1cee89373353a192729a3eb
https://github.com/apache/cloudstack/tree/f84ed2aadf350191c1cee89373353a192729a3eb
Potential fix for pull request findinghttps://github.com/apache/cloudstack/pull/12973/commits/5996ee16ecf51efaad423d012366cd86d70c84d4
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
5996ee1https://github.com/apache/cloudstack/pull/12973/commits/5996ee16ecf51efaad423d012366cd86d70c84d4
https://github.com/apache/cloudstack/tree/5996ee16ecf51efaad423d012366cd86d70c84d4
Potential fix for pull request findinghttps://github.com/apache/cloudstack/pull/12973/commits/d6289b648ab05bc813ae8ddfad0446b180783244
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
d6289b6https://github.com/apache/cloudstack/pull/12973/commits/d6289b648ab05bc813ae8ddfad0446b180783244
https://github.com/apache/cloudstack/tree/d6289b648ab05bc813ae8ddfad0446b180783244
Potential fix for pull request findinghttps://github.com/apache/cloudstack/pull/12973/commits/5dce6fc7d7f0af44daaa385abc506a696c41783d
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
5dce6fchttps://github.com/apache/cloudstack/pull/12973/commits/5dce6fc7d7f0af44daaa385abc506a696c41783d
https://github.com/apache/cloudstack/tree/5dce6fc7d7f0af44daaa385abc506a696c41783d
Potential fix for pull request findinghttps://github.com/apache/cloudstack/pull/12973/commits/3b5c9195f887a1bb305ad1b7e6acfea89c4e2328
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
3b5c919https://github.com/apache/cloudstack/pull/12973/commits/3b5c9195f887a1bb305ad1b7e6acfea89c4e2328
https://github.com/apache/cloudstack/tree/3b5c9195f887a1bb305ad1b7e6acfea89c4e2328
Potential fix for pull request findinghttps://github.com/apache/cloudstack/pull/12973/commits/d0cad25a5b5bc9c4ca3c8f83a99060c40d5ae719
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
d0cad25https://github.com/apache/cloudstack/pull/12973/commits/d0cad25a5b5bc9c4ca3c8f83a99060c40d5ae719
https://github.com/apache/cloudstack/tree/d0cad25a5b5bc9c4ca3c8f83a99060c40d5ae719
fix complation and testhttps://github.com/apache/cloudstack/pull/12973/commits/987b3b3448f6d8b17b288d7d1b1b876a43684af5
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
987b3b3https://github.com/apache/cloudstack/pull/12973/commits/987b3b3448f6d8b17b288d7d1b1b876a43684af5
https://github.com/apache/cloudstack/tree/987b3b3448f6d8b17b288d7d1b1b876a43684af5
fix mokito UnnecessaryStubbinghttps://github.com/apache/cloudstack/pull/12973/commits/8e04b154a5bb598d473c91a3cc0f632a7338e2a8
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
8e04b15https://github.com/apache/cloudstack/pull/12973/commits/8e04b154a5bb598d473c91a3cc0f632a7338e2a8
https://github.com/apache/cloudstack/tree/8e04b154a5bb598d473c91a3cc0f632a7338e2a8
fix cachePeriodField illegal arghttps://github.com/apache/cloudstack/pull/12973/commits/63ae895269101486e7be90b308db67050c731ed0
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
63ae895https://github.com/apache/cloudstack/pull/12973/commits/63ae895269101486e7be90b308db67050c731ed0
https://github.com/apache/cloudstack/tree/63ae895269101486e7be90b308db67050c731ed0
fix null testhttps://github.com/apache/cloudstack/pull/12973/commits/4eda50efa8b713aead2ffa58fd34832717c2a9ab
sliceofapplepiehttps://github.com/apache/cloudstack/commits?author=sliceofapplepie
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
4eda50ehttps://github.com/apache/cloudstack/pull/12973/commits/4eda50efa8b713aead2ffa58fd34832717c2a9ab
https://github.com/apache/cloudstack/tree/4eda50efa8b713aead2ffa58fd34832717c2a9ab
Fix buildhttps://github.com/apache/cloudstack/pull/12973/commits/5b1aca4b4d4daa57cf1e81e0c9022954356660eb
https://github.com/nvazquez
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
5b1aca4https://github.com/apache/cloudstack/pull/12973/commits/5b1aca4b4d4daa57cf1e81e0c9022954356660eb
https://github.com/apache/cloudstack/tree/5b1aca4b4d4daa57cf1e81e0c9022954356660eb
Remove unnecessary stubbingshttps://github.com/apache/cloudstack/pull/12973/commits/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0
https://github.com/nvazquez
nvazquezhttps://github.com/apache/cloudstack/commits?author=nvazquez
3a3df82https://github.com/apache/cloudstack/pull/12973/commits/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0
https://github.com/apache/cloudstack/tree/3a3df829a9afe23cf944ae9ca7bce0ff065e5db0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.