René's URL Explorer Experiment

Title: Add ROOT CAs to the trust store and allow force provisioning of certs hosts & systemVMs via ssh by vishesh92 · Pull Request #12911 · apache/cloudstack · GitHub

Open Graph Title: Add ROOT CAs to the trust store and allow force provisioning of certs hosts & systemVMs via ssh by vishesh92 · Pull Request #12911 · apache/cloudstack

X Title: Add ROOT CAs to the trust store and allow force provisioning of certs hosts & systemVMs via ssh by vishesh92 · Pull Request #12911 · apache/cloudstack

Description: Description This PR adds ROOT CAs to the trust store in System VMs & the management This PR also adds another parameter forced to provisionCertificate command which allows provisioning certs via SSH to KVM hosts & system VMs. Doc PR: apache/cloudstack-documentation#641 Details This pull request introduces several improvements and new features to the CloudStack Certificate Authority (CA) management system, with a focus on enhancing certificate provisioning flexibility, supporting user-provided CA material, and improving truststore management. The most significant changes add support for forced certificate re-provisioning via SSH for disconnected agents, clarify and enforce requirements for custom CA keys, and enable automatic truststore injection for outgoing HTTPS connections. Certificate Provisioning Enhancements: Added a forced boolean parameter to the ProvisionCertificateCmd API and the CAManager.provisionCertificate method, allowing administrators to re-provision agent certificates via SSH when agents are disconnected (e.g., after a CA change). This is supported for KVM hosts and SystemVMs. The implementation includes a new provisionCertificateViaSsh method for KVM hosts. [1] [2] [3] [4] [5] [6] CA Provider and Configuration Improvements: Expanded and clarified configuration key documentation for user-provided CA material in the RootCAProvider, including PEM format requirements and the need to set all three keys together. Enhanced error handling and logging when loading user-provided CA keys/certificates fails, with fallback to auto-generation. [1] [2] Improved the description of the ca.framework.provider.plugin configuration key to clarify its purpose and the requirements for custom CA material. Truststore Management: Introduced a new configuration key ca.framework.inject.default.truststore to control whether the CA provider's certificate is injected into the JVM default truststore on management server startup, enabling outgoing HTTPS connections from the management server to trust servers signed by the configured CA. Updated the keystore-cert-import script to also import the CA certificate into the realhostip.keystore used by the SSVM JVM, ensuring trust for CloudStack CA-signed servers. Script and Utility Fixes: Improved the keystore-cert-import script to handle certificate splitting and file cleanup more robustly, preventing errors if no certificates are present. Code Cleanup: Removed unused imports and code from LibvirtServerDiscoverer and related classes as part of the refactoring for SSH-based certificate provisioning. [1] [2] [3] [4] [5] [6] [7] These changes collectively improve CloudStack's certificate management flexibility, security, and ease of integration with external CA infrastructures. Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds functionality) Bug fix (non-breaking change which fixes an issue) Enhancement (improves an existing feature and functionality) Cleanup (Code refactoring and cleanup, that may add test cases) Build/CI Test (unit or integration test code) Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale Major Minor Bug Severity BLOCKER Critical Major Minor Trivial Screenshots (if appropriate): How Has This Been Tested? Generate custom CA and generate server certificates using it Setup nginx to serve template files over https using the above certs Try to register the template (both direct-download & non-direct-download) from the nginx via HTTPS. It will fail due to invalid certs. update the cloudstack configuration cmk update configuration name=ca.plugin.root.private.key value="$(cat private-key.key)" cmk update configuration name=ca.plugin.root.public.key value="$(cat public-key.pub)" cmk update configuration name=ca.plugin.root.ca.certificate value="$(cat ca-chain.crt)" Restart cloudstack management server systemctl restart cloudstack-management SystemVMs & cloudstack-agent with KVM stop working after this. Force provision certs to update certs on hosts & systemVMs. Console proxy will stop working on existing running VMs. They will require a stop & start for the console proxy to work. Try to register the template again. How did you try to break this feature and the system with this change?

Open Graph Description: Description This PR adds ROOT CAs to the trust store in System VMs & the management This PR also adds another parameter forced to provisionCertificate command which allows provisioning certs vi...

X Description: Description This PR adds ROOT CAs to the trust store in System VMs & the management This PR also adds another parameter forced to provisionCertificate command which allows provisioning cert...

Opengraph URL: https://github.com/apache/cloudstack/pull/12911

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width