Title: Add offering preset variables for `Network` and `VPC` Quota tariffs by hsato03 · Pull Request #11810 · apache/cloudstack · GitHub
Open Graph Title: Add offering preset variables for `Network` and `VPC` Quota tariffs by hsato03 · Pull Request #11810 · apache/cloudstack
X Title: Add offering preset variables for `Network` and `VPC` Quota tariffs by hsato03 · Pull Request #11810 · apache/cloudstack
Description: Description This PR adds two new preset variables for Network and VPC usage type Quota tariffs. For Network tariffs, the variables value.networkOffering.id and value.networkOffering.name have been created. For VPC tariffs, the variables value.vpcOffering.id and value.vpcOffering.name have been added. They represent the resource's offering ID and name, respectively. Types of changes Breaking change (fix or feature that would cause existing functionality to change) New feature (non-breaking change which adds functionality) Bug fix (non-breaking change which fixes an issue) Enhancement (improves an existing feature and functionality) Cleanup (Code refactoring and cleanup, that may add test cases) Build/CI Test (unit or integration test code) Feature/Enhancement Scale or Bug Severity Feature/Enhancement Scale Major Minor Bug Severity BLOCKER Critical Major Minor Trivial Screenshots (if appropriate): How Has This Been Tested? I created an isolated network and a VPC with the following offerings. Offering ID Name Network 30b8c61a-f75a-4b65-8ff3-52a20b179333 DefaultIsolatedNetworkOfferingWithSourceNatService VPC 2128acd0-9753-4e2a-8c99-2815da566873 Default VPC offering Then, I created a Network tariff (offering-test-network) with the following activation rule. if (value.networkOffering.id === '30b8c61a-f75a-4b65-8ff3-52a20b179333 && value.networkOffering.name === 'DefaultIsolatedNetworkOfferingWithSourceNatService') { 300 } else { 0 } Next, I created a VPC tariff (offering-test-vpc) with the following activation rule. if (value.vpcOffering.id === '2128acd0-9753-4e2a-8c99-2815da566873 && value.vpcOffering.name === 'Default VPC offering') { 500 } else { 0 } I called the quotaUpdate API and verified that the value 300 was returned by the offering-test-network activation rule, while offering-test-vpc returned 500. How did you try to break this feature and the system with this change?
Open Graph Description: Description This PR adds two new preset variables for Network and VPC usage type Quota tariffs. For Network tariffs, the variables value.networkOffering.id and value.networkOffering.name have been...
X Description: Description This PR adds two new preset variables for Network and VPC usage type Quota tariffs. For Network tariffs, the variables value.networkOffering.id and value.networkOffering.name have been...
Opengraph URL: https://github.com/apache/cloudstack/pull/11810
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:084b26ab-f0e5-d98c-998f-8ef6c3e0e283 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BE7A:1E0BA3:34F7073:463802E:6A6557C8 |
| html-safe-nonce | 4c1f68ffd80149157c0010dfc075f72604de30d39985cfd67f209dd10cf8919e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTdBOjFFMEJBMzozNEY3MDczOjQ2MzgwMkU6NkE2NTU3QzgiLCJ2aXNpdG9yX2lkIjoiNzk2NjU3OTM0ODQzNDQwOTQxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 85498db7c4ffa4ec3f82be131fabbbaad42b99d8d6e44df2b7709a7ecc34288e |
| hovercard-subject-tag | pull_request:2898820836 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/apache/cloudstack/pull/11810/commits/61715c42b39ef2ff919bf9311174fe90507ad0f9 |
| twitter:image | https://avatars.githubusercontent.com/u/39202678?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/39202678?s=400&v=4 |
| og:image:alt | Description This PR adds two new preset variables for Network and VPC usage type Quota tariffs. For Network tariffs, the variables value.networkOffering.id and value.networkOffering.name have been... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/apache/cloudstack git https://github.com/apache/cloudstack.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 9759448 |
| octolytics-dimension-repository_nwo | apache/cloudstack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9759448 |
| octolytics-dimension-repository_network_root_nwo | apache/cloudstack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width