| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a09e8727-072f-302d-2bbf-0c5ba43c77c3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF1C:28E279:A6925F5:A9E2ED7:6A50A1E8 |
| html-safe-nonce | 6863cbd45a3462fd7533aa9bbf6b8b72175c5d22aa67f41004fbfd4764c0ea86 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjFDOjI4RTI3OTpBNjkyNUY1OkE5RTJFRDc6NkE1MEExRTgiLCJ2aXNpdG9yX2lkIjoiNjYyOTkwMTQxNjQ0NjQ0ODQwIiwicmVnaW9uX2VkZ2UiOiJzZWEiLCJyZWdpb25fcmVuZGVyIjoic2VhIn0= |
| visitor-hmac | 997bebbdcb826701ed0e786bd43c78f70b0aab7f44bd5db0e548cc70e2fd1f7b |
| hovercard-subject-tag | pull_request:2457013210 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/apache/cloudstack/10704/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a0a8c6bbea8e6d79a241cc95c1c66cc34608d44c32ffc6954b85531568edc6ca/apache/cloudstack/pull/10704 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a0a8c6bbea8e6d79a241cc95c1c66cc34608d44c32ffc6954b85531568edc6ca/apache/cloudstack/pull/10704 |
| og:image:alt | Description
This PR...
Fixes: #10664
Types of changes
Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds func... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DaanHoogland |
| hostname | github.com |
| expected-hostname | github.com |
| None | d6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb |
| turbo-cache-control | no-cache |
| go-import | github.com/apache/cloudstack git https://github.com/apache/cloudstack.git |
| octolytics-dimension-user_id | 47359 |
| octolytics-dimension-user_login | apache |
| octolytics-dimension-repository_id | 9759448 |
| octolytics-dimension-repository_nwo | apache/cloudstack |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 9759448 |
| octolytics-dimension-repository_network_root_nwo | apache/cloudstack |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/apache/cloudstack/pull/10704#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F10704 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F10704 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=apache%2Fcloudstack |
| Reload | https://github.com/apache/cloudstack/pull/10704 |
| Reload | https://github.com/apache/cloudstack/pull/10704 |
| Reload | https://github.com/apache/cloudstack/pull/10704 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
|
apache
| https://github.com/apache |
| cloudstack | https://github.com/apache/cloudstack |
|
Notifications
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Fork
1.3k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Star
3k
| https://github.com/login?return_to=%2Fapache%2Fcloudstack |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
538
| https://github.com/apache/cloudstack/issues |
|
Pull requests
261
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security and quality
0
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
|
Code
| https://github.com/apache/cloudstack |
|
Issues
| https://github.com/apache/cloudstack/issues |
|
Pull requests
| https://github.com/apache/cloudstack/pulls |
|
Discussions
| https://github.com/apache/cloudstack/discussions |
|
Actions
| https://github.com/apache/cloudstack/actions |
|
Projects
| https://github.com/apache/cloudstack/projects |
|
Wiki
| https://github.com/apache/cloudstack/wiki |
|
Security and quality
| https://github.com/apache/cloudstack/security |
|
Insights
| https://github.com/apache/cloudstack/pulse |
| weizhouapache | https://github.com/weizhouapache |
| apache:4.19 | https://github.com/apache/cloudstack/tree/4.19 |
| shapeblue:ghi10664-specifySharedVlan | https://github.com/shapeblue/cloudstack/tree/ghi10664-specifySharedVlan |
| Conversation | https://github.com/apache/cloudstack/pull/10704 |
| Commits1 (1) | https://github.com/apache/cloudstack/pull/10704/commits |
| Checks | https://github.com/apache/cloudstack/pull/10704/checks |
| Files changed | https://github.com/apache/cloudstack/pull/10704/files |
| server: check startip and startipv6 of shared network | https://github.com/apache/cloudstack/pull/10704#top |
| weizhouapache | https://github.com/weizhouapache |
| apache:4.19 | https://github.com/apache/cloudstack/tree/4.19 |
| shapeblue:ghi10664-specifySharedVlan | https://github.com/shapeblue/cloudstack/tree/ghi10664-specifySharedVlan |
|
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 14, 2025 | https://github.com/apache/cloudstack/pull/10704#issue-2992347331 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| #10664 | https://github.com/apache/cloudstack/issues/10664 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/apps/boring-cyborg |
| boring-cyborg | https://github.com/apps/boring-cyborg |
|
component:networking
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Anetworking |
| Apr 14, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17244658483 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 14, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2800922926 |
| @blueorangutan | https://github.com/blueorangutan |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Apr 14, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2800924553 |
| @DaanHoogland | https://github.com/DaanHoogland |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/apps/codecov |
| codecov | https://github.com/apps/codecov |
| Apr 14, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2800946507 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| Codecov | https://app.codecov.io/gh/apache/cloudstack/pull/10704?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| (99ea77d) | https://app.codecov.io/gh/apache/cloudstack/commit/99ea77dc83901fd88db4e1fcb2f7623bd343b5b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| (9c78d22) | https://app.codecov.io/gh/apache/cloudstack/commit/9c78d224c112f243b37a40448ffe6e3d4a24cf09?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Files with missing lines | https://app.codecov.io/gh/apache/cloudstack/pull/10704?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| ...ain/java/com/cloud/network/NetworkServiceImpl.java | https://app.codecov.io/gh/apache/cloudstack/pull/10704?src=pr&el=tree&filepath=server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fcloud%2Fnetwork%2FNetworkServiceImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL25ldHdvcmsvTmV0d29ya1NlcnZpY2VJbXBsLmphdmE= |
| 6 Missing and 1 partial ⚠️ | https://app.codecov.io/gh/apache/cloudstack/pull/10704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Flag | https://app.codecov.io/gh/apache/cloudstack/pull/10704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| uitests | https://app.codecov.io/gh/apache/cloudstack/pull/10704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| unittests | https://app.codecov.io/gh/apache/cloudstack/pull/10704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Click here | https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment |
| ☔ View full report in Codecov by Sentry | https://app.codecov.io/gh/apache/cloudstack/pull/10704?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Share it here | https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Apr 14, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2801115388 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
|
| https://github.com/DaanHoogland |
| remove condition for associated network when !specifyvlan in shared n… | https://github.com/apache/cloudstack/pull/10704/commits/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| 9c78d22 | https://github.com/apache/cloudstack/pull/10704/commits/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| apache#10168 | https://github.com/apache/cloudstack/pull/10168 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| force-pushed | https://github.com/apache/cloudstack/compare/e178089599f552fe6e764db589d2ec275dfd782e..9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| e178089 | https://github.com/apache/cloudstack/commit/e178089599f552fe6e764db589d2ec275dfd782e |
| 9c78d22 | https://github.com/apache/cloudstack/commit/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
|
Compare
| https://github.com/apache/cloudstack/compare/e178089599f552fe6e764db589d2ec275dfd782e..9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| April 14, 2025 09:56 | https://github.com/apache/cloudstack/pull/10704#event-17245838689 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Apr 14, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2801397122 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 15, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2804586915 |
| @weizhouapache | https://github.com/weizhouapache |
| #10114 | https://github.com/apache/cloudstack/issues/10114 |
| https://private-user-images.githubusercontent.com/2486961/433790523-dadef2f5-d3b4-445a-b285-a00496ca6381.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODM2Njk1MjUsIm5iZiI6MTc4MzY2OTIyNSwicGF0aCI6Ii8yNDg2OTYxLzQzMzc5MDUyMy1kYWRlZjJmNS1kM2I0LTQ0NWEtYjI4NS1hMDA0OTZjYTYzODEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA3MTBUMDc0MDI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODA2YjlkMTQ5YmU1YTNkNmQ4NzI1ODcxMzg0Mjc5NGU4ODI0ZTlhYmM4YjljZDIyMTJmYmQ4MzlkNGZlN2E5NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.hio6RnJ92deEao0wmXeS08ir--PN_lSMhUklYTxw29U |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| April 15, 2025 10:27 | https://github.com/apache/cloudstack/pull/10704#event-17266612043 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
| Apr 15, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2804651340 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| @weizhouapache | https://github.com/weizhouapache |
| #10114 | https://github.com/apache/cloudstack/issues/10114 |
| https://private-user-images.githubusercontent.com/2486961/433790523-dadef2f5-d3b4-445a-b285-a00496ca6381.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3ODM2Njk1MjUsIm5iZiI6MTc4MzY2OTIyNSwicGF0aCI6Ii8yNDg2OTYxLzQzMzc5MDUyMy1kYWRlZjJmNS1kM2I0LTQ0NWEtYjI4NS1hMDA0OTZjYTYzODEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI2MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNjA3MTBUMDc0MDI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODA2YjlkMTQ5YmU1YTNkNmQ4NzI1ODcxMzg0Mjc5NGU4ODI0ZTlhYmM4YjljZDIyMTJmYmQ4MzlkNGZlN2E5NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmcmVzcG9uc2UtY29udGVudC10eXBlPWltYWdlJTJGcG5nIn0.hio6RnJ92deEao0wmXeS08ir--PN_lSMhUklYTxw29U |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
|
Apr 15, 2025
| https://github.com/apache/cloudstack/pull/10704#pullrequestreview-2768063191 |
|
View reviewed changes
| https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| server/src/main/java/com/cloud/network/NetworkServiceImpl.java | https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09#diff-7bfbe70cf2ad3958f1fecdd618c55d20a93890ed559386e00c76c72e3ce00cd7 |
| weizhouapache | https://github.com/weizhouapache |
| Apr 15, 2025 | https://github.com/apache/cloudstack/pull/10704#discussion_r2044411425 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| cloudstack/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java | https://github.com/apache/cloudstack/blob/b2b2218a8abf750c92a31bd89078d96b5c65159e/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java#L6720-L6730 |
| b2b2218 | https://github.com/apache/cloudstack/commit/b2b2218a8abf750c92a31bd89078d96b5c65159e |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 15, 2025 | https://github.com/apache/cloudstack/pull/10704#discussion_r2044434761 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
|
Apr 15, 2025
| https://github.com/apache/cloudstack/pull/10704#pullrequestreview-2768075222 |
|
View reviewed changes
| https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| weizhouapache | https://github.com/weizhouapache |
| https://github.com/apache/cloudstack/pull/10704#pullrequestreview-2768075222 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #10114 | https://github.com/apache/cloudstack/issues/10114 |
| #10664 | https://github.com/apache/cloudstack/issues/10664 |
| #10114 | https://github.com/apache/cloudstack/issues/10114 |
| #10114 | https://github.com/apache/cloudstack/issues/10114 |
| #10664 | https://github.com/apache/cloudstack/issues/10664 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
|
status:needs-testing
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Astatus%3Aneeds-testing |
| Apr 15, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17268540511 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 15, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17272126347 |
|
Creating Shared Network is failing when using specifyVlan is false
#10664
| https://github.com/apache/cloudstack/issues/10664 |
| https://github.com/blueorangutan |
| blueorangutan | https://github.com/blueorangutan |
| Apr 16, 2025 | https://github.com/apache/cloudstack/pull/10704#issuecomment-2807921204 |
| https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10704-t12995-kvm-ol8.zip | https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10704-t12995-kvm-ol8.zip |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
| Apr 16, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17283057563 |
| https://github.com/vladimirpetrov |
| vladimirpetrov | https://github.com/vladimirpetrov |
| Apr 16, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17285409383 |
| https://github.com/vladimirpetrov |
| vladimirpetrov | https://github.com/vladimirpetrov |
|
Apr 16, 2025
| https://github.com/apache/cloudstack/pull/10704#pullrequestreview-2772916235 |
|
View reviewed changes
| https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| vladimirpetrov | https://github.com/vladimirpetrov |
| https://github.com/apache/cloudstack/pull/10704#pullrequestreview-2772916235 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/vladimirpetrov |
| vladimirpetrov | https://github.com/vladimirpetrov |
|
status:needs-testing
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Astatus%3Aneeds-testing |
| Apr 16, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17291242478 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
| 53d3d19 | https://github.com/apache/cloudstack/commit/53d3d19606bcf332753f4b51b31b851fe53cbd66 |
| Apr 16, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17291408374 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
|
Apr 16, 2025
| https://github.com/apache/cloudstack/pull/10704#ref-issue-2974830207 |
|
Creating Shared Network is failing when using specifyVlan is false
#10664
| https://github.com/apache/cloudstack/issues/10664 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
| April 17, 2025 06:56 | https://github.com/apache/cloudstack/pull/10704#event-17301028265 |
| https://github.com/DaanHoogland |
| DaanHoogland | https://github.com/DaanHoogland |
|
Apr 17, 2025
| https://github.com/apache/cloudstack/pull/10704#pullrequestreview-2774836877 |
|
View reviewed changes
| https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
| server/src/main/java/com/cloud/network/NetworkServiceImpl.java | https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09#diff-7bfbe70cf2ad3958f1fecdd618c55d20a93890ed559386e00c76c72e3ce00cd7 |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 17, 2025 | https://github.com/apache/cloudstack/pull/10704#discussion_r2048392976 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @wido | https://github.com/wido |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| wido | https://github.com/wido |
| Apr 17, 2025 | https://github.com/apache/cloudstack/pull/10704#discussion_r2048540857 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 17, 2025 | https://github.com/apache/cloudstack/pull/10704#discussion_r2048589314 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @wido | https://github.com/wido |
| @weizhouapache | https://github.com/weizhouapache |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| weizhouapache | https://github.com/weizhouapache |
| Apr 17, 2025 | https://github.com/apache/cloudstack/pull/10704#discussion_r2048656920 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| DaanHoogland | https://github.com/DaanHoogland |
| Apr 18, 2025 | https://github.com/apache/cloudstack/pull/10704#discussion_r2050578937 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #10746 | https://github.com/apache/cloudstack/pull/10746 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
| https://github.com/weizhouapache |
| weizhouapache | https://github.com/weizhouapache |
| Apr 17, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17301481845 |
| https://github.com/Pearl1594 |
| Pearl1594 | https://github.com/Pearl1594 |
| 4.19.3 | https://github.com/apache/cloudstack/milestone/38 |
| May 1, 2025 | https://github.com/apache/cloudstack/pull/10704#event-17486265221 |
| dhslove | https://github.com/dhslove |
|
Jun 19, 2025
| https://github.com/apache/cloudstack/pull/10704#ref-commit-7d84ead |
|
| https://github.com/DaanHoogland |
|
| https://github.com/dhslove |
| server: check startip and endip of shared network ( | https://github.com/ablecloud-team/ablestack-cloud/commit/7d84ead16bb7804576cfad603009080a5ee13425 |
| apache#10704 | https://github.com/apache/cloudstack/pull/10704 |
| ) | https://github.com/ablecloud-team/ablestack-cloud/commit/7d84ead16bb7804576cfad603009080a5ee13425 |
| 7d84ead | https://github.com/ablecloud-team/ablestack-cloud/commit/7d84ead16bb7804576cfad603009080a5ee13425 |
| apache#10168 | https://github.com/apache/cloudstack/pull/10168 |
| https://github.co/hiddenchars |
| https://github.com/apache/cloudstack/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fapache%2Fcloudstack%2Fpull%2F10704 |
|
| https://github.com/wido |
|
wido
| https://github.com/wido |
|
| https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
|
| https://github.com/weizhouapache |
|
weizhouapache
| https://github.com/weizhouapache |
|
| https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
|
| https://github.com/vladimirpetrov |
|
vladimirpetrov
| https://github.com/vladimirpetrov |
|
| https://github.com/apache/cloudstack/pull/10704/files/9c78d224c112f243b37a40448ffe6e3d4a24cf09 |
|
| https://github.com/vladimirpetrov |
|
vladimirpetrov
| https://github.com/vladimirpetrov |
|
component:networking
| https://github.com/apache/cloudstack/issues?q=state%3Aopen%20label%3Acomponent%3Anetworking |
|
4.19.3
| https://github.com/apache/cloudstack/milestone/38 |
|
Creating Shared Network is failing when using specifyVlan is false
| https://github.com/apache/cloudstack/issues/10664 |
| Please reload this page | https://github.com/apache/cloudstack/pull/10704 |
|
| https://github.com/DaanHoogland |
|
| https://github.com/blueorangutan |
|
| https://github.com/weizhouapache |
|
| https://github.com/wido |
|
| https://github.com/vladimirpetrov |
|
| https://github.com/Pearl1594 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |