René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Maintenance mode destination nullpointer with local storage data disk","articleBody":"\u003c!--\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release and main branch are affected too.\r\nAlways add information AFTER of these HTML comments, but no need to delete the comments.\r\n--\u003e\r\n\r\n##### ISSUE TYPE\r\n\u003c!-- Pick one below and delete the rest --\u003e\r\n * Bug Report\r\n\r\n##### COMPONENT NAME\r\n\u003c!--\r\nCategorize the issue, e.g. API, VR, VPN, UI, etc.\r\n--\u003e\r\n~~~\r\nMaintenance Mode\r\n~~~\r\n\r\n##### CLOUDSTACK VERSION\r\n\u003c!--\r\nNew line separated list of affected versions, commit ID for issues on main branch.\r\n--\u003e\r\n\r\n~~~\r\n4.19.1.2\r\n~~~\r\n\r\n##### CONFIGURATION\r\n\u003c!--\r\nInformation about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise\r\n--\u003e\r\n~~~\r\nhost.maintenance.local.storage.strategy: Migration\r\n~~~\r\n\r\n##### OS / ENVIRONMENT\r\n\u003c!--\r\nInformation about the environment if relevant, N/A otherwise\r\n--\u003e\r\n\r\n\r\n##### SUMMARY\r\n\u003c!-- Explain the problem/feature briefly --\u003e\r\nNullpointer exception when setting a host in maintenance if the host has a running vm with a local storage data disk.\r\n\r\nFound the bug while fixing another bug where the host going into maintenance is not avoided so maintenance for local storage vms can fail.\r\nDuring testing I did not find a path in the current version to reach the breaking code without a debugger attached.\r\n\r\nBug is caused by the deployment returning `null` causing a nullpointer in https://github.com/apache/cloudstack/blob/18fe4226cecc930ec0b39c43e5b63a48c17c2ad4/server/src/main/java/com/cloud/resource/ResourceManagerImpl.java#L1471\r\n\r\nDeployment returns null as the only suitable storage pool returned by `findSuitablePoolsForVolumes` in `server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java` for the data disk is the host the data disk is located on.  (Only applies for data disk, for a local storage root disk all suitable storage pools are evaluated). With that host being avoided to prepare it for maintenance the deployment planner has no suitable hosts returning null.\r\n\r\nMigrating the vm using the ui does not cause issues.\r\n\r\n##### STEPS TO REPRODUCE\r\n\u003c!--\r\nFor bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.\r\n\r\nFor new features, show how the feature would be used.\r\n--\u003e\r\n* Create a vm with a local storage data disk.\r\n* Add breakpoint at the start of https://github.com/apache/cloudstack/blob/18fe4226cecc930ec0b39c43e5b63a48c17c2ad4/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java#L300\r\n* Set host with the vm in maintenance\r\n* Add the host going into maintenance to the avoids `avoids.addHost();`\r\n* Continue running\r\n\r\n\u003c!-- Paste example playbooks or commands between quotes below --\u003e\r\n\r\n\r\n\u003c!-- You can also paste gist.github.com links for larger files --\u003e\r\n\r\n##### EXPECTED RESULTS\r\n\u003c!-- What did you expect to happen when running the steps above? --\u003e\r\nVM migrated and host going into maintenance\r\n\r\n##### ACTUAL RESULTS\r\n\u003c!-- What actually happened? --\u003e\r\n\r\n\u003c!-- Paste verbatim command output between quotes below --\u003e\r\n~~~\r\n2024-11-01 16:04:39,428 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-5:ctx-b739d4ae job-371) (logid:51494050) Unexpected exception while executing org.apache.cloudstack.api.command.\r\nadmin.host.PrepareForMaintenanceCmd\r\njava.lang.NullPointerException\r\n        at com.cloud.resource.ResourceManagerImpl.migrateAwayVmWithVolumes(ResourceManagerImpl.java:1471)\r\n        at com.cloud.resource.ResourceManagerImpl.doMaintain(ResourceManagerImpl.java:1403)\r\n        at com.cloud.resource.ResourceManagerImpl.maintain(ResourceManagerImpl.java:1489)\r\n        at com.cloud.resource.ResourceManagerImpl.maintain(ResourceManagerImpl.java:1543)\r\n        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n        at java.base/java.lang.reflect.Method.invoke(Method.java:566)\r\n        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)\r\n        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)\r\n        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)\r\n        at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)\r\n        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)\r\n        at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)\r\n        at com.sun.proxy.$Proxy200.maintain(Unknown Source)\r\n        at org.apache.cloudstack.api.command.admin.host.PrepareForMaintenanceCmd.execute(PrepareForMaintenanceCmd.java:101)\r\n        at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:172)\r\n        at com.cloud.api.ApiAsyncJobDispatcher.runJob(ApiAsyncJobDispatcher.java:112)\r\n        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.runInContext(AsyncJobManagerImpl.java:654)\r\n        at org.apache.cloudstack.managed.context.ManagedContextRunnable$1.run(ManagedContextRunnable.java:48)\r\n        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)\r\n        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)\r\n        at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)\r\n        at org.apache.cloudstack.managed.context.ManagedContextRunnable.run(ManagedContextRunnable.java:45)\r\n        at org.apache.cloudstack.framework.jobs.impl.AsyncJobManagerImpl$5.run(AsyncJobManagerImpl.java:602)\r\n        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)\r\n        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)\r\n        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)\r\n        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)\r\n        at java.base/java.lang.Thread.run(Thread.java:829)\r\n\r\n~~~\r\n\r\n","author":{"url":"https://github.com/BartJM","@type":"Person","name":"BartJM"},"datePublished":"2024-11-04T16:32:31.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":9},"url":"https://github.com/9887/cloudstack/issues/9887"}