René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"The sensitive information of uri may leak","articleBody":"\u003c!--\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release and main branch are affected too.\r\nAlways add information AFTER of these HTML comments, but no need to delete the comments.\r\n--\u003e\r\n\r\n##### ISSUE TYPE\r\n\u003c!-- Pick one below and delete the rest --\u003e\r\n * Bug Report\r\n\r\n\r\n##### COMPONENT NAME\r\n\u003c!--\r\nCategorize the issue, e.g. API, VR, VPN, UI, etc.\r\n--\u003e\r\n~~~\r\ncloudstack-service-secondary-storage \r\n~~~\r\n\r\n##### CLOUDSTACK VERSION\r\n\u003c!--\r\nNew line separated list of affected versions, commit ID for issues on main branch.\r\n--\u003e\r\n\r\n~~~\r\ncommit ID: 45d267ccbf2749c547cbbbac4a2cb1f3351dcaf2 on main branch.\r\n~~~\r\n\r\n##### CONFIGURATION\r\n\u003c!--\r\nInformation about the configuration if relevant, e.g. basic network, advanced networking, etc.  N/A otherwise\r\n--\u003e\r\n\r\n\r\n##### OS / ENVIRONMENT\r\n\u003c!--\r\nInformation about the environment if relevant, N/A otherwise\r\n--\u003e\r\n\r\n\r\n##### SUMMARY\r\n\u003c!-- Explain the problem/feature briefly --\u003e\r\nThe sensitive information of URI may leak through \"logger.error\"\r\n\r\n\r\n##### STEPS TO REPRODUCE\r\n\u003c!--\r\nFor bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.\r\n\r\nFor new features, show how the feature would be used.\r\n--\u003e\r\n\r\n\u003c!-- Paste example playbooks or commands between quotes below --\u003e\r\n~~~\r\n\r\n~~~\r\n\r\n\u003c!-- You can also paste gist.github.com links for larger files --\u003e\r\n\r\n##### EXPECTED RESULTS\r\n\u003c!-- What did you expect to happen when running the steps above? --\u003e\r\n\r\n~~~\r\n\r\n~~~\r\n\r\n##### ACTUAL RESULTS\r\n\u003c!-- What actually happened? --\u003e\r\n\r\n\u003c!-- Paste verbatim command output between quotes below --\u003e\r\n~~~\r\n\r\n~~~\r\n\r\n#### error code location\r\n~~~\r\nprotected String parseCifsMountOptions(URI uri) {\r\n    List\u003cNameValuePair\u003e args = URLEncodedUtils.parse(uri, \"UTF-8\");\r\n    boolean foundUser = false;\r\n    boolean foundPswd = false;\r\n    StringBuilder extraOpts = new StringBuilder();\r\n    for (NameValuePair nvp : args) {\r\n        String name = nvp.getName();\r\n        if (name.equals(\"user\")) {\r\n            foundUser = true;\r\n            logger.debug(\"foundUser is\" + foundUser);\r\n        } else if (name.equals(\"password\")) {\r\n            foundPswd = true;\r\n            logger.debug(\"password is present in uri\");\r\n        }\r\n\r\n        extraOpts.append(name + \"=\" + nvp.getValue() + \",\");\r\n    }\r\n\r\n    if (logger.isDebugEnabled()) {\r\n        logger.error(\"extraOpts now \" + extraOpts); //output \r\n    }\r\n\r\n    if (!foundUser || !foundPswd) {\r\n        String errMsg = \"Missing user and password from URI. Make sure they\" + \"are in the query string and separated by '\u0026'.  E.g. \"\r\n                + \"cifs://example.com/some_share?user=foo\u0026password=bar\";\r\n        logger.error(errMsg);\r\n        throw new CloudRuntimeException(errMsg);\r\n    }\r\n    return extraOpts.toString();\r\n}\r\n~~~\r\n","author":{"url":"https://github.com/YLChen-007","@type":"Person","name":"YLChen-007"},"datePublished":"2024-03-31T02:59:24.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/8853/cloudstack/issues/8853"}